)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ec79663634ea4159f76dfe726acb40768162d7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"418a333c_0aaeb440","updated":"2024-03-08 00:21:18.000000000","message":"One other thing we can do is to add pre-commit testing to tox so that its actually executed each time we use the \"pep8\" environment. See an example here: https://review.opendev.org/c/openstack/manila/+/885114","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3747bc85f79a22071a76e54a92f21d35ab1ccb85","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e123309c_766a1dce","in_reply_to":"418a333c_0aaeb440","updated":"2024-03-08 08:37:09.000000000","message":"Also note that, if we use pre-commit in pep8 target then we can remove a few test dependencies such as hacking from test-requirements, because these are installed by pre-commit.","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91a3556b00778a9fa66ba3e64e09ce7bac7ece5a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffdd8eba_a3a5868f","in_reply_to":"e123309c_766a1dce","updated":"2024-03-08 21:37:18.000000000","message":"++","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"eb77a41c80d9b9b857d0fc133d9afd81879ccce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b0b4aab_11654bc2","in_reply_to":"ffdd8eba_a3a5868f","updated":"2024-03-09 21:10:58.000000000","message":"Done. Thanks.","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3747bc85f79a22071a76e54a92f21d35ab1ccb85","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.1.0,\u003c3.2.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c193b9e0_df3a9c59","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":33},"updated":"2024-03-08 08:37:09.000000000","message":"This now needs to be \u003e\u003d6.1.0,\u003c6.2.0","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"aa06fe1c67508d24dc090d4e4c5b0b45954a2e34","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.1.0,\u003c3.2.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2978480c_715641f9","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":33},"in_reply_to":"a1bde8ef_cdda2442","updated":"2024-03-09 20:55:14.000000000","message":"Done, Thanks","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91a3556b00778a9fa66ba3e64e09ce7bac7ece5a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.1.0,\u003c3.2.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a1bde8ef_cdda2442","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":33},"in_reply_to":"c193b9e0_df3a9c59","updated":"2024-03-08 21:37:18.000000000","message":"+1","commit_id":"c8bd813307ed903100b04105613773e279de057c"}],"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c87ea8d07f6ea2f97b1f6b3b507ce4542572c8ad","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is helpful to automate code style checks when commiting, avoiding"},{"line_number":10,"context_line":"the need to remember to do this manually."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id3f38942972bc6d35427e66bb26f8f1b2f271f7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e123ca9b_4cd0fb36","line":11,"updated":"2024-03-11 18:59:25.000000000","message":"Please add:\n\nThe run_tests.sh script has been removed from the repository since\nit is outdated, unused and had a number of uncaught formatting issues.","commit_id":"1763bfa6f0ede9e62d101c5299cff8ebad748faa"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"f5d8657781e8ce64361af64754b94568be0905f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is helpful to automate code style checks when commiting, avoiding"},{"line_number":10,"context_line":"the need to remember to do this manually."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id3f38942972bc6d35427e66bb26f8f1b2f271f7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f4e11671_8c1e1d1f","line":11,"in_reply_to":"e123ca9b_4cd0fb36","updated":"2024-03-11 20:25:02.000000000","message":"Done.","commit_id":"1763bfa6f0ede9e62d101c5299cff8ebad748faa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3747bc85f79a22071a76e54a92f21d35ab1ccb85","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dddaedcf_b0a811a1","updated":"2024-03-08 08:37:09.000000000","message":"It seems this needs to be updated since https://review.opendev.org/c/openstack/manila/+/906970 was already merged","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ec79663634ea4159f76dfe726acb40768162d7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5d4add8_ab412d9f","updated":"2024-03-08 00:21:18.000000000","message":"recheck\n\nsporadic functional test failure","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91a3556b00778a9fa66ba3e64e09ce7bac7ece5a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d92c087a_f370c66c","in_reply_to":"66a000bc_d934b049","updated":"2024-03-08 21:37:18.000000000","message":"Thanks for pointing that out!","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"aa06fe1c67508d24dc090d4e4c5b0b45954a2e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f48cc633_54bc5af1","in_reply_to":"d92c087a_f370c66c","updated":"2024-03-09 20:55:14.000000000","message":"Hi Takashi, Thanks for the review. I had a conflict when I try to commit changes I made to some of the files changed in the link you mentioned. And I have accepted all the changes that came from the your change. I try to compare the changes but I don\u0027t see anything to update. Can you point a specific file that needs to be updated? Thanks","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"16b9ec6f8cdb80f79af95afcfe280b111491d5fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66a000bc_d934b049","in_reply_to":"dddaedcf_b0a811a1","updated":"2024-03-08 08:38:24.000000000","message":"Sorry that\u0027s a wrong link. Please check https://review.opendev.org/c/openstack/python-manilaclient/+/906971","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c87ea8d07f6ea2f97b1f6b3b507ce4542572c8ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2386fab7_e855cf2c","updated":"2024-03-11 18:59:25.000000000","message":"LGTM; please add context regarding why the \"run_tests.sh\" file had to be removed with this commit if you make another patch","commit_id":"1763bfa6f0ede9e62d101c5299cff8ebad748faa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59a4078e1d71ffd396186ddb207c930f85c03a39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db4c342e_1a82f1dd","updated":"2025-02-25 19:56:27.000000000","message":"/me only did a rebase to get this on top of master :)\nLGTM, thank you!","commit_id":"97cfa8e0928d63f3c9d34e44f0d85135f3736373"}],"run_tests.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ec79663634ea4159f76dfe726acb40768162d7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9734ded5_54fcab82","updated":"2024-03-08 00:21:18.000000000","message":"This file is ancient; and probably not used at all.. thanks for fixing up the formatting here; but maybe you could delete this file in a different commit","commit_id":"c8bd813307ed903100b04105613773e279de057c"},{"author":{"_account_id":36483,"name":"melaku alehegn","email":"melakualehegn34@gmail.com","username":"melakualehegn"},"change_message_id":"aa06fe1c67508d24dc090d4e4c5b0b45954a2e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5ded4d7_6daaefea","in_reply_to":"9734ded5_54fcab82","updated":"2024-03-09 20:55:14.000000000","message":"Sure. Will do on my next patch.","commit_id":"c8bd813307ed903100b04105613773e279de057c"}]}