)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8681f68_16e5fec1","updated":"2024-03-14 19:38:43.000000000","message":"Thanks for working on this tspyderboy. Please see comments inline","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac8fa0b9_3561a08c","in_reply_to":"d8681f68_16e5fec1","updated":"2024-03-16 19:55:45.000000000","message":"Thanks for the analysis and the link to documentation","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8989611bd0e3593ec5c88f53a164089bc0f64e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ae856159_e042b61a","updated":"2024-03-19 17:46:25.000000000","message":"Thanks @tspyderboy. this looks good; only thing missing is a release note. Can you please add one? https://docs.openstack.org/python-manilaclient/latest/contributor/adding_release_notes.html","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab817c9a_4422824d","updated":"2024-03-16 19:55:45.000000000","message":"Thanks for the detailed review. Acknowledged all the comments.","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"806dcff6005b1bc242d1fc4f2506842227dfd461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ec88dc17_618d9b53","updated":"2024-03-19 19:32:21.000000000","message":"Thanks; LGTM","commit_id":"b98aa0472db047371971888d61693f28afff47e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"933ab4bcf016dd0c7ad1b742411e3146b516f228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"92516fba_82a4f1a4","updated":"2024-03-19 23:30:49.000000000","message":"Thanks; I just noticed another issue with variable naming; can you please fix it up?","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"842c3420c7472540e12a5a11d974bedcb278eec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"caa0e702_a4026208","updated":"2024-03-20 18:17:08.000000000","message":"LGTM, thank you!","commit_id":"3103b8c56aa9e0629ab40bd8bb7200e1427fe913"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec7285b13d9d45a12fb40feea698ee645a5f6623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fd1bb8de_67b28daf","updated":"2024-03-20 15:04:41.000000000","message":"Thanks for the update!","commit_id":"3103b8c56aa9e0629ab40bd8bb7200e1427fe913"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"bf7c2e9c7264219dddbfe83245f2ed201d7424f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2b22512e_51457af5","updated":"2024-03-20 13:37:18.000000000","message":"thanks","commit_id":"3103b8c56aa9e0629ab40bd8bb7200e1427fe913"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8989611bd0e3593ec5c88f53a164089bc0f64e","unresolved":true,"context_lines":[{"line_number":983,"context_line":"    @mock.patch.object(shell_v2, \u0027_find_share\u0027, mock.Mock())"},{"line_number":984,"context_line":"    @mock.patch.object(shell_v2, \u0027_wait_for_resource_status\u0027, mock.Mock())"},{"line_number":985,"context_line":"    def test_snapshot_manage(self, cmd_args, valid_params):"},{"line_number":986,"context_line":"        share_to_manage \u003d shares.Share(\u0027fake_share\u0027, {\u0027id\u0027: \u00271234\u0027})"},{"line_number":987,"context_line":"        shell_v2._find_share.return_value \u003d share_to_manage"},{"line_number":988,"context_line":"        self.run_command(\u0027snapshot-manage fake_share fake_provider_location \u0027"},{"line_number":989,"context_line":"                         + cmd_args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"221253c8_2d7914e0","line":986,"range":{"start_line":986,"start_character":8,"end_line":986,"end_character":23},"updated":"2024-03-19 17:46:25.000000000","message":"the resource being managed is snapshot.. so it feels wrong to call this \"share_to_manage\"; perhaps \"share_containing_snapshot\"?","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"ae72f02f31f63e43e01b837aeb53ed091fdcffb2","unresolved":false,"context_lines":[{"line_number":983,"context_line":"    @mock.patch.object(shell_v2, \u0027_find_share\u0027, mock.Mock())"},{"line_number":984,"context_line":"    @mock.patch.object(shell_v2, \u0027_wait_for_resource_status\u0027, mock.Mock())"},{"line_number":985,"context_line":"    def test_snapshot_manage(self, cmd_args, valid_params):"},{"line_number":986,"context_line":"        share_to_manage \u003d shares.Share(\u0027fake_share\u0027, {\u0027id\u0027: \u00271234\u0027})"},{"line_number":987,"context_line":"        shell_v2._find_share.return_value \u003d share_to_manage"},{"line_number":988,"context_line":"        self.run_command(\u0027snapshot-manage fake_share fake_provider_location \u0027"},{"line_number":989,"context_line":"                         + cmd_args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dd6777cd_0f9a0508","line":986,"range":{"start_line":986,"start_character":8,"end_line":986,"end_character":23},"in_reply_to":"221253c8_2d7914e0","updated":"2024-03-19 19:21:26.000000000","message":"Acknowledged","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8989611bd0e3593ec5c88f53a164089bc0f64e","unresolved":true,"context_lines":[{"line_number":1024,"context_line":"            [mock.call(self.shell.cs, \u0027fake_share\u0027)])"},{"line_number":1025,"context_line":"        self.assertEqual(1, shell_v2._find_share.call_count)"},{"line_number":1026,"context_line":"        # _wait_for_resource_status should be triggered once"},{"line_number":1027,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls("},{"line_number":1028,"context_line":"            [mock.call(self.shell.cs,"},{"line_number":1029,"context_line":"                       mock.ANY, \u0027available\u0027,"},{"line_number":1030,"context_line":"                       resource_type\u003d\u0027snapshot\u0027)])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ba6280e_e2dbda46","line":1027,"updated":"2024-03-19 17:46:25.000000000","message":"instead of using assert_has_calls and asserting the call_count; you could use \"assert_called_once_with\"...","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"806dcff6005b1bc242d1fc4f2506842227dfd461","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            [mock.call(self.shell.cs, \u0027fake_share\u0027)])"},{"line_number":1025,"context_line":"        self.assertEqual(1, shell_v2._find_share.call_count)"},{"line_number":1026,"context_line":"        # _wait_for_resource_status should be triggered once"},{"line_number":1027,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls("},{"line_number":1028,"context_line":"            [mock.call(self.shell.cs,"},{"line_number":1029,"context_line":"                       mock.ANY, \u0027available\u0027,"},{"line_number":1030,"context_line":"                       resource_type\u003d\u0027snapshot\u0027)])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fe3f1f16_f7c717cb","line":1027,"in_reply_to":"1a70bae1_e0b87891","updated":"2024-03-19 19:32:21.000000000","message":"It\u0027s redundant to do this because the method is doing just that: https://github.com/python/cpython/blob/1ab0d0b1167d78bf19661a3b5e533a2b68a57604/Lib/unittest/mock.py#L977-L986","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"ae72f02f31f63e43e01b837aeb53ed091fdcffb2","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            [mock.call(self.shell.cs, \u0027fake_share\u0027)])"},{"line_number":1025,"context_line":"        self.assertEqual(1, shell_v2._find_share.call_count)"},{"line_number":1026,"context_line":"        # _wait_for_resource_status should be triggered once"},{"line_number":1027,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls("},{"line_number":1028,"context_line":"            [mock.call(self.shell.cs,"},{"line_number":1029,"context_line":"                       mock.ANY, \u0027available\u0027,"},{"line_number":1030,"context_line":"                       resource_type\u003d\u0027snapshot\u0027)])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a70bae1_e0b87891","line":1027,"in_reply_to":"9ba6280e_e2dbda46","updated":"2024-03-19 19:21:26.000000000","message":"Thanks, will keep assert_called_once_with as well as \"asserting the call_count\" to have tighter check that no other calls are being made","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"c43e9c2643ee42db6b7625412e0875b5ce18da25","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            [mock.call(self.shell.cs, \u0027fake_share\u0027)])"},{"line_number":1025,"context_line":"        self.assertEqual(1, shell_v2._find_share.call_count)"},{"line_number":1026,"context_line":"        # _wait_for_resource_status should be triggered once"},{"line_number":1027,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls("},{"line_number":1028,"context_line":"            [mock.call(self.shell.cs,"},{"line_number":1029,"context_line":"                       mock.ANY, \u0027available\u0027,"},{"line_number":1030,"context_line":"                       resource_type\u003d\u0027snapshot\u0027)])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ded84b37_7f525cbe","line":1027,"in_reply_to":"fe3f1f16_f7c717cb","updated":"2024-03-19 19:36:10.000000000","message":"Got it, thanks for the pointer. \nRemoving the reduntant checks","commit_id":"267ee530cb6701532f17974a9fa23021c8ef38bb"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"    \u0027--wait\u0027,"},{"line_number":1709,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1710,"context_line":"    default\u003dFalse,"},{"line_number":1711,"context_line":"    help\u003d\u0027Wait for share snapshot to manage\u0027)"},{"line_number":1712,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":1713,"context_line":"    \"\"\"Manage share snapshot not handled by Manila (Admin only).\"\"\""},{"line_number":1714,"context_line":"    share_ref \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"66838924_5d51f7cd","line":1711,"range":{"start_line":1711,"start_character":37,"end_line":1711,"end_character":43},"updated":"2024-03-14 19:38:43.000000000","message":"be managed","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"    \u0027--wait\u0027,"},{"line_number":1709,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1710,"context_line":"    default\u003dFalse,"},{"line_number":1711,"context_line":"    help\u003d\u0027Wait for share snapshot to manage\u0027)"},{"line_number":1712,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":1713,"context_line":"    \"\"\"Manage share snapshot not handled by Manila (Admin only).\"\"\""},{"line_number":1714,"context_line":"    share_ref \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e20d4594_7e8238b4","line":1711,"range":{"start_line":1711,"start_character":37,"end_line":1711,"end_character":43},"in_reply_to":"66838924_5d51f7cd","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1721,"context_line":"    )"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    if args.wait:"},{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"92344784_ba3f488f","line":1724,"range":{"start_line":1724,"start_character":7,"end_line":1724,"end_character":39},"updated":"2024-03-14 19:38:43.000000000","message":"please remove these print statements... here and on line 1726","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"    )"},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"    if args.wait:"},{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"14b9139e_ac7ec9b9","line":1724,"range":{"start_line":1724,"start_character":7,"end_line":1724,"end_character":39},"in_reply_to":"92344784_ba3f488f","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"},{"line_number":1728,"context_line":"        except exceptions.CommandError as e:"},{"line_number":1729,"context_line":"            print(e, file\u003dsys.stderr)"},{"line_number":1730,"context_line":"    _print_share_snapshot(cs, share_snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d8cc07c_0acf9750","line":1727,"range":{"start_line":1727,"start_character":67,"end_line":1727,"end_character":74},"updated":"2024-03-14 19:38:43.000000000","message":"\"managed\" isn\u0027t a valid status. The snapshot moves to \"available\" status when the manage operation completes successfully. \n\nhttps://docs.openstack.org/api-ref/shared-file-system/index.html#share-snapshots","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"},{"line_number":1728,"context_line":"        except exceptions.CommandError as e:"},{"line_number":1729,"context_line":"            print(e, file\u003dsys.stderr)"},{"line_number":1730,"context_line":"    _print_share_snapshot(cs, share_snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b6f836ea_87700ca6","line":1727,"range":{"start_line":1727,"start_character":39,"end_line":1727,"end_character":48},"updated":"2024-03-14 19:38:43.000000000","message":"the thing being managed here is the share_snapshot, not the share (\"share_ref\")... so you need to use \"_wait_for_resource_status\" instead setting resource_type to \"snapshot\"","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"},{"line_number":1728,"context_line":"        except exceptions.CommandError as e:"},{"line_number":1729,"context_line":"            print(e, file\u003dsys.stderr)"},{"line_number":1730,"context_line":"    _print_share_snapshot(cs, share_snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3db36974_19a6614a","line":1727,"range":{"start_line":1727,"start_character":67,"end_line":1727,"end_character":74},"in_reply_to":"0d8cc07c_0acf9750","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"        print(\"args.wait: \", args.wait)"},{"line_number":1725,"context_line":"        try:"},{"line_number":1726,"context_line":"            print(\"_wait_for_share_status\")"},{"line_number":1727,"context_line":"            _wait_for_share_status(cs, share_ref, expected_status\u003d\u0027managed\u0027)"},{"line_number":1728,"context_line":"        except exceptions.CommandError as e:"},{"line_number":1729,"context_line":"            print(e, file\u003dsys.stderr)"},{"line_number":1730,"context_line":"    _print_share_snapshot(cs, share_snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9966ab2d_c026f808","line":1727,"range":{"start_line":1727,"start_character":39,"end_line":1727,"end_character":48},"in_reply_to":"b6f836ea_87700ca6","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1786,"context_line":"    \u0027--wait\u0027,"},{"line_number":1787,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1788,"context_line":"    default\u003dFalse,"},{"line_number":1789,"context_line":"    help\u003d\u0027Wait for share snapshot to unmanage\u0027)"},{"line_number":1790,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":1791,"context_line":"    \"\"\"Unmanage one or more share snapshots (Admin only).\"\"\""},{"line_number":1792,"context_line":"    failure_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"137658a3_a04aa753","line":1789,"range":{"start_line":1789,"start_character":37,"end_line":1789,"end_character":45},"updated":"2024-03-14 19:38:43.000000000","message":"be unmanaged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"    \u0027--wait\u0027,"},{"line_number":1787,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1788,"context_line":"    default\u003dFalse,"},{"line_number":1789,"context_line":"    help\u003d\u0027Wait for share snapshot to unmanage\u0027)"},{"line_number":1790,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":1791,"context_line":"    \"\"\"Unmanage one or more share snapshots (Admin only).\"\"\""},{"line_number":1792,"context_line":"    failure_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"16d29360_28fb94bb","line":1789,"range":{"start_line":1789,"start_character":37,"end_line":1789,"end_character":45},"in_reply_to":"137658a3_a04aa753","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b31f48e04b20f010e20d54d8b32537a2935885a","unresolved":true,"context_lines":[{"line_number":1795,"context_line":"            snapshot_ref \u003d _find_share_snapshot(cs, snapshot)"},{"line_number":1796,"context_line":"            snapshot_ref.unmanage_snapshot()"},{"line_number":1797,"context_line":"            if args.wait:"},{"line_number":1798,"context_line":"                _wait_for_share_status(cs, snapshot_ref,"},{"line_number":1799,"context_line":"                                       expected_status\u003d\u0027unmanaged\u0027)"},{"line_number":1800,"context_line":"        except Exception as e:"},{"line_number":1801,"context_line":"            failure_count +\u003d 1"},{"line_number":1802,"context_line":"            print(\"Unmanage for share snapshot %s failed: %s\" % (snapshot, e),"}],"source_content_type":"text/x-python","patch_set":3,"id":"873377b6_e1cc761a","line":1799,"range":{"start_line":1798,"start_character":15,"end_line":1799,"end_character":67},"updated":"2024-03-14 19:38:43.000000000","message":"\"unmanaged\" isn\u0027t a valid status.. when unmanaged, the status is \"deleted\". \n\nAlso, you\u0027re using the snapshot_ref but invoking \"_wait_for_share_status\". you should be invoking  \"_wait_for_resource_status\" instead setting resource_type to \"snapshot\"","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"446fafaea8475055cfaed52d56c434b53a3909fb","unresolved":false,"context_lines":[{"line_number":1795,"context_line":"            snapshot_ref \u003d _find_share_snapshot(cs, snapshot)"},{"line_number":1796,"context_line":"            snapshot_ref.unmanage_snapshot()"},{"line_number":1797,"context_line":"            if args.wait:"},{"line_number":1798,"context_line":"                _wait_for_share_status(cs, snapshot_ref,"},{"line_number":1799,"context_line":"                                       expected_status\u003d\u0027unmanaged\u0027)"},{"line_number":1800,"context_line":"        except Exception as e:"},{"line_number":1801,"context_line":"            failure_count +\u003d 1"},{"line_number":1802,"context_line":"            print(\"Unmanage for share snapshot %s failed: %s\" % (snapshot, e),"}],"source_content_type":"text/x-python","patch_set":3,"id":"f155c0fe_42ed4570","line":1799,"range":{"start_line":1798,"start_character":15,"end_line":1799,"end_character":67},"in_reply_to":"873377b6_e1cc761a","updated":"2024-03-16 19:55:45.000000000","message":"Acknowledged","commit_id":"5664603e05ddb93bed29c1471d402b3c95b50fd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"933ab4bcf016dd0c7ad1b742411e3146b516f228","unresolved":true,"context_lines":[{"line_number":326,"context_line":"    cliutils.print_dict(info.get(\u0027members\u0027, {}))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"def _wait_for_snapshot_status(cs, share, expected_status\u003d\u0027available\u0027):"},{"line_number":330,"context_line":"    return _wait_for_resource_status("},{"line_number":331,"context_line":"        cs, share, expected_status, resource_type\u003d\u0027snapshot\u0027)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c81ff6c1_ab41ce8e","line":329,"range":{"start_line":329,"start_character":34,"end_line":329,"end_character":39},"updated":"2024-03-19 23:30:49.000000000","message":"snapshot","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"bf7c2e9c7264219dddbfe83245f2ed201d7424f2","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    cliutils.print_dict(info.get(\u0027members\u0027, {}))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"def _wait_for_snapshot_status(cs, share, expected_status\u003d\u0027available\u0027):"},{"line_number":330,"context_line":"    return _wait_for_resource_status("},{"line_number":331,"context_line":"        cs, share, expected_status, resource_type\u003d\u0027snapshot\u0027)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"e399c478_4d57a250","line":329,"range":{"start_line":329,"start_character":34,"end_line":329,"end_character":39},"in_reply_to":"c81ff6c1_ab41ce8e","updated":"2024-03-20 13:37:18.000000000","message":"thanks for the catch","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"933ab4bcf016dd0c7ad1b742411e3146b516f228","unresolved":true,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"def _wait_for_snapshot_status(cs, share, expected_status\u003d\u0027available\u0027):"},{"line_number":330,"context_line":"    return _wait_for_resource_status("},{"line_number":331,"context_line":"        cs, share, expected_status, resource_type\u003d\u0027snapshot\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"def _find_share_snapshot(cs, snapshot):"}],"source_content_type":"text/x-python","patch_set":8,"id":"84b4c363_280fa858","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":17},"updated":"2024-03-19 23:30:49.000000000","message":"snapshot","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"fc32e597dc47749d26297ae670730f03f6b229d8","unresolved":true,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"def _wait_for_snapshot_status(cs, share, expected_status\u003d\u0027available\u0027):"},{"line_number":330,"context_line":"    return _wait_for_resource_status("},{"line_number":331,"context_line":"        cs, share, expected_status, resource_type\u003d\u0027snapshot\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"def _find_share_snapshot(cs, snapshot):"}],"source_content_type":"text/x-python","patch_set":8,"id":"c2c71a9f_e3272701","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":17},"in_reply_to":"84b4c363_280fa858","updated":"2024-03-20 13:36:10.000000000","message":"thanks for the catch","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"bf7c2e9c7264219dddbfe83245f2ed201d7424f2","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"def _wait_for_snapshot_status(cs, share, expected_status\u003d\u0027available\u0027):"},{"line_number":330,"context_line":"    return _wait_for_resource_status("},{"line_number":331,"context_line":"        cs, share, expected_status, resource_type\u003d\u0027snapshot\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"def _find_share_snapshot(cs, snapshot):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1791ae7e_9362383f","line":331,"range":{"start_line":331,"start_character":12,"end_line":331,"end_character":17},"in_reply_to":"c2c71a9f_e3272701","updated":"2024-03-20 13:37:18.000000000","message":"a","commit_id":"61a50266ec0aeca491aaaed75b6cee3bbb8d1134"}]}