)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"010868551627fe61c34b58c0123c7efdd5f63bed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-24 02:01:52 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"--wait\" option for managing/unmanaging a share server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Managing a share server"},{"line_number":10,"context_line":"$ manila share-server-manage manila@paris share_net_test backend_server_1 --wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eb8f48d6_9f8aabc5","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":33},"updated":"2024-03-25 23:40:46.000000000","message":"Looks like we did this with https://github.com/openstack/python-manilaclient/commit/13ec1d3f443c952cd3086458503bda47967b2c91\n\nand this commit is only touching the \"unmanage\" o/p","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"51dba676a9eab160b526a2e3eddab40d94b33dd7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-24 02:01:52 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"--wait\" option for managing/unmanaging a share server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Managing a share server"},{"line_number":10,"context_line":"$ manila share-server-manage manila@paris share_net_test backend_server_1 --wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ec66f7dd_bb06ca72","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":33},"in_reply_to":"eb8f48d6_9f8aabc5","updated":"2024-03-26 11:01:53.000000000","message":"Yes, touching only share-server-manage","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"010868551627fe61c34b58c0123c7efdd5f63bed","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"--wait\" option for managing/unmanaging a share server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Managing a share server"},{"line_number":10,"context_line":"$ manila share-server-manage manila@paris share_net_test backend_server_1 --wait"},{"line_number":11,"context_line":"\u003cCLI waits for the share server to reach \"active\" state\" before returning to the prompt\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"2) Unmanaging a share server"},{"line_number":14,"context_line":"$ manila share-server-unmanage 441d806f-f0e0-4c90-b7e2-a553c6aa76b2 --wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ca08fc19_7032bf52","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":88},"updated":"2024-03-25 23:40:46.000000000","message":"remove","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"51dba676a9eab160b526a2e3eddab40d94b33dd7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"--wait\" option for managing/unmanaging a share server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Managing a share server"},{"line_number":10,"context_line":"$ manila share-server-manage manila@paris share_net_test backend_server_1 --wait"},{"line_number":11,"context_line":"\u003cCLI waits for the share server to reach \"active\" state\" before returning to the prompt\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"2) Unmanaging a share server"},{"line_number":14,"context_line":"$ manila share-server-unmanage 441d806f-f0e0-4c90-b7e2-a553c6aa76b2 --wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8b5db69c_81e20a40","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":88},"in_reply_to":"ca08fc19_7032bf52","updated":"2024-03-26 11:01:53.000000000","message":"Done","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"010868551627fe61c34b58c0123c7efdd5f63bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6630c6de_32b92c1d","updated":"2024-03-25 23:40:46.000000000","message":"Thank you tspyderboy. Can you please see the comments inline; and also add a release note? https://docs.openstack.org/python-manilaclient/latest/contributor/adding_release_notes.html","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dbef17567a22747d2b9e11844e41948d82f98e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"782148d0_a306c5ed","updated":"2024-03-29 17:02:49.000000000","message":"Hey tspyderboy; i\u0027ve a further comment inline. Can you please take a look. I don\u0027t mind you fixing that bug in a different patch..","commit_id":"dab699357d80af37667260407536e1987426efc3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"57f5ae8b98da1422fbffc791ffd669735111fd4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b898638a_286814fc","updated":"2024-03-26 22:56:12.000000000","message":"Thanks; LGTM","commit_id":"dab699357d80af37667260407536e1987426efc3"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"39fcb89a4da357c9b37b2f5a8c5ff1176b2b3241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99dc380a_bc6051db","updated":"2024-03-31 19:35:53.000000000","message":"Hi, please check _print_share_server\nThanks","commit_id":"515ff865c0e693d75d9cb55d0beea9f4ef4b0278"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6a1f2b557b0cd1d6547a24e7d9a9f9997d52cced","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9fdf780a_bd7f6301","updated":"2024-04-05 16:59:57.000000000","message":"Thanks for the changes! Please see my comment inline","commit_id":"7c0b6fc4963a3b931212fec65a6257e4ac51bc19"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"b167df7d0d9d177c326274d9036fc51e66ab4605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0e2effc1_1d72d1d6","updated":"2024-04-08 18:05:17.000000000","message":"Thanks for the reference, popped 2 keys","commit_id":"c2a9b04dc844d2e321e2ff448ab826b3ca0e9d5d"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"010868551627fe61c34b58c0123c7efdd5f63bed","unresolved":true,"context_lines":[{"line_number":1778,"context_line":"            if args.wait:"},{"line_number":1779,"context_line":"                _wait_for_resource_status("},{"line_number":1780,"context_line":"                    cs, server, resource_type\u003d\u0027share_server\u0027,"},{"line_number":1781,"context_line":"                    expected_status\u003d\u0027inactive\u0027)"},{"line_number":1782,"context_line":"        except Exception as e:"},{"line_number":1783,"context_line":"            failure_count +\u003d 1"},{"line_number":1784,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5914be7_dcc9113e","line":1781,"range":{"start_line":1781,"start_character":37,"end_line":1781,"end_character":45},"updated":"2024-03-25 23:40:46.000000000","message":"it\u0027ll be \"deleted\"\n\n\"inactive\" is used only briefly when an unused share server is being decomissioned forever.","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"51dba676a9eab160b526a2e3eddab40d94b33dd7","unresolved":false,"context_lines":[{"line_number":1778,"context_line":"            if args.wait:"},{"line_number":1779,"context_line":"                _wait_for_resource_status("},{"line_number":1780,"context_line":"                    cs, server, resource_type\u003d\u0027share_server\u0027,"},{"line_number":1781,"context_line":"                    expected_status\u003d\u0027inactive\u0027)"},{"line_number":1782,"context_line":"        except Exception as e:"},{"line_number":1783,"context_line":"            failure_count +\u003d 1"},{"line_number":1784,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"}],"source_content_type":"text/x-python","patch_set":2,"id":"497055d5_86f85738","line":1781,"range":{"start_line":1781,"start_character":37,"end_line":1781,"end_character":45},"in_reply_to":"b5914be7_dcc9113e","updated":"2024-03-26 11:01:53.000000000","message":"Got it, final status would be \u0027deleted\u0027","commit_id":"bc1c0c239d014ef93200cfd17c45e96fbe3990b3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dbef17567a22747d2b9e11844e41948d82f98e4d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        \u0027share_access_rule\u0027: _find_share_access_rule,"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    print_resource \u003d {"},{"line_number":64,"context_line":"        \u0027share\u0027: _print_share,"},{"line_number":65,"context_line":"        \u0027snapshot\u0027: _print_share_snapshot,"},{"line_number":66,"context_line":"        \u0027share_replica\u0027: _print_share_replica,"},{"line_number":67,"context_line":"        \u0027share_group\u0027: _print_share_group,"},{"line_number":68,"context_line":"        \u0027share_group_snapshot\u0027: _print_share_group_snapshot,"},{"line_number":69,"context_line":"        \u0027share_instance\u0027: _print_share_instance,"},{"line_number":70,"context_line":"        \u0027share_access_rule\u0027: _print_share_access_rule,"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    expected_status \u003d expected_status or (\u0027available\u0027, )"},{"line_number":74,"context_line":"    if not isinstance(expected_status, (list, tuple, set)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dcfb79fb_4eb8c2e6","line":71,"range":{"start_line":63,"start_character":4,"end_line":71,"end_character":5},"updated":"2024-03-29 17:02:49.000000000","message":"this block is missing \"share_server\"; see bug https://bugs.launchpad.net/python-manilaclient/+bug/1982428","commit_id":"dab699357d80af37667260407536e1987426efc3"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"39fcb89a4da357c9b37b2f5a8c5ff1176b2b3241","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \u0027share_access_rule\u0027: _find_share_access_rule,"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    print_resource \u003d {"},{"line_number":64,"context_line":"        \u0027share\u0027: _print_share,"},{"line_number":65,"context_line":"        \u0027snapshot\u0027: _print_share_snapshot,"},{"line_number":66,"context_line":"        \u0027share_replica\u0027: _print_share_replica,"},{"line_number":67,"context_line":"        \u0027share_group\u0027: _print_share_group,"},{"line_number":68,"context_line":"        \u0027share_group_snapshot\u0027: _print_share_group_snapshot,"},{"line_number":69,"context_line":"        \u0027share_instance\u0027: _print_share_instance,"},{"line_number":70,"context_line":"        \u0027share_access_rule\u0027: _print_share_access_rule,"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    expected_status \u003d expected_status or (\u0027available\u0027, )"},{"line_number":74,"context_line":"    if not isinstance(expected_status, (list, tuple, set)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"63cd7dd4_f697251e","line":71,"range":{"start_line":63,"start_character":4,"end_line":71,"end_character":5},"in_reply_to":"dcfb79fb_4eb8c2e6","updated":"2024-03-31 19:35:53.000000000","message":"Hi, have added. Please review keys it will print.\nThanks","commit_id":"dab699357d80af37667260407536e1987426efc3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6a1f2b557b0cd1d6547a24e7d9a9f9997d52cced","unresolved":true,"context_lines":[{"line_number":387,"context_line":"def _print_share_server(cs, share_server):"},{"line_number":388,"context_line":"    info \u003d share_server._info.copy()"},{"line_number":389,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":390,"context_line":"    if info.get(\u0027export_locations\u0027):"},{"line_number":391,"context_line":"        info[\u0027export_locations\u0027] \u003d ("},{"line_number":392,"context_line":"            cliutils.convert_dict_list_to_string("},{"line_number":393,"context_line":"                info[\u0027export_locations\u0027],"},{"line_number":394,"context_line":"                ignored_keys\u003d[\u0027replica_state\u0027, \u0027availability_zone\u0027,"},{"line_number":395,"context_line":"                              \u0027share_replica_id\u0027]))"},{"line_number":396,"context_line":"    cliutils.print_dict(info)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1909421a_deaacac4","line":395,"range":{"start_line":390,"start_character":0,"end_line":395,"end_character":51},"updated":"2024-04-05 16:59:57.000000000","message":"these keys aren\u0027t present in a share server; see https://docs.openstack.org/api-ref/shared-file-system/index.html#id441","commit_id":"7c0b6fc4963a3b931212fec65a6257e4ac51bc19"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"b167df7d0d9d177c326274d9036fc51e66ab4605","unresolved":false,"context_lines":[{"line_number":387,"context_line":"def _print_share_server(cs, share_server):"},{"line_number":388,"context_line":"    info \u003d share_server._info.copy()"},{"line_number":389,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":390,"context_line":"    if info.get(\u0027export_locations\u0027):"},{"line_number":391,"context_line":"        info[\u0027export_locations\u0027] \u003d ("},{"line_number":392,"context_line":"            cliutils.convert_dict_list_to_string("},{"line_number":393,"context_line":"                info[\u0027export_locations\u0027],"},{"line_number":394,"context_line":"                ignored_keys\u003d[\u0027replica_state\u0027, \u0027availability_zone\u0027,"},{"line_number":395,"context_line":"                              \u0027share_replica_id\u0027]))"},{"line_number":396,"context_line":"    cliutils.print_dict(info)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d1a9c430_d815ed4d","line":395,"range":{"start_line":390,"start_character":0,"end_line":395,"end_character":51},"in_reply_to":"1909421a_deaacac4","updated":"2024-04-08 18:05:17.000000000","message":"Acknowledged","commit_id":"7c0b6fc4963a3b931212fec65a6257e4ac51bc19"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6a1f2b557b0cd1d6547a24e7d9a9f9997d52cced","unresolved":true,"context_lines":[{"line_number":4655,"context_line":"    share_server \u003d cs.share_servers.get(args.id)"},{"line_number":4656,"context_line":"    # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":4657,"context_line":"    # so remove big dict from view."},{"line_number":4658,"context_line":"    if \"backend_details\" in share_server._info:"},{"line_number":4659,"context_line":"        del share_server._info[\"backend_details\"]"},{"line_number":4660,"context_line":"    cliutils.print_dict(share_server._info)"},{"line_number":4661,"context_line":""},{"line_number":4662,"context_line":""},{"line_number":4663,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":9,"id":"d1d60344_2a85b650","line":4660,"range":{"start_line":4658,"start_character":0,"end_line":4660,"end_character":43},"updated":"2024-04-05 16:59:57.000000000","message":"This is how a share server\u0027s being printed; can you use this logic in _print_share_server and replace this code with a call to that method as well?","commit_id":"7c0b6fc4963a3b931212fec65a6257e4ac51bc19"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"b167df7d0d9d177c326274d9036fc51e66ab4605","unresolved":false,"context_lines":[{"line_number":4655,"context_line":"    share_server \u003d cs.share_servers.get(args.id)"},{"line_number":4656,"context_line":"    # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":4657,"context_line":"    # so remove big dict from view."},{"line_number":4658,"context_line":"    if \"backend_details\" in share_server._info:"},{"line_number":4659,"context_line":"        del share_server._info[\"backend_details\"]"},{"line_number":4660,"context_line":"    cliutils.print_dict(share_server._info)"},{"line_number":4661,"context_line":""},{"line_number":4662,"context_line":""},{"line_number":4663,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":9,"id":"4bf62fe1_57ba6f79","line":4660,"range":{"start_line":4658,"start_character":0,"end_line":4660,"end_character":43},"in_reply_to":"d1d60344_2a85b650","updated":"2024-04-08 18:05:17.000000000","message":"Acknowledged","commit_id":"7c0b6fc4963a3b931212fec65a6257e4ac51bc19"}]}