)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a118e1dee104798dcc7ce8f9d27fd7372abbc56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5db318ee_999da12e","updated":"2024-03-15 23:51:52.000000000","message":"Thank you for working on this change, Solly. Please see comment inline regarding the fix. \n\nCould you think of a good unit test here: https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/tests/unit/osc/v2/test_security_services.py\n\nAlso, please add a bugfix release note: https://docs.openstack.org/python-manilaclient/latest/contributor/adding_release_notes.html","commit_id":"aff1ebc5b45cedd3778f18f97f2b778b6a90badc"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"efd3f5601048cb5d34b7321a0aafe26056f5d551","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b18e8ee1_f5b2fa20","in_reply_to":"5db318ee_999da12e","updated":"2024-03-18 07:06:07.000000000","message":"Thanks for the comment. I have resolved the issues in the next patchset.","commit_id":"aff1ebc5b45cedd3778f18f97f2b778b6a90badc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76835d5f_bd187900","updated":"2024-03-18 22:21:54.000000000","message":"Thank you for the updated patch Solly. Please see more comments inline","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f566776_255ae70d","updated":"2024-03-19 13:03:34.000000000","message":"Thanks Goutham. This patch resolves the issues","commit_id":"655d294eda7d7c5e2fd06b2b4ad9a6c9c3ae47b9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bd0e95866b9bff3127cc86aa1f0a4f9ff4afde1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d32c3dc7_27fc750d","updated":"2024-03-19 17:52:12.000000000","message":"Thanks for the updates; the unit test passes because manilaclient SDK has a check for empty arguments: https://github.com/openstack/python-manilaclient/blob/af8f3faf0fd0afcbda8accbe3f6511e8aa95be9f/manilaclient/v2/security_services.py#L210-L212\n\nYour code is supposed to raise an error before we get to that stage","commit_id":"76625f0b601f33caa26e41fcc983de79d8cb12ec"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"be9b442b03001c344115d9dac2ff51b6ffdf530a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dfb3a5b5_cf7425e1","updated":"2024-03-25 08:13:24.000000000","message":"The current behavior is consistent with the existing commands in openstack CLI, and this change breaks that consistency. If we aim to \"fix\" this behavior then we have to \"fix\" all commands, but I\u0027m not too sure if that can be beneficial enough to pay effort for...\n\nSee https://bugs.launchpad.net/python-manilaclient/+bug/2032984/comments/4","commit_id":"25126a85447b1d3ce5b00a9b2b5dafc820963e32"}],"manilaclient/osc/v2/security_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a118e1dee104798dcc7ce8f9d27fd7372abbc56a","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        args \u003d [\u0027dns_ip\u0027, \u0027server\u0027, \u0027domain\u0027, \u0027user\u0027, \u0027password\u0027,"},{"line_number":284,"context_line":"                \u0027name\u0027, \u0027description\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        arg_exists \u003d false"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for arg in args:"},{"line_number":289,"context_line":"            if getattr(parsed_args, arg) is not None:"},{"line_number":290,"context_line":"                arg_exists \u003d true"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if arg_exists is false:"},{"line_number":293,"context_line":"            raise exceptions.CommandError("},{"line_number":294,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":295,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3713983c_9e24c9c7","line":292,"range":{"start_line":286,"start_character":8,"end_line":292,"end_character":31},"updated":"2024-03-15 23:51:52.000000000","message":"`if not any(getattr(parsed_args, arg) for arg in args)`","commit_id":"aff1ebc5b45cedd3778f18f97f2b778b6a90badc"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"efd3f5601048cb5d34b7321a0aafe26056f5d551","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        args \u003d [\u0027dns_ip\u0027, \u0027server\u0027, \u0027domain\u0027, \u0027user\u0027, \u0027password\u0027,"},{"line_number":284,"context_line":"                \u0027name\u0027, \u0027description\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        arg_exists \u003d false"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for arg in args:"},{"line_number":289,"context_line":"            if getattr(parsed_args, arg) is not None:"},{"line_number":290,"context_line":"                arg_exists \u003d true"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if arg_exists is false:"},{"line_number":293,"context_line":"            raise exceptions.CommandError("},{"line_number":294,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":295,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"11ebdb0c_986b058e","line":292,"range":{"start_line":286,"start_character":8,"end_line":292,"end_character":31},"in_reply_to":"3713983c_9e24c9c7","updated":"2024-03-18 07:06:07.000000000","message":"Done","commit_id":"aff1ebc5b45cedd3778f18f97f2b778b6a90badc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(getattr(parsed_args, arg) for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"                \"Usage:\""},{"line_number":290,"context_line":"                \"[--param] [value]\""},{"line_number":291,"context_line":"                \"\""},{"line_number":292,"context_line":"                \"\""},{"line_number":293,"context_line":"                \"   --dns_ip:       Set DNS IP address used.\""},{"line_number":294,"context_line":"                \"   --server:       Set security service IP address(hostname).\""},{"line_number":295,"context_line":"                \"   --domain:       Set security service domain.\""},{"line_number":296,"context_line":"                \"   --user:         Set security service user or group.\""},{"line_number":297,"context_line":"                \"   --password:     Set security password used by user.\""},{"line_number":298,"context_line":"                \"   --name:         Set security service name.\""},{"line_number":299,"context_line":"                \"   --description:  Set security service description.\""},{"line_number":300,"context_line":"            )"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        security_service \u003d oscutils.find_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a330a15_ea6454f0","line":299,"range":{"start_line":288,"start_character":16,"end_line":299,"end_character":70},"updated":"2024-03-18 22:21:54.000000000","message":"No need to repeat the help text here. \n\nThe error message can simply say:\n\n\"No arguments provided. See `openstack help share security service set`.\"","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(getattr(parsed_args, arg) for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"                \"Usage:\""},{"line_number":290,"context_line":"                \"[--param] [value]\""},{"line_number":291,"context_line":"                \"\""},{"line_number":292,"context_line":"                \"\""},{"line_number":293,"context_line":"                \"   --dns_ip:       Set DNS IP address used.\""},{"line_number":294,"context_line":"                \"   --server:       Set security service IP address(hostname).\""},{"line_number":295,"context_line":"                \"   --domain:       Set security service domain.\""},{"line_number":296,"context_line":"                \"   --user:         Set security service user or group.\""},{"line_number":297,"context_line":"                \"   --password:     Set security password used by user.\""},{"line_number":298,"context_line":"                \"   --name:         Set security service name.\""},{"line_number":299,"context_line":"                \"   --description:  Set security service description.\""},{"line_number":300,"context_line":"            )"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        security_service \u003d oscutils.find_resource("}],"source_content_type":"text/x-python","patch_set":2,"id":"a0d1c720_c5bd74f4","line":299,"range":{"start_line":288,"start_character":16,"end_line":299,"end_character":70},"in_reply_to":"9a330a15_ea6454f0","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bd0e95866b9bff3127cc86aa1f0a4f9ff4afde1","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        args \u003d [\u0027dns_ip\u0027, \u0027server\u0027, \u0027domain\u0027, \u0027user\u0027, \u0027password\u0027,"},{"line_number":284,"context_line":"                \u0027name\u0027, \u0027description\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(arg in parsed_args for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"2d761644_50329cd2","line":286,"range":{"start_line":286,"start_character":8,"end_line":286,"end_character":55},"updated":"2024-03-19 17:52:12.000000000","message":"any reason you updated this? \nthis current check doesn\u0027t make sense to me.. and it doesn\u0027t work as expected in my test environment\n\n\"parsed_args\" object will always contain these optional arguments because we define them - they will all have a default value of None... in this check, we have to check if any argument is not None.. i.e., has the user provided at least one of the optional arguments?","commit_id":"76625f0b601f33caa26e41fcc983de79d8cb12ec"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"75c61cb5ea4a4f41361e982ce49baa85c254e0e0","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        args \u003d [\u0027dns_ip\u0027, \u0027server\u0027, \u0027domain\u0027, \u0027user\u0027, \u0027password\u0027,"},{"line_number":284,"context_line":"                \u0027name\u0027, \u0027description\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(arg in parsed_args for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2d0d47c_dbf3d2b4","line":286,"range":{"start_line":286,"start_character":8,"end_line":286,"end_character":55},"in_reply_to":"2d761644_50329cd2","updated":"2024-03-20 07:52:00.000000000","message":"Using the \"get_attr\" method threw an error when no optional argument is passed.","commit_id":"76625f0b601f33caa26e41fcc983de79d8cb12ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5d4de9992b05386d110631f53e8f001aea9931d1","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        args \u003d [\u0027dns_ip\u0027, \u0027server\u0027, \u0027domain\u0027, \u0027user\u0027, \u0027password\u0027,"},{"line_number":284,"context_line":"                \u0027name\u0027, \u0027description\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(arg in parsed_args for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"f12fef7d_c6826c4a","line":286,"range":{"start_line":286,"start_character":8,"end_line":286,"end_character":55},"in_reply_to":"e2d0d47c_dbf3d2b4","updated":"2024-03-20 18:36:36.000000000","message":"Isnt that the point of this bug fix? :)\n\nWhat is the error you got?","commit_id":"76625f0b601f33caa26e41fcc983de79d8cb12ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bd0e95866b9bff3127cc86aa1f0a4f9ff4afde1","unresolved":true,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if not any(arg in parsed_args for arg in args):"},{"line_number":287,"context_line":"            raise exceptions.CommandError("},{"line_number":288,"context_line":"                \"Error: Missing argument: Please provide the optional argument\""},{"line_number":289,"context_line":"            )"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        security_service \u003d oscutils.find_resource("}],"source_content_type":"text/x-python","patch_set":4,"id":"25427386_eda9ce6b","line":288,"range":{"start_line":288,"start_character":57,"end_line":288,"end_character":60},"updated":"2024-03-19 17:52:12.000000000","message":"any of the optional arguments","commit_id":"76625f0b601f33caa26e41fcc983de79d8cb12ec"}],"manilaclient/tests/unit/osc/v2/test_security_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[{"line_number":252,"context_line":"    def test_share_security_service_set_missing_arg_params(self):"},{"line_number":253,"context_line":"        arglist \u003d ["},{"line_number":254,"context_line":"            self.security_service.id,"},{"line_number":255,"context_line":"            \u0027--dns-ip\u0027, self.security_service.dns_ip"},{"line_number":256,"context_line":"        ]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"fe082aed_138458db","line":255,"range":{"start_line":255,"start_character":12,"end_line":255,"end_character":52},"updated":"2024-03-18 22:21:54.000000000","message":"this is a parameter; and including it will not trigger the check that you\u0027re adding","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    def test_share_security_service_set_missing_arg_params(self):"},{"line_number":253,"context_line":"        arglist \u003d ["},{"line_number":254,"context_line":"            self.security_service.id,"},{"line_number":255,"context_line":"            \u0027--dns-ip\u0027, self.security_service.dns_ip"},{"line_number":256,"context_line":"        ]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"a5051c26_1dd4f8c7","line":255,"range":{"start_line":255,"start_character":12,"end_line":255,"end_character":52},"in_reply_to":"fe082aed_138458db","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        verifylist \u003d ["},{"line_number":259,"context_line":"            (\u0027security_service\u0027, self.security_service.id),"},{"line_number":260,"context_line":"            (\u0027dns_ip\u0027, self.security_service.dns_ip)"},{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":2,"id":"19209174_f9bfdff8","line":260,"range":{"start_line":260,"start_character":11,"end_line":260,"end_character":52},"updated":"2024-03-18 22:21:54.000000000","message":"remove","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        verifylist \u003d ["},{"line_number":259,"context_line":"            (\u0027security_service\u0027, self.security_service.id),"},{"line_number":260,"context_line":"            (\u0027dns_ip\u0027, self.security_service.dns_ip)"},{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":2,"id":"305abaf6_6319f723","line":260,"range":{"start_line":260,"start_character":11,"end_line":260,"end_character":52},"in_reply_to":"19209174_f9bfdff8","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":264,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":265,"context_line":"        self.assertIsNone(result)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_share_security_service_set(self):"},{"line_number":268,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"eb2d0c65_24a6b074","line":265,"range":{"start_line":264,"start_character":8,"end_line":265,"end_character":33},"updated":"2024-03-18 22:21:54.000000000","message":"```\n\nself.assertRaises(exceptions.CommandError,\n                  self.cmd.take_action,\n                  arglist)\n                  \n```","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":264,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":265,"context_line":"        self.assertIsNone(result)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_share_security_service_set(self):"},{"line_number":268,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7dec82af_6927ef60","line":265,"range":{"start_line":264,"start_character":8,"end_line":265,"end_character":33},"in_reply_to":"eb2d0c65_24a6b074","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"32254c752f41f1672af4b6e97f596ade7e09edf3","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            (\u0027security_service\u0027, self.security_service.id),"},{"line_number":259,"context_line":"        ]"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":262,"context_line":"        self.assertRaises(exceptions.CommandError,"},{"line_number":263,"context_line":"                          self.cmd.take_action,"},{"line_number":264,"context_line":"                          arglist)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fda6cda5_66a8d82b","line":261,"in_reply_to":"35763525_a6e64de5","updated":"2024-03-19 14:14:50.000000000","message":"Fixed in patchset 4","commit_id":"655d294eda7d7c5e2fd06b2b4ad9a6c9c3ae47b9"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"d0195e55f0309ed104cb077a3e81ac0306fb3a92","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            (\u0027security_service\u0027, self.security_service.id),"},{"line_number":259,"context_line":"        ]"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":262,"context_line":"        self.assertRaises(exceptions.CommandError,"},{"line_number":263,"context_line":"                          self.cmd.take_action,"},{"line_number":264,"context_line":"                          arglist)"}],"source_content_type":"text/x-python","patch_set":3,"id":"35763525_a6e64de5","line":261,"in_reply_to":"71631dc0_c8960fa3","updated":"2024-03-19 14:13:52.000000000","message":"\u003e pep8: F841 local variable \u0027parsed_args\u0027 is assigned to but never used\n\nPlease fix.","commit_id":"655d294eda7d7c5e2fd06b2b4ad9a6c9c3ae47b9"}],"releasenotes/notes/bug-2032984-osc-operation-display-error-message-on-absent-optional-params-value-e39e1c752399e1c7.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bfe8031_728e7840","updated":"2024-03-18 22:21:54.000000000","message":"suggest cutting the file name short here.. maybe:\n\nreleasenotes/notes/bug-2032984-raise-missing-args-error-e39e1c752399e1c7.yaml","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b8ff0b9_7b6f0e28","in_reply_to":"6bfe8031_728e7840","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5321284cbf145f8e0a56e49574bd1ed0faca2939","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Display error message when an optional flag is used, but no value is passsed."},{"line_number":5,"context_line":"    See `launchpad bug #2032986 \u003chttps://launchpad.net/bugs/2032986\u003e`_ for more"},{"line_number":6,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0403cca1_da732712","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":81},"updated":"2024-03-18 22:21:54.000000000","message":"The \"openstack share security set\" command now displays an appropriate error message when optional arguments are entirely omitted.","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"},{"author":{"_account_id":36850,"name":"Solomon Barine Akpuru","display_name":"Solly","email":"solobarine@gmail.com","username":"solly47"},"change_message_id":"5a54b7863abfb3079b34ea1f9c78185ea997407d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Display error message when an optional flag is used, but no value is passsed."},{"line_number":5,"context_line":"    See `launchpad bug #2032986 \u003chttps://launchpad.net/bugs/2032986\u003e`_ for more"},{"line_number":6,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8372237b_e806d74c","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":81},"in_reply_to":"0403cca1_da732712","updated":"2024-03-19 13:03:34.000000000","message":"Done","commit_id":"c1d51096c3496a6298b093ca92eca1ca736a11e3"}]}