)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6e974f1628963c5bf4a622a7212e1a8259a8b53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"057cc617_2648fdf7","updated":"2024-03-28 23:03:15.000000000","message":"Hey tspyderboy; thanks for tackling this... you\u0027re getting good at this; can you also add a waiter to the OSC version of the \"share replica promote\" command? https://github.com/openstack/python-manilaclient/blob/3103b8c56aa9e0629ab40bd8bb7200e1427fe913/manilaclient/osc/v2/share_replicas.py#L339-L359","commit_id":"64c2041ce3348d405f90b54fbaf06bd3484c88b4"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"46c4b442c26575320cc1c9eb49071f2873f05570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d56e477b_8a749f58","in_reply_to":"057cc617_2648fdf7","updated":"2024-03-29 10:16:46.000000000","message":"Thanks, added test too for it.","commit_id":"64c2041ce3348d405f90b54fbaf06bd3484c88b4"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"07cbd4832067947bbf3f733ee0774260c5a94682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8d5488a_38c234f3","updated":"2024-03-31 19:57:44.000000000","message":"Please check again\nThanks","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"84e7fcfce50e05e90997ea41ceb1aa4ce9e1cd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"964ac8da_9e654a98","updated":"2024-04-05 17:15:11.000000000","message":"Thanks tspyderboy. A few more comments inline..","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"73cf7a4349f6b97a9c43129c04db3e66d1177acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ad10d80_255dada3","updated":"2024-05-16 08:14:37.000000000","message":"manila client has been deprecated, just update OSC is ok.\nit is not necessary to upate manilaclient/v2/shell.py\nbut it also LGTM.","commit_id":"789e65bee3156d861c813f290e6f87153aaea3b3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5f3401af7a0cbf83b8fcf8b9fef2b61ff7a31d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3b41fe5_45aaa2ce","updated":"2024-05-15 22:09:18.000000000","message":"thanks for your patience with the review here; I tested this and it looks good! Good work tspyderboy!\n\nrecheck\n\nlets get some new logs","commit_id":"789e65bee3156d861c813f290e6f87153aaea3b3"}],"manilaclient/osc/v2/share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b559756470250b0970ce743e3ca84e3743371e63","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        except Exception as e:"},{"line_number":387,"context_line":"            raise exceptions.CommandError(_("},{"line_number":388,"context_line":"                \"Failed to promote replica to \u0027active\u0027: %s\" % (e)))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class ResyncShareReplica(command.Command):"},{"line_number":392,"context_line":"    \"\"\"Resync share replica\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9196d66e_30b12b75","line":389,"updated":"2024-03-29 18:43:52.000000000","message":"you\u0027ve to implement the waiting?","commit_id":"8265b7e102b7c0b66f3b8895622444d7799dee7e"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"07cbd4832067947bbf3f733ee0774260c5a94682","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        except Exception as e:"},{"line_number":387,"context_line":"            raise exceptions.CommandError(_("},{"line_number":388,"context_line":"                \"Failed to promote replica to \u0027active\u0027: %s\" % (e)))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class ResyncShareReplica(command.Command):"},{"line_number":392,"context_line":"    \"\"\"Resync share replica\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"2cd60093_021b470a","line":389,"in_reply_to":"3e3b9c98_389250aa","updated":"2024-03-31 19:57:44.000000000","message":"Done","commit_id":"8265b7e102b7c0b66f3b8895622444d7799dee7e"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"34c7cdde720e83d9d0f538a4f2deca105d12e52b","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        except Exception as e:"},{"line_number":387,"context_line":"            raise exceptions.CommandError(_("},{"line_number":388,"context_line":"                \"Failed to promote replica to \u0027active\u0027: %s\" % (e)))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class ResyncShareReplica(command.Command):"},{"line_number":392,"context_line":"    \"\"\"Resync share replica\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3e3b9c98_389250aa","line":389,"in_reply_to":"9196d66e_30b12b75","updated":"2024-03-29 19:44:30.000000000","message":"Hi for,\n            if parsed_args.wait:\n                if not osc_utils.wait_for_status(\n                        status_f\u003dshare_client.share_replicas.get,\n                        res_id\u003dreplica.id,\n                        success_status\u003d[\u0027available\u0027]\n                ):\n\nSo, the success_status should be \u0027active\u0027 or \u0027available\u0027? Also, is there any documentation for the same, to have a better understanding.","commit_id":"8265b7e102b7c0b66f3b8895622444d7799dee7e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"84e7fcfce50e05e90997ea41ceb1aa4ce9e1cd1e","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                if not osc_utils.wait_for_status("},{"line_number":388,"context_line":"                        status_f\u003dshare_client.share_replicas.get,"},{"line_number":389,"context_line":"                        res_id\u003dreplica.id,"},{"line_number":390,"context_line":"                        success_status\u003d[\u0027active\u0027]"},{"line_number":391,"context_line":"                ):"},{"line_number":392,"context_line":"                    LOG.error(_(\"ERROR: Share replica is in error state.\"))"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8999f32e_085d06d4","line":390,"range":{"start_line":390,"start_character":48,"end_line":390,"end_character":49},"updated":"2024-04-05 17:15:11.000000000","message":"you need to set \"status_field\" to \"replica_state\" in this call. Please see:\n\n\nhttps://opendev.org/openstack/osc-lib/src/commit/41b8a44f696d14a84b5d93e2c76f96a4ec73901e/osc_lib/utils/__init__.py#L717","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"8c492420704ddf6641e8d1f5860dd73c5d5f9212","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                if not osc_utils.wait_for_status("},{"line_number":388,"context_line":"                        status_f\u003dshare_client.share_replicas.get,"},{"line_number":389,"context_line":"                        res_id\u003dreplica.id,"},{"line_number":390,"context_line":"                        success_status\u003d[\u0027active\u0027]"},{"line_number":391,"context_line":"                ):"},{"line_number":392,"context_line":"                    LOG.error(_(\"ERROR: Share replica is in error state.\"))"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"66756b89_5530e7a7","line":390,"range":{"start_line":390,"start_character":48,"end_line":390,"end_character":49},"in_reply_to":"8999f32e_085d06d4","updated":"2024-04-10 05:19:51.000000000","message":"Acknowledged","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"}],"manilaclient/tests/unit/osc/v2/test_share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"84e7fcfce50e05e90997ea41ceb1aa4ce9e1cd1e","unresolved":true,"context_lines":[{"line_number":619,"context_line":"        self.share_replica \u003d ("},{"line_number":620,"context_line":"            manila_fakes.FakeShareReplica.create_one_replica("},{"line_number":621,"context_line":"                attrs\u003d{"},{"line_number":622,"context_line":"                    \u0027status\u0027: \u0027active\u0027}"},{"line_number":623,"context_line":"            )"},{"line_number":624,"context_line":"        )"},{"line_number":625,"context_line":"        self.replicas_mock.get.return_value \u003d self.share_replica"}],"source_content_type":"text/x-python","patch_set":4,"id":"cccb9bbe_0587d657","line":622,"range":{"start_line":622,"start_character":21,"end_line":622,"end_character":27},"updated":"2024-04-05 17:15:11.000000000","message":"\"active\" is a \"replica_state\", not \"status\". A valid status would be \"available\"","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"8c492420704ddf6641e8d1f5860dd73c5d5f9212","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        self.share_replica \u003d ("},{"line_number":620,"context_line":"            manila_fakes.FakeShareReplica.create_one_replica("},{"line_number":621,"context_line":"                attrs\u003d{"},{"line_number":622,"context_line":"                    \u0027status\u0027: \u0027active\u0027}"},{"line_number":623,"context_line":"            )"},{"line_number":624,"context_line":"        )"},{"line_number":625,"context_line":"        self.replicas_mock.get.return_value \u003d self.share_replica"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c6d7d00_4472e7b2","line":622,"range":{"start_line":622,"start_character":21,"end_line":622,"end_character":27},"in_reply_to":"cccb9bbe_0587d657","updated":"2024-04-10 05:19:51.000000000","message":"Acknowledged","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"84e7fcfce50e05e90997ea41ceb1aa4ce9e1cd1e","unresolved":true,"context_lines":[{"line_number":676,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        self.replicas_mock.promote.assert_called_with("},{"line_number":679,"context_line":"            self.share_replica)"},{"line_number":680,"context_line":"        self.assertIsNone(result)"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def test_share_replica_promote_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"c5997589_59181499","line":679,"range":{"start_line":679,"start_character":30,"end_line":679,"end_character":31},"updated":"2024-04-05 17:15:11.000000000","message":"assert the waiter was called with the params you expect..","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"8c492420704ddf6641e8d1f5860dd73c5d5f9212","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        self.replicas_mock.promote.assert_called_with("},{"line_number":679,"context_line":"            self.share_replica)"},{"line_number":680,"context_line":"        self.assertIsNone(result)"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def test_share_replica_promote_exception(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"747b1b6c_c7705ccc","line":679,"range":{"start_line":679,"start_character":30,"end_line":679,"end_character":31},"in_reply_to":"c5997589_59181499","updated":"2024-04-10 05:19:51.000000000","message":"Acknowledged","commit_id":"38f54eadc74fa2a00cd90cd60f5d81f572255a7a"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6e974f1628963c5bf4a622a7212e1a8259a8b53","unresolved":true,"context_lines":[{"line_number":6563,"context_line":"    if args.wait:"},{"line_number":6564,"context_line":"        _wait_for_resource_status("},{"line_number":6565,"context_line":"            cs, replica, resource_type\u003d\u0027share_replica\u0027,"},{"line_number":6566,"context_line":"            expected_status\u003d\u0027available\u0027)"},{"line_number":6567,"context_line":""},{"line_number":6568,"context_line":""},{"line_number":6569,"context_line":"@api_versions.wraps(\"2.47\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"810a16bd_28e0f7d4","line":6566,"range":{"start_line":6566,"start_character":12,"end_line":6566,"end_character":39},"updated":"2024-03-28 23:03:15.000000000","message":"while this can work, it doesn\u0027t prevent race conditions.. \n\ni suggest using \"status_attr\" as \"replica_state\" and wait until the expected_status\u003d\"active\"","commit_id":"64c2041ce3348d405f90b54fbaf06bd3484c88b4"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"46c4b442c26575320cc1c9eb49071f2873f05570","unresolved":false,"context_lines":[{"line_number":6563,"context_line":"    if args.wait:"},{"line_number":6564,"context_line":"        _wait_for_resource_status("},{"line_number":6565,"context_line":"            cs, replica, resource_type\u003d\u0027share_replica\u0027,"},{"line_number":6566,"context_line":"            expected_status\u003d\u0027available\u0027)"},{"line_number":6567,"context_line":""},{"line_number":6568,"context_line":""},{"line_number":6569,"context_line":"@api_versions.wraps(\"2.47\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fdbc79cd_07eed106","line":6566,"range":{"start_line":6566,"start_character":12,"end_line":6566,"end_character":39},"in_reply_to":"810a16bd_28e0f7d4","updated":"2024-03-29 10:16:46.000000000","message":"Sure, changed it to: \nexpected_status\u003d\u0027active\u0027,\nstatus_attr\u003d\u0027replica_state\u0027","commit_id":"64c2041ce3348d405f90b54fbaf06bd3484c88b4"}]}