)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"77a9a6b42ae829e738fa4605b5490934ba94c39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d52f119a_8c6ecfe2","updated":"2024-04-25 12:34:50.000000000","message":"cover and tox -e py38 are passing locally. \n\nrecheck","commit_id":"78977076a203132ae7155a3385d730613405f453"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a9a413cbd5c39e7a3c7d91ec0a39dea33ca87249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d09ee97_7d866deb","updated":"2024-04-25 14:30:18.000000000","message":"recheck","commit_id":"78977076a203132ae7155a3385d730613405f453"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4d6a5212caeef598faa37eed0309547be94056c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c6ae76f_18d15441","updated":"2024-05-06 06:22:01.000000000","message":"some comments. thanks for your change.","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8b07de7f3806c8bf2bb61e00324636b6b47a230d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"98be6d0f_bc349ac8","updated":"2024-05-09 03:42:03.000000000","message":"openstack share create support add encryption_key_id will be another patch?","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bab420a072b39d75b198550a26d0484827c2e56e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5413c1da_99f76cd1","updated":"2024-05-06 16:23:10.000000000","message":"recheck","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b7904283d73ee1d37321e233262ac399417bbd34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c49f1a24_52f15b13","updated":"2024-05-13 15:52:57.000000000","message":"recheck","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b7904283d73ee1d37321e233262ac399417bbd34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b76320d_63d3119a","in_reply_to":"98be6d0f_bc349ac8","updated":"2024-05-13 15:52:57.000000000","message":"yes","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"96c38c4f0ed527841713eea9c16b223601a5d75e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"317ed5ba_b2b0801a","updated":"2024-05-21 02:36:42.000000000","message":"client code LGTM.","commit_id":"101808552cc8753b19843c1087f9f785b9a3cab5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ac13eeac8565c7ba2edea90cef578ce4c3490ad9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d8d3df42_b436fa13","updated":"2025-01-29 15:07:05.000000000","message":"recheck","commit_id":"a2bc6dfa6a577789d974d47e8f168bd3301849f5"}],"manilaclient/osc/v2/share_types.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4d6a5212caeef598faa37eed0309547be94056c3","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    \u0027description\u0027"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ATTRIBUTES_WITH_ENCRYPT \u003d ["},{"line_number":39,"context_line":"    \u0027id\u0027,"},{"line_number":40,"context_line":"    \u0027name\u0027,"},{"line_number":41,"context_line":"    \u0027visibility\u0027,"},{"line_number":42,"context_line":"    \u0027is_default\u0027,"},{"line_number":43,"context_line":"    \u0027required_extra_specs\u0027,"},{"line_number":44,"context_line":"    \u0027optional_extra_specs\u0027,"},{"line_number":45,"context_line":"    \u0027description\u0027,"},{"line_number":46,"context_line":"    \u0027encryption\u0027"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def format_share_type(share_type, formatter\u003d\u0027table\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fcbe5e48_1cd99fd7","line":47,"range":{"start_line":38,"start_character":0,"end_line":47,"end_character":1},"updated":"2024-05-06 06:22:01.000000000","message":"ATTRIBUTES_WITH_ENCRYPT \u003d ATTRIBUTES.append(\u0027encryption\u0027)","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"906a1c34d118a8a8adef7ec0548d4be7a6ff2669","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027description\u0027"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ATTRIBUTES_WITH_ENCRYPT \u003d ["},{"line_number":39,"context_line":"    \u0027id\u0027,"},{"line_number":40,"context_line":"    \u0027name\u0027,"},{"line_number":41,"context_line":"    \u0027visibility\u0027,"},{"line_number":42,"context_line":"    \u0027is_default\u0027,"},{"line_number":43,"context_line":"    \u0027required_extra_specs\u0027,"},{"line_number":44,"context_line":"    \u0027optional_extra_specs\u0027,"},{"line_number":45,"context_line":"    \u0027description\u0027,"},{"line_number":46,"context_line":"    \u0027encryption\u0027"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def format_share_type(share_type, formatter\u003d\u0027table\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9409acd_3b12d887","line":47,"range":{"start_line":38,"start_character":0,"end_line":47,"end_character":1},"in_reply_to":"634f3f6d_e37bd8ad","updated":"2024-05-07 02:44:18.000000000","message":"Done","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ba96d45bcf2beb99f3adf03683feff89b9be8d0d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027description\u0027"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ATTRIBUTES_WITH_ENCRYPT \u003d ["},{"line_number":39,"context_line":"    \u0027id\u0027,"},{"line_number":40,"context_line":"    \u0027name\u0027,"},{"line_number":41,"context_line":"    \u0027visibility\u0027,"},{"line_number":42,"context_line":"    \u0027is_default\u0027,"},{"line_number":43,"context_line":"    \u0027required_extra_specs\u0027,"},{"line_number":44,"context_line":"    \u0027optional_extra_specs\u0027,"},{"line_number":45,"context_line":"    \u0027description\u0027,"},{"line_number":46,"context_line":"    \u0027encryption\u0027"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def format_share_type(share_type, formatter\u003d\u0027table\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"634f3f6d_e37bd8ad","line":47,"range":{"start_line":38,"start_character":0,"end_line":47,"end_character":1},"in_reply_to":"fcbe5e48_1cd99fd7","updated":"2024-05-06 11:37:54.000000000","message":"py38 tests run in parallel and causes different values of ATTRIBUTES at a time. Thus test fails. So we need to assign them separately.","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4d6a5212caeef598faa37eed0309547be94056c3","unresolved":true,"context_lines":[{"line_number":257,"context_line":"        share_type \u003d share_client.share_types.create(**kwargs)"},{"line_number":258,"context_line":"        formatted_type \u003d format_share_type(share_type, parsed_args.formatter)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if encryption:"},{"line_number":261,"context_line":"            attrib \u003d ATTRIBUTES_WITH_ENCRYPT"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            attrib \u003d ATTRIBUTES"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return (attrib, oscutils.get_dict_properties("},{"line_number":266,"context_line":"                formatted_type._info, attrib))"}],"source_content_type":"text/x-python","patch_set":4,"id":"72cae236_037e3e0c","line":263,"range":{"start_line":260,"start_character":8,"end_line":263,"end_character":31},"updated":"2024-05-06 06:22:01.000000000","message":"attrib \u003d ATTRIBUTES_WITH_ENCRYPT if encryption else ATTRIBUTES","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ba96d45bcf2beb99f3adf03683feff89b9be8d0d","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        share_type \u003d share_client.share_types.create(**kwargs)"},{"line_number":258,"context_line":"        formatted_type \u003d format_share_type(share_type, parsed_args.formatter)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if encryption:"},{"line_number":261,"context_line":"            attrib \u003d ATTRIBUTES_WITH_ENCRYPT"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            attrib \u003d ATTRIBUTES"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return (attrib, oscutils.get_dict_properties("},{"line_number":266,"context_line":"                formatted_type._info, attrib))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5768d1_afa84b4b","line":263,"range":{"start_line":260,"start_character":8,"end_line":263,"end_character":31},"in_reply_to":"72cae236_037e3e0c","updated":"2024-05-06 11:37:54.000000000","message":"Done","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4d6a5212caeef598faa37eed0309547be94056c3","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            cmd +\u003d f\u0027 --encryption-cipher {encryption_cipher}\u0027"},{"line_number":237,"context_line":"        if encryption_provider:"},{"line_number":238,"context_line":"            cmd +\u003d f\u0027 --encryption-provider {encryption_provider}\u0027"},{"line_number":239,"context_line":"        if encryption_key_sizer:"},{"line_number":240,"context_line":"            cmd +\u003d f\u0027 --encryption-key-size {encryption_key_size}\u0027"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if formatter \u003d\u003d \u0027json\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"b1c88579_719bd418","line":239,"range":{"start_line":239,"start_character":11,"end_line":239,"end_character":31},"updated":"2024-05-06 06:22:01.000000000","message":"encryption_key_size","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ba96d45bcf2beb99f3adf03683feff89b9be8d0d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            cmd +\u003d f\u0027 --encryption-cipher {encryption_cipher}\u0027"},{"line_number":237,"context_line":"        if encryption_provider:"},{"line_number":238,"context_line":"            cmd +\u003d f\u0027 --encryption-provider {encryption_provider}\u0027"},{"line_number":239,"context_line":"        if encryption_key_sizer:"},{"line_number":240,"context_line":"            cmd +\u003d f\u0027 --encryption-key-size {encryption_key_size}\u0027"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        if formatter \u003d\u003d \u0027json\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"549705ad_82326cf9","line":239,"range":{"start_line":239,"start_character":11,"end_line":239,"end_character":31},"in_reply_to":"b1c88579_719bd418","updated":"2024-05-06 11:37:54.000000000","message":"Done","commit_id":"1b64b957740eae6e0d8d634d21b1cd66fb3f7316"}],"manilaclient/tests/functional/osc/test_share_types.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"906a1c34d118a8a8adef7ec0548d4be7a6ff2669","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            extra_specs\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        types_list \u003d self.listing_result("},{"line_number":134,"context_line":"            \u0027share type\u0027, \u0027list --all\u0027, client\u003dself.admin_client)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.assertTableStruct(types_list, ["},{"line_number":137,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"50fcc307_26f67374","line":134,"range":{"start_line":134,"start_character":27,"end_line":134,"end_character":37},"updated":"2024-05-07 02:44:18.000000000","message":"\u0027list --all --encryption-type\u0027","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"fe60e2194e0b1717e926b94428ffe14ee88a2e7f","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            extra_specs\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        types_list \u003d self.listing_result("},{"line_number":134,"context_line":"            \u0027share type\u0027, \u0027list --all\u0027, client\u003dself.admin_client)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.assertTableStruct(types_list, ["},{"line_number":137,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"6952edf5_6cea6b9b","line":134,"range":{"start_line":134,"start_character":27,"end_line":134,"end_character":37},"in_reply_to":"50fcc307_26f67374","updated":"2024-05-14 01:04:40.000000000","message":"you need add --encryption-type this to fix zuul error. and then recheck.\n\n    types_list \u003d self.listing_result(\n            \u0027share type\u0027, \u0027list --all --encryption-type\u0027, client\u003dself.admin_client)","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3f41829e31b059a0614b5c6e553e0eb62a234950","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            extra_specs\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        types_list \u003d self.listing_result("},{"line_number":134,"context_line":"            \u0027share type\u0027, \u0027list --all\u0027, client\u003dself.admin_client)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.assertTableStruct(types_list, ["},{"line_number":137,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b152ccf4_c8952b4c","line":134,"range":{"start_line":134,"start_character":27,"end_line":134,"end_character":37},"in_reply_to":"6952edf5_6cea6b9b","updated":"2024-05-15 10:32:24.000000000","message":"Done","commit_id":"0d0d78a2dea3720cf9c1e19091207b5adacecf4c"}]}