)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"35982e076e1b671545585493441709ed4828c4ad","unresolved":true,"context_lines":[{"line_number":11,"context_line":"ID field to the share servers list to be used as a search option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8071f7218101f9fcee059d943494b5914a89ba1a"},{"line_number":14,"context_line":"Closes-Bug: #2068631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"97b1fe16_494d21d0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2024-07-22 15:22:10.000000000","message":"This bug has a note at the end:\n\n\"In the same spirit: maybe add filter for \u0027identifier\u0027, too?\"\n\nDo we want to create a different low-hanging-fruit bug for that?","commit_id":"e561e6e8a22cf4a8a317d5fbf9c39347cfc4bdcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6e21931ae658f750fe8ac6c93b59e869a05372d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ID field to the share servers list to be used as a search option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8071f7218101f9fcee059d943494b5914a89ba1a"},{"line_number":14,"context_line":"Closes-Bug: #2068631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6de89500_17c55144","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"97b1fe16_494d21d0","updated":"2024-07-22 17:03:02.000000000","message":"As I was already touching that part of the code, don\u0027t mind doing the edit. Please check the latest PS","commit_id":"e561e6e8a22cf4a8a317d5fbf9c39347cfc4bdcc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"35982e076e1b671545585493441709ed4828c4ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57f9ca8d_b9b6f8ed","updated":"2024-07-22 15:22:10.000000000","message":"Thanks Carlos!","commit_id":"e561e6e8a22cf4a8a317d5fbf9c39347cfc4bdcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eea308998421bb59e045b560a94cf72a59aecfec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7236acef_0ac2e8b5","updated":"2024-07-22 17:03:15.000000000","message":"Thanks for the review, please take a look at the most recent PS :)","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c65964dbe0991391efc9465bdf032adb2c799b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"808195a5_71440b1b","updated":"2024-07-22 19:45:34.000000000","message":"there\u0027s a typo in the error message; and i\u0027ve asked to revise another error message for consistency","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"8906a9cba3c6cb904b638be6074a21a4f501dcfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f77833e6_8e10fd7d","updated":"2024-07-24 14:41:03.000000000","message":"LGTM, \nnit:patch description you replace \"back end\" to \"backend\" as \"backend\" is more commonly used compare to \"back end\"","commit_id":"c8b1665d639ce7a9d4bd183a85178fc2b100da8c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1552069b6c297bc21b22d042e0fe733b3c01d1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9523cb39_f8c43c9d","updated":"2024-07-26 08:22:58.000000000","message":"LGTM, thanks.","commit_id":"c8b1665d639ce7a9d4bd183a85178fc2b100da8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"515b8bec63ce4202b608e3413b416bb887390d6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4dcd44f_0ab9974d","updated":"2024-07-23 23:26:03.000000000","message":"LGTM; thank you","commit_id":"c8b1665d639ce7a9d4bd183a85178fc2b100da8c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0fc70519e70d1f9af25a36ffdef3dd05346bc3e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a81ac0ad_f332221c","updated":"2024-07-23 13:10:43.000000000","message":"Thanks for the review, PTAL","commit_id":"c8b1665d639ce7a9d4bd183a85178fc2b100da8c"}],"manilaclient/osc/v2/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c65964dbe0991391efc9465bdf032adb2c799b5","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        if (parsed_args.identifier and"},{"line_number":181,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.49\")):"},{"line_number":182,"context_line":"            raise exceptions.CommandError("},{"line_number":183,"context_line":"                \"Filtering by identifyier is only allowed with manila API \""},{"line_number":184,"context_line":"                \"version \u003e\u003d 2.49.\""},{"line_number":185,"context_line":"            )"},{"line_number":186,"context_line":"        if (parsed_args.share_network_subnet and"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fac9d5f_8c4e1dd9","line":183,"range":{"start_line":183,"start_character":30,"end_line":183,"end_character":41},"updated":"2024-07-22 19:45:34.000000000","message":"identifier","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0fc70519e70d1f9af25a36ffdef3dd05346bc3e0","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        if (parsed_args.identifier and"},{"line_number":181,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.49\")):"},{"line_number":182,"context_line":"            raise exceptions.CommandError("},{"line_number":183,"context_line":"                \"Filtering by identifyier is only allowed with manila API \""},{"line_number":184,"context_line":"                \"version \u003e\u003d 2.49.\""},{"line_number":185,"context_line":"            )"},{"line_number":186,"context_line":"        if (parsed_args.share_network_subnet and"}],"source_content_type":"text/x-python","patch_set":4,"id":"3450421e_4a3a89ac","line":183,"range":{"start_line":183,"start_character":30,"end_line":183,"end_character":41},"in_reply_to":"4fac9d5f_8c4e1dd9","updated":"2024-07-23 13:10:43.000000000","message":"Done","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c65964dbe0991391efc9465bdf032adb2c799b5","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        if (parsed_args.source_share_server_id and"},{"line_number":193,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.57\")):"},{"line_number":194,"context_line":"            raise exceptions.CommandError("},{"line_number":195,"context_line":"                \"Share server migration is only supported for API \""},{"line_number":196,"context_line":"                \"version \u003e\u003d 2.57.\""},{"line_number":197,"context_line":"            )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        columns \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"4cbb00da_729e707e","line":196,"range":{"start_line":195,"start_character":16,"end_line":196,"end_character":34},"updated":"2024-07-22 19:45:34.000000000","message":"The error needs to call out what was incorrect; \n\n```suggestion\n                \"Filtering by source_share_server_id is not only allowed with \"\n                \"manila API version \u003e\u003d2.57.\"\n                \n```","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0fc70519e70d1f9af25a36ffdef3dd05346bc3e0","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if (parsed_args.source_share_server_id and"},{"line_number":193,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.57\")):"},{"line_number":194,"context_line":"            raise exceptions.CommandError("},{"line_number":195,"context_line":"                \"Share server migration is only supported for API \""},{"line_number":196,"context_line":"                \"version \u003e\u003d 2.57.\""},{"line_number":197,"context_line":"            )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        columns \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"84b7b116_a118c9f8","line":196,"range":{"start_line":195,"start_character":16,"end_line":196,"end_character":34},"in_reply_to":"4cbb00da_729e707e","updated":"2024-07-23 13:10:43.000000000","message":"Done","commit_id":"a15f01cd8fa7707415f4deebc6e38135c934d3b7"}],"releasenotes/notes/bug-2068631-add-filter-by-source-share-server-id-d40500dcf184c321.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"35982e076e1b671545585493441709ed4828c4ad","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Share server list commands now support filtering share servers by source"},{"line_number":5,"context_line":"    share server IDs. For more details, please refer to"},{"line_number":6,"context_line":"    `Launchpad bug #1896949 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2068631\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"be7f20bd_1740944c","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":30},"updated":"2024-07-22 15:22:10.000000000","message":"there\u0027s only one?","commit_id":"e561e6e8a22cf4a8a317d5fbf9c39347cfc4bdcc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6e21931ae658f750fe8ac6c93b59e869a05372d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Share server list commands now support filtering share servers by source"},{"line_number":5,"context_line":"    share server IDs. For more details, please refer to"},{"line_number":6,"context_line":"    `Launchpad bug #1896949 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2068631\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9cd029a9_1dc8c637","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":30},"in_reply_to":"be7f20bd_1740944c","updated":"2024-07-22 17:03:02.000000000","message":"yep :) fixed","commit_id":"e561e6e8a22cf4a8a317d5fbf9c39347cfc4bdcc"}]}