)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bb1f4d71a4e5a86711b30b45aee25fbcd827e18","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add ensure shares command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new command to trigger the ensure shares API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If40328c83ec4c87d727aceac89a1a14b9fd8a25d"},{"line_number":12,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f80aa61b_1f0501c8","line":10,"updated":"2024-09-03 22:22:08.000000000","message":"Depends-On: If7bf059eb8581f20a3ceb7c1af93558774f4ef5e","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6843fe7276f1d7dd8116f49b6e73f940f8a371a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ensure shares command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a new command to trigger the ensure shares API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If40328c83ec4c87d727aceac89a1a14b9fd8a25d"},{"line_number":12,"context_line":"Signed-off-by: Carlos Eduardo \u003cces.eduardo98@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cb77c6d0_1dd2c2cf","line":10,"in_reply_to":"f80aa61b_1f0501c8","updated":"2024-09-13 20:10:07.000000000","message":"Done","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"93ad001fe1cf82aa920ee68c9c099c002b2c5f9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72649059_d7678566","updated":"2024-08-30 06:26:26.000000000","message":"Thanks Carlos; some comments inline","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3346723177b68845891d8fe74641dc93f7402f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45c40b1b_25568ff7","updated":"2024-08-30 18:59:26.000000000","message":"Thanks for the review, please take another look :)","commit_id":"53c04febacf47f8f3907fd6566f2f2460b5c04d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6914d538eab947970d009c79c3f9aa90a03aecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"425d4fea_d1e738ad","updated":"2024-09-03 23:03:39.000000000","message":"Hey Carlos; i\u0027ve workflowed the manila patch.. you can keep the dependency on the export location metadata change if you\u0027d like here; but, it\u0027ll bump the API version to 2.87... so you\u0027ll need a rebase anyway.","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bb1f4d71a4e5a86711b30b45aee25fbcd827e18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"497838f8_42ec251e","updated":"2024-09-03 22:22:08.000000000","message":"Thanks Carlos; minor comments inline","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ad55bf3a4f99ccf7f071500df56c2311e6d39b1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c9fd70cc_7c9671d2","updated":"2024-09-19 20:27:50.000000000","message":"LGTM, thanks for adding cli support to this new feature","commit_id":"85110db866fe1012393039f3429a2e97c913ee8c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aecb6ed208ef12d015bc5376b04d0688bc099264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3e6576f1_6deb8ebf","updated":"2024-11-07 20:25:28.000000000","message":"A minor issue that you can address in a follow up.. \n\nthanks Carlos!","commit_id":"baa0091d539060d6cf253fb0b23d8aaa7be84e81"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b500b23850832e83681f6fd5dc7cbfe90af6d409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4a06f7e8_98164658","updated":"2024-11-07 20:25:59.000000000","message":"Ah; a rebase was done, @ashrod98@redhat.com - can you please re-review and workflow?","commit_id":"baa0091d539060d6cf253fb0b23d8aaa7be84e81"}],"manilaclient/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bb1f4d71a4e5a86711b30b45aee25fbcd827e18","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    def _accept(self, url, body):"},{"line_number":202,"context_line":"        resp, body \u003d self.api.client.post(url, body\u003dbody)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _ensure_shares(self, url, body):"},{"line_number":205,"context_line":"        resp, body \u003d self.api.client.post(url, body\u003dbody)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _delete(self, url):"},{"line_number":208,"context_line":"        resp, body \u003d self.api.client.delete(url)"}],"source_content_type":"text/x-python","patch_set":7,"id":"de7bbd91_8b569fa6","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":57},"updated":"2024-09-03 22:22:08.000000000","message":"this is relevant only to services.. so move it to the Service","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6843fe7276f1d7dd8116f49b6e73f940f8a371a4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _accept(self, url, body):"},{"line_number":202,"context_line":"        resp, body \u003d self.api.client.post(url, body\u003dbody)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _ensure_shares(self, url, body):"},{"line_number":205,"context_line":"        resp, body \u003d self.api.client.post(url, body\u003dbody)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _delete(self, url):"},{"line_number":208,"context_line":"        resp, body \u003d self.api.client.delete(url)"}],"source_content_type":"text/x-python","patch_set":7,"id":"90e131a2_b106141f","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":57},"in_reply_to":"de7bbd91_8b569fa6","updated":"2024-09-13 20:10:07.000000000","message":"Done","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"}],"manilaclient/osc/v2/services.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"afe36f52e9367f1819404bc6e891a34c1bb4ead4","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":156,"context_line":"            service._info, columns) for service in services)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return (columns, data)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class EnsureShareService(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e829aaef_8140af25","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":30},"updated":"2024-08-30 13:11:48.000000000","message":"add ensuring field to this method","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bb1f4d71a4e5a86711b30b45aee25fbcd827e18","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":156,"context_line":"            service._info, columns) for service in services)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return (columns, data)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class EnsureShareService(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b71c821_51b8a6c1","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":30},"in_reply_to":"e829aaef_8140af25","updated":"2024-09-03 22:22:08.000000000","message":"?","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6843fe7276f1d7dd8116f49b6e73f940f8a371a4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":156,"context_line":"            service._info, columns) for service in services)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return (columns, data)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class EnsureShareService(command.Command):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a87c7d4_7b381aa0","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":30},"in_reply_to":"e829aaef_8140af25","updated":"2024-09-13 20:10:07.000000000","message":"Done","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"93ad001fe1cf82aa920ee68c9c099c002b2c5f9a","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        return (columns, data)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class EnsureShareService(command.Command):"},{"line_number":162,"context_line":"    \"\"\"Run ensure shares in a back end (Admin only).\"\"\""},{"line_number":163,"context_line":"    _description \u003d _(\"Run ensure shares in a back end (Admin only).\")"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"19d1ce0a_372bb393","line":161,"updated":"2024-08-30 06:26:26.000000000","message":"unit tests please; functional testing will be very hard because we run tests with concurrency \u003e 1","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3346723177b68845891d8fe74641dc93f7402f8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return (columns, data)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class EnsureShareService(command.Command):"},{"line_number":162,"context_line":"    \"\"\"Run ensure shares in a back end (Admin only).\"\"\""},{"line_number":163,"context_line":"    _description \u003d _(\"Run ensure shares in a back end (Admin only).\")"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"437bd79b_eaebc10d","line":161,"in_reply_to":"19d1ce0a_372bb393","updated":"2024-08-30 18:59:26.000000000","message":"Done","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"87e405099cd9f6643ab4ead33da07a7bec3fd49a","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        ]"},{"line_number":152,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.83\"):"},{"line_number":153,"context_line":"            columns.append(\u0027Disabled Reason\u0027)"},{"line_number":154,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.87\"):"},{"line_number":155,"context_line":"            columns.append(\u0027Ensuring\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        data \u003d (osc_utils.get_dict_properties("}],"source_content_type":"text/x-python","patch_set":10,"id":"b511def9_6cc7c55b","line":154,"range":{"start_line":154,"start_character":64,"end_line":154,"end_character":68},"updated":"2024-09-18 17:37:18.000000000","message":"2.86","commit_id":"d1bff9009cc594d393b1884fc69e0100d8475960"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"66e1feed9630b182aa6475bbadf94c373e3e400a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        ]"},{"line_number":152,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.83\"):"},{"line_number":153,"context_line":"            columns.append(\u0027Disabled Reason\u0027)"},{"line_number":154,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.87\"):"},{"line_number":155,"context_line":"            columns.append(\u0027Ensuring\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        data \u003d (osc_utils.get_dict_properties("}],"source_content_type":"text/x-python","patch_set":10,"id":"1c95f852_fb6f0150","line":154,"range":{"start_line":154,"start_character":64,"end_line":154,"end_character":68},"in_reply_to":"b511def9_6cc7c55b","updated":"2024-09-18 18:36:39.000000000","message":"good catch, thanks!","commit_id":"d1bff9009cc594d393b1884fc69e0100d8475960"}],"manilaclient/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a74fdb919d6bc78f7b8c8c47b49347e3c80e8787","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        return self._do_disable(host, binary, RESOURCE_PATH,"},{"line_number":88,"context_line":"                                disable_reason\u003ddisable_reason)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @api_versions.wraps(\"2.86\")  # noqa"},{"line_number":91,"context_line":"    def ensure_shares(self, host):  # noqa"},{"line_number":92,"context_line":"        resource_path \u003d f\u0027{RESOURCE_PATH}/ensure_shares\u0027"},{"line_number":93,"context_line":"        body \u003d {\"host\": host}"}],"source_content_type":"text/x-python","patch_set":4,"id":"61d32bea_2f09099f","line":90,"range":{"start_line":90,"start_character":33,"end_line":90,"end_character":39},"updated":"2024-08-30 06:25:13.000000000","message":"these #noqa\u0027s aren\u0027t needed i think; try dropping them","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3346723177b68845891d8fe74641dc93f7402f8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return self._do_disable(host, binary, RESOURCE_PATH,"},{"line_number":88,"context_line":"                                disable_reason\u003ddisable_reason)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @api_versions.wraps(\"2.86\")  # noqa"},{"line_number":91,"context_line":"    def ensure_shares(self, host):  # noqa"},{"line_number":92,"context_line":"        resource_path \u003d f\u0027{RESOURCE_PATH}/ensure_shares\u0027"},{"line_number":93,"context_line":"        body \u003d {\"host\": host}"}],"source_content_type":"text/x-python","patch_set":4,"id":"96d084a0_59073ae6","line":90,"range":{"start_line":90,"start_character":33,"end_line":90,"end_character":39},"in_reply_to":"61d32bea_2f09099f","updated":"2024-08-30 18:59:26.000000000","message":"Done","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bb1f4d71a4e5a86711b30b45aee25fbcd827e18","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    def ensure_shares(self, host):  # noqa"},{"line_number":92,"context_line":"        resource_path \u003d f\u0027{RESOURCE_PATH}/ensure_shares\u0027"},{"line_number":93,"context_line":"        body \u003d {\"host\": host}"},{"line_number":94,"context_line":"        return self._ensure_shares(resource_path, body)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def server_api_version(self, url_append\u003d\"\"):"},{"line_number":97,"context_line":"        \"\"\"Returns the API Version supported by the server."}],"source_content_type":"text/x-python","patch_set":7,"id":"85d64130_edfcf89b","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":34},"updated":"2024-09-03 22:22:08.000000000","message":"Move the `_ensure_shares` method to this class..","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6843fe7276f1d7dd8116f49b6e73f940f8a371a4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def ensure_shares(self, host):  # noqa"},{"line_number":92,"context_line":"        resource_path \u003d f\u0027{RESOURCE_PATH}/ensure_shares\u0027"},{"line_number":93,"context_line":"        body \u003d {\"host\": host}"},{"line_number":94,"context_line":"        return self._ensure_shares(resource_path, body)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def server_api_version(self, url_append\u003d\"\"):"},{"line_number":97,"context_line":"        \"\"\"Returns the API Version supported by the server."}],"source_content_type":"text/x-python","patch_set":7,"id":"8d8cb9ef_d9d70a41","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":34},"in_reply_to":"85d64130_edfcf89b","updated":"2024-09-13 20:10:07.000000000","message":"Done","commit_id":"817573f2b8914c4daf416e68014ba4526cefa062"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aecb6ed208ef12d015bc5376b04d0688bc099264","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                                disable_reason\u003ddisable_reason)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @api_versions.wraps(\"2.86\")"},{"line_number":91,"context_line":"    def ensure_shares(self, host):  # noqa"},{"line_number":92,"context_line":"        resource_path \u003d f\u0027{RESOURCE_PATH}/ensure_shares\u0027"},{"line_number":93,"context_line":"        body \u003d {\"host\": host}"},{"line_number":94,"context_line":"        return self.api.client.post(resource_path, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ba0f411_42f9f2ea","line":91,"range":{"start_line":91,"start_character":36,"end_line":91,"end_character":42},"updated":"2024-11-07 20:25:28.000000000","message":"not necessary","commit_id":"baa0091d539060d6cf253fb0b23d8aaa7be84e81"}],"releasenotes/notes/add-ensure-shares-command-6cd854408de1979b.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a74fdb919d6bc78f7b8c8c47b49347e3c80e8787","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting from API version 2.87, it is possible to run ensure shares"},{"line_number":5,"context_line":"    on a given manila-share host, in order to update the shares"},{"line_number":6,"context_line":"    information."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"308edb86_420117e3","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":34},"updated":"2024-08-30 06:25:13.000000000","message":"this may eventually be the case; but in this patch, its still 2.86","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3346723177b68845891d8fe74641dc93f7402f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting from API version 2.87, it is possible to run ensure shares"},{"line_number":5,"context_line":"    on a given manila-share host, in order to update the shares"},{"line_number":6,"context_line":"    information."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1b903850_83d9ec84","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":34},"in_reply_to":"308edb86_420117e3","updated":"2024-08-30 18:59:26.000000000","message":"Done","commit_id":"c282ee2da4ac9d1893bcd9ccf1dd285b4103eeed"}]}