)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98010611c985a09102c5ba1a25473d0f2546aac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"00ff8233_42b5bee5","updated":"2026-01-17 03:25:31.000000000","message":"recheck\n\n\n(checking if gate\u0027s fine)","commit_id":"4b6b0a1c695d2bc7c453ed7eccf146d293c24a39"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55212734ad9a3ea81f611b199048a16a6c0e05c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3833899d_7cb61860","updated":"2026-02-19 18:39:47.000000000","message":"recheck\nlogs are gone","commit_id":"4b6b0a1c695d2bc7c453ed7eccf146d293c24a39"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4e0f7094fe30f483eea074809dd7145b8966ec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"136276e1_c0fcbab6","updated":"2026-02-26 09:56:57.000000000","message":"@kinpaa@gmail.com @gawasthi2010@gmail.com can you please review this change? This helps the other client changes moving forward as well, as they depend on this one in the tree","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d26109d915b3a520734cafc564cfa8843a7a6b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e2eba8ee_f3b58458","updated":"2026-02-24 19:18:32.000000000","message":"LGTM; if you make another patch, one or more tests here would be useful. I think you could add a negative functional test that filters hosts on ensuring\u003dFalse at least - that\u0027s something that\u0027s hard to test elsewhere.","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4bca9e36503abfe24ae35389f1c2a6ffa447e090","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36e71cd0_053eb8a6","updated":"2026-02-26 10:02:23.000000000","message":"ensuring flag takes boolean value so why is default None ?","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f1400f770e0312547bb30829b7a684da386b9a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"011569c2_eaa8e8bd","in_reply_to":"166a56ca_0f276c66","updated":"2026-02-26 13:27:54.000000000","message":"Comments being addressed here: https://review.opendev.org/c/openstack/python-manilaclient/+/978062","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9b7372195f6e94f54ca308d389baee7645a47ae1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e44cdc8_f1b199d0","in_reply_to":"36e71cd0_053eb8a6","updated":"2026-02-26 10:26:19.000000000","message":"good question. The default is none because we assume no filter is specified. We can simply remove it too, as it won\u0027t make a difference, considering that we\u0027ll look at it only when it\u0027s inside parsed args","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6e4f563bad16ddd037f098111d59b37e50342274","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b4794b9_be85e554","in_reply_to":"3e44cdc8_f1b199d0","updated":"2026-02-26 10:28:05.000000000","message":"if parsed_args.ensuring: \ncan be then \nif parsed_args.ensuring is not None: ?","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f7c4fc0990e0911717afc57a49aaa1e0535f1d56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"166a56ca_0f276c66","in_reply_to":"7a02c51f_cdacf023","updated":"2026-02-26 10:58:43.000000000","message":"I can drop the default in a follow-up change, alongside the other message command Goutham just sent. I\u0027m merging this in the interest of time, so that I can pull the trigger in the qos type client change as well. Thanks Kiran","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6697f1597efb72d707fc47834dd4ada9c3db713a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aef49291_8dee9473","in_reply_to":"9b4794b9_be85e554","updated":"2026-02-26 10:52:09.000000000","message":"I think both will still work. Parsed args won\u0027t have ensuring unless it is specified for either true or false, which will be enforced with True or False, so the none default is redundant and can be removed and the code can stay as is even if we remove that","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ac3922513fdea9c9f91e9a91710e4a03a5cb0fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7a02c51f_cdacf023","in_reply_to":"aef49291_8dee9473","updated":"2026-02-26 10:57:25.000000000","message":"ok, I assumed with parsed_args.ensuring being \"False\" will never be set.","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"}],"manilaclient/api_versions.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"756dd2c97dd6b1d6e1e50ce3f0997e0b15aca18b","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.88\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bb26cc8_de7cc785","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":19},"updated":"2024-09-19 20:34:49.000000000","message":"why 2.88? ensure shares is 2.86 microversion","commit_id":"088485e1447771b6a9f9fe65b6cbded0e0ab1b05"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"092f7eb04f4c5d0976a20798f55b91fe573da996","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.88\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"eade630e_1d1d3a54","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":19},"in_reply_to":"0bb26cc8_de7cc785","updated":"2024-11-07 20:23:36.000000000","message":"this was missed; and can\u0027t be backported since the release is about a month old..","commit_id":"088485e1447771b6a9f9fe65b6cbded0e0ab1b05"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d26109d915b3a520734cafc564cfa8843a7a6b9f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.88\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"d17de695_53db30e2","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":19},"in_reply_to":"eade630e_1d1d3a54","updated":"2026-02-24 19:18:32.000000000","message":"Done","commit_id":"088485e1447771b6a9f9fe65b6cbded0e0ab1b05"}],"manilaclient/osc/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d26109d915b3a520734cafc564cfa8843a7a6b9f","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        if parsed_args.ensuring:"},{"line_number":161,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.93\"):"},{"line_number":162,"context_line":"                raise exceptions.CommandError("},{"line_number":163,"context_line":"                    \"Filtering services whether they are running ensure \""},{"line_number":164,"context_line":"                    \"shares or not is only supported by manila API version \""},{"line_number":165,"context_line":"                    \"\u003e\u003d 2.93\""},{"line_number":166,"context_line":"                )"},{"line_number":167,"context_line":"            search_opts[\u0027ensuring\u0027] \u003d parsed_args.ensuring"}],"source_content_type":"text/x-python","patch_set":7,"id":"93388ea3_6a7e9536","line":164,"range":{"start_line":163,"start_character":21,"end_line":164,"end_character":34},"updated":"2026-02-24 19:18:32.000000000","message":"Filtering services that are ensuring shares","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f1400f770e0312547bb30829b7a684da386b9a0a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        if parsed_args.ensuring:"},{"line_number":161,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.93\"):"},{"line_number":162,"context_line":"                raise exceptions.CommandError("},{"line_number":163,"context_line":"                    \"Filtering services whether they are running ensure \""},{"line_number":164,"context_line":"                    \"shares or not is only supported by manila API version \""},{"line_number":165,"context_line":"                    \"\u003e\u003d 2.93\""},{"line_number":166,"context_line":"                )"},{"line_number":167,"context_line":"            search_opts[\u0027ensuring\u0027] \u003d parsed_args.ensuring"}],"source_content_type":"text/x-python","patch_set":7,"id":"74684b14_2cf1d7b4","line":164,"range":{"start_line":163,"start_character":21,"end_line":164,"end_character":34},"in_reply_to":"93388ea3_6a7e9536","updated":"2026-02-26 13:27:54.000000000","message":"Done","commit_id":"bb847614445bb755dacc6e908bea26b8c025fbec"}]}