)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b10e5809dd0e4b0bdd8f0e4195927403a95b0439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"abf4d548_de9cb321","updated":"2024-10-09 16:18:26.000000000","message":"Error is observed in resource lock during access rule show command. check https://12a4bab8d6e5809d9b2b-30b0a72bc63e960bd7a500e425d4bd8d.ssl.cf2.rackcdn.com/931914/1/check/python-manilaclient-functional/112a3e9/controller/logs/screen-m-api.txt\n\nSearch \"Caught error: tuple.index(x): x not in tuple: ValueError: tuple.index(x): x not in tuple\"","commit_id":"0ff6240774f72e1d335c32cd1cecf1f3d023ab42"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08ffc4a2ea14e8e9e0039f5b393499bbb31cf162","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"328a8208_d390741f","updated":"2024-10-10 21:21:59.000000000","message":"Still looking at the server patch; but got a minor comment inline.. could you also please add a release note?","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f0bc56a0af5326a5bc4a95fc1e76cab43839a113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48a26774_5d2502c5","updated":"2024-10-11 06:06:21.000000000","message":"code looks good, some comment inlines.","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6299a4a058a5062d8256c1440da86bf3030338b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae982f34_26f73250","updated":"2024-10-10 12:56:42.000000000","message":"recheck","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"df31f6ef643bb6a325e2664f90faf4f21b1e3fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a2e0209_af496d5c","updated":"2024-10-18 03:37:09.000000000","message":"LGTM, thanks!","commit_id":"ec92c40d7e46a0535420eb8faa277739966f849e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1d09bb7277063f49e4c506d4a5fe513b65431504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"25a7a998_c964a093","updated":"2025-02-05 01:45:19.000000000","message":"LGTM, let\u0027s merge this.","commit_id":"c06f3dca4dc2daa48ff98675ab11fe50ebcb39e9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a4794e5f2b63e9ffcdab98c60d0ac4a1cfc3155e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c4633f34_16b0f613","updated":"2024-12-18 10:42:55.000000000","message":"LGTM, thank you Kiran","commit_id":"c06f3dca4dc2daa48ff98675ab11fe50ebcb39e9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"e7348aaecc3192a1ac3af5ab1bf8bb03bc881b3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"75932998_e399bb18","updated":"2025-01-30 18:17:50.000000000","message":"recheck old logs","commit_id":"c06f3dca4dc2daa48ff98675ab11fe50ebcb39e9"}],"manilaclient/osc/v2/share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"08ffc4a2ea14e8e9e0039f5b393499bbb31cf162","unresolved":true,"context_lines":[{"line_number":421,"context_line":"            \"--access-level\","},{"line_number":422,"context_line":"            metavar\u003d\"\u003caccess_level\u003e\","},{"line_number":423,"context_line":"            default\u003dNone,"},{"line_number":424,"context_line":"            help\u003d_(\"Filter access rules by the access level.\")"},{"line_number":425,"context_line":"        )"},{"line_number":426,"context_line":"        return parser"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"29803161_244e0d51","line":424,"range":{"start_line":424,"start_character":19,"end_line":424,"end_character":62},"updated":"2024-10-10 21:21:59.000000000","message":"choices\u003d[\u0027rw\u0027, \u0027ro\u0027],\n            help\u003d_(\u0027Share access level (\"rw\" and \"ro\" access levels \u0027\n                   \u0027are supported) to set.\u0027)","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4925a2c04329b5929498ae60e5c73d9ff8f1b9c7","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            \"--access-level\","},{"line_number":422,"context_line":"            metavar\u003d\"\u003caccess_level\u003e\","},{"line_number":423,"context_line":"            default\u003dNone,"},{"line_number":424,"context_line":"            help\u003d_(\"Filter access rules by the access level.\")"},{"line_number":425,"context_line":"        )"},{"line_number":426,"context_line":"        return parser"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1dba8a5a_d8c43953","line":424,"range":{"start_line":424,"start_character":19,"end_line":424,"end_character":62},"in_reply_to":"29803161_244e0d51","updated":"2024-10-11 08:37:58.000000000","message":"Done","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f0bc56a0af5326a5bc4a95fc1e76cab43839a113","unresolved":true,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def take_action(self, parsed_args):"},{"line_number":429,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":430,"context_line":"        access_rule \u003d share_client.share_access_rules.get("},{"line_number":431,"context_line":"            parsed_args.access_id"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        if (parsed_args.property and"},{"line_number":435,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.45\")):"}],"source_content_type":"text/x-python","patch_set":2,"id":"007e2a3a_e3d8c1e8","line":432,"range":{"start_line":430,"start_character":8,"end_line":432,"end_character":9},"updated":"2024-10-11 06:06:21.000000000","message":"We can move these two lines to 445 to improve execution efficiency.\nIf the version number is incorrect, do not need to obtain the access rule","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4925a2c04329b5929498ae60e5c73d9ff8f1b9c7","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def take_action(self, parsed_args):"},{"line_number":429,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":430,"context_line":"        access_rule \u003d share_client.share_access_rules.get("},{"line_number":431,"context_line":"            parsed_args.access_id"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        if (parsed_args.property and"},{"line_number":435,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.45\")):"}],"source_content_type":"text/x-python","patch_set":2,"id":"14805ea8_b887fc5f","line":432,"range":{"start_line":430,"start_character":8,"end_line":432,"end_character":9},"in_reply_to":"007e2a3a_e3d8c1e8","updated":"2024-10-11 08:37:58.000000000","message":"Done","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"}],"manilaclient/v2/share_access_rules.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f0bc56a0af5326a5bc4a95fc1e76cab43839a113","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def set_access_level(self, access, access_level):"},{"line_number":85,"context_line":"        \"\"\"Set or update access level for share access rule."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":88,"context_line":"            text with its ID."},{"line_number":89,"context_line":"        :param access_level: value of access_level (e.g. ro/rw)"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1cd6a3f7_c811d8fd","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":32},"updated":"2024-10-11 06:06:21.000000000","message":"access","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4925a2c04329b5929498ae60e5c73d9ff8f1b9c7","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def set_access_level(self, access, access_level):"},{"line_number":85,"context_line":"        \"\"\"Set or update access level for share access rule."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":88,"context_line":"            text with its ID."},{"line_number":89,"context_line":"        :param access_level: value of access_level (e.g. ro/rw)"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"772028b8_1eb97ec0","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":32},"in_reply_to":"1cd6a3f7_c811d8fd","updated":"2024-10-11 08:37:58.000000000","message":"this is same as set_metadata and so share_access_rule should be fine. wdyt ?","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ce1703451632de0c2a43360e80b66218b6cc6b2f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def set_access_level(self, access, access_level):"},{"line_number":85,"context_line":"        \"\"\"Set or update access level for share access rule."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":88,"context_line":"            text with its ID."},{"line_number":89,"context_line":"        :param access_level: value of access_level (e.g. ro/rw)"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"cadf93f1_9e233025","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":32},"in_reply_to":"4f93dc93_64e20920","updated":"2024-10-16 08:27:10.000000000","message":"Done","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1c8300f759656aac648112f51fed1b5c0a1a4f8c","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    def set_access_level(self, access, access_level):"},{"line_number":85,"context_line":"        \"\"\"Set or update access level for share access rule."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":88,"context_line":"            text with its ID."},{"line_number":89,"context_line":"        :param access_level: value of access_level (e.g. ro/rw)"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"4f93dc93_64e20920","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":32},"in_reply_to":"772028b8_1eb97ec0","updated":"2024-10-11 09:49:05.000000000","message":"i think we should fix it in set_metadata also.\nMy guess is that when someone wrote the set_metadata parameter description, they copied it directly from the def get() parameter description.\nObviously the entry to the def get() function is share_access_rule, but the entry to def set_metadata() is access.","commit_id":"ac5b1fbb82fc22adf161fd751f6cb7792203f8d1"}]}