)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"37b8e8c5a026e6aaceec8356634e0d248b5a634d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add CLI support and tests for performing a restore operation"},{"line_number":10,"context_line":"with Manilas share backup API that targets a non-source share"},{"line_number":11,"context_line":"i.e. a share other then that used to create the backup.)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint out-of-place-restore"},{"line_number":14,"context_line":"Change-Id: I8414c62010cd369e27cc5b693612c59d4e7516a3"},{"line_number":15,"context_line":"Signed-off-by: Zachary Goggin \u003czachary.goggin@cern.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"d24a012b_83533b5a","line":12,"updated":"2025-08-14 05:07:36.000000000","message":"add:\n```\n\nDepends-On: I060b0dc579e3057f2cb046ebe3271287f8fbc9f9\n\n```","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"1164dfa0c6f74ee9e68a07d4fafb0e0c58d35790","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add CLI support and tests for performing a restore operation"},{"line_number":10,"context_line":"with Manilas share backup API that targets a non-source share"},{"line_number":11,"context_line":"i.e. a share other then that used to create the backup.)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint out-of-place-restore"},{"line_number":14,"context_line":"Change-Id: I8414c62010cd369e27cc5b693612c59d4e7516a3"},{"line_number":15,"context_line":"Signed-off-by: Zachary Goggin \u003czachary.goggin@cern.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5df0cb9f_49e88151","line":12,"in_reply_to":"d24a012b_83533b5a","updated":"2025-08-14 14:42:15.000000000","message":"Done","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"ab484143a0712fa37fc052c7b5c20e0c93f1f54d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dbe2af5d_d6b60564","updated":"2025-07-28 07:48:23.000000000","message":"I have dropped the changes from the feature that would allow\nshare create --backup-id \u003cid\u003e, see [1]comment in manila implementation\nfor justification.\n\n[1] https://review.opendev.org/c/openstack/manila/+/954333/comments/53d67f31_2d9d44fd","commit_id":"84610b2dc3713329b987ed3fd68984dab5406053"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38272c67ab297b70ed9652ecc6fc8821b5b32a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6056561f_636052bb","updated":"2025-08-14 05:06:51.000000000","message":"Thank you Zac, please see some comments inline","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"1164dfa0c6f74ee9e68a07d4fafb0e0c58d35790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5d8fe00e_0a41542b","in_reply_to":"6056561f_636052bb","updated":"2025-08-14 14:42:15.000000000","message":"Thanks for taking the time to review! :)","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dbf97dbf9e3050cf73c8d8a36438bcba7d14fb4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"885f6503_801d2491","updated":"2025-08-14 20:57:47.000000000","message":"recheck\n\nCI will need a \"recheck\" if you update the parent change in manila.","commit_id":"58f7e62d556efbde5968c457bcddd088eb04c16a"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"0f4b35a8f570710fd9936d815359aaaef05817ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f1a86c2e_36427386","in_reply_to":"885f6503_801d2491","updated":"2025-08-15 09:22:59.000000000","message":"Thanks, will hold off on further //rechecks// until the manila change stops moving.","commit_id":"58f7e62d556efbde5968c457bcddd088eb04c16a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7f12868edc73b28e563d47e1bed89c55ad2aa483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4ac59d97_69df1e31","updated":"2025-08-26 21:08:21.000000000","message":"Hey, Zach. Thanks for working on this. One minor comment only related to the failing test :)","commit_id":"3334dc7ec698ff77dd22c544c26c57077a61c4b4"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"3b9876c2929861e3fc0320a4a035e8f1003488fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1df291d8_aec2e529","in_reply_to":"4ac59d97_69df1e31","updated":"2025-08-28 09:00:50.000000000","message":"Hi Carlos, Likewise thanks for the review!","commit_id":"3334dc7ec698ff77dd22c544c26c57077a61c4b4"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"df9392e8fcdb7086c32b28b744ae4304bfd8aa70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"643f92e7_f49b8da6","updated":"2025-08-28 09:40:51.000000000","message":"note for self: do a recheck after rebasing manila change / comments.","commit_id":"a61aebc055f2d7b9f6167b30e5a364150b0d43dc"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"7b631d1928268435679b4e2dd99a89ceea939d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d3a01a41_848c1af0","updated":"2025-08-28 10:19:04.000000000","message":"recheck rebase of main change done.","commit_id":"a61aebc055f2d7b9f6167b30e5a364150b0d43dc"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"7b631d1928268435679b4e2dd99a89ceea939d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5a013fc3_9a5e38c0","in_reply_to":"643f92e7_f49b8da6","updated":"2025-08-28 10:19:04.000000000","message":"Done","commit_id":"a61aebc055f2d7b9f6167b30e5a364150b0d43dc"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"87b8fc964688a036f0a2d9c3de7c01afbaeda9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8d197e4e_9840de92","updated":"2025-08-28 12:27:00.000000000","message":"recheck - failure appears to be transient, rather then with patchset","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9a99c9515788db985ca9c22d73afe4794fbb7b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"41c91d6f_6ca04ca5","updated":"2025-08-28 18:40:40.000000000","message":"apologies for pushing a change here, the issue was trivial, and i wanted to see if this can get a clean run in the CI","commit_id":"1f14d90b171a93daebe08aa61c4e9efd830e4701"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"9264ffbe5220e204739fbfe7dc16b99ce1ca7edc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f3aa20d8_e61ecc76","in_reply_to":"41c91d6f_6ca04ca5","updated":"2025-08-28 19:14:25.000000000","message":"No worries at all, thanks for your prudence goutham.\nI\u0027m back home now so will start addressing these.","commit_id":"1f14d90b171a93daebe08aa61c4e9efd830e4701"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4990e714a698491026d70587c9ad5864b75c078b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"89f8cefe_a4571c2d","updated":"2025-08-28 20:31:02.000000000","message":"LGTM, thanks for the hard work, Zach!","commit_id":"4996e2b86746e359f1662ea4545c9b6ed3809107"}],"manilaclient/osc/v2/share_backups.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38272c67ab297b70ed9652ecc6fc8821b5b32a5","unresolved":true,"context_lines":[{"line_number":298,"context_line":"            share_client.share_backups,"},{"line_number":299,"context_line":"            parsed_args.backup"},{"line_number":300,"context_line":"        )"},{"line_number":301,"context_line":"        if parsed_args.target_share is not None:"},{"line_number":302,"context_line":"            target_share_id \u003d osc_utils.find_resource("},{"line_number":303,"context_line":"                share_client.shares,"},{"line_number":304,"context_line":"                parsed_args.target_share"}],"source_content_type":"text/x-python","patch_set":14,"id":"75a8a59d_35f1b0d8","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":48},"updated":"2025-08-14 05:06:51.000000000","message":"it\u0027d be helpful to check if the microversion is 2.90 or above .. like this: https://opendev.org/openstack/python-manilaclient/src/commit/2bf13b1425333a39b36fb2da952f6227e1871afd/manilaclient/osc/v2/share.py#L243-L249","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"1164dfa0c6f74ee9e68a07d4fafb0e0c58d35790","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            share_client.share_backups,"},{"line_number":299,"context_line":"            parsed_args.backup"},{"line_number":300,"context_line":"        )"},{"line_number":301,"context_line":"        if parsed_args.target_share is not None:"},{"line_number":302,"context_line":"            target_share_id \u003d osc_utils.find_resource("},{"line_number":303,"context_line":"                share_client.shares,"},{"line_number":304,"context_line":"                parsed_args.target_share"}],"source_content_type":"text/x-python","patch_set":14,"id":"63640ffe_a69d2a87","line":301,"range":{"start_line":301,"start_character":0,"end_line":301,"end_character":48},"in_reply_to":"75a8a59d_35f1b0d8","updated":"2025-08-14 14:42:15.000000000","message":"Done","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dbf97dbf9e3050cf73c8d8a36438bcba7d14fb4b","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        if parsed_args.target_share is not None:"},{"line_number":304,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.90\u0027):"},{"line_number":305,"context_line":"                raise exceptions.CommandError("},{"line_number":306,"context_line":"                    \u0027performing targeted restores is only availible \u0027"},{"line_number":307,"context_line":"                    \u0027for API microversion \u003e\u003d 2.90\u0027)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                target_share_id \u003d osc_utils.find_resource("}],"source_content_type":"text/x-python","patch_set":15,"id":"41bfdfa9_634f7236","line":306,"range":{"start_line":306,"start_character":58,"end_line":306,"end_character":67},"updated":"2025-08-14 20:57:47.000000000","message":"typo","commit_id":"58f7e62d556efbde5968c457bcddd088eb04c16a"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"61774943cc1bec2a4726916623af7ee922aad24c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        if parsed_args.target_share is not None:"},{"line_number":304,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.90\u0027):"},{"line_number":305,"context_line":"                raise exceptions.CommandError("},{"line_number":306,"context_line":"                    \u0027performing targeted restores is only availible \u0027"},{"line_number":307,"context_line":"                    \u0027for API microversion \u003e\u003d 2.90\u0027)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                target_share_id \u003d osc_utils.find_resource("}],"source_content_type":"text/x-python","patch_set":15,"id":"94b74606_1bf7fd95","line":306,"range":{"start_line":306,"start_character":58,"end_line":306,"end_character":67},"in_reply_to":"41bfdfa9_634f7236","updated":"2025-08-15 09:21:29.000000000","message":"Done","commit_id":"58f7e62d556efbde5968c457bcddd088eb04c16a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f71b76ac9714c31ca7eecf9f78cdbfd4e0776111","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        share_client.share_backups.restore(share_backup.id, **kwargs)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if parsed_args.wait:"},{"line_number":325,"context_line":"            if not oscutils.wait_for_status("},{"line_number":326,"context_line":"                status_f\u003dshare_client.shares.get,"},{"line_number":327,"context_line":"                res_id\u003d(target_share_id or share_backup.share_id),"},{"line_number":328,"context_line":"                success_status\u003d[\u0027available\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"7df5584d_f7805f72","line":325,"range":{"start_line":325,"start_character":19,"end_line":325,"end_character":27},"updated":"2025-08-28 18:39:43.000000000","message":"this has to be \"osc_utils\"","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"9264ffbe5220e204739fbfe7dc16b99ce1ca7edc","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        share_client.share_backups.restore(share_backup.id, **kwargs)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if parsed_args.wait:"},{"line_number":325,"context_line":"            if not oscutils.wait_for_status("},{"line_number":326,"context_line":"                status_f\u003dshare_client.shares.get,"},{"line_number":327,"context_line":"                res_id\u003d(target_share_id or share_backup.share_id),"},{"line_number":328,"context_line":"                success_status\u003d[\u0027available\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"91ed739b_00108eec","line":325,"range":{"start_line":325,"start_character":19,"end_line":325,"end_character":27},"in_reply_to":"7df5584d_f7805f72","updated":"2025-08-28 19:14:25.000000000","message":"Acknowledged","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"0983cb6b890c87629f8938b1dc776c144ef0de02","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        share_client.share_backups.restore(share_backup.id, **kwargs)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if parsed_args.wait:"},{"line_number":325,"context_line":"            if not oscutils.wait_for_status("},{"line_number":326,"context_line":"                status_f\u003dshare_client.shares.get,"},{"line_number":327,"context_line":"                res_id\u003d(target_share_id or share_backup.share_id),"},{"line_number":328,"context_line":"                success_status\u003d[\u0027available\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"890a3da1_7e30b458","line":325,"range":{"start_line":325,"start_character":19,"end_line":325,"end_character":27},"in_reply_to":"91ed739b_00108eec","updated":"2025-08-28 19:25:03.000000000","message":"Done with patchset 21.","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"}],"manilaclient/tests/functional/osc/test_share_backups.py":[{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"63e365fe61936b58e107b8c68dcb0e13a110a259","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        share \u003d json.loads(self.openstack("},{"line_number":85,"context_line":"            f\u0027share show -f json {share[\"id\"]}\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, backup[\u0027status\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, share[\u0027status\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_share_backup_set(self):"},{"line_number":91,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":1,"id":"be968eff_4449b8da","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":61},"updated":"2025-04-11 16:11:45.000000000","message":"I think \"maybe\" the functional test fails with:\n\n\"Failed to delete share with name or ID \u002749932899-8bfe-4a5d-826f-454169f7d9d4\u0027: Invalid share: Share status must be one of (\u0027available\u0027, \u0027error\u0027, \u0027inactive\u0027)\"\n\nBecause we don\u0027t clean up the share here, maybe its hanging in backup_restoring....","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"d0427a7eb66ef0bfbdff2ab77ec833c1ec924742","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        share \u003d json.loads(self.openstack("},{"line_number":85,"context_line":"            f\u0027share show -f json {share[\"id\"]}\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, backup[\u0027status\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, share[\u0027status\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_share_backup_set(self):"},{"line_number":91,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d073f7e2_a4f2a119","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":61},"in_reply_to":"432376bd_86bb13dc","updated":"2025-07-28 00:01:52.000000000","message":"fixed, this is caused due to the share and share backup hanging in a state that doesn\u0027t allow deletion (e.g. not AVAILABLE)  I will resolve for now but if this approach should be changed, feel free to reopen or comment.","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"a840fd724b6d34e0152c1559610c4a3e804cd1b5","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        share \u003d json.loads(self.openstack("},{"line_number":85,"context_line":"            f\u0027share show -f json {share[\"id\"]}\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, backup[\u0027status\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(\u0027backup_restoring\u0027, share[\u0027status\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_share_backup_set(self):"},{"line_number":91,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":1,"id":"432376bd_86bb13dc","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":61},"in_reply_to":"be968eff_4449b8da","updated":"2025-07-27 22:17:59.000000000","message":"fixed partially, caused by a difference of state between a share(restoring) and a backup(backup_restoring) during a restore operation.\n\nwaiting for run to determine why share / backup deletion fails, I think the above is still true.","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"4d7352b1467feccdb08c5ffa8d44fc5d5c08edf1","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # cleanup share and backup state after test is done to prevent"},{"line_number":91,"context_line":"        # their hung state from preventing deletion after test conclusion."},{"line_number":92,"context_line":"        self.openstack(f\u0027share set --status available {share[\"id\"]}\u0027)"},{"line_number":93,"context_line":"        self.openstack(f\u0027share backup set --status available {backup[\"id\"]}\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_share_backup_set(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"c7a2457c_a1763a12","line":92,"updated":"2025-08-06 14:33:03.000000000","message":"is there a better way to do this?","commit_id":"32b5a23729276cd30b8a1fc13a7054c9466c6d6d"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"96f59f81edbcea68f20e8fcebe97a3bd92d4682c","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # cleanup share and backup state after test is done to prevent"},{"line_number":91,"context_line":"        # their hung state from preventing deletion after test conclusion."},{"line_number":92,"context_line":"        self.openstack(f\u0027share set --status available {share[\"id\"]}\u0027)"},{"line_number":93,"context_line":"        self.openstack(f\u0027share backup set --status available {backup[\"id\"]}\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_share_backup_set(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"065fbea0_b9904e49","line":92,"in_reply_to":"1c1359e1_bcc7a5e3","updated":"2025-08-14 15:22:09.000000000","message":"Done","commit_id":"32b5a23729276cd30b8a1fc13a7054c9466c6d6d"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"1164dfa0c6f74ee9e68a07d4fafb0e0c58d35790","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # cleanup share and backup state after test is done to prevent"},{"line_number":91,"context_line":"        # their hung state from preventing deletion after test conclusion."},{"line_number":92,"context_line":"        self.openstack(f\u0027share set --status available {share[\"id\"]}\u0027)"},{"line_number":93,"context_line":"        self.openstack(f\u0027share backup set --status available {backup[\"id\"]}\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_share_backup_set(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1c1359e1_bcc7a5e3","line":92,"in_reply_to":"8feb7338_d98b98be","updated":"2025-08-14 14:42:15.000000000","message":"Acknowledged, testing.","commit_id":"32b5a23729276cd30b8a1fc13a7054c9466c6d6d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38272c67ab297b70ed9652ecc6fc8821b5b32a5","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # cleanup share and backup state after test is done to prevent"},{"line_number":91,"context_line":"        # their hung state from preventing deletion after test conclusion."},{"line_number":92,"context_line":"        self.openstack(f\u0027share set --status available {share[\"id\"]}\u0027)"},{"line_number":93,"context_line":"        self.openstack(f\u0027share backup set --status available {backup[\"id\"]}\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_share_backup_set(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"8feb7338_d98b98be","line":92,"in_reply_to":"c7a2457c_a1763a12","updated":"2025-08-14 05:06:51.000000000","message":"yes, we could wait for the restore operation to finish by using \"--wait\" in the command on lines 79-80.. you might have to change the asserts on lines 87-88 though","commit_id":"32b5a23729276cd30b8a1fc13a7054c9466c6d6d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7f12868edc73b28e563d47e1bed89c55ad2aa483","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            backup_options\u003d{\u0027dummy\u0027: True})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.openstack("},{"line_number":80,"context_line":"            f\u0027share backup restore {backup[\"id\"]} --wait\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        backup \u003d json.loads(self.openstack("},{"line_number":83,"context_line":"            f\u0027share backup show -f json {backup[\"id\"]}\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"e5b6763c_73c16924","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":56},"updated":"2025-08-26 21:08:21.000000000","message":"I believe this is what is causing an issue on this testing. In case we\u0027d like to use the --wait flag, it should be added as one of the parameters for the command.","commit_id":"3334dc7ec698ff77dd22c544c26c57077a61c4b4"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"3b9876c2929861e3fc0320a4a035e8f1003488fe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            backup_options\u003d{\u0027dummy\u0027: True})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.openstack("},{"line_number":80,"context_line":"            f\u0027share backup restore {backup[\"id\"]} --wait\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        backup \u003d json.loads(self.openstack("},{"line_number":83,"context_line":"            f\u0027share backup show -f json {backup[\"id\"]}\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"298f0a53_5a81e028","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":56},"in_reply_to":"e5b6763c_73c16924","updated":"2025-08-28 09:00:50.000000000","message":"Done.","commit_id":"3334dc7ec698ff77dd22c544c26c57077a61c4b4"}],"manilaclient/v2/share_backups.py":[{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"7703520d09cbbc437832ae680bc8853589a9a39f","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id, target_share_id\u003dNone):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id, info\u003dtarget_share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d130c3a6_30c0a30f","line":113,"updated":"2025-04-11 15:59:35.000000000","message":"reminder for self, api version probably \nneeds to be bumped (not just here) \nseek clarification and refer to previous change.","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"5a5a488d9a78a9b6d0591571af340cb75ed3a571","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id, target_share_id\u003dNone):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id, info\u003dtarget_share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"10f459fe_30c0131d","line":113,"in_reply_to":"2016c588_ffaf1ec1","updated":"2025-08-08 15:22:43.000000000","message":"Done","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"f0eeda3fbcd3f466468d3ae81ef6897264f253ab","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id, target_share_id\u003dNone):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id, info\u003dtarget_share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2016c588_ffaf1ec1","line":113,"in_reply_to":"d130c3a6_30c0a30f","updated":"2025-07-28 20:17:52.000000000","message":"reminder for self, create release note with reno \nonce microversion / version is determined.","commit_id":"c30f550f2a77e6cdccaf43e92aa9e94ce1d462c6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e38272c67ab297b70ed9652ecc6fc8821b5b32a5","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"150ddb1b_9c8c7c1b","line":113,"range":{"start_line":113,"start_character":30,"end_line":113,"end_character":31},"updated":"2025-08-14 05:06:51.000000000","message":"add the last microversion this method is supported until:\n\n\n```suggestion\n    @api_versions.wraps(\"2.80\", \"2.89\")\n```","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"1164dfa0c6f74ee9e68a07d4fafb0e0c58d35790","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bb173375_60eaca26","line":113,"range":{"start_line":113,"start_character":30,"end_line":113,"end_character":31},"in_reply_to":"150ddb1b_9c8c7c1b","updated":"2025-08-14 14:42:15.000000000","message":"Done","commit_id":"42f55f8c05201a7334a60c89dc0c8937ecc30a33"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"598b22f54c415245b3e03917c110657e2cdb70ca","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\", \"2.89\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"108fd20c_c7798149","line":113,"range":{"start_line":113,"start_character":33,"end_line":113,"end_character":37},"updated":"2025-08-28 19:01:00.000000000","message":"2.90","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"9264ffbe5220e204739fbfe7dc16b99ce1ca7edc","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\", \"2.89\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"57171660_fef6762e","line":113,"range":{"start_line":113,"start_character":33,"end_line":113,"end_character":37},"in_reply_to":"108fd20c_c7798149","updated":"2025-08-28 19:14:25.000000000","message":"Acknowledged","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"},{"author":{"_account_id":36761,"name":"za","display_name":"zgoggin","email":"zacharygoggin@coenin.co.uk","username":"za","status":"Manila share backup enthusiast :)"},"change_message_id":"0983cb6b890c87629f8938b1dc776c144ef0de02","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        url \u003d RESOURCE_PATH % backup_id"},{"line_number":111,"context_line":"        self._delete(url)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.80\", \"2.89\")"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def restore(self, backup_id):"},{"line_number":116,"context_line":"        return self._action(\u0027restore\u0027, backup_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"b8a87ae7_abe90dde","line":113,"range":{"start_line":113,"start_character":33,"end_line":113,"end_character":37},"in_reply_to":"57171660_fef6762e","updated":"2025-08-28 19:25:03.000000000","message":"Done","commit_id":"dc4c01a47c08416f20c11d1dd14589af53dfe3e1"}]}