)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb5aa794_a0d40bbc","updated":"2025-06-11 15:48:07.000000000","message":"Thanks for working on this change, Maria! Please take a look at the comments inline :)","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea6320f3_f0b711a8","updated":"2025-07-16 18:19:57.000000000","message":"Thanks for working on this change, Maria. Please take a look at the comments inline","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9fc50a14bca9041adc8382df1624b80d51d78c7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4a06ff77_572fb51e","updated":"2025-07-30 22:54:27.000000000","message":"Hi Maria, \n\nYou might need to tell git to check out and commit with unix style line endings:\n\n```\n   git config --global core.autocrlf input\n```\n\n\nbefore your next update","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"}],"manilaclient/tests/functional/osc/test_share_groups.py":[{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":12,"context_line":"import logging\r"},{"line_number":13,"context_line":"import uuid\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"from openstackclient.identity import common as identity_common\r"},{"line_number":16,"context_line":"from osc_lib.cli import parseractions\r"},{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"caf72c5d_e670980c","line":15,"in_reply_to":"b2e98495_5cbbe237","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027openstackclient.identity.common as identity_common\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import uuid\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"from openstackclient.identity import common as identity_common\r"},{"line_number":16,"context_line":"from osc_lib.cli import parseractions\r"},{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf07226f_faa6b0f0","line":16,"in_reply_to":"8c635606_8dbde642","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027osc_lib.cli.parseractions\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"from openstackclient.identity import common as identity_common\r"},{"line_number":16,"context_line":"from osc_lib.cli import parseractions\r"},{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"},{"line_number":20,"context_line":"import json\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"715291ba_d266b277","line":17,"in_reply_to":"dbea4a2f_1b74a4d0","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027osc_lib.command.command\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from openstackclient.identity import common as identity_common\r"},{"line_number":16,"context_line":"from osc_lib.cli import parseractions\r"},{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"},{"line_number":20,"context_line":"import json\r"},{"line_number":21,"context_line":"import logging\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"66867bd5_6ebc5587","line":18,"in_reply_to":"1ab99743_e79c755d","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027osc_lib.exceptions\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from osc_lib.cli import parseractions\r"},{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"},{"line_number":20,"context_line":"import json\r"},{"line_number":21,"context_line":"import logging\r"},{"line_number":22,"context_line":"from manilaclient.tests.functional.osc import base\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"9730ae75_028c433f","line":19,"in_reply_to":"18a8f52a_8095b2c1","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027osc_lib.utils as osc_utils\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from osc_lib.command import command\r"},{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"},{"line_number":20,"context_line":"import json\r"},{"line_number":21,"context_line":"import logging\r"},{"line_number":22,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":23,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"10542ef8_88d2a611","line":20,"in_reply_to":"67bcd451_c4079be8","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (osc_lib.utils, json)\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from osc_lib import exceptions\r"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils\r"},{"line_number":20,"context_line":"import json\r"},{"line_number":21,"context_line":"import logging\r"},{"line_number":22,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"from manilaclient import api_versions\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"91368c58_55a1a455","line":21,"in_reply_to":"1bb0c38f_53a06665","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F811 redefinition of unused \u0027logging\u0027 from line 12\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging\r"},{"line_number":22,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"from manilaclient import api_versions\r"},{"line_number":25,"context_line":"from manilaclient.common._i18n import _\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"24329b2e_fbbfa5bc","line":24,"in_reply_to":"120fd2dc_6d9d717b","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027manilaclient.api_versions\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"from manilaclient import api_versions\r"},{"line_number":25,"context_line":"from manilaclient.common._i18n import _\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":28,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6b5db4c_b3ecf8b3","line":25,"in_reply_to":"97bd178b_c0498cc0","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: F401 \u0027manilaclient.common._i18n._\u0027 imported but unused\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertIsNotNone(result[\u0027share_group_type_id\u0027])\r"},{"line_number":50,"context_line":"\r"},{"line_number":51,"context_line":"        self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":52,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"7564b6de_b7e5d5cd","line":52,"in_reply_to":"eeb56255_16b69298","updated":"2025-08-13 18:20:33.000000000","message":"\u003e pep8: W391 blank line at end of file\n\nPlease fix.","commit_id":"46e5df5c25e3c6a35008057b25ccc4d634c57ba7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":22,"context_line":"class TestShareGroups(base.OSCClientTestBase):\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a70a3c8_bacc78f3","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":35},"updated":"2025-06-11 15:48:07.000000000","message":"we can use an actual name for this, like: fake_share_group","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TestShareGroups(base.OSCClientTestBase):\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"905f996a_89dffe34","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":35},"in_reply_to":"7a70a3c8_bacc78f3","updated":"2025-07-16 18:19:57.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TestShareGroups(base.OSCClientTestBase):\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"786ae24f_2e444cad","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":35},"in_reply_to":"7a70a3c8_bacc78f3","updated":"2025-08-13 18:20:33.000000000","message":"changed to fake_share_group","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fa18033_ad7f1417","line":30,"range":{"start_line":27,"start_character":7,"end_line":30,"end_character":16},"updated":"2025-06-11 15:48:07.000000000","message":"so the deletion of the created share group should be after the creation, otherwise it will fail.","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"35fb7aed_86c3bcbf","line":30,"range":{"start_line":27,"start_character":7,"end_line":30,"end_character":16},"in_reply_to":"4fa18033_ad7f1417","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":25,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":26,"context_line":"\r"},{"line_number":27,"context_line":"        try:\r"},{"line_number":28,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"b73bda0f_26aef1db","line":30,"range":{"start_line":27,"start_character":7,"end_line":30,"end_character":16},"in_reply_to":"4fa18033_ad7f1417","updated":"2025-07-16 18:19:57.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5b9e1d8_b594ef5d","line":32,"range":{"start_line":32,"start_character":88,"end_line":32,"end_character":95},"updated":"2025-06-11 15:48:07.000000000","message":"I\u0027d say we don\u0027t need this for this command, as we are not grabbing the output of it","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1068a43_35848e8f","line":32,"range":{"start_line":32,"start_character":88,"end_line":32,"end_character":95},"in_reply_to":"a5b9e1d8_b594ef5d","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"05fbda7c_146c3bb1","line":32,"in_reply_to":"b77a46d8_bb3f10c9","updated":"2025-08-13 18:20:33.000000000","message":"fixed spacing","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        except Exception:\r"},{"line_number":30,"context_line":"            pass\r"},{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"b77a46d8_bb3f10c9","line":32,"in_reply_to":"cd93bbe0_63416657","updated":"2025-06-11 15:48:07.000000000","message":"\u003e pep8: E501 line too long (97 \u003e 79 characters)\n\nPlease fix.","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"        print(\"DEBUG: Result keys:\", result.keys())\r"},{"line_number":38,"context_line":"        print(\"DEBUG: Result data:\", result)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"328a720e_4785e389","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":39},"updated":"2025-06-11 15:48:07.000000000","message":"```suggestion\n        share_group \u003d self.dict_result(\u0027share group\u0027, f\u0027show {sg_name}\u0027)\n```","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"        self.openstack(f\u0027share group create --name {sg_name} --share-group-type default -f json\u0027)\r"},{"line_number":33,"context_line":"\r"},{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"        print(\"DEBUG: Result keys:\", result.keys())\r"},{"line_number":38,"context_line":"        print(\"DEBUG: Result data:\", result)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebe3ea7d_fe9d5034","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":39},"in_reply_to":"328a720e_4785e389","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"        print(\"DEBUG: Result keys:\", result.keys())\r"},{"line_number":38,"context_line":"        print(\"DEBUG: Result data:\", result)\r"},{"line_number":39,"context_line":"\r"},{"line_number":40,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, result)\r"},{"line_number":41,"context_line":"        self.assertIsNotNone(result[\u0027share_group_type_id\u0027])\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"861664bc_b5be4575","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":44},"updated":"2025-06-11 15:48:07.000000000","message":"please remove this debug info after you debug","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":35,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"        print(\"DEBUG: Result keys:\", result.keys())\r"},{"line_number":38,"context_line":"        print(\"DEBUG: Result data:\", result)\r"},{"line_number":39,"context_line":"\r"},{"line_number":40,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, result)\r"},{"line_number":41,"context_line":"        self.assertIsNotNone(result[\u0027share_group_type_id\u0027])\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1ac72bb_e7fbf31b","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":44},"in_reply_to":"861664bc_b5be4575","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":44,"context_line":"\r"},{"line_number":45,"context_line":"    def test_create_share_group_with_description_and_share_type(self):\r"},{"line_number":46,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":47,"context_line":"        description \u003d \"Test share group with description\"\r"},{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"272f0893_d9314992","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":35},"updated":"2025-06-11 15:48:07.000000000","message":"same as above","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":44,"context_line":"\r"},{"line_number":45,"context_line":"    def test_create_share_group_with_description_and_share_type(self):\r"},{"line_number":46,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":47,"context_line":"        description \u003d \"Test share group with description\"\r"},{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"49207c13_df499e70","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":35},"in_reply_to":"272f0893_d9314992","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":47,"context_line":"        description \u003d \"Test share group with description\"\r"},{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"},{"line_number":50,"context_line":"        share_types \u003d json.loads(raw_types)\r"},{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3252717d_ec22ab31","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":43},"updated":"2025-06-11 15:48:07.000000000","message":"```suggestion\n        share_types \u003d self.listing_result(\u0027share type\u0027, \u0027list\u0027)\n```","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":47,"context_line":"        description \u003d \"Test share group with description\"\r"},{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"},{"line_number":50,"context_line":"        share_types \u003d json.loads(raw_types)\r"},{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"548e3839_11c614b4","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":43},"in_reply_to":"3252717d_ec22ab31","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"},{"line_number":50,"context_line":"        share_types \u003d json.loads(raw_types)\r"},{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"},{"line_number":54,"context_line":"        try:\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"20a34620_0794c9b4","line":51,"in_reply_to":"84271457_899455cf","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\r"},{"line_number":49,"context_line":"        raw_types \u003d self.openstack(\u0027share type list -f json\u0027)\r"},{"line_number":50,"context_line":"        share_types \u003d json.loads(raw_types)\r"},{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"},{"line_number":54,"context_line":"        try:\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"84271457_899455cf","line":51,"in_reply_to":"ce79edb7_6ac9be4c","updated":"2025-06-11 15:48:07.000000000","message":"\u003e pep8: E501 line too long (83 \u003e 79 characters)\n\nPlease fix.","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"},{"line_number":54,"context_line":"        try:\r"},{"line_number":55,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":56,"context_line":"        except Exception:\r"},{"line_number":57,"context_line":"            pass\r"},{"line_number":58,"context_line":"\r"},{"line_number":59,"context_line":"        self.openstack(\r"},{"line_number":60,"context_line":"            f\u0027share group create --name {sg_name} \u0027\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"90cac6df_8fc8175e","line":57,"range":{"start_line":54,"start_character":8,"end_line":57,"end_character":16},"updated":"2025-06-11 15:48:07.000000000","message":"no need to delete this yet, as the creation hasn\u0027t happened","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertGreater(len(share_types), 0, \"No share types available to use.\")\r"},{"line_number":52,"context_line":"        share_type_id \u003d share_types[0][\u0027ID\u0027]\r"},{"line_number":53,"context_line":"\r"},{"line_number":54,"context_line":"        try:\r"},{"line_number":55,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":56,"context_line":"        except Exception:\r"},{"line_number":57,"context_line":"            pass\r"},{"line_number":58,"context_line":"\r"},{"line_number":59,"context_line":"        self.openstack(\r"},{"line_number":60,"context_line":"            f\u0027share group create --name {sg_name} \u0027\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"b40b47da_a78a2762","line":57,"range":{"start_line":54,"start_character":8,"end_line":57,"end_character":16},"in_reply_to":"90cac6df_8fc8175e","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            f\u0027--share-group-type default -f json\u0027\r"},{"line_number":64,"context_line":"        )\r"},{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":67,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":68,"context_line":"\r"},{"line_number":69,"context_line":"        print(\"DEBUG: Share group result:\", result)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"0316a7cc_f7d13a21","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":36},"updated":"2025-06-11 15:48:07.000000000","message":"please use dict_result as suggested in the comment above","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            f\u0027--share-group-type default -f json\u0027\r"},{"line_number":64,"context_line":"        )\r"},{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":67,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":68,"context_line":"\r"},{"line_number":69,"context_line":"        print(\"DEBUG: Share group result:\", result)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"40390107_e972a6ef","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":36},"in_reply_to":"0316a7cc_f7d13a21","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        )\r"},{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":67,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":68,"context_line":"\r"},{"line_number":69,"context_line":"        print(\"DEBUG: Share group result:\", result)\r"},{"line_number":70,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"4083ef7e_d18cae7e","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":40},"updated":"2025-06-11 15:48:07.000000000","message":"please drop this","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        )\r"},{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":67,"context_line":"        result \u003d json.loads(raw_output)\r"},{"line_number":68,"context_line":"\r"},{"line_number":69,"context_line":"        print(\"DEBUG: Share group result:\", result)\r"},{"line_number":70,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3feca16_a11a0d09","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":40},"in_reply_to":"4083ef7e_d18cae7e","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        except Exception:\r"},{"line_number":92,"context_line":"            pass\r"},{"line_number":93,"context_line":"\r"},{"line_number":94,"context_line":"        self.openstack(\r"},{"line_number":95,"context_line":"            f\u0027share group create --name {sg_name} \u0027\r"},{"line_number":96,"context_line":"            f\u0027--share-group-type {share_group_type_id} -f json\u0027\r"},{"line_number":97,"context_line":"        )\r"},{"line_number":98,"context_line":"\r"},{"line_number":99,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":100,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d4118e1_deaf603c","line":97,"range":{"start_line":94,"start_character":8,"end_line":97,"end_character":9},"updated":"2025-06-11 15:48:07.000000000","message":"this scenario is already being covered above, so maybe we can drop this test","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        except Exception:\r"},{"line_number":92,"context_line":"            pass\r"},{"line_number":93,"context_line":"\r"},{"line_number":94,"context_line":"        self.openstack(\r"},{"line_number":95,"context_line":"            f\u0027share group create --name {sg_name} \u0027\r"},{"line_number":96,"context_line":"            f\u0027--share-group-type {share_group_type_id} -f json\u0027\r"},{"line_number":97,"context_line":"        )\r"},{"line_number":98,"context_line":"\r"},{"line_number":99,"context_line":"        raw_output \u003d self.openstack(f\u0027share group show {sg_name} -f json\u0027)\r"},{"line_number":100,"context_line":"        result \u003d json.loads(raw_output)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"a347bb86_9f3e271c","line":97,"range":{"start_line":94,"start_character":8,"end_line":97,"end_character":9},"in_reply_to":"6d4118e1_deaf603c","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":109,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":110,"context_line":"\r"},{"line_number":111,"context_line":"        raw_networks \u003d self.openstack(\u0027share network list -f json\u0027)\r"},{"line_number":112,"context_line":"        share_networks \u003d json.loads(raw_networks)\r"},{"line_number":113,"context_line":"        self.assertGreater(len(share_networks), 0, \"No share networks available to use.\")\r"},{"line_number":114,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":115,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b428e84_5ac2ebf5","line":112,"range":{"start_line":111,"start_character":8,"end_line":112,"end_character":49},"updated":"2025-06-11 15:48:07.000000000","message":"please use listing_result, but also, if we don\u0027t have the network, the test could create it","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":109,"context_line":"        sg_name \u003d str(uuid.uuid4())\r"},{"line_number":110,"context_line":"\r"},{"line_number":111,"context_line":"        raw_networks \u003d self.openstack(\u0027share network list -f json\u0027)\r"},{"line_number":112,"context_line":"        share_networks \u003d json.loads(raw_networks)\r"},{"line_number":113,"context_line":"        self.assertGreater(len(share_networks), 0, \"No share networks available to use.\")\r"},{"line_number":114,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":115,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9e38fab_7efcd577","line":112,"range":{"start_line":111,"start_character":8,"end_line":112,"end_character":49},"in_reply_to":"0b428e84_5ac2ebf5","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a38cfbd2baf59dc693f23be38845dda8d9e3c21f","unresolved":true,"context_lines":[{"line_number":110,"context_line":"\r"},{"line_number":111,"context_line":"        raw_networks \u003d self.openstack(\u0027share network list -f json\u0027)\r"},{"line_number":112,"context_line":"        share_networks \u003d json.loads(raw_networks)\r"},{"line_number":113,"context_line":"        self.assertGreater(len(share_networks), 0, \"No share networks available to use.\")\r"},{"line_number":114,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"        try:\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"37da868e_e2c79b82","line":113,"in_reply_to":"0414f991_97c7df5f","updated":"2025-06-11 15:48:07.000000000","message":"\u003e pep8: E501 line too long (89 \u003e 79 characters)\n\nPlease fix.","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":110,"context_line":"\r"},{"line_number":111,"context_line":"        raw_networks \u003d self.openstack(\u0027share network list -f json\u0027)\r"},{"line_number":112,"context_line":"        share_networks \u003d json.loads(raw_networks)\r"},{"line_number":113,"context_line":"        self.assertGreater(len(share_networks), 0, \"No share networks available to use.\")\r"},{"line_number":114,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"        try:\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"af165f2a_34e9d370","line":113,"in_reply_to":"37da868e_e2c79b82","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":false,"context_lines":[{"line_number":110,"context_line":"\r"},{"line_number":111,"context_line":"        raw_networks \u003d self.openstack(\u0027share network list -f json\u0027)\r"},{"line_number":112,"context_line":"        share_networks \u003d json.loads(raw_networks)\r"},{"line_number":113,"context_line":"        self.assertGreater(len(share_networks), 0, \"No share networks available to use.\")\r"},{"line_number":114,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"        try:\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"b1449b88_26a9edc7","line":113,"in_reply_to":"37da868e_e2c79b82","updated":"2025-07-16 18:19:57.000000000","message":"Done","commit_id":"dcdd8f3e05412f59406edfae9d017faa48a5a710"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\r"},{"line_number":14,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import logging\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":19,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"bbcf4186_5dabc393","line":16,"in_reply_to":"2711c901_e2eaa8e5","updated":"2025-08-13 18:20:33.000000000","message":"removed import","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\r"},{"line_number":14,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import logging\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":19,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"2711c901_e2eaa8e5","line":16,"in_reply_to":"88907a34_50307427","updated":"2025-07-16 18:19:57.000000000","message":"\u003e pep8: F811 redefinition of unused \u0027logging\u0027 from line 12\n\nPlease fix.","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import logging\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":21,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"81042c1e_ef22e7fe","line":18,"in_reply_to":"7cc3a2d6_26e34431","updated":"2025-07-16 18:19:57.000000000","message":"\u003e pep8: F811 redefinition of unused \u0027base\u0027 from line 14\n\nPlease fix.","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import logging\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":21,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ef13f518_7e26aa7c","line":18,"in_reply_to":"81042c1e_ef22e7fe","updated":"2025-08-13 18:20:33.000000000","message":"deleted one of them","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ab8b43bf_d449d98b","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":52},"updated":"2025-07-16 18:19:57.000000000","message":"please use another name for this share type, as by default, the devstack creates a share type named dhss_false or reuse the existing share type for the share group type. I\u0027d prefer you drop it and take the suggestion below :)","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"39ca1321_9171d9ed","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":52},"in_reply_to":"ab8b43bf_d449d98b","updated":"2025-08-13 18:20:33.000000000","message":"done","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"db59870e_c36a6a77","line":28,"range":{"start_line":27,"start_character":8,"end_line":28,"end_character":71},"updated":"2025-07-16 18:19:57.000000000","message":"```suggestion\n        group_type_name \u003d \"fake_group_type_name\"\n        self.openstack(f\u0027share group type create {group_type_name} dhss_false\u0027)\n```","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c35c295_b8de6579","line":28,"range":{"start_line":27,"start_character":8,"end_line":28,"end_character":71},"in_reply_to":"69c14716_efddf5ca","updated":"2025-08-13 18:20:33.000000000","message":"done","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"370182c54e76f939f2ef405fc8a50b2a7613ca81","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def test_create_and_show_share_group(self):\r"},{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"69c14716_efddf5ca","line":28,"range":{"start_line":27,"start_character":8,"end_line":28,"end_character":71},"in_reply_to":"db59870e_c36a6a77","updated":"2025-07-16 18:25:47.000000000","message":"Here, I\u0027m suggesting to define the name of the share group to a variable because it\u0027s going to be easier to refer to it later","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"        share_group \u003d self.dict_result(\u0027share group\u0027,\r"},{"line_number":34,"context_line":"                                       f\u0027show {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"1821f1b1_ae23402f","line":31,"range":{"start_line":29,"start_character":7,"end_line":31,"end_character":54},"updated":"2025-07-16 18:19:57.000000000","message":"```suggestion\n        self.openstack(\n            f\u0027share group create --name {sg_name}\u0027\n            f\u0027 --share-group-type {group_type_name} -f json\u0027)\n```","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"370182c54e76f939f2ef405fc8a50b2a7613ca81","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"        share_group \u003d self.dict_result(\u0027share group\u0027,\r"},{"line_number":34,"context_line":"                                       f\u0027show {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5312cb_ddbbe624","line":31,"range":{"start_line":29,"start_character":7,"end_line":31,"end_character":54},"in_reply_to":"1821f1b1_ae23402f","updated":"2025-07-16 18:25:47.000000000","message":"and here we\u0027re referring to the value we set in that previous variable","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        sg_name \u003d \"fake_share_group\"\r"},{"line_number":27,"context_line":"        self.openstack(\u0027share type create dhss_false false\u0027)\r"},{"line_number":28,"context_line":"        self.openstack(\u0027share group type create dhss_false dhss_false\u0027)\r"},{"line_number":29,"context_line":"        self.openstack(\r"},{"line_number":30,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":31,"context_line":"            f\u0027 --share-group-type dhss_false -f json\u0027)\r"},{"line_number":32,"context_line":"\r"},{"line_number":33,"context_line":"        share_group \u003d self.dict_result(\u0027share group\u0027,\r"},{"line_number":34,"context_line":"                                       f\u0027show {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"c72c4166_8c0ca335","line":31,"range":{"start_line":29,"start_character":7,"end_line":31,"end_character":54},"in_reply_to":"ba5312cb_ddbbe624","updated":"2025-08-13 18:20:33.000000000","message":"done","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4da0fb52d24962b7abb37f164a6cfafdc4be6fde","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            pass\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":45,"context_line":"        sg_name \u003d \"fake_share_group_with_network\"\r"},{"line_number":46,"context_line":"        self.openstack(\"share network create\")\r"},{"line_number":47,"context_line":"        share_networks \u003d self.listing_result(\u0027share\u0027, \u0027network list\u0027)\r"},{"line_number":48,"context_line":"        self.openstack(\u0027share type create dhss_true_1 true\u0027)\r"},{"line_number":49,"context_line":"        self.openstack(\u0027share group type create dhss_true dhss_true_1\u0027)\r"},{"line_number":50,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":51,"context_line":"        share_group \u003d self.dict_result(\r"},{"line_number":52,"context_line":"            \u0027share group create\u0027,\r"},{"line_number":53,"context_line":"            f\u0027--name {sg_name} --share-group-type dhss_true --share-network {share_network_id}\u0027\r"},{"line_number":54,"context_line":"        )\r"},{"line_number":55,"context_line":"\r"},{"line_number":56,"context_line":"        result \u003d self.dict_result(\u0027share group \u0027, f\u0027show {share_group[\"id\"]} \u0027)\r"},{"line_number":57,"context_line":"\r"},{"line_number":58,"context_line":"        self.assertEqual(result[\u0027name\u0027], sg_name)\r"},{"line_number":59,"context_line":"        self.assertEqual(result[\u0027share_network_id\u0027], share_network_id)\r"},{"line_number":60,"context_line":"        self.openstack(f\u0027share group delete {share_group[\"id\"]}\u0027)\r"},{"line_number":61,"context_line":"        self.openstack(f\u0027share network delete {share_network_id}\u0027)\r"},{"line_number":62,"context_line":"\r"},{"line_number":63,"context_line":"    def test_delete_share_group(self):\r"},{"line_number":64,"context_line":"        sg_name \u003d \"fake_share_group\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"b1d6cd1a_26bb8aec","line":61,"range":{"start_line":45,"start_character":8,"end_line":61,"end_character":66},"updated":"2025-07-16 18:19:57.000000000","message":"```suggestion\n        sg_name \u003d \"fake_share_group_with_network\"\n        share_group_type_name \u003d \"fake_share_group_type_name\"\n        share_network_name \u003d \"fake_share_network_name\"\n        share_network \u003d self.create_share_network(name\u003dshare_network_name)\n        self.create_share_group_type(\n            name\u003dshare_group_type_name, share_types\u003d\u0027dhss_true\u0027)\n\n        share_network_id \u003d share_network[\u0027id\u0027]\n        share_group \u003d self.dict_result(\n            \u0027share group create\u0027,\n            f\u0027--name {sg_name} --share-group-type dhss_true --share-network {share_network_id}\u0027\n        )\n\n        result \u003d self.dict_result(\u0027share group \u0027, f\u0027show {share_group[\"id\"]} \u0027)\n\n        self.assertEqual(result[\u0027name\u0027], sg_name)\n        self.assertEqual(result[\u0027share_network_id\u0027], share_network_id)\n        self.openstack(f\u0027share group delete {share_group[\"id\"]}\u0027)\n```","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"370182c54e76f939f2ef405fc8a50b2a7613ca81","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            pass\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":45,"context_line":"        sg_name \u003d \"fake_share_group_with_network\"\r"},{"line_number":46,"context_line":"        self.openstack(\"share network create\")\r"},{"line_number":47,"context_line":"        share_networks \u003d self.listing_result(\u0027share\u0027, \u0027network list\u0027)\r"},{"line_number":48,"context_line":"        self.openstack(\u0027share type create dhss_true_1 true\u0027)\r"},{"line_number":49,"context_line":"        self.openstack(\u0027share group type create dhss_true dhss_true_1\u0027)\r"},{"line_number":50,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":51,"context_line":"        share_group \u003d self.dict_result(\r"},{"line_number":52,"context_line":"            \u0027share group create\u0027,\r"},{"line_number":53,"context_line":"            f\u0027--name {sg_name} --share-group-type dhss_true --share-network {share_network_id}\u0027\r"},{"line_number":54,"context_line":"        )\r"},{"line_number":55,"context_line":"\r"},{"line_number":56,"context_line":"        result \u003d self.dict_result(\u0027share group \u0027, f\u0027show {share_group[\"id\"]} \u0027)\r"},{"line_number":57,"context_line":"\r"},{"line_number":58,"context_line":"        self.assertEqual(result[\u0027name\u0027], sg_name)\r"},{"line_number":59,"context_line":"        self.assertEqual(result[\u0027share_network_id\u0027], share_network_id)\r"},{"line_number":60,"context_line":"        self.openstack(f\u0027share group delete {share_group[\"id\"]}\u0027)\r"},{"line_number":61,"context_line":"        self.openstack(f\u0027share network delete {share_network_id}\u0027)\r"},{"line_number":62,"context_line":"\r"},{"line_number":63,"context_line":"    def test_delete_share_group(self):\r"},{"line_number":64,"context_line":"        sg_name \u003d \"fake_share_group\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2030520_b3908fe6","line":61,"range":{"start_line":45,"start_character":8,"end_line":61,"end_character":66},"in_reply_to":"b1d6cd1a_26bb8aec","updated":"2025-07-16 18:25:47.000000000","message":"There are a couple of issues with this test, so in the suggested refactoring I:\n\n- Added the content of names of groups and share networks to variables, so that we avoid mistakes when re-typing things while coding\n- Instead of creating the share group type and share network manually, I\u0027ve reused a method that already exists in the base OSC class, and that method will automatically add the necessary cleanups.\n- Matched the share group types and share types so that the share group creation doesn\u0027t fail.\n\nI think this should help with the current issues. In case you need more help, please let me know and I\u0027ll be happy to meet and/or review any code you push.","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            pass\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":45,"context_line":"        sg_name \u003d \"fake_share_group_with_network\"\r"},{"line_number":46,"context_line":"        self.openstack(\"share network create\")\r"},{"line_number":47,"context_line":"        share_networks \u003d self.listing_result(\u0027share\u0027, \u0027network list\u0027)\r"},{"line_number":48,"context_line":"        self.openstack(\u0027share type create dhss_true_1 true\u0027)\r"},{"line_number":49,"context_line":"        self.openstack(\u0027share group type create dhss_true dhss_true_1\u0027)\r"},{"line_number":50,"context_line":"        share_network_id \u003d share_networks[0][\u0027ID\u0027]\r"},{"line_number":51,"context_line":"        share_group \u003d self.dict_result(\r"},{"line_number":52,"context_line":"            \u0027share group create\u0027,\r"},{"line_number":53,"context_line":"            f\u0027--name {sg_name} --share-group-type dhss_true --share-network {share_network_id}\u0027\r"},{"line_number":54,"context_line":"        )\r"},{"line_number":55,"context_line":"\r"},{"line_number":56,"context_line":"        result \u003d self.dict_result(\u0027share group \u0027, f\u0027show {share_group[\"id\"]} \u0027)\r"},{"line_number":57,"context_line":"\r"},{"line_number":58,"context_line":"        self.assertEqual(result[\u0027name\u0027], sg_name)\r"},{"line_number":59,"context_line":"        self.assertEqual(result[\u0027share_network_id\u0027], share_network_id)\r"},{"line_number":60,"context_line":"        self.openstack(f\u0027share group delete {share_group[\"id\"]}\u0027)\r"},{"line_number":61,"context_line":"        self.openstack(f\u0027share network delete {share_network_id}\u0027)\r"},{"line_number":62,"context_line":"\r"},{"line_number":63,"context_line":"    def test_delete_share_group(self):\r"},{"line_number":64,"context_line":"        sg_name \u003d \"fake_share_group\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"1e982f07_15f8ccd3","line":61,"range":{"start_line":45,"start_character":8,"end_line":61,"end_character":66},"in_reply_to":"d2030520_b3908fe6","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"aa62b819bfdeaa06145888b9c12d99e9db5afd30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1d2b911791b0f5fe08339569afe1583154806f7d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"class TestShareGroups(base.OSCClientTestBase):\r"}],"source_content_type":"text/x-python","patch_set":7,"id":"f7debd29_29691029","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"updated":"2025-07-23 18:02:31.000000000","message":"please remove this","commit_id":"e0f25a43ce050d6ad61411d535b70ed8d0d2c6bc"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\r"},{"line_number":13,"context_line":"from manilaclient.tests.functional.osc import base\r"},{"line_number":14,"context_line":"\r"},{"line_number":15,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"class TestShareGroups(base.OSCClientTestBase):\r"}],"source_content_type":"text/x-python","patch_set":7,"id":"f29ba724_32a9a3d7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"in_reply_to":"f7debd29_29691029","updated":"2025-08-13 18:20:33.000000000","message":"Done","commit_id":"e0f25a43ce050d6ad61411d535b70ed8d0d2c6bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2591145a5e4c8bd88b19a8b73688d2c1694c6056","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        group_type_name \u003d data_utils.rand_name(\"share-group-type\")\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"        share_type \u003d self.create_share_type()\r"},{"line_number":25,"context_line":"        self.create_share_group_type(\r"},{"line_number":26,"context_line":"            name\u003dgroup_type_name, share_types\u003dshare_type[\u0027id\u0027])\r"},{"line_number":27,"context_line":"\r"},{"line_number":28,"context_line":"        self.openstack(\r"},{"line_number":29,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":30,"context_line":"            f\u0027 --share-group-type {group_type_name} \u0027\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d00c91c_046fc181","line":27,"range":{"start_line":25,"start_character":8,"end_line":27,"end_character":0},"updated":"2025-07-30 22:58:05.000000000","message":"capture the share group type here:\n```\n  share_group_type \u003d self.create_share_group_type(\n            name\u003dgroup_type_name, share_types\u003dshare_type[\u0027id\u0027])\n```","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        group_type_name \u003d data_utils.rand_name(\"share-group-type\")\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"        share_type \u003d self.create_share_type()\r"},{"line_number":25,"context_line":"        self.create_share_group_type(\r"},{"line_number":26,"context_line":"            name\u003dgroup_type_name, share_types\u003dshare_type[\u0027id\u0027])\r"},{"line_number":27,"context_line":"\r"},{"line_number":28,"context_line":"        self.openstack(\r"},{"line_number":29,"context_line":"            f\u0027share group create --name {sg_name}\u0027\r"},{"line_number":30,"context_line":"            f\u0027 --share-group-type {group_type_name} \u0027\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6e51f50_1ec2981c","line":27,"range":{"start_line":25,"start_character":8,"end_line":27,"end_character":0},"in_reply_to":"6d00c91c_046fc181","updated":"2025-08-13 18:20:33.000000000","message":"pasted this line to the new patch","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2591145a5e4c8bd88b19a8b73688d2c1694c6056","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                                       f\u0027show {sg_name}\u0027)\r"},{"line_number":35,"context_line":"\r"},{"line_number":36,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, share_group)\r"},{"line_number":37,"context_line":"        self.assertIsNotNone(share_group[\u0027share_group_type_id\u0027])\r"},{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"        try:\r"},{"line_number":40,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"c9a8080d_16d84abe","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":64},"updated":"2025-07-30 22:58:05.000000000","message":"instead of assertIsNotNone, use assertEqual to ensure that the share group type matches what you requested.. \n```\n  self.assertEqual(share_group_type[\u0027id\u0027], share_group[\u0027share_group_type_id\u0027])\n  \n```","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                       f\u0027show {sg_name}\u0027)\r"},{"line_number":35,"context_line":"\r"},{"line_number":36,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, share_group)\r"},{"line_number":37,"context_line":"        self.assertIsNotNone(share_group[\u0027share_group_type_id\u0027])\r"},{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"        try:\r"},{"line_number":40,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"403d9158_d9cfd169","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":64},"in_reply_to":"c9a8080d_16d84abe","updated":"2025-08-13 18:20:33.000000000","message":"replaced this is new patch","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2591145a5e4c8bd88b19a8b73688d2c1694c6056","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, share_group)\r"},{"line_number":37,"context_line":"        self.assertIsNotNone(share_group[\u0027share_group_type_id\u0027])\r"},{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"        try:\r"},{"line_number":40,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":41,"context_line":"        except Exception:\r"},{"line_number":42,"context_line":"            pass\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":45,"context_line":"        sg_name \u003d \"fake_share_group_with_network\"\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"f28624a1_e47161ff","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":16},"updated":"2025-07-30 22:58:05.000000000","message":"curious why the try..except block here, and not in the tests below","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"24d2780837237f9ca19e2a64ffa21d30340109af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertIn(\u0027share_group_type_id\u0027, share_group)\r"},{"line_number":37,"context_line":"        self.assertIsNotNone(share_group[\u0027share_group_type_id\u0027])\r"},{"line_number":38,"context_line":"\r"},{"line_number":39,"context_line":"        try:\r"},{"line_number":40,"context_line":"            self.openstack(f\u0027share group delete {sg_name}\u0027)\r"},{"line_number":41,"context_line":"        except Exception:\r"},{"line_number":42,"context_line":"            pass\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"    def test_create_share_group_with_share_network(self):\r"},{"line_number":45,"context_line":"        sg_name \u003d \"fake_share_group_with_network\"\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"45420f3b_cd2a4b1a","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":16},"in_reply_to":"f28624a1_e47161ff","updated":"2025-08-13 18:20:33.000000000","message":"This was actually a mistake, I was actually told to remove this and i did but then i was trying different things with the code and they didnt work and i wasnt sure how to go back on pycharm so i copied a previous patch that had the try block lol, i\u0027ll delete it again","commit_id":"027cb0ac940d17f32ca5dc9860675573fb706740"}]}