)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf688a676db617622ffbb453b235943dad79959d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Test Plan:"},{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"009bb11d_962312c3","line":21,"updated":"2025-10-27 17:05:26.000000000","message":"Do you need an \"Assisted-By\" comment here as well?","commit_id":"0856a046801ecae0ab56a36c285d73429f247d9f"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Test Plan:"},{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"928ef97d_53fdea15","line":21,"in_reply_to":"009bb11d_962312c3","updated":"2025-10-28 11:31:39.000000000","message":"Sure, added","commit_id":"0856a046801ecae0ab56a36c285d73429f247d9f"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"8526768385c129177c7f2095b8163ee91e592c14","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Test Plan:"},{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"265cd079_fe0b45c6","line":21,"in_reply_to":"928ef97d_53fdea15","updated":"2025-10-28 23:39:12.000000000","message":"Done","commit_id":"0856a046801ecae0ab56a36c285d73429f247d9f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62677a4bb624adaaee1f48e085eb409ac3b6b6b3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"},{"line_number":25,"context_line":"Assisted-By: Copilot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ee4025d9_0f57b383","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":6},"updated":"2025-10-27 18:35:50.000000000","message":"Since this addresses the \"share network create\" command, and not the \"share network subnet create\" command, please set this as \"Partial-Bug\" instead of \"Closes-Bug\".\n\nAlternatively, you could fix up the \"share network subnet create\" command as well in the same change: https://github.com/openstack/python-manilaclient/blob/7ed6482c6d41c6069736b46275930f3d6a596575/manilaclient/osc/v2/share_network_subnets.py#L113-L119","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"8526768385c129177c7f2095b8163ee91e592c14","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"},{"line_number":25,"context_line":"Assisted-By: Copilot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5058480d_5128569d","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":6},"in_reply_to":"3349fabb_3d1aa8c7","updated":"2025-10-28 23:39:12.000000000","message":"Done","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- Added unit tests to verify valid and invalid"},{"line_number":20,"context_line":"  neutron info."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #2051394"},{"line_number":23,"context_line":"Change-Id: Ib233f02ad94326d5b8ffadf962fb911d417b024a"},{"line_number":24,"context_line":"Signed-off-by: denver-baraka \u003cdenverbaraka@gmail.com\u003e"},{"line_number":25,"context_line":"Assisted-By: Copilot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3349fabb_3d1aa8c7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":6},"in_reply_to":"ee4025d9_0f57b383","updated":"2025-10-28 11:31:39.000000000","message":"resolving with just the \"Partial_Bug\"","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f279bd4f_6c4dadc0","updated":"2025-10-22 23:24:09.000000000","message":"Good start, Denver. Please see comments inline","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf688a676db617622ffbb453b235943dad79959d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a924ee90_6f1c2a63","updated":"2025-10-27 17:05:26.000000000","message":"Hey @denverbaraka@gmail.com; thanks for the changes.. Can you add a bug fix release note here? https://docs.openstack.org/python-manilaclient/latest/contributor/adding_release_notes.html#what-are-release-notes","commit_id":"0856a046801ecae0ab56a36c285d73429f247d9f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62677a4bb624adaaee1f48e085eb409ac3b6b6b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7ad88ee5_d6561087","updated":"2025-10-27 18:35:50.000000000","message":"@denverbaraka@gmail.com: some more comments inline","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65623ca5_2f316e01","in_reply_to":"7ad88ee5_d6561087","updated":"2025-10-28 11:31:39.000000000","message":"Acknowledged","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74e42d77_b28356cd","updated":"2025-10-28 11:31:39.000000000","message":"resolved the issues highlighted","commit_id":"795202d86553615da266fbeee69a74bcba7e072f"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"8526768385c129177c7f2095b8163ee91e592c14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d816be8c_37cf45e1","updated":"2025-10-28 23:39:12.000000000","message":"fixed the \"share network subnet create\" command as well to close the bug and not a partial bug","commit_id":"bd0c996abd40aa60a9456fc67dcd03fe6e431301"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f69378077a1d191e9b87cae675b19bd032ead31e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cd59caf4_97a1f104","updated":"2025-10-29 20:28:24.000000000","message":"LGTM, thank you Denver","commit_id":"53ca6e9f873e04e2a14c46739f859aecd9ea74f3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d6e8d8e60b9f0431d7aaca0cf49ea9814b8e6527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8f89bb46_56d1a570","updated":"2025-10-30 18:55:51.000000000","message":"LGTM, thanks Denver!","commit_id":"53ca6e9f873e04e2a14c46739f859aecd9ea74f3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"0ae7f3a1bc8f9841d254ea26d2d4bb3e7e2efe04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b2700d8f_6c883940","updated":"2025-10-30 00:38:27.000000000","message":"Thanks for the review, :)","commit_id":"53ca6e9f873e04e2a14c46739f859aecd9ea74f3"}],"manilaclient/osc/v2/share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad8f059a906c7b9b4d96c5f6af09e441b8cc9a59","unresolved":true,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"            subnet_create_check \u003d ("},{"line_number":155,"context_line":"                share_client.share_networks.share_network_subnet_create_check("},{"line_number":156,"context_line":"                    neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":157,"context_line":"                    neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":158,"context_line":"                    availability_zone\u003dparsed_args.availability_zone,"},{"line_number":159,"context_line":"                    reset_operation\u003dparsed_args.restart_check,"}],"source_content_type":"text/x-python","patch_set":5,"id":"afabdf63_4c0dd0c1","line":156,"range":{"start_line":156,"start_character":35,"end_line":156,"end_character":61},"updated":"2025-10-29 05:50:58.000000000","message":"neutron_net_id","commit_id":"bd0c996abd40aa60a9456fc67dcd03fe6e431301"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"31a0cb6274568ab95eb74943841ce4126d1e312f","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"            subnet_create_check \u003d ("},{"line_number":155,"context_line":"                share_client.share_networks.share_network_subnet_create_check("},{"line_number":156,"context_line":"                    neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":157,"context_line":"                    neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":158,"context_line":"                    availability_zone\u003dparsed_args.availability_zone,"},{"line_number":159,"context_line":"                    reset_operation\u003dparsed_args.restart_check,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cec78130_93de4cd7","line":156,"range":{"start_line":156,"start_character":35,"end_line":156,"end_character":61},"in_reply_to":"afabdf63_4c0dd0c1","updated":"2025-10-29 08:30:27.000000000","message":"Done","commit_id":"bd0c996abd40aa60a9456fc67dcd03fe6e431301"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad8f059a906c7b9b4d96c5f6af09e441b8cc9a59","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            subnet_create_check \u003d ("},{"line_number":155,"context_line":"                share_client.share_networks.share_network_subnet_create_check("},{"line_number":156,"context_line":"                    neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":157,"context_line":"                    neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":158,"context_line":"                    availability_zone\u003dparsed_args.availability_zone,"},{"line_number":159,"context_line":"                    reset_operation\u003dparsed_args.restart_check,"},{"line_number":160,"context_line":"                    share_network_id\u003dshare_network_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f94c2418_98f02850","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":67},"updated":"2025-10-29 05:50:58.000000000","message":"neutron_subnet_id","commit_id":"bd0c996abd40aa60a9456fc67dcd03fe6e431301"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"31a0cb6274568ab95eb74943841ce4126d1e312f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            subnet_create_check \u003d ("},{"line_number":155,"context_line":"                share_client.share_networks.share_network_subnet_create_check("},{"line_number":156,"context_line":"                    neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":157,"context_line":"                    neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":158,"context_line":"                    availability_zone\u003dparsed_args.availability_zone,"},{"line_number":159,"context_line":"                    reset_operation\u003dparsed_args.restart_check,"},{"line_number":160,"context_line":"                    share_network_id\u003dshare_network_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fbd4afd6_2ef3196a","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":67},"in_reply_to":"f94c2418_98f02850","updated":"2025-10-29 08:30:27.000000000","message":"Done","commit_id":"bd0c996abd40aa60a9456fc67dcd03fe6e431301"}],"manilaclient/osc/v2/share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def take_action(self, parsed_args):"},{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2bbde667_f5cd79bb","line":303,"updated":"2025-10-22 23:24:09.000000000","message":"Good start here, Denver. The bug refers to two problems:\n\n1) If we\u0027re able to validate if neutron_network_id and neutron_subnet_id exist and are usable, we should do that - so checking for the neutron client and performing validation selectively is a good approach\n2) This command should also allow referring to the network and subnet by their names instead of IDs. This can be achieved by using \"find_network\" and \"find_subnet\" methods instead of \"get_network\" and \"get_subnet\"","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def take_action(self, parsed_args):"},{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"074c1a7e_900192f2","line":303,"in_reply_to":"2bbde667_f5cd79bb","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    def take_action(self, parsed_args):"},{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bedfe336_70dbf0ee","line":304,"updated":"2025-10-22 23:24:09.000000000","message":"Capture these parsed args as variables:\n\n```\nneutron_net_id \u003d parsed_args.neutron_net_id\nneutron_subnet_id \u003d parsed_args.neutron_subnet_id\n```","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def take_action(self, parsed_args):"},{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eee1e879_6ea187ec","line":304,"in_reply_to":"bedfe336_70dbf0ee","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"},{"line_number":308,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8cf8c05_aed8457c","line":305,"range":{"start_line":305,"start_character":30,"end_line":305,"end_character":56},"updated":"2025-10-22 23:24:09.000000000","message":"test neutron_net_id instead","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":303,"context_line":"        neutron_client \u003d getattr(self.app.client_manager, \u0027network\u0027, None)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"},{"line_number":308,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"429eb814_5d33e0c1","line":305,"range":{"start_line":305,"start_character":30,"end_line":305,"end_character":56},"in_reply_to":"d8cf8c05_aed8457c","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"},{"line_number":308,"context_line":"            except Exception:"},{"line_number":309,"context_line":"                raise exceptions.CommandError("},{"line_number":310,"context_line":"                    f\"Neutron network \u0027{parsed_args.neutron_net_id}\u0027\""}],"source_content_type":"text/x-python","patch_set":1,"id":"82152056_9606c60f","line":307,"range":{"start_line":307,"start_character":16,"end_line":307,"end_character":70},"updated":"2025-10-22 23:24:09.000000000","message":"neutron_net_id \u003d neutron_client.find_network(parsed_args.neutron_net_id, ignore_missing\u003dFalse).id","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if neutron_client and parsed_args.neutron_net_id:"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                neutron_client.get_network(parsed_args.neutron_net_id)"},{"line_number":308,"context_line":"            except Exception:"},{"line_number":309,"context_line":"                raise exceptions.CommandError("},{"line_number":310,"context_line":"                    f\"Neutron network \u0027{parsed_args.neutron_net_id}\u0027\""}],"source_content_type":"text/x-python","patch_set":1,"id":"a3cd92bf_352a0608","line":307,"range":{"start_line":307,"start_character":16,"end_line":307,"end_character":70},"in_reply_to":"82152056_9606c60f","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                raise exceptions.CommandError("},{"line_number":310,"context_line":"                    f\"Neutron network \u0027{parsed_args.neutron_net_id}\u0027\""},{"line_number":311,"context_line":"                    f\" not found.\")"},{"line_number":312,"context_line":"        if neutron_client and parsed_args.neutron_subnet_id:"},{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                neutron_client.get_subnet(parsed_args.neutron_subnet_id)"},{"line_number":315,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae8f8bbf_9f381e8b","line":312,"range":{"start_line":312,"start_character":42,"end_line":312,"end_character":59},"updated":"2025-10-22 23:24:09.000000000","message":"test neutron_subnet_id instead","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                raise exceptions.CommandError("},{"line_number":310,"context_line":"                    f\"Neutron network \u0027{parsed_args.neutron_net_id}\u0027\""},{"line_number":311,"context_line":"                    f\" not found.\")"},{"line_number":312,"context_line":"        if neutron_client and parsed_args.neutron_subnet_id:"},{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                neutron_client.get_subnet(parsed_args.neutron_subnet_id)"},{"line_number":315,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7cbd1436_fb9a599b","line":312,"range":{"start_line":312,"start_character":42,"end_line":312,"end_character":59},"in_reply_to":"ae8f8bbf_9f381e8b","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                    f\" not found.\")"},{"line_number":312,"context_line":"        if neutron_client and parsed_args.neutron_subnet_id:"},{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                neutron_client.get_subnet(parsed_args.neutron_subnet_id)"},{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                raise exceptions.CommandError("},{"line_number":317,"context_line":"                    f\"Neutron subnet \u0027{parsed_args.neutron_subnet_id}\u0027\""}],"source_content_type":"text/x-python","patch_set":1,"id":"e4a61374_749090d1","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":72},"updated":"2025-10-22 23:24:09.000000000","message":"neutron_subnet_id \u003d client.find_subnet(neutron_subnet_id, ignore_missing\u003dFalse).id","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    f\" not found.\")"},{"line_number":312,"context_line":"        if neutron_client and parsed_args.neutron_subnet_id:"},{"line_number":313,"context_line":"            try:"},{"line_number":314,"context_line":"                neutron_client.get_subnet(parsed_args.neutron_subnet_id)"},{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                raise exceptions.CommandError("},{"line_number":317,"context_line":"                    f\"Neutron subnet \u0027{parsed_args.neutron_subnet_id}\u0027\""}],"source_content_type":"text/x-python","patch_set":1,"id":"516bb973_34b23917","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":72},"in_reply_to":"e4a61374_749090d1","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        kwargs \u003d {"},{"line_number":330,"context_line":"            \"name\": parsed_args.name,"},{"line_number":331,"context_line":"            \"description\": parsed_args.description,"},{"line_number":332,"context_line":"            \"neutron_net_id\": parsed_args.neutron_net_id,"},{"line_number":333,"context_line":"            \"neutron_subnet_id\": parsed_args.neutron_subnet_id,"},{"line_number":334,"context_line":"        }"},{"line_number":335,"context_line":"        if availability_zone:"},{"line_number":336,"context_line":"            kwargs[\u0027availability_zone\u0027] \u003d availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"259c0eca_299106e1","line":333,"range":{"start_line":332,"start_character":12,"end_line":333,"end_character":63},"updated":"2025-10-22 23:24:09.000000000","message":"```suggestion\n            \"neutron_net_id\": neutron_net_id,\n            \"neutron_subnet_id\": neutron_subnet_id,\n```","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        kwargs \u003d {"},{"line_number":330,"context_line":"            \"name\": parsed_args.name,"},{"line_number":331,"context_line":"            \"description\": parsed_args.description,"},{"line_number":332,"context_line":"            \"neutron_net_id\": parsed_args.neutron_net_id,"},{"line_number":333,"context_line":"            \"neutron_subnet_id\": parsed_args.neutron_subnet_id,"},{"line_number":334,"context_line":"        }"},{"line_number":335,"context_line":"        if availability_zone:"},{"line_number":336,"context_line":"            kwargs[\u0027availability_zone\u0027] \u003d availability_zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"235c8a5f_0e4ab6b1","line":333,"range":{"start_line":332,"start_character":12,"end_line":333,"end_character":63},"in_reply_to":"259c0eca_299106e1","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"}],"manilaclient/tests/unit/osc/v2/test_share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c3e5cb9393ee62a55fd1bf46182367ed6b7fac3","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        neutron_client \u003d mock.Mock()"},{"line_number":166,"context_line":"        self.app.client_manager.network \u003d neutron_client"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        neutron_client.get_network.side_effect \u003d Exception(\"Network not found\")"},{"line_number":169,"context_line":"        neutron_client.get_subnet.side_effect \u003d Exception(\"Subnet not found\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        arglist \u003d ["},{"line_number":172,"context_line":"            \u0027--neutron-net-id\u0027, fake_neutron_net_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0998a66_7f92dd9c","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":77},"updated":"2025-10-22 23:24:09.000000000","message":"split this into separate tests please","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"26401eb1be0d1d4d7f9e7c4da043efb47499365f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        neutron_client \u003d mock.Mock()"},{"line_number":166,"context_line":"        self.app.client_manager.network \u003d neutron_client"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        neutron_client.get_network.side_effect \u003d Exception(\"Network not found\")"},{"line_number":169,"context_line":"        neutron_client.get_subnet.side_effect \u003d Exception(\"Subnet not found\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        arglist \u003d ["},{"line_number":172,"context_line":"            \u0027--neutron-net-id\u0027, fake_neutron_net_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f760ab9c_a878de3e","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":77},"in_reply_to":"a0998a66_7f92dd9c","updated":"2025-10-23 18:14:04.000000000","message":"Done","commit_id":"691054b86e6ff1f3f9063ee8ed1e2d9bfde81624"}],"releasenotes/notes/bug-2051394-fix-validate-neutron-info-ebe679675111eec9.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62677a4bb624adaaee1f48e085eb409ac3b6b6b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The \"openstack share network create\" and"},{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a76ea4a4_dad236c7","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":52},"updated":"2025-10-27 18:35:50.000000000","message":"The \"openstack share network subnet create\" command hasn\u0027t been fixed up by this change.. it\u0027s only the \"share network create\" command","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"8526768385c129177c7f2095b8163ee91e592c14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The \"openstack share network create\" and"},{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0bb45a45_0db2f92c","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":52},"in_reply_to":"194133e3_0582c92e","updated":"2025-10-28 23:39:12.000000000","message":"Done","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The \"openstack share network create\" and"},{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"194133e3_0582c92e","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":52},"in_reply_to":"a76ea4a4_dad236c7","updated":"2025-10-28 11:31:39.000000000","message":"corrected","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62677a4bb624adaaee1f48e085eb409ac3b6b6b3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"},{"line_number":8,"context_line":"    unexpectedly when invalid neutron network or"},{"line_number":9,"context_line":"    subnet IDs were supplied. The client now performs"},{"line_number":10,"context_line":"    proper validation and handles missing or invalid"},{"line_number":11,"context_line":"    network data gracefully."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1e98bff3_7b4f076a","line":9,"range":{"start_line":7,"start_character":16,"end_line":9,"end_character":29},"updated":"2025-10-27 18:35:50.000000000","message":"this validation only happened in Manila, not in the client previously","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"a22530cd04c579a0323b61bc52b6167b16b5051a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"},{"line_number":8,"context_line":"    unexpectedly when invalid neutron network or"},{"line_number":9,"context_line":"    subnet IDs were supplied. The client now performs"},{"line_number":10,"context_line":"    proper validation and handles missing or invalid"},{"line_number":11,"context_line":"    network data gracefully."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b17d3978_f385f23d","line":9,"range":{"start_line":7,"start_character":16,"end_line":9,"end_character":29},"in_reply_to":"1e98bff3_7b4f076a","updated":"2025-10-28 11:31:39.000000000","message":"made a correction","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"8526768385c129177c7f2095b8163ee91e592c14","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"openstack share network subnet create\" commands"},{"line_number":5,"context_line":"    now validate Neutron network information provided."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Previously, these commands could fail or behave"},{"line_number":8,"context_line":"    unexpectedly when invalid neutron network or"},{"line_number":9,"context_line":"    subnet IDs were supplied. The client now performs"},{"line_number":10,"context_line":"    proper validation and handles missing or invalid"},{"line_number":11,"context_line":"    network data gracefully."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"92ef6b76_30092194","line":9,"range":{"start_line":7,"start_character":16,"end_line":9,"end_character":29},"in_reply_to":"b17d3978_f385f23d","updated":"2025-10-28 23:39:12.000000000","message":"Done","commit_id":"dd56f564f2c1c4330401b57c35e2520d827a4ff3"}]}