)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"511742c012ca0b33be788087681108899f04f3ec","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow settings --task-state without value (to send null) or None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The osc commands `openstack share set \u003cshare-id\u003e --task-state` and `openstack share server set \u003cshare-server-id\u003e --task-state`  were failing when no value was provided, or when None was passed as an argument, leading to the API receive the string \"null\" instead of the JSON null value."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This change makes the --task-state argument optional, allowing it to be specified without a value or with the string \"None\"."},{"line_number":12,"context_line":"In both cases, the command correctly interprets these inputs as e request to clear the task state by sending a proper null value to the API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9be6546f_7e02bc54","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":285},"updated":"2025-10-23 11:05:02.000000000","message":"nit: please wrap these lines in 72 characters as defined in the commit messages guidelines: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1370aecebd5b8028493c0353273516b07efed221"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"9ca9e5f066029e5c4524a73fb39c8ede35ca9009","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow settings --task-state without value (to send null) or None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The osc commands `openstack share set \u003cshare-id\u003e --task-state` and `openstack share server set \u003cshare-server-id\u003e --task-state`  were failing when no value was provided, or when None was passed as an argument, leading to the API receive the string \"null\" instead of the JSON null value."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This change makes the --task-state argument optional, allowing it to be specified without a value or with the string \"None\"."},{"line_number":12,"context_line":"In both cases, the command correctly interprets these inputs as e request to clear the task state by sending a proper null value to the API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6e4bcc82_9ea12554","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":285},"in_reply_to":"9be6546f_7e02bc54","updated":"2025-10-23 13:46:44.000000000","message":"Done","commit_id":"1370aecebd5b8028493c0353273516b07efed221"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"511742c012ca0b33be788087681108899f04f3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10544cdf_96af5c23","updated":"2025-10-23 11:05:02.000000000","message":"Thank you for working on this change. I have some suggestions and dropped some comments inline. Please take a look.\nAlso, could you please add a release note [1] for this change? \n\n[1] https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"1370aecebd5b8028493c0353273516b07efed221"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"9ca9e5f066029e5c4524a73fb39c8ede35ca9009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99408843_8a5e1a8a","updated":"2025-10-23 13:46:44.000000000","message":"Thank you for your feedback. I reverted back the change in shell.py file as well as added the release note and adjusted the length of the lines in the commit message.","commit_id":"b9e36ddc436a9459231d6c8b9075b880cb8c53a1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a332515ff6e684ebf495d30352f3a1ee23785f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"891dfcb1_13430e14","updated":"2025-10-23 14:09:02.000000000","message":"I\u0027ve one more question, sorry: have you tested this change manually? If not, we might want to introduce a functional test at least for the shares","commit_id":"17865754fdc68b540d898a408034ece0fb9ba295"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"18f79a5d1c490d8755b4b0c1aae332426162cd62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ad8d345_630da257","in_reply_to":"891dfcb1_13430e14","updated":"2025-10-24 07:15:36.000000000","message":"Yes, I have tested it before and after the changes. Here is the output:\nhttps://paste.opendev.org/show/829420/\nIs this enough, or should I do some other tests?","commit_id":"17865754fdc68b540d898a408034ece0fb9ba295"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"baf1246060d3c26dc8dc0c00281700caad1dcba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"be7a83d3_c7fec8fe","updated":"2025-10-25 05:54:17.000000000","message":"Thank you for the feedback. I added the underscore.","commit_id":"e1df68aca751ae20a0181b2bd04d58c96ab01a69"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c99e3b3c3707f3bcf7d0ec96d5804d2495026eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8460084_20df2778","updated":"2025-10-28 14:11:41.000000000","message":"LGTM, thanks for working on this change and testing it!","commit_id":"d0060a45a94f787b956e966912970def0fad85f4"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"511742c012ca0b33be788087681108899f04f3ec","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"    \u0027--task_state\u0027,"},{"line_number":1172,"context_line":"    \u0027--state\u0027,"},{"line_number":1173,"context_line":"    metavar\u003d\u0027\u003ctask_state\u003e\u0027,"},{"line_number":1174,"context_line":"    default\u003dNone,"},{"line_number":1175,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1176,"context_line":"    required\u003dFalse,"},{"line_number":1177,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fbed854_727ba1b2","line":1174,"range":{"start_line":1174,"start_character":0,"end_line":1174,"end_character":17},"updated":"2025-10-23 11:05:02.000000000","message":"we do not need to change the shell client, as the bug only focuses on the OSC, so please undo this change","commit_id":"1370aecebd5b8028493c0353273516b07efed221"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"9ca9e5f066029e5c4524a73fb39c8ede35ca9009","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"    \u0027--task_state\u0027,"},{"line_number":1172,"context_line":"    \u0027--state\u0027,"},{"line_number":1173,"context_line":"    metavar\u003d\u0027\u003ctask_state\u003e\u0027,"},{"line_number":1174,"context_line":"    default\u003dNone,"},{"line_number":1175,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1176,"context_line":"    required\u003dFalse,"},{"line_number":1177,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1477049c_4b383988","line":1174,"range":{"start_line":1174,"start_character":0,"end_line":1174,"end_character":17},"in_reply_to":"1fbed854_727ba1b2","updated":"2025-10-23 13:46:44.000000000","message":"Done","commit_id":"1370aecebd5b8028493c0353273516b07efed221"}],"releasenotes/notes/bug-2108991-fix-task-state-none-handling-in-osc-share-set-307f3f4a2b232dd8.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3a332515ff6e684ebf495d30352f3a1ee23785f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `openstack share set` and `openstack share server set` commands now"},{"line_number":5,"context_line":"    properly handle the `--task-state` argument when given no value or \"None\", "},{"line_number":6,"context_line":"    sending a proper null value to the API. For more details, please refer to"},{"line_number":7,"context_line":"    `Launchpad bug #2108991 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2108991\u003e`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4bf6350a_c97e5a02","line":4,"updated":"2025-10-23 14:09:02.000000000","message":"please drop the blank space in the line below","commit_id":"17865754fdc68b540d898a408034ece0fb9ba295"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"676696aac8dbbb69dbade82ae74c79ea62af9d97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `openstack share set` and `openstack share server set` commands now"},{"line_number":5,"context_line":"    properly handle the `--task-state` argument when given no value or \"None\", "},{"line_number":6,"context_line":"    sending a proper null value to the API. For more details, please refer to"},{"line_number":7,"context_line":"    `Launchpad bug #2108991 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2108991\u003e`."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b69102e7_6d38d5d2","line":4,"in_reply_to":"4bf6350a_c97e5a02","updated":"2025-10-24 08:43:29.000000000","message":"Done","commit_id":"17865754fdc68b540d898a408034ece0fb9ba295"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff9e48c15457b6294e90427f3ad17e403798904c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The `openstack share set` and `openstack share server set` commands now"},{"line_number":5,"context_line":"    properly handle the `--task-state` argument when given no value or \"None\","},{"line_number":6,"context_line":"    sending a proper null value to the API. For more details, please refer to"},{"line_number":7,"context_line":"    `Launchpad bug #2108991 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2108991\u003e`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"29606c12_f50e68d1","line":7,"range":{"start_line":7,"start_character":90,"end_line":7,"end_character":91},"updated":"2025-10-24 22:25:48.000000000","message":"add a underscore (_) after the back-tick to actually link the text - Launchpad bug #2108991, rather than put the URL in the text\n\n\n```suggestion\n    `Launchpad bug #2108991 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2108991\u003e`_.\n```","commit_id":"e1df68aca751ae20a0181b2bd04d58c96ab01a69"},{"author":{"_account_id":38463,"name":"llm tech","display_name":"llmtech","email":"llm.tech.developer@gmail.com","username":"llmtech"},"change_message_id":"baf1246060d3c26dc8dc0c00281700caad1dcba6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The `openstack share set` and `openstack share server set` commands now"},{"line_number":5,"context_line":"    properly handle the `--task-state` argument when given no value or \"None\","},{"line_number":6,"context_line":"    sending a proper null value to the API. For more details, please refer to"},{"line_number":7,"context_line":"    `Launchpad bug #2108991 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/2108991\u003e`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"471c7d93_c2406bb4","line":7,"range":{"start_line":7,"start_character":90,"end_line":7,"end_character":91},"in_reply_to":"29606c12_f50e68d1","updated":"2025-10-25 05:54:17.000000000","message":"Done","commit_id":"e1df68aca751ae20a0181b2bd04d58c96ab01a69"}]}