)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9648b63752bd7d6bd43c3dcd072c7d30e595fad5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Premlata \u003cpremlata84277@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-23 19:48:05 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add --wait flag to share-server-manage and unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the --wait flag to the share-server-manage"},{"line_number":10,"context_line":"and share-server-unmanage commands, allowing users to wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7c525a2d_831ee072","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":42},"updated":"2025-10-23 17:53:06.000000000","message":"just unmanage right now","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"},{"author":{"_account_id":36422,"name":"PREMLATA","display_name":"premlata84277","email":"premlata84277@gmail.com","username":"premlata84277"},"change_message_id":"88071836b5bff529114d468fcd1cd8620eae5038","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Premlata \u003cpremlata84277@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-23 19:48:05 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add --wait flag to share-server-manage and unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the --wait flag to the share-server-manage"},{"line_number":10,"context_line":"and share-server-unmanage commands, allowing users to wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"be60e96c_251c0098","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":42},"in_reply_to":"7c525a2d_831ee072","updated":"2025-10-27 20:31:27.000000000","message":"Acknowledged","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9648b63752bd7d6bd43c3dcd072c7d30e595fad5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add --wait flag to share-server-manage and unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the --wait flag to the share-server-manage"},{"line_number":10,"context_line":"and share-server-unmanage commands, allowing users to wait"},{"line_number":11,"context_line":"for the asynchronous operations to complete before returning"},{"line_number":12,"context_line":"to the command prompt."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bc757db2_91cd535e","line":10,"range":{"start_line":9,"start_character":41,"end_line":10,"end_character":3},"updated":"2025-10-23 17:53:06.000000000","message":"same","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"},{"author":{"_account_id":36422,"name":"PREMLATA","display_name":"premlata84277","email":"premlata84277@gmail.com","username":"premlata84277"},"change_message_id":"88071836b5bff529114d468fcd1cd8620eae5038","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add --wait flag to share-server-manage and unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the --wait flag to the share-server-manage"},{"line_number":10,"context_line":"and share-server-unmanage commands, allowing users to wait"},{"line_number":11,"context_line":"for the asynchronous operations to complete before returning"},{"line_number":12,"context_line":"to the command prompt."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d9c87c3e_09541560","line":10,"range":{"start_line":9,"start_character":41,"end_line":10,"end_character":3},"in_reply_to":"bc757db2_91cd535e","updated":"2025-10-27 20:31:27.000000000","message":"Acknowledged","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3721a99543bcaf0d268044b85b78871ce4b782c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9280f2d2_4a041dc8","updated":"2025-10-28 13:58:32.000000000","message":"LGTM, thanks for working on this change.","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9648b63752bd7d6bd43c3dcd072c7d30e595fad5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5582356e_6afb4c7c","updated":"2025-10-23 17:53:06.000000000","message":"Please see comments inline regarding the commit message","commit_id":"a41d7d1596ce5963431897caf79147594f5622dc"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7309d9321849bcf20f0c5e0c9429462ce5663c9c","unresolved":true,"context_lines":[{"line_number":1777,"context_line":"    for server in args.share_server:"},{"line_number":1778,"context_line":"        try:"},{"line_number":1779,"context_line":"            cs.share_servers.unmanage(server, args.force)"},{"line_number":1780,"context_line":"            if args.wait:"},{"line_number":1781,"context_line":"                try:"},{"line_number":1782,"context_line":"                    share_server_ref \u003d _find_share_server(cs, server)"},{"line_number":1783,"context_line":"                    _wait_for_resource_status("},{"line_number":1784,"context_line":"                        cs, share_server_ref, resource_type\u003d\u0027share_server\u0027,"},{"line_number":1785,"context_line":"                        expected_status\u003d\u0027unmanaged\u0027)"},{"line_number":1786,"context_line":"                except exceptions.CommandError as e:"},{"line_number":1787,"context_line":"                    print(e, file\u003dsys.stderr)"},{"line_number":1788,"context_line":"                    failure_count +\u003d 1"},{"line_number":1789,"context_line":"        except Exception as e:"},{"line_number":1790,"context_line":"            failure_count +\u003d 1"},{"line_number":1791,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcedf3eb_4507d0ea","line":1788,"range":{"start_line":1780,"start_character":12,"end_line":1788,"end_character":38},"updated":"2025-10-22 20:31:57.000000000","message":"exceptions raised here will be caught by the outer block, and the failure count will be incorrect","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9648b63752bd7d6bd43c3dcd072c7d30e595fad5","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"    for server in args.share_server:"},{"line_number":1778,"context_line":"        try:"},{"line_number":1779,"context_line":"            cs.share_servers.unmanage(server, args.force)"},{"line_number":1780,"context_line":"            if args.wait:"},{"line_number":1781,"context_line":"                try:"},{"line_number":1782,"context_line":"                    share_server_ref \u003d _find_share_server(cs, server)"},{"line_number":1783,"context_line":"                    _wait_for_resource_status("},{"line_number":1784,"context_line":"                        cs, share_server_ref, resource_type\u003d\u0027share_server\u0027,"},{"line_number":1785,"context_line":"                        expected_status\u003d\u0027unmanaged\u0027)"},{"line_number":1786,"context_line":"                except exceptions.CommandError as e:"},{"line_number":1787,"context_line":"                    print(e, file\u003dsys.stderr)"},{"line_number":1788,"context_line":"                    failure_count +\u003d 1"},{"line_number":1789,"context_line":"        except Exception as e:"},{"line_number":1790,"context_line":"            failure_count +\u003d 1"},{"line_number":1791,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"}],"source_content_type":"text/x-python","patch_set":1,"id":"edbec59c_a732cdc8","line":1788,"range":{"start_line":1780,"start_character":12,"end_line":1788,"end_character":38},"in_reply_to":"dcedf3eb_4507d0ea","updated":"2025-10-23 17:53:06.000000000","message":"Done","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7309d9321849bcf20f0c5e0c9429462ce5663c9c","unresolved":true,"context_lines":[{"line_number":1786,"context_line":"                except exceptions.CommandError as e:"},{"line_number":1787,"context_line":"                    print(e, file\u003dsys.stderr)"},{"line_number":1788,"context_line":"                    failure_count +\u003d 1"},{"line_number":1789,"context_line":"        except Exception as e:"},{"line_number":1790,"context_line":"            failure_count +\u003d 1"},{"line_number":1791,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1792,"context_line":"                  file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"02ada723_6ecef56e","line":1789,"updated":"2025-10-22 20:31:57.000000000","message":"Within one exception handling block, you will need to, both:\n\n- attempt unmanage\n- if wait, invoke _wait_for_resource_status","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"},{"author":{"_account_id":36422,"name":"PREMLATA","display_name":"premlata84277","email":"premlata84277@gmail.com","username":"premlata84277"},"change_message_id":"88071836b5bff529114d468fcd1cd8620eae5038","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                except exceptions.CommandError as e:"},{"line_number":1787,"context_line":"                    print(e, file\u003dsys.stderr)"},{"line_number":1788,"context_line":"                    failure_count +\u003d 1"},{"line_number":1789,"context_line":"        except Exception as e:"},{"line_number":1790,"context_line":"            failure_count +\u003d 1"},{"line_number":1791,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1792,"context_line":"                  file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5fc4f59_b8199020","line":1789,"in_reply_to":"00ca77b5_b68f8f1a","updated":"2025-10-27 20:31:27.000000000","message":"Done","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9648b63752bd7d6bd43c3dcd072c7d30e595fad5","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                except exceptions.CommandError as e:"},{"line_number":1787,"context_line":"                    print(e, file\u003dsys.stderr)"},{"line_number":1788,"context_line":"                    failure_count +\u003d 1"},{"line_number":1789,"context_line":"        except Exception as e:"},{"line_number":1790,"context_line":"            failure_count +\u003d 1"},{"line_number":1791,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1792,"context_line":"                  file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"00ca77b5_b68f8f1a","line":1789,"in_reply_to":"02ada723_6ecef56e","updated":"2025-10-23 17:53:06.000000000","message":"Hey @premlata84277@gmail.com: you can resolve comments that you\u0027ve addressed. See https://youtu.be/zwQChupbU-c for instructions..","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"}],"releasenotes/notes/bug-1898315-add-wait-flag-to-manage-share-server-operation-be6488c2a57536e1.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7309d9321849bcf20f0c5e0c9429462ce5663c9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90c38a0d_2f986823","updated":"2025-10-22 20:31:57.000000000","message":"You can\u0027t edit an existing release note, please add a new one for this specific improvement","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"},{"author":{"_account_id":36422,"name":"PREMLATA","display_name":"premlata84277","email":"premlata84277@gmail.com","username":"premlata84277"},"change_message_id":"88071836b5bff529114d468fcd1cd8620eae5038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb2457b8_ea479238","in_reply_to":"90c38a0d_2f986823","updated":"2025-10-27 20:31:27.000000000","message":"Done","commit_id":"14063b78033d96b9ec6503e2c9af66b733c3fa02"}]}