)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fcaca21_8acb4344","updated":"2026-01-27 22:21:55.000000000","message":"Thanks Maria, \n\nit looks like there\u0027re a bunch of linting issues. Could you please run \"tox -e pep8\" and fix these, or, use pre-commit so some of these can be automatically cleaned up by the scripts we have","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"}],"manilaclient/tests/functional/osc/test_share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(share[\"id\"], snapshot[\"share_id\"])"},{"line_number":246,"context_line":"        self.assertEqual(snapshot_name, snapshot[\"name\"])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        show_result \u003d self.dict_result("},{"line_number":249,"context_line":"            \u0027share snapshot show\u0027,"},{"line_number":250,"context_line":"            f\u0027{snapshot[\"id\"]}\u0027"},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fd016602_548e0717","line":251,"range":{"start_line":248,"start_character":22,"end_line":251,"end_character":9},"updated":"2026-01-27 22:21:55.000000000","message":"The object name and command should be separated. This should be written like this:\n\n```\nshow_result \u003d self.dict_result(\n      \u0027share snapshot\u0027, f\u0027show {snapshot[\"id\"]}\u0027\n  )\n```","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.assertEqual(share[\"id\"], snapshot[\"share_id\"])"},{"line_number":246,"context_line":"        self.assertEqual(snapshot_name, snapshot[\"name\"])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        show_result \u003d self.dict_result("},{"line_number":249,"context_line":"            \u0027share snapshot show\u0027,"},{"line_number":250,"context_line":"            f\u0027{snapshot[\"id\"]}\u0027"},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"faa5dabb_8bd0bbb2","line":251,"range":{"start_line":248,"start_character":22,"end_line":251,"end_character":9},"in_reply_to":"fd016602_548e0717","updated":"2026-02-25 17:32:42.000000000","message":"updated in pycharm","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":250,"context_line":"            f\u0027{snapshot[\"id\"]}\u0027"},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        show_properties \u003d dict("},{"line_number":256,"context_line":"            item.split(\u0027\u003d\u0027) for item in show_result[\u0027properties\u0027].split(\u0027, \u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9a7f771_504ec21e","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":67},"updated":"2026-01-27 22:21:55.000000000","message":"It\u0027s going to be one of these three. So we should tighten this assert, something along these lines:\n\n```\n  self.assertIsNotNone(show_result.get(\u0027properties\u0027))\n  self.assertNotEqual(show_result.get(\u0027properties\u0027), \u0027\u0027)\n```","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            f\u0027{snapshot[\"id\"]}\u0027"},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        show_properties \u003d dict("},{"line_number":256,"context_line":"            item.split(\u0027\u003d\u0027) for item in show_result[\u0027properties\u0027].split(\u0027, \u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a012361_7a430c2a","line":253,"range":{"start_line":253,"start_character":0,"end_line":253,"end_character":67},"in_reply_to":"a9a7f771_504ec21e","updated":"2026-02-25 17:32:42.000000000","message":"Done","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        show_properties \u003d dict("},{"line_number":256,"context_line":"            item.split(\u0027\u003d\u0027) for item in show_result[\u0027properties\u0027].split(\u0027, \u0027)"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.assertIn(\u0027key1\u0027, show_properties)"},{"line_number":260,"context_line":"        self.assertIn(\u0027key2\u0027, show_properties)"},{"line_number":261,"context_line":"        self.assertEqual(\"\u0027value1\u0027\", show_properties[\u0027key1\u0027])"},{"line_number":262,"context_line":"        self.assertEqual(\"\u0027value2\u0027\", show_properties[\u0027key2\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        self.assertRaises("},{"line_number":265,"context_line":"            exceptions.CommandError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab6162ac_3d785138","line":262,"range":{"start_line":255,"start_character":8,"end_line":262,"end_character":61},"updated":"2026-01-27 22:21:55.000000000","message":"maybe:\n\n```\nself.assertEqual(\"key1\u003d\u0027value1\u0027, key2\u003d\u0027value2\u0027\", show_result[\u0027properties\u0027])\n```","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        self.assertNotIn(show_result[\u0027properties\u0027], [{}, \"\", None])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        show_properties \u003d dict("},{"line_number":256,"context_line":"            item.split(\u0027\u003d\u0027) for item in show_result[\u0027properties\u0027].split(\u0027, \u0027)"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.assertIn(\u0027key1\u0027, show_properties)"},{"line_number":260,"context_line":"        self.assertIn(\u0027key2\u0027, show_properties)"},{"line_number":261,"context_line":"        self.assertEqual(\"\u0027value1\u0027\", show_properties[\u0027key1\u0027])"},{"line_number":262,"context_line":"        self.assertEqual(\"\u0027value2\u0027\", show_properties[\u0027key2\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        self.assertRaises("},{"line_number":265,"context_line":"            exceptions.CommandError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d98649ab_2696c192","line":262,"range":{"start_line":255,"start_character":8,"end_line":262,"end_character":61},"in_reply_to":"ab6162ac_3d785138","updated":"2026-02-25 17:32:42.000000000","message":"Done","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        self.assertEqual(\"\u0027value2\u0027\", show_properties[\u0027key2\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        self.assertRaises("},{"line_number":265,"context_line":"            exceptions.CommandError,"},{"line_number":266,"context_line":"        self.openstack,"},{"line_number":267,"context_line":"            f\u0027share snapshot set {snapshot[\"id\"]} --property xyzzy\u0027)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"db4aac9f_730b833f","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":23},"updated":"2026-01-27 22:21:55.000000000","message":"You\u0027ll need to import exceptions.","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self.assertEqual(\"\u0027value2\u0027\", show_properties[\u0027key2\u0027])"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        self.assertRaises("},{"line_number":265,"context_line":"            exceptions.CommandError,"},{"line_number":266,"context_line":"        self.openstack,"},{"line_number":267,"context_line":"            f\u0027share snapshot set {snapshot[\"id\"]} --property xyzzy\u0027)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"caacd0f1_99743fa9","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":23},"in_reply_to":"db4aac9f_730b833f","updated":"2026-02-25 17:32:42.000000000","message":"Done","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":270,"context_line":"            \u0027share snapshot delete\u0027,"},{"line_number":271,"context_line":"            f\u0027{snapshot[\"id\"]} --wait\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertRaises("},{"line_number":274,"context_line":"            exceptions.CommandError,"},{"line_number":275,"context_line":"        self.openstack,"},{"line_number":276,"context_line":"            f\u0027share snapshot unset {snapshot[\"id\"]} --property fakekey\u0027)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_share_snapshot_show_metadata(self):"},{"line_number":279,"context_line":"        share \u003d self.create_share(share_type\u003d\u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1e3294f_072ea4ce","line":276,"range":{"start_line":273,"start_character":0,"end_line":276,"end_character":72},"updated":"2026-01-27 22:21:55.000000000","message":"There are two \"errors\" here:\n\n1) The snapshot doesn\u0027t exist (this failure occurs first)\n2) The property \"fakekey\" doesn\u0027t exist (we\u0027ll never get around to checking this)\n\nI suspect your intention was to test the second failure. If yes, move this above the deletion code.\n\nIf you\u0027re trying to test if you can use a non-existent snapshot in the unset command, you\u0027d do that with a valid metadata item so as to separate the concerns.","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \u0027share snapshot delete\u0027,"},{"line_number":271,"context_line":"            f\u0027{snapshot[\"id\"]} --wait\u0027)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertRaises("},{"line_number":274,"context_line":"            exceptions.CommandError,"},{"line_number":275,"context_line":"        self.openstack,"},{"line_number":276,"context_line":"            f\u0027share snapshot unset {snapshot[\"id\"]} --property fakekey\u0027)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_share_snapshot_show_metadata(self):"},{"line_number":279,"context_line":"        share \u003d self.create_share(share_type\u003d\u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"435afc04_fe4bfc89","line":276,"range":{"start_line":273,"start_character":0,"end_line":276,"end_character":72},"in_reply_to":"f1e3294f_072ea4ce","updated":"2026-02-25 17:32:42.000000000","message":"Done","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        snapshot \u003d self.dict_result("},{"line_number":284,"context_line":"            \u0027share snapshot create\u0027,"},{"line_number":285,"context_line":"            f\u0027--name {snapshot_name} {share[\"id\"]}\u0027"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        self.dict_result("},{"line_number":289,"context_line":"            \u0027share snapshot set\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cee1f5a5_16ddd0ab","line":286,"range":{"start_line":283,"start_character":8,"end_line":286,"end_character":9},"updated":"2026-01-27 22:21:55.000000000","message":"You could use self.create_snapshot with add_cleanup\u003dTrue because the goal of the test is testing the \"share snapshot set\" command\n\n```\nsnapshot \u003d self.create_snapshot(share\u003dshare[\u0027id\u0027], add_cleanup\u003dTrue)\n```","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        snapshot \u003d self.dict_result("},{"line_number":284,"context_line":"            \u0027share snapshot create\u0027,"},{"line_number":285,"context_line":"            f\u0027--name {snapshot_name} {share[\"id\"]}\u0027"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        self.dict_result("},{"line_number":289,"context_line":"            \u0027share snapshot set\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"51926a44_1b271a27","line":286,"range":{"start_line":283,"start_character":8,"end_line":286,"end_character":9},"in_reply_to":"cee1f5a5_16ddd0ab","updated":"2026-02-25 17:32:42.000000000","message":"added to new patch","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f7a7f8f61fca8a66ca44ff78306e10d519f5370b","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        snapshot \u003d self.dict_result("},{"line_number":325,"context_line":"            \u0027share snapshot create\u0027,"},{"line_number":326,"context_line":"            f\u0027--name {snapshot_name} {share[\"id\"]}\u0027"},{"line_number":327,"context_line":"        )"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        self.dict_result("}],"source_content_type":"text/x-python","patch_set":3,"id":"9ca6019b_6a4ff8d2","line":326,"range":{"start_line":324,"start_character":0,"end_line":326,"end_character":51},"updated":"2026-01-27 22:21:55.000000000","message":"same comment as above","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"e61a8b28ffcc8060165b41fd487e2b2faaea197d","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        snapshot \u003d self.dict_result("},{"line_number":325,"context_line":"            \u0027share snapshot create\u0027,"},{"line_number":326,"context_line":"            f\u0027--name {snapshot_name} {share[\"id\"]}\u0027"},{"line_number":327,"context_line":"        )"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        self.dict_result("}],"source_content_type":"text/x-python","patch_set":3,"id":"caf632bc_6cd0e991","line":326,"range":{"start_line":324,"start_character":0,"end_line":326,"end_character":51},"in_reply_to":"9ca6019b_6a4ff8d2","updated":"2026-02-25 17:32:42.000000000","message":"Done","commit_id":"02c0f6328c2de7d94d8c0afb1b77520ebfef9fe4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"26d7aca0beac2291c98fc186e985b18b4eb38b55","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        )"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_share_snapshot_create_with_metadata(self):"},{"line_number":236,"context_line":"        share \u003d self.create_share(share_type\u003d\u0027default\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"472f0be1_926b430c","line":236,"range":{"start_line":236,"start_character":34,"end_line":236,"end_character":54},"updated":"2026-02-25 19:44:02.000000000","message":"please remove the share type kwarg.","commit_id":"36b73b74fa5205f55974a9ddeb735aa7c8bf3a28"},{"author":{"_account_id":37481,"name":"Maria Gallego","display_name":"Maria Isabel","email":"gallegomaria0204@gmail.com","username":"marissa0204"},"change_message_id":"afbdce9ca77d3c567078033bde8bad85925fd6b0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        )"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_share_snapshot_create_with_metadata(self):"},{"line_number":236,"context_line":"        share \u003d self.create_share(share_type\u003d\u0027default\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        snapshot_name \u003d data_utils.rand_name(\"snapshot\")"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bb0e7439_494f0d2e","line":236,"range":{"start_line":236,"start_character":34,"end_line":236,"end_character":54},"in_reply_to":"472f0be1_926b430c","updated":"2026-02-27 01:00:15.000000000","message":"done","commit_id":"36b73b74fa5205f55974a9ddeb735aa7c8bf3a28"}]}