)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b854ecd03bd05cd6e3d5b4ea6d3678e5f00e7035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32e852b5_ce54cee5","updated":"2026-01-20 15:08:05.000000000","message":"Great job on this change! Thanks for proposing it. I only have a minor comment related to one of the changes made. Please take a look at it","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"60d1100485d83cf270be8d8bfa180c6cfb8d1c3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a94d6b4_0ab7fa05","updated":"2026-01-20 15:08:16.000000000","message":"recheck\nfunctional tests logs are gone","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f481031e3147e8542cb3fb569a7fe2a3ffa498e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e3f9265d_23d0f30d","updated":"2026-01-26 18:18:10.000000000","message":"looks like some unit tests need to be fixed up here","commit_id":"a1c6d125ea306ab80f7d2f2ca66c186434b48372"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"f22c8f99fdf3d5f38708068f78256406b7fabd3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3971549a_16050fa6","in_reply_to":"e3f9265d_23d0f30d","updated":"2026-02-03 06:37:10.000000000","message":"@gouthampravi@gmail.com, the 8 failed tests are","commit_id":"a1c6d125ea306ab80f7d2f2ca66c186434b48372"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7f18b825954a446e330c8137a2cf3da36efabb66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63788f61_4e8da178","updated":"2026-02-19 14:38:39.000000000","message":"LGTM, thank you for working on this change!","commit_id":"e4edf76825c351cde2a486dbefed2a00211c5055"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"f22c8f99fdf3d5f38708068f78256406b7fabd3a","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            \u0027name\u0027: name,"},{"line_number":314,"context_line":"            \u0027description\u0027: description,"},{"line_number":315,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":316,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":317,"context_line":"        }"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if is_public is not None:"},{"line_number":320,"context_line":"            body[\u0027is_public\u0027] \u003d is_public"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return self._create(resource_path, {\u0027share\u0027: body}, \u0027share\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"f796d4a9_0ae5c721","line":321,"range":{"start_line":316,"start_character":0,"end_line":321,"end_character":0},"updated":"2026-02-03 06:37:10.000000000","message":"@gouthampravi@gmail.com, to resolve the failed tc in the `test_shell.py`(scheduled to be deprecated), I have to fix this code as:\n```suggestion\n        }\n\n        if is_public is not None:\n            body[\u0027is_public\u0027] \u003d is_public\n\n        if mount_point_name is not None: ### to-be\n            body[\u0027mount_point_name\u0027] \u003d mount_point_name\n```\n\n\nI think \u0027mount_point_name\u0027 is more similar to \u0027share_server_id\u0027 than \u0027is_public\u0027. Because `is_public` is boolean type, so, that key shouldn\u0027t be in the body before the supported version, but `share_server_id` or `mount_point_name` is string type so it is not a problem even if the {\u0027mount_point_name\u0027: None} is in the unsupported version\u0027s body. (In the manila\u0027s controller code, it checks the api-version and remove unsupported keys)\nSo, I think checking whether `mount_point_name` is None is unnecessary. Please share your thoughts! \nIf you think it\u0027s right to change it, I\u0027ll upload the changes right away!","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62b443e35e24ee64e0a5e353f34cfefcd9c57df1","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            \u0027name\u0027: name,"},{"line_number":314,"context_line":"            \u0027description\u0027: description,"},{"line_number":315,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":316,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":317,"context_line":"        }"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if is_public is not None:"},{"line_number":320,"context_line":"            body[\u0027is_public\u0027] \u003d is_public"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return self._create(resource_path, {\u0027share\u0027: body}, \u0027share\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebfa6e1c_0abeb3d6","line":321,"range":{"start_line":316,"start_character":0,"end_line":321,"end_character":0},"in_reply_to":"8074a23a_83d07aca","updated":"2026-02-19 22:11:09.000000000","message":"Done","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"2876ad90bb9b03deb9e0e63fc13c197009b1d629","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            \u0027name\u0027: name,"},{"line_number":314,"context_line":"            \u0027description\u0027: description,"},{"line_number":315,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":316,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":317,"context_line":"        }"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if is_public is not None:"},{"line_number":320,"context_line":"            body[\u0027is_public\u0027] \u003d is_public"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return self._create(resource_path, {\u0027share\u0027: body}, \u0027share\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"eab9c159_7fadbc41","line":321,"range":{"start_line":316,"start_character":0,"end_line":321,"end_character":0},"in_reply_to":"9029f331_509e2400","updated":"2026-02-04 06:02:18.000000000","message":"Oh, I see. I\u0027ll upload the changes. Thank you @gouthampravi@gmail.com!","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"242c83508612d588c38ee892318c20ff579f1faa","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            \u0027name\u0027: name,"},{"line_number":314,"context_line":"            \u0027description\u0027: description,"},{"line_number":315,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":316,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":317,"context_line":"        }"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if is_public is not None:"},{"line_number":320,"context_line":"            body[\u0027is_public\u0027] \u003d is_public"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return self._create(resource_path, {\u0027share\u0027: body}, \u0027share\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"8074a23a_83d07aca","line":321,"range":{"start_line":316,"start_character":0,"end_line":321,"end_character":0},"in_reply_to":"eab9c159_7fadbc41","updated":"2026-02-19 06:24:52.000000000","message":"@gouthampravi@gmail.com: I fixed the failing tests. Please check again!","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b941c49d8c2e92ef71c5d287af67c35d1afb993a","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            \u0027name\u0027: name,"},{"line_number":314,"context_line":"            \u0027description\u0027: description,"},{"line_number":315,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":316,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":317,"context_line":"        }"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if is_public is not None:"},{"line_number":320,"context_line":"            body[\u0027is_public\u0027] \u003d is_public"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return self._create(resource_path, {\u0027share\u0027: body}, \u0027share\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9029f331_509e2400","line":321,"range":{"start_line":316,"start_character":0,"end_line":321,"end_character":0},"in_reply_to":"f796d4a9_0ae5c721","updated":"2026-02-04 05:47:08.000000000","message":"Ah, while the server would ignore/pop off the keys, we should do the right thing here.. \n\nso\n\n```\n       if mount_point_name is not None:\n            body[\u0027mount_point_name\u0027] \u003d mount_point_name\n```\n\nseems like the right logic to me. \n\nI say this also because we\u0027re slowly adding JSON schema validation in the server; and this manage API will be covered soon too: https://review.opendev.org/q/project:openstack/manila+hashtag:json-schema-validation\nInitially the schema will allow \"additional properties\" to preserve the API\u0027s behavior of accepting unnecessary keys and just ignoring them. However, in a future API microversion, we\u0027ll turn that validation to a strict validation where the user will receive an HTTP 400 if unrecognized keys are provided.","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b854ecd03bd05cd6e3d5b4ea6d3678e5f00e7035","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"    \"\u0027driver_handles_share_servers\u0027 extra_spec set to True. Available \""},{"line_number":1717,"context_line":"    \"only for microversion \u003e\u003d 2.49. (Default\u003dNone)\","},{"line_number":1718,"context_line":")"},{"line_number":1719,"context_line":"@cliutils.arg("},{"line_number":1720,"context_line":"    \u0027--mount_point_name\u0027,"},{"line_number":1721,"context_line":"    \u0027--mount-point-name\u0027,"},{"line_number":1722,"context_line":"    metavar\u003d\u0027\u003cmount-point-name\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"10d4e9fd_a7534b4d","line":1719,"updated":"2026-01-20 15:08:05.000000000","message":"the shell client is deprecated and will be removed on this release... that said, I think we can avoid making any changes to this file.","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"8aacd7c1f43da7953745c248ed6dcf2e7e71e4c0","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"    \"\u0027driver_handles_share_servers\u0027 extra_spec set to True. Available \""},{"line_number":1717,"context_line":"    \"only for microversion \u003e\u003d 2.49. (Default\u003dNone)\","},{"line_number":1718,"context_line":")"},{"line_number":1719,"context_line":"@cliutils.arg("},{"line_number":1720,"context_line":"    \u0027--mount_point_name\u0027,"},{"line_number":1721,"context_line":"    \u0027--mount-point-name\u0027,"},{"line_number":1722,"context_line":"    metavar\u003d\u0027\u003cmount-point-name\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba18b183_aedb806d","line":1719,"in_reply_to":"002bac07_bac222cd","updated":"2026-01-21 02:20:23.000000000","message":"Yes, I got it. I\u0027ve removed the changes to shell.py file. Thank you for the review!","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4b682fb7091f880bd047bbd8410e4276df8f68a","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"    \"\u0027driver_handles_share_servers\u0027 extra_spec set to True. Available \""},{"line_number":1717,"context_line":"    \"only for microversion \u003e\u003d 2.49. (Default\u003dNone)\","},{"line_number":1718,"context_line":")"},{"line_number":1719,"context_line":"@cliutils.arg("},{"line_number":1720,"context_line":"    \u0027--mount_point_name\u0027,"},{"line_number":1721,"context_line":"    \u0027--mount-point-name\u0027,"},{"line_number":1722,"context_line":"    metavar\u003d\u0027\u003cmount-point-name\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"002bac07_bac222cd","line":1719,"in_reply_to":"10d4e9fd_a7534b4d","updated":"2026-01-20 19:09:36.000000000","message":"+1 Please drop changes here since we\u0027ll be merging https://review.opendev.org/c/openstack/python-manilaclient/+/973726 soon","commit_id":"33ddff31995686f993e3af651d3bcb0b83468f11"}]}