)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"82ca644be3dd802af2791680ff2bde83b95dbc6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c46d944_e63ecee6","updated":"2026-02-26 21:58:57.000000000","message":"thanks for the reviews, PTAL","commit_id":"1d8d036cbbcdf4c54c1a1626aa728aea0f118f3d"}],"manilaclient/osc/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0fc01398ff3e96e451b3c101a0b01eb11de2f9a6","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            \u0027state\u0027: parsed_args.state,"},{"line_number":157,"context_line":"            \u0027zone\u0027: parsed_args.zone,"},{"line_number":158,"context_line":"        }"},{"line_number":159,"context_line":"        if parsed_args.ensuring:"},{"line_number":160,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.93\"):"},{"line_number":161,"context_line":"                raise exceptions.CommandError("},{"line_number":162,"context_line":"                    \"Filtering services that are ensuring shares is only \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7249e2c9_2231e7d1","line":159,"range":{"start_line":159,"start_character":31,"end_line":159,"end_character":32},"updated":"2026-02-26 20:16:38.000000000","message":"thinking about the comment from @kinpaa@gmail.com.. this should indeed be \n\n`if parsed_args.ensuring is not None`\n\nbecause right now, you couldn\u0027t specify \"False\" and have this make the API call.. \n\nthis works now just because the filter is totally skipped, and we won\u0027t really see services in \"ensuring\" state during a normal CI run.","commit_id":"1d8d036cbbcdf4c54c1a1626aa728aea0f118f3d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9696a5a793cfa1a320b36d9dc5643dd5c54b37a0","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            \u0027state\u0027: parsed_args.state,"},{"line_number":157,"context_line":"            \u0027zone\u0027: parsed_args.zone,"},{"line_number":158,"context_line":"        }"},{"line_number":159,"context_line":"        if parsed_args.ensuring:"},{"line_number":160,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.93\"):"},{"line_number":161,"context_line":"                raise exceptions.CommandError("},{"line_number":162,"context_line":"                    \"Filtering services that are ensuring shares is only \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5547f476_6e8a3f5b","line":159,"range":{"start_line":159,"start_character":31,"end_line":159,"end_character":32},"in_reply_to":"7249e2c9_2231e7d1","updated":"2026-02-26 21:58:43.000000000","message":"Done","commit_id":"1d8d036cbbcdf4c54c1a1626aa728aea0f118f3d"}],"manilaclient/tests/functional/osc/test_share_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0fc01398ff3e96e451b3c101a0b01eb11de2f9a6","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            flags\u003df\u0027--os-share-api-version {ENSURE_SHARES_MICROVERSION} \u0027,"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        services \u003d self.parser.listing(output)"},{"line_number":96,"context_line":"        if services:"},{"line_number":97,"context_line":"            for service in services:"},{"line_number":98,"context_line":"                self.assertEqual(ensuring, service[\u0027Ensuring\u0027])"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7c1401a8_67414bfe","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":20},"updated":"2026-02-26 20:16:38.000000000","message":"nit: the call should always return a list, so the loop alone is sufficient","commit_id":"1d8d036cbbcdf4c54c1a1626aa728aea0f118f3d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9696a5a793cfa1a320b36d9dc5643dd5c54b37a0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            flags\u003df\u0027--os-share-api-version {ENSURE_SHARES_MICROVERSION} \u0027,"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        services \u003d self.parser.listing(output)"},{"line_number":96,"context_line":"        if services:"},{"line_number":97,"context_line":"            for service in services:"},{"line_number":98,"context_line":"                self.assertEqual(ensuring, service[\u0027Ensuring\u0027])"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cb0c43aa_0686cee4","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":20},"in_reply_to":"7c1401a8_67414bfe","updated":"2026-02-26 21:58:43.000000000","message":"Done","commit_id":"1d8d036cbbcdf4c54c1a1626aa728aea0f118f3d"}]}