)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0894a16f63283039965c3856115cb947f648d1ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b90809c3_57956e69","updated":"2026-02-27 10:40:12.000000000","message":"Need to reopen this PR as rename of option suggested during review of previous PR does not work, so we better use unique name for Manila instead of os-endpoint-override.","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00365a50286656be0b77b16dbfa2d386a4b0c46a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"107819f6_1d3476d3","updated":"2026-03-10 20:53:23.000000000","message":"Please test this with the latest auth changes in this client and see comment inline","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5fa4512ddaa42b795219517f71285e3861efdaa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a00ae9f_9ad4dd54","updated":"2026-03-16 13:32:38.000000000","message":"@gouthampravi@gmail.com\nIs current patchset looks fine ?","commit_id":"2d7fa376b63f3f1101527b6721c9dde1a02b0c15"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd102cc8d08f4210db3e36699e2f47a18a3a423e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b21c932_8e29a0e0","updated":"2026-03-18 17:40:46.000000000","message":"Can you please include a release note for this?","commit_id":"d23b8218507861ee16cd4ddf6d665a74ae1a7d61"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bad62ee04cfdb8e233ff25351ac4a71ccef7d40c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c2421a1_ef5d71f7","updated":"2026-03-18 18:45:25.000000000","message":"Code LGTM, thanks. Please add the release note, as per Goutham\u0027s request","commit_id":"d23b8218507861ee16cd4ddf6d665a74ae1a7d61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83e175858b2c6b91592b80ecae0f2ae5009de02b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"644998b1_3145bc7c","updated":"2026-03-18 17:40:33.000000000","message":"Thanks Kiran!","commit_id":"d23b8218507861ee16cd4ddf6d665a74ae1a7d61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ce0fd6a1c5e8ef7ab05f55bad625e4f3ce4d5374","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d140114_e2f12068","updated":"2026-03-19 17:24:50.000000000","message":"Please avoid editing a historic release note - this is technically feasible, but sort of defeats the purpose because it doesn\u0027t show up as a \"new\" thing when you\u0027re browsing release notes. It silently updates the previous note. What\u0027s the point?\n\nUnless you\u0027re fixing a typo or something insignificant, don\u0027t edit a note - add a new one to call out what changed in the behavior.","commit_id":"a9a3f33d180866c077d47c0e6bf91b9e89d4b4f5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c729ae7849980572118961a3abfa46a9d65f3b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8eb91782_1ad8002c","updated":"2026-03-19 18:02:45.000000000","message":"LGTM, thank you","commit_id":"df6f2dd4729f41244a3cdeae33202255038170dd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f92dff21f06d9d9741102f43975260b122fbc554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"490ffc82_82e972a4","updated":"2026-04-16 15:34:03.000000000","message":"LGTM, thanks Kiran","commit_id":"df6f2dd4729f41244a3cdeae33202255038170dd"}],"manilaclient/osc/plugin.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00365a50286656be0b77b16dbfa2d386a4b0c46a","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Returns a shared file system service client.\"\"\""},{"line_number":65,"context_line":"    requested_api_version \u003d instance._api_version[API_NAME]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    service_type, manila_endpoint_url \u003d _get_manila_url_from_service_catalog("},{"line_number":68,"context_line":"        instance"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    instance.setup_auth()"},{"line_number":71,"context_line":"    debugging_enabled \u003d instance._cli_options.debug"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ebbcc4d0_e7750a0c","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":5},"updated":"2026-03-10 20:53:23.000000000","message":"When we initialize the client, we _always_ do this. The bug could be here.\n\nIf we have an override, we don\u0027t need to hit the service catalog. Grab the endpoint override here and send it over along with the service type. If you don\u0027t supply the service type, despite having the endpoint override, it\u0027ll fail to find the manila endpoint and fall back on an incorrect behavior - in your bug report, it looks like it falls back to the nova service endpoint.\n\n\n```suggestion\n\n    endpoint_override \u003d getattr(\n        instance._cli_options, \u0027os_endpoint_override\u0027, None\n    )\n    if endpoint_override:\n        manila_endpoint_url \u003d endpoint_override\n        service_type \u003d constants.SFS_SERVICE_TYPE\n    else:\n        service_type, manila_endpoint_url \u003d (\n            _get_manila_url_from_service_catalog(instance)\n    )\n```","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a216e85fcdabfa8e94519afc97c5db01cf8b0ac1","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Returns a shared file system service client.\"\"\""},{"line_number":65,"context_line":"    requested_api_version \u003d instance._api_version[API_NAME]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    service_type, manila_endpoint_url \u003d _get_manila_url_from_service_catalog("},{"line_number":68,"context_line":"        instance"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    instance.setup_auth()"},{"line_number":71,"context_line":"    debugging_enabled \u003d instance._cli_options.debug"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"397cf55d_68f8bbd0","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":5},"in_reply_to":"10cdb015_9ac7dca9","updated":"2026-03-11 18:55:28.000000000","message":"the solution you have: \"--os-shared-file-system-endpoint-override\" will be implemented by default with the openstacksdk..","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0c0bf10df9e916c289f3fa0a75c11de732d96f54","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Returns a shared file system service client.\"\"\""},{"line_number":65,"context_line":"    requested_api_version \u003d instance._api_version[API_NAME]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    service_type, manila_endpoint_url \u003d _get_manila_url_from_service_catalog("},{"line_number":68,"context_line":"        instance"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    instance.setup_auth()"},{"line_number":71,"context_line":"    debugging_enabled \u003d instance._cli_options.debug"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a2098407_dd017ab6","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":5},"in_reply_to":"397cf55d_68f8bbd0","updated":"2026-03-12 13:28:48.000000000","message":"Acknowledged","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"078fe02f01b4662fc3e495d45df0333f4eb7b0be","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Returns a shared file system service client.\"\"\""},{"line_number":65,"context_line":"    requested_api_version \u003d instance._api_version[API_NAME]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    service_type, manila_endpoint_url \u003d _get_manila_url_from_service_catalog("},{"line_number":68,"context_line":"        instance"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    instance.setup_auth()"},{"line_number":71,"context_line":"    debugging_enabled \u003d instance._cli_options.debug"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"10cdb015_9ac7dca9","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":5},"in_reply_to":"ebbcc4d0_e7750a0c","updated":"2026-03-11 06:00:20.000000000","message":"This works, but the solution I have provided in this pull request also works without this change you suggested.","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"00365a50286656be0b77b16dbfa2d386a4b0c46a","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"4529a2aa_5b179e7a","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"updated":"2026-03-10 20:53:23.000000000","message":"-1\n\nMy original objection to this still holds.. it\u0027s weird if you need to do:\n\n\"openstack --os-shared-file-system-endpoint-override OVERRIDE share list\"\n\n\nwe\u0027re executing a subset of commands that _need_ to map to the manila endpoint, not to any other service.","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0c0bf10df9e916c289f3fa0a75c11de732d96f54","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"b4a8cfa6_935f3321","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"0d1cd170_ac611a6d","updated":"2026-03-12 13:28:48.000000000","message":"Done","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a216e85fcdabfa8e94519afc97c5db01cf8b0ac1","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"0d1cd170_ac611a6d","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"16ac05c4_d016249a","updated":"2026-03-11 18:55:28.000000000","message":"oh, you mean environment variables? that\u0027d be kinda silly... if they do use multiple OpenStack services, they\u0027d ideally not use \"OS_ENDPOINT_OVERRIDE\" as an env variable at all.\n\nMaybe preserve the env variable you\u0027re adding (\"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\") and keep the opt name as \"--os-endpoint-override\" - it\u0027ll satisfy both use cases..","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"078fe02f01b4662fc3e495d45df0333f4eb7b0be","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"16ac05c4_d016249a","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"4529a2aa_5b179e7a","updated":"2026-03-11 06:00:20.000000000","message":"This is why I assume separate endpoint option makes sense. One can have config value OS_ENDPOINT_OVERRIDE use for Nova and OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE use for Manila. I am fine with either approach. Let me know as a reply and I update the PR with above suggestions.","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"887871a7587fc804a6846a70bed04a904b5ec033","unresolved":true,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"e2dbeab5_b193ef49","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"b4a8cfa6_935f3321","updated":"2026-03-17 04:44:41.000000000","message":"you can\u0027t drop the env var ``OS_ENDPOINT_OVERRIDE`` - that\u0027d be a regression. I\u0027d preserve \"OS_ENDPOINT_OVERRIDE\" but add it in the order of preference because the default value is executed in the order we specify it here...  \n\nif someone has `OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE` set, that\u0027d be the default, and OS_ENDPOINT_OVERRIDE is ignored by our client\n\n\n\n```\n        default\u003dutils.env(\n            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\",\n            \"OS_ENDPOINT_OVERRIDE\",\n            \"OS_MANILA_BYPASS_URL\",\n            \"MANILACLIENT_BYPASS_URL\",\n        )\n```","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e5f14a1c60d37a2b8d0bbe8d279aea3dfe52f98f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        \u0027(Env: OS_SHARE_API_VERSION)\u0027,"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    parser.add_argument("},{"line_number":128,"context_line":"        \"--os-shared-file-system-endpoint-override\","},{"line_number":129,"context_line":"        metavar\u003d\"\u003cendpoint-override\u003e\","},{"line_number":130,"context_line":"        default\u003dutils.env("},{"line_number":131,"context_line":"            \"OS_SHARED_FILE_SYSTEM_ENDPOINT_OVERRIDE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"8af0087b_c23af0ac","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"e2dbeab5_b193ef49","updated":"2026-03-17 09:26:15.000000000","message":"Done","commit_id":"20d4b0bcdccec435031c6d33f418f3b10d751b5f"}]}