)]}'
{"id":"openstack%2Fpython-manilaclient~981626","triplet_id":"openstack%2Fpython-manilaclient~master~Ie95ba4e6db92cc233ad2917744bc1b7e3e9b571e","project":"openstack/python-manilaclient","branch":"master","topic":"client_test","attention_set":{"29632":{"account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"last_update":"2026-03-21 00:51:16.000000000","reason":"\u003cGERRIT_ACCOUNT_37843\u003e replied on the change","reason_account":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"}},"16643":{"account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"last_update":"2026-04-03 02:08:55.000000000","reason":"Vote got outdated and was removed: Code-Review-1"},"37843":{"account":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"last_update":"2026-04-02 22:55:28.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":["outreachy-2026-prospect"],"change_id":"Ie95ba4e6db92cc233ad2917744bc1b7e3e9b571e","subject":"Add unit tests for client version handling","status":"NEW","created":"2026-03-21 00:50:17.000000000","updated":"2026-04-03 03:16:09.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"d5d36fafd0edd7f5fb69fac7a598de27fa94d3d6","_number":981626,"virtual_id_number":981626,"owner":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-04-03 03:16:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-21 00:51:16.000000000","updated_by":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"},{"updated":"2026-03-21 00:51:16.000000000","updated_by":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2026-03-21 01:28:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f38433fe9295ac28ae9e8b3c705568a37a1b18ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"date":"2026-03-21 00:50:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a90e5d0e37a7129822b5770f0e456d74faabf508","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-21 01:28:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/93e5299fc9254101970f7d67d9501a71\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5aac5feeed3f4d19b87ae01d453c3f2a : SUCCESS in 7m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9a53a0276e6c4f71b97a08d0bf37d180 : SUCCESS in 3m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1aacc309fc594645bbc6e62c0808fc4d : SUCCESS in 3m 13s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/84df37870b664e9992730e43bd8a2242 : SUCCESS in 3m 17s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0cc65984c115447db226506c372b256a : SUCCESS in 3m 48s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/72da03e18b204d37a31806a09fbf3f31 : SUCCESS in 5m 58s (non-voting)\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/dea43e90129f4f9c8b4b2d5eb8c0656d : SUCCESS in 2m 29s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/8b742fd63f4a4693b7d9e71c4cab24fe : FAILURE in 32m 59s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/65a3fa1823164f358a5d1ff95d16f446 : FAILURE in 31m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b10858322080f86a4f2b142ba33dbf959b4a96f5","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-03-31 20:07:03.000000000","message":"Hashtag added: outreachy-2026-prospect","accounts_in_message":[],"_revision_number":1},{"id":"bfbc57d2b3de184d592a28c05d89bbc07be8bbf9","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-04-02 22:55:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nThank you Olamide for adding tests for the client version handling code. A few things to address:\n\n1. The commit subject \"Improves file robustness\" is too vague — it should describe what the patch actually does (e.g., \"Add unit tests for client version handling\").\n2. Please note that this change overlaps significantly with https://review.opendev.org/c/openstack/python-manilaclient/+/982543 which adds the same test_get_client_class_v1 test. Please coordinate with the other contributor.\n3. Minor commit message issues — see inline comments.\n\nWere any AI tools used when working on this change? If yes, please see https://openinfra.org/legal/ai-policy/","accounts_in_message":[],"_revision_number":1},{"id":"a3627a8c4fd3c78bd488a96856d938f759fa2eb4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"date":"2026-04-03 02:08:55.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"d5d36fafd0edd7f5fb69fac7a598de27fa94d3d6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-03 03:16:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ddd7480c6efa4d62ba3045f6834dc39f\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b78fde461b644fa2b17685c06ed48c49 : SUCCESS in 7m 37s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/735f31d3245c4db9ababdba356963505 : SUCCESS in 4m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/09506c52345c4543903de5278bbca881 : SUCCESS in 3m 53s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b63ee18a0e6f43f38ef579ecca3028db : SUCCESS in 3m 59s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/c80d32b26e79450c97f14be37530747b : SUCCESS in 3m 25s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/42d48324a84c461d8a0bd6732397c7ac : SUCCESS in 6m 41s (non-voting)\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/3b06d7f5820a4faa9909fcb955a10086 : SUCCESS in 3m 36s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/6925cf1d2a48443b96e7cc37bb8854fc : FAILURE in 15m 52s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/8ef99945cad74832a2d329d6eb6a8ecb : FAILURE in 31m 01s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"10d76a965599670576e626ba1ff4484e8ac0e113","revisions":{"bda7a01ffe22773b092723746e437090e0972507":{"kind":"REWORK","_number":1,"created":"2026-03-21 00:50:17.000000000","uploader":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"ref":"refs/changes/26/981626/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/26/981626/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/1"}}},"commit":{"parents":[{"commit":"3996ff3e6aba50d8b7a4c705857f3a0401210660","subject":"Update master for stable/2026.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3996ff3e6aba50d8b7a4c705857f3a0401210660"}]}],"author":{"name":"olamidepeterojo","email":"peterojoolamide@gmail.com","date":"2026-03-20 23:18:45.000000000","tz":0},"committer":{"name":"olamidepeterojo","email":"peterojoolamide@gmail.com","date":"2026-03-21 00:47:12.000000000","tz":0},"subject":"Improves file robustness","message":"Improves file robustness\n\nThis PR:\n- Adds test for v1 client class to verify get_client_class(`1`) resolves correctly to the v1 client.\n\n- Ensures when an APIVersion object is passed, it is used directly and nor re-wrapped\n\n- Verifies api_versions.APIVersion is not called in this case\n\n- Adds a defensive test to confirm that unexpected values returned from get_major_version() raise UnsupportedVersion\n\nCloses-Bug: #2145056\n\nChange-Id: Ie95ba4e6db92cc233ad2917744bc1b7e3e9b571e\nSigned-off-by: olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bda7a01ffe22773b092723746e437090e0972507"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bda7a01ffe22773b092723746e437090e0972507"}]},"branch":"refs/heads/master"},"10d76a965599670576e626ba1ff4484e8ac0e113":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-04-03 02:08:55.000000000","uploader":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"ref":"refs/changes/26/981626/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/26/981626/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/26/981626/2"}}},"commit":{"parents":[{"commit":"3996ff3e6aba50d8b7a4c705857f3a0401210660","subject":"Update master for stable/2026.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3996ff3e6aba50d8b7a4c705857f3a0401210660"}]}],"author":{"name":"olamidepeterojo","email":"peterojoolamide@gmail.com","date":"2026-03-20 23:18:45.000000000","tz":0},"committer":{"name":"Olamide Ojo","email":"peterojoolamide@gmail.com","date":"2026-04-03 02:08:55.000000000","tz":0},"subject":"Add unit tests for client version handling","message":"Add unit tests for client version handling\n\nThis Patch:\n- Adds test for v1 client class to verify get_client_class(`1`) resolves correctly to the v1 client.\n\n- Ensures when an APIVersion object is passed, it is used directly and not re-wrapped\n\n- Verifies api_versions.APIVersion is not called in this case\n\n- Adds a defensive test to confirm that unexpected values returned from get_major_version() raise UnsupportedVersion\n\nCloses-Bug: #2145056\n\nChange-Id: Ie95ba4e6db92cc233ad2917744bc1b7e3e9b571e\nSigned-off-by: olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/10d76a965599670576e626ba1ff4484e8ac0e113"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/10d76a965599670576e626ba1ff4484e8ac0e113"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}