)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"80f8aae99b35febe4360660dc2d73d97a659a2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1269ffd3_f1ae6bb4","updated":"2026-03-30 10:57:39.000000000","message":"Hi Goutham and Carlos,  \n\nJust following up on this PR. I’d really appreciate any feedback when you have a moment.","commit_id":"16285e25ad011a3646030f74b2d9db5bda0a5316"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"38774c6e1ec75d511cc1e774f2eeda36e77ee7d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b198171f_b52e4ba5","updated":"2026-04-08 10:09:46.000000000","message":"Hi, I’ve addressed all the review comments in the latest patchset.\n\nWould appreciate another look when you have time. Thank you!","commit_id":"96eb0dad5d5f3ce734472222fac59a88855dda94"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"ece7b81612f193ad92de4655fbaa66431dc384ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"435218dc_bf3b4e5b","updated":"2026-04-05 05:07:34.000000000","message":"Thanks for the detailed review! I\u0027ve addressed all the inline comments, added unit tests for --spec and the deprecation warning for --group-specs and added a release note under the deprecations section.","commit_id":"96eb0dad5d5f3ce734472222fac59a88855dda94"}],"manilaclient/osc/v2/share_group_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c82d023c4e1ebfd53a0aba468c2c6610e9d4014c","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":292,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":293,"context_line":"        )"},{"line_number":294,"context_line":"        parser.add_argument("},{"line_number":295,"context_line":"            \"--group-specs\","},{"line_number":296,"context_line":"            type\u003dstr,"},{"line_number":297,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":298,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":299,"context_line":"            default\u003dNone,"},{"line_number":300,"context_line":"            help\u003d_("},{"line_number":301,"context_line":"                \"Extra specs key and value of share group type that will be\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ce046cf0_0e6295d9","line":298,"range":{"start_line":294,"start_character":0,"end_line":298,"end_character":34},"updated":"2026-04-02 07:07:54.000000000","message":"I think honestly, a better approach is to fix this. This should really be a repeatable option \"--spec\". \n\nWe can take the approach of deprecating \"--group-specs\" and introducing a repeatable \"--spec\" option. I really hate this nargs\u003d\u0027*\u0027 approach and the OSC guidelines are against it too.","commit_id":"16285e25ad011a3646030f74b2d9db5bda0a5316"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2a56944278b6e448c852f8bd2950c68d7dcbdfa8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":292,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":293,"context_line":"        )"},{"line_number":294,"context_line":"        parser.add_argument("},{"line_number":295,"context_line":"            \"--group-specs\","},{"line_number":296,"context_line":"            type\u003dstr,"},{"line_number":297,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":298,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":299,"context_line":"            default\u003dNone,"},{"line_number":300,"context_line":"            help\u003d_("},{"line_number":301,"context_line":"                \"Extra specs key and value of share group type that will be\""}],"source_content_type":"text/x-python","patch_set":1,"id":"68da38cf_e288f32b","line":298,"range":{"start_line":294,"start_character":0,"end_line":298,"end_character":34},"in_reply_to":"3af9fb05_b15997fe","updated":"2026-04-02 18:29:59.000000000","message":"Done","commit_id":"16285e25ad011a3646030f74b2d9db5bda0a5316"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"cd7dd56aa6c7d08f5b9d43f94f4a700349b00a9e","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":292,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":293,"context_line":"        )"},{"line_number":294,"context_line":"        parser.add_argument("},{"line_number":295,"context_line":"            \"--group-specs\","},{"line_number":296,"context_line":"            type\u003dstr,"},{"line_number":297,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":298,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":299,"context_line":"            default\u003dNone,"},{"line_number":300,"context_line":"            help\u003d_("},{"line_number":301,"context_line":"                \"Extra specs key and value of share group type that will be\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3af9fb05_b15997fe","line":298,"range":{"start_line":294,"start_character":0,"end_line":298,"end_character":34},"in_reply_to":"ce046cf0_0e6295d9","updated":"2026-04-02 10:13:05.000000000","message":"Thank you for the feedback. I have replaced  --group-specs(nargs\u003d\u0027*\u0027) with a repeatable --spec option (action\u003d\u0027append\u0027) in line with OSC guidelines. Kept --group-specs as a deprecated hidden option for backwards compatibility.","commit_id":"16285e25ad011a3646030f74b2d9db5bda0a5316"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8d01501374979d18e2ef75d9cd0d33f73a3dfcae","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \"--spec\","},{"line_number":295,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":296,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":297,"context_line":"            dest\u003d\u0027specs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f33da57_9ca12e99","line":294,"updated":"2026-04-02 23:08:51.000000000","message":"maybe add `--group-spec` as an alias here apart from `--spec`.","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"68394b98400f3eaab06ccf2b1d6196098844fa41","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \"--spec\","},{"line_number":295,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":296,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":297,"context_line":"            dest\u003d\u0027specs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"480d60f4_ed12450b","line":294,"in_reply_to":"4ef8e4e2_3302a53b","updated":"2026-04-05 04:58:38.000000000","message":"Done","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"40f78028dfa752a21583ca5f8436136acd4c8f24","unresolved":true,"context_lines":[{"line_number":291,"context_line":"            help\u003d_(\"Name or ID of the share group type to modify\"),"},{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \"--spec\","},{"line_number":295,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":296,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":297,"context_line":"            dest\u003d\u0027specs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ef8e4e2_3302a53b","line":294,"in_reply_to":"9f33da57_9ca12e99","updated":"2026-04-05 04:58:11.000000000","message":"Done — added --group-spec as a second alias alongside --spec","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8d01501374979d18e2ef75d9cd0d33f73a3dfcae","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            help\u003d_("},{"line_number":300,"context_line":"                \"Extra specs key and value of share group type that will be\""},{"line_number":301,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":302,"context_line":"                \" Example: --group-specs consistent-snapshot-support\u003dTrue\""},{"line_number":303,"context_line":"                \"--spec another_key\u003dvalue\""},{"line_number":304,"context_line":"            ),"},{"line_number":305,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"be31a0f0_c67234e6","line":302,"updated":"2026-04-02 23:08:51.000000000","message":"Two issues in the help text:\n1. Missing space: the concatenation produces `\"...True--spec`.\n2. The example still references `--group-specs` but should use the\n   new option name consistently:\n   `\" Example: --spec consistent-snapshot-support\u003dTrue\"\n   \" --spec another_key\u003dvalue\"`","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"68394b98400f3eaab06ccf2b1d6196098844fa41","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            help\u003d_("},{"line_number":300,"context_line":"                \"Extra specs key and value of share group type that will be\""},{"line_number":301,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":302,"context_line":"                \" Example: --group-specs consistent-snapshot-support\u003dTrue\""},{"line_number":303,"context_line":"                \"--spec another_key\u003dvalue\""},{"line_number":304,"context_line":"            ),"},{"line_number":305,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a8e669c_abb2711c","line":302,"in_reply_to":"31029543_4f4478d8","updated":"2026-04-05 04:58:38.000000000","message":"Done","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"40f78028dfa752a21583ca5f8436136acd4c8f24","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            help\u003d_("},{"line_number":300,"context_line":"                \"Extra specs key and value of share group type that will be\""},{"line_number":301,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":302,"context_line":"                \" Example: --group-specs consistent-snapshot-support\u003dTrue\""},{"line_number":303,"context_line":"                \"--spec another_key\u003dvalue\""},{"line_number":304,"context_line":"            ),"},{"line_number":305,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"31029543_4f4478d8","line":302,"in_reply_to":"be31a0f0_c67234e6","updated":"2026-04-05 04:58:11.000000000","message":"Fixed both. I added the missing space before --spec on the last line and updated the example to use --spec consistently instead of --group-specs.","commit_id":"d768088bc4e00bbe2f3e99b519e08267fc83554b"}]}