)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"8c5c49a2926f1728338f7a140402e89f2f0e2931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"64421d65_351074c7","updated":"2026-04-06 10:26:38.000000000","message":"I also added unit tests for the new --extra-spec option and the deprecation warning for --extra-specs and updated the release note to include both a deprecations and a fixes section, following the same pattern as the share group type patch. Does that look right to you?","commit_id":"cdf7e5a8a34befb4717450219293d6f882b40887"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"4a599f0cb7d729cbb3c03450e1f7cfa27f20060c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f60d1b57_1cd77401","updated":"2026-04-06 10:18:19.000000000","message":"Thanks for the review! I\u0027ve addressed both inline comments.","commit_id":"cdf7e5a8a34befb4717450219293d6f882b40887"}],"manilaclient/osc/v2/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9caaa323110785a9c612fda074dada8a852ea63c","unresolved":true,"context_lines":[{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"49634dbd_3aebccc6","line":292,"range":{"start_line":292,"start_character":71,"end_line":292,"end_character":72},"updated":"2026-04-02 23:00:37.000000000","message":"missing a space before this quote","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2d6e1e93f561762aba85096addd2e97fe53e95c7","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1081a3bf_2f8ed0c7","line":292,"range":{"start_line":292,"start_character":71,"end_line":292,"end_character":72},"in_reply_to":"338ef2d9_5b26712c","updated":"2026-04-06 10:14:45.000000000","message":"Done","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"c813cd4bcd9565e8361750744ca4fe21d06d8f09","unresolved":true,"context_lines":[{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"338ef2d9_5b26712c","line":292,"range":{"start_line":292,"start_character":71,"end_line":292,"end_character":72},"in_reply_to":"49634dbd_3aebccc6","updated":"2026-04-06 10:14:26.000000000","message":"Done.I have fixed the missing space and updated the help text to use the new --extra-spec option consistently.","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0fd9a87088667de6153b55ad58d06fc20a773f01","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            metavar\u003d\"\u003cshare_type\u003e\","},{"line_number":282,"context_line":"            help\u003d_(\"Name or ID of the share type to modify\"),"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        parser.add_argument("},{"line_number":285,"context_line":"            \"--extra-specs\","},{"line_number":286,"context_line":"            type\u003dstr,"},{"line_number":287,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":288,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"},{"line_number":296,"context_line":"        )"},{"line_number":297,"context_line":"        parser.add_argument("},{"line_number":298,"context_line":"            \u0027--public\u0027,"},{"line_number":299,"context_line":"            metavar\u003d\"\u003cpublic\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"bbb967be_6eb61520","line":296,"range":{"start_line":284,"start_character":7,"end_line":296,"end_character":9},"updated":"2026-04-02 23:00:01.000000000","message":"You can\u0027t change the behavior of an existing attr like this - it could break some tools that depend on this. I\u0027d suggest the same approach that you took with the share group type specs would work here: https://review.opendev.org/c/openstack/python-manilaclient/+/981672","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2d6e1e93f561762aba85096addd2e97fe53e95c7","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            metavar\u003d\"\u003cshare_type\u003e\","},{"line_number":282,"context_line":"            help\u003d_(\"Name or ID of the share type to modify\"),"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        parser.add_argument("},{"line_number":285,"context_line":"            \"--extra-specs\","},{"line_number":286,"context_line":"            type\u003dstr,"},{"line_number":287,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":288,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"},{"line_number":296,"context_line":"        )"},{"line_number":297,"context_line":"        parser.add_argument("},{"line_number":298,"context_line":"            \u0027--public\u0027,"},{"line_number":299,"context_line":"            metavar\u003d\"\u003cpublic\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"d4f844e2_3f381d7a","line":296,"range":{"start_line":284,"start_character":7,"end_line":296,"end_character":9},"in_reply_to":"8d80690a_0c8d2c39","updated":"2026-04-06 10:14:45.000000000","message":"Done","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"c813cd4bcd9565e8361750744ca4fe21d06d8f09","unresolved":true,"context_lines":[{"line_number":281,"context_line":"            metavar\u003d\"\u003cshare_type\u003e\","},{"line_number":282,"context_line":"            help\u003d_(\"Name or ID of the share type to modify\"),"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        parser.add_argument("},{"line_number":285,"context_line":"            \"--extra-specs\","},{"line_number":286,"context_line":"            type\u003dstr,"},{"line_number":287,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":288,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":289,"context_line":"            default\u003dNone,"},{"line_number":290,"context_line":"            help\u003d_("},{"line_number":291,"context_line":"                \"Extra specs key and value of share type that will be\""},{"line_number":292,"context_line":"                \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":293,"context_line":"                \u0027Repeat for multiple extra specs \u0027"},{"line_number":294,"context_line":"                \u0027e.g. --extra-specs key1\u003dval1 --extra-specs key2\u003dval2\u0027"},{"line_number":295,"context_line":"            ),"},{"line_number":296,"context_line":"        )"},{"line_number":297,"context_line":"        parser.add_argument("},{"line_number":298,"context_line":"            \u0027--public\u0027,"},{"line_number":299,"context_line":"            metavar\u003d\"\u003cpublic\u003e\","}],"source_content_type":"text/x-python","patch_set":2,"id":"8d80690a_0c8d2c39","line":296,"range":{"start_line":284,"start_character":7,"end_line":296,"end_character":9},"in_reply_to":"bbb967be_6eb61520","updated":"2026-04-06 10:14:26.000000000","message":"Done. I have followed the same pattern as the share group type patch. Added a new --extra-spec option with action\u003d\u0027append\u0027 and kept --extra-specs with nargs\u003d\u0027+\u0027 but deprecated it with a warning in take_action","commit_id":"81155fbe880b07c08067cc18850ea0dc8448078b"}]}