)]}'
{"id":"openstack%2Fpython-manilaclient~982663","triplet_id":"openstack%2Fpython-manilaclient~master~Icb6373cc287e26e478272e439572cb5cd98dbac1","project":"openstack/python-manilaclient","branch":"master","attention_set":{"38986":{"account":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"last_update":"2026-03-30 15:02:11.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Icb6373cc287e26e478272e439572cb5cd98dbac1","subject":"OSC: Add missing tests for share groups and fix snapshot filter","status":"NEW","created":"2026-03-30 14:18:45.000000000","updated":"2026-03-31 07:17:01.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bb757de5a3918d0fff826c0956bea74847bcccbf","_number":982663,"virtual_id_number":982663,"owner":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-31 07:17:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-30 15:02:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aa36e29718ce0cfec4fa1eb1e6ccb7f3b7103c23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"date":"2026-03-30 14:18:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a87de4a8643425a05a6357f59bf4d742ceeac6d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 15:02:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/f8096ff1405d4448b5e97fc5ad19248e\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7a3f57e692814aeba25c342d411811fb : SUCCESS in 7m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3ce0f2e2d68b4c838b6d685f5a3a2362 : SUCCESS in 3m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b426c57e7dc249b89edf645eadfad98b : FAILURE in 3m 24s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/eada71b4b62a4f638aa99b15a7b769c7 : SUCCESS in 3m 12s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/2fa172de40e046649699552fe8eac5ff : SUCCESS in 3m 21s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2b3a8830897f47b59fb7790c577d5642 : SUCCESS in 6m 10s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/dec9837511724d33b7e0165fb26a1b9d : SUCCESS in 5m 15s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/f31a7f12b6084595a6ab82e35453e656 : SUCCESS in 37m 40s\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/ae5f68acd7324aac9ffca4bde1fb6cc7 : SUCCESS in 2m 53s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/fa3c9415fca84643b0b1982c7352786d : FAILURE in 32m 21s (non-voting)\n- python-manilaclient-functional-fips https://zuul.opendev.org/t/openstack/build/a7b1f6273be546809d4c9c3778cbeb38 : POST_FAILURE in 19m 05s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/de974e4e5c314fa79b97b02ad60bc772 : FAILURE in 28m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"afc3b1ffba617888b51001d9353d45f4dafbb5ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"date":"2026-03-31 06:39:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"bb757de5a3918d0fff826c0956bea74847bcccbf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-31 07:17:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3b530456459b488799d315afdd77a117\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d6e00ff7214d4e0bb6771e0423471845 : SUCCESS in 3m 51s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/85bf23c6cdb747e48fe580a530d90fc6 : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dc7dab2480494f4bb826051db51de561 : SUCCESS in 2m 27s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b6cf3d68fbc34e58903cab9d2dc4f07d : SUCCESS in 4m 04s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/5925e946bf884119b087c0498cd7f841 : SUCCESS in 3m 57s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/4cb0722e5e3e4776894a7a75126b08fb : SUCCESS in 4m 40s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/955e6d44c6424271be21407bb2b94e31 : SUCCESS in 4m 51s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/bd914e50990f4feaacb4e1da3925e654 : SUCCESS in 31m 57s\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/a5cf323181bf48f08b98407c96db2c2d : SUCCESS in 1m 50s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/f00066fa81e7436786179fc853ba33ab : FAILURE in 15m 56s (non-voting)\n- python-manilaclient-functional-fips https://zuul.opendev.org/t/openstack/build/3eec5650f5eb49cb99fcfab484a63e4e : POST_FAILURE in 8m 32s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/8066ffa9346e4aca9d6f7125cc73a7ba : FAILURE in 12m 49s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8354f876ee345c111bc856304719b9a905b30ce5","revisions":{"b073aaf1a2bc8b3e06ba9c26f2751c9153ca999e":{"kind":"REWORK","_number":1,"created":"2026-03-30 14:18:45.000000000","uploader":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"ref":"refs/changes/63/982663/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/63/982663/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/1"}}},"commit":{"parents":[{"commit":"6c2b5c808530bf2c8eb467adfd272ba010224f10","subject":"Fix typo \u0027occured\u0027 should be \u0027occurred\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6c2b5c808530bf2c8eb467adfd272ba010224f10"}]}],"author":{"name":"Elizabeth Njoroge","email":"njorogewambuielizabeth@gmail.com","date":"2026-03-30 14:16:12.000000000","tz":180},"committer":{"name":"Elizabeth Njoroge","email":"njorogewambuielizabeth@gmail.com","date":"2026-03-30 14:18:36.000000000","tz":180},"subject":"OSC: Add missing tests for share groups and fix snapshot filter","message":"OSC: Add missing tests for share groups and fix snapshot filter\n\nThis patch adds missing unit tests for \u0027share group create\u0027 and\n\u0027share group list\u0027 command options that were marked as TODOs.\n\nDuring the implementation of these tests, a bug was discovered in\n\u0027share group list\u0027 where it incorrectly used \u0027share_snapshots\u0027 instead\nof \u0027share_group_snapshots\u0027 for the \u0027--snapshot\u0027 filter. This patch\nfixes that as well.\n\nMissing tests added for:\n- openstack share group create:\n  --share-group-type, --share-network, --source-share-group-snapshot\n- openstack share group list:\n  --share-server, --share-group-type, --snapshot, --share-network\n\nChange-Id: Icb6373cc287e26e478272e439572cb5cd98dbac1\nSigned-off-by: Elizabeth Njoroge \u003cnjorogewambuielizabeth@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b073aaf1a2bc8b3e06ba9c26f2751c9153ca999e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b073aaf1a2bc8b3e06ba9c26f2751c9153ca999e"}]},"branch":"refs/heads/master"},"8354f876ee345c111bc856304719b9a905b30ce5":{"kind":"REWORK","_number":2,"created":"2026-03-31 06:39:54.000000000","uploader":{"_account_id":38986,"name":"Lizzy Njoroge","display_name":"Lizzy","email":"njorogewambuielizabeth@gmail.com","username":"Lizzy_Njoroge"},"ref":"refs/changes/63/982663/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/63/982663/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/63/982663/2"}}},"commit":{"parents":[{"commit":"6c2b5c808530bf2c8eb467adfd272ba010224f10","subject":"Fix typo \u0027occured\u0027 should be \u0027occurred\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6c2b5c808530bf2c8eb467adfd272ba010224f10"}]}],"author":{"name":"Elizabeth Njoroge","email":"njorogewambuielizabeth@gmail.com","date":"2026-03-30 14:16:12.000000000","tz":180},"committer":{"name":"Elizabeth Njoroge","email":"njorogewambuielizabeth@gmail.com","date":"2026-03-31 06:39:46.000000000","tz":180},"subject":"OSC: Add missing tests for share groups and fix snapshot filter","message":"OSC: Add missing tests for share groups and fix snapshot filter\n\nThis patch adds missing unit tests for \u0027share group create\u0027 and\n\u0027share group list\u0027 command options that were marked as TODOs.\n\nDuring the implementation of these tests, a bug was discovered in\n\u0027share group list\u0027 where it incorrectly used \u0027share_snapshots\u0027 instead\nof \u0027share_group_snapshots\u0027 for the \u0027--snapshot\u0027 filter. This patch\nfixes that as well.\n\nMissing tests added for:\n- openstack share group create:\n  --share-group-type, --share-network, --source-share-group-snapshot\n- openstack share group list:\n  --share-server, --share-group-type, --snapshot, --share-network\n\nChange-Id: Icb6373cc287e26e478272e439572cb5cd98dbac1\nSigned-off-by: Elizabeth Njoroge \u003cnjorogewambuielizabeth@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8354f876ee345c111bc856304719b9a905b30ce5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8354f876ee345c111bc856304719b9a905b30ce5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}