)]}'
{"id":"openstack%2Fpython-manilaclient~983426","triplet_id":"openstack%2Fpython-manilaclient~master~I16f56a3b09cebb5070f72f1bd1dedeba88852ca1","project":"openstack/python-manilaclient","branch":"master","topic":"unit-tests-v2-share-access-rules","attention_set":{"29632":{"account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"last_update":"2026-04-06 12:49:43.000000000","reason":"\u003cGERRIT_ACCOUNT_38471\u003e replied on the change","reason_account":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"}},"16643":{"account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"last_update":"2026-04-06 12:49:43.000000000","reason":"\u003cGERRIT_ACCOUNT_38471\u003e replied on the change","reason_account":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"}},"38471":{"account":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"last_update":"2026-04-06 13:05:00.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":["outreachy-2026-prospect"],"change_id":"I16f56a3b09cebb5070f72f1bd1dedeba88852ca1","subject":"add missing unit tests for v2/share_access_rules","status":"NEW","created":"2026-04-06 12:45:47.000000000","updated":"2026-04-23 09:53:30.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"579d95feee152839b080f7fd3c198ce5c1f646b4","_number":983426,"virtual_id_number":983426,"owner":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-04-06 13:47:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"}],"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-06 12:49:43.000000000","updated_by":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"},{"updated":"2026-04-06 12:49:43.000000000","updated_by":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2026-04-06 13:05:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-23 09:53:30.000000000","updated_by":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"reviewer":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"state":"CC"}],"messages":[{"id":"f0578cbf2a3ab5b60c9faf7b6b272a3c5c75b717","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"date":"2026-04-06 12:45:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f096a60e72a0b0732aee9d01598716791e45ab97","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-06 13:05:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/80f0c7deee5c47f38ded940606fe161a\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c1954b4c98c84f9d86abd8b99317fa77 : SUCCESS in 3m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b668e611aa354b7cb8f0d6a42e8eab90 : SUCCESS in 4m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4ebf93d37e7c4d19b2712fee9ac2e598 : FAILURE in 2m 52s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/25e55632fffb4ab795534e775ad1b366 : SUCCESS in 2m 34s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/61c9eb64f2ca407fb3092f5c45e18920 : SUCCESS in 3m 39s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2bbf3612b71d4b0cac7f1c8a8c6a8d90 : SUCCESS in 5m 38s (non-voting)\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/0509656fdd1a431496530fc0ca291828 : SUCCESS in 3m 01s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/f7f3b1cde711437fa9ba8be943530e41 : FAILURE in 18m 23s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/0882db123db24ac4978da4460f4994cf : FAILURE in 15m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9439f58f0f17a8420a89d41b83727413b2aa6604","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"date":"2026-04-06 13:14:16.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"c16a90bd656d6716a10b4f9a5cec7830cd0c7575","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-06 13:47:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3f10b01467c54495bf67fdb9c282b128\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e5ec8a04bbf4201a9c910bef14c1ae0 : SUCCESS in 7m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9b1f69cbf60d416db3fd449b25a7c054 : SUCCESS in 3m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e96449ee26c449d0b18dc8181e9db040 : SUCCESS in 3m 13s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3f462645aa2b4ca7a6c1d9905deb990e : SUCCESS in 6m 34s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/755be2a26146452397b3807db6eacf8e : SUCCESS in 3m 07s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/65a71581ab7e489cb816f8a3ca7c051d : SUCCESS in 5m 00s (non-voting)\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/4ce4126f268c4e90ac76e1b0c4934599 : SUCCESS in 3m 14s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/7966235985f34076950c583ea586c7dc : FAILURE in 28m 50s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/a9684109e094467181eb1788af08ecde : FAILURE in 21m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ef9521f13812956ca03726e567dfcb1e4656daf9","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-04-06 20:35:11.000000000","message":"Hashtag added: outreachy-2026-prospect","accounts_in_message":[],"_revision_number":2},{"id":"579d95feee152839b080f7fd3c198ce5c1f646b4","author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"date":"2026-04-23 09:53:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b5972871783c3d7f61e000e61f480eb7d5a90537","revisions":{"9cb37e2bdbb58176bd9ce6cf61d39daacde2f708":{"kind":"REWORK","_number":1,"created":"2026-04-06 12:45:47.000000000","uploader":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"ref":"refs/changes/26/983426/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/26/983426/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/1"}}},"commit":{"parents":[{"commit":"6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e","subject":"Merge \"update stale OpenStack references in README.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e"}]}],"author":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-06 12:35:12.000000000","tz":180},"committer":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-06 12:35:12.000000000","tz":180},"subject":"add missing unit tests for v2/share_access_rules","message":"add missing unit tests for v2/share_access_rules\n\nThe share access rules API client module\nmanilaclient/v2/share_access_rules.py had no unit tests in\nmanilaclient/tests/unit/v2/ resulting in only 49% test coverage.\n\nThis patch adds unit tests for the following methods:\n- get: verifies GET /share-access-rules/{id}\n- access_list: verifies GET /share-access-rules\n- set_metadata: verifies PUT /share-access-rules/{id}/metadata\n- unset_metadata: verifies DELETE /share-access-rules/{id}/metadata/{key}\n- set_access_level: verifies PUT /share-access-rules/{id}\n\nCoverage increased from 49% to 96%.\n\nCloses-bug: #2147333\nChange-Id: I16f56a3b09cebb5070f72f1bd1dedeba88852ca1\nSigned-off-by: Denver Baraka \u003cdenverbaraka@gmail.com\u003e\nAssisted-by: Claude\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9cb37e2bdbb58176bd9ce6cf61d39daacde2f708"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9cb37e2bdbb58176bd9ce6cf61d39daacde2f708"}]},"branch":"refs/heads/master"},"b5972871783c3d7f61e000e61f480eb7d5a90537":{"kind":"REWORK","_number":2,"created":"2026-04-06 13:14:16.000000000","uploader":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"ref":"refs/changes/26/983426/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/26/983426/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/26/983426/2"}}},"commit":{"parents":[{"commit":"6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e","subject":"Merge \"update stale OpenStack references in README.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e"}]}],"author":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-06 12:35:12.000000000","tz":180},"committer":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-06 13:13:27.000000000","tz":180},"subject":"add missing unit tests for v2/share_access_rules","message":"add missing unit tests for v2/share_access_rules\n\nThe share access rules API client module\nmanilaclient/v2/share_access_rules.py had no unit tests in\nmanilaclient/tests/unit/v2/ resulting in only 49% test coverage.\n\nThis patch adds unit tests for the following methods:\n- get: verifies GET /share-access-rules/{id}\n- access_list: verifies GET /share-access-rules\n- set_metadata: verifies PUT /share-access-rules/{id}/metadata\n- unset_metadata: verifies DELETE /share-access-rules/{id}/metadata/{key}\n- set_access_level: verifies PUT /share-access-rules/{id}\n\nCoverage increased from 49% to 96%.\n\nCloses-bug: #2147333\nChange-Id: I16f56a3b09cebb5070f72f1bd1dedeba88852ca1\nSigned-off-by: Denver Baraka \u003cdenverbaraka@gmail.com\u003e\nAssisted-by: Claude\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5972871783c3d7f61e000e61f480eb7d5a90537"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5972871783c3d7f61e000e61f480eb7d5a90537"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
