)]}'
{"id":"openstack%2Fpython-manilaclient~983689","triplet_id":"openstack%2Fpython-manilaclient~master~I76dc1461151d2e253b62e029751d3dd2f5ca65db","project":"openstack/python-manilaclient","branch":"master","topic":"add-test-qos-types","attention_set":{"29632":{"account":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"last_update":"2026-04-10 21:24:42.000000000","reason":"\u003cGERRIT_ACCOUNT_38471\u003e replied on the change","reason_account":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"}},"16643":{"account":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"last_update":"2026-04-10 21:24:42.000000000","reason":"\u003cGERRIT_ACCOUNT_38471\u003e replied on the change","reason_account":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I76dc1461151d2e253b62e029751d3dd2f5ca65db","subject":"Improve test coverage for v2/qos_types","status":"NEW","created":"2026-04-08 09:55:09.000000000","updated":"2026-04-10 21:24:42.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"41a559d06c123c22ed4b355b87f18f6692fb38fe","_number":983689,"virtual_id_number":983689,"owner":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-04-08 10:15:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-08 10:15:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-10 21:24:42.000000000","updated_by":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"},{"updated":"2026-04-10 21:24:42.000000000","updated_by":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"}],"messages":[{"id":"204d01b69ef9d4c77aad82d8f3c608d5eacd2e09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"date":"2026-04-08 09:55:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66aab0cc08bd8700e4219440eb90e3ac8a1dd001","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-08 10:15:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a7566108b83e4f93919c78fbab95f482\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8099c26cb5db4f97855e62f86d9363f7 : SUCCESS in 5m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bc1ce9038b2a4c01a171ef2296c84b73 : SUCCESS in 2m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/27078e3bea3b4dd68189e277b304994e : SUCCESS in 3m 30s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5463392ee2a24a9ca2b29f0056d0d8ee : SUCCESS in 2m 01s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/f9cceb917dd841bc830cbb246b3f8778 : SUCCESS in 2m 51s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/cde7a4bbd24b402aa5a5bc05e9ae61c2 : SUCCESS in 4m 39s (non-voting)\n- python-manilaclient-tox-bandit https://zuul.opendev.org/t/openstack/build/409e600244504ba88dd8ee9dc288d1f5 : SUCCESS in 1m 52s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/f3819fcddca3406186298528a3054a12 : FAILURE in 19m 18s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/af322983e9584e2f821f27b470406fb2 : FAILURE in 13m 10s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"87ae4e29ef1359a08c2ac5ceef2288900c44f1d5","revisions":{"87ae4e29ef1359a08c2ac5ceef2288900c44f1d5":{"kind":"REWORK","_number":1,"created":"2026-04-08 09:55:09.000000000","uploader":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"ref":"refs/changes/89/983689/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/89/983689/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/89/983689/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/89/983689/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/89/983689/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/89/983689/1"}}},"commit":{"parents":[{"commit":"6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e","subject":"Merge \"update stale OpenStack references in README.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6fb890908a4bf0e5b7fdc15b4fbeb0d0dbf4767e"}]}],"author":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-08 09:53:21.000000000","tz":180},"committer":{"name":"Denver Baraka","email":"denverbaraka@gmail.com","date":"2026-04-08 09:53:21.000000000","tz":180},"subject":"Improve test coverage for v2/qos_types","message":"Improve test coverage for v2/qos_types\n\nThe qos types API client module manilaclient/v2/qos_types.py\nhad only 75% code coverage.\n\nThe existing tests did not cover the following cases:\n- get: not tested at all\n- list with sort_key parameter\n- list with sort_dir parameter\n- list with invalid sort_key (ValueError)\n- list with invalid sort_dir (ValueError)\n- create with description parameter\n- update with no kwargs (early return)\n\nPartial-Bug: #1364800\nChange-Id: I76dc1461151d2e253b62e029751d3dd2f5ca65db\nSigned-off-by: Denver Baraka \u003cdenverbaraka@gmail.com\u003e\nAssisted-by: Claude\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/87ae4e29ef1359a08c2ac5ceef2288900c44f1d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/87ae4e29ef1359a08c2ac5ceef2288900c44f1d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}