)]}'
{"mistralclient/api/base.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"efb9872bea859a63dc16fae18f78aa9236f044a4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # As long as the \u0027next\u0027 link is not empty, keep requesting it"},{"line_number":123,"context_line":"            # till there is no more items."},{"line_number":124,"context_line":"            url \u003d next_url.split(\u0027/\u0027)[-1]"},{"line_number":125,"context_line":"            items \u003d self._list(\u0027/%s\u0027 % url, response_key, items)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return items"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_711bc1ca","line":125,"updated":"2015-09-17 13:13:18.000000000","message":"I don\u0027t understand these changes. It seems there is a wrong logic there. Why we need to request next batch of elements again and again (if we requested only one page (say, 10 elements from max 50) ?\n\nOne more thing, I don\u0027t like this recursive calls.\n\nI suppose this method doesn\u0027t need to be edited at all. It works as designed: gets response by given url and returns corresponding resources. But this method need to return link on the next batch of resources and it is needed to be passed somewhere.","commit_id":"bdec6df38373f650655ee6766a912e86f244b04c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"912f4fd0cac3ad1409e833c38439b8ca962bc9cb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # As long as the \u0027next\u0027 link is not empty, keep requesting it"},{"line_number":123,"context_line":"            # till there is no more items."},{"line_number":124,"context_line":"            url \u003d next_url.split(\u0027/\u0027)[-1]"},{"line_number":125,"context_line":"            items \u003d self._list(\u0027/%s\u0027 % url, response_key, items)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return items"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0108cc26","line":125,"in_reply_to":"ba15a1d1_711bc1ca","updated":"2015-09-18 09:36:14.000000000","message":"Nikolay, yes, you\u0027re right,","commit_id":"bdec6df38373f650655ee6766a912e86f244b04c"}],"mistralclient/api/v2/actions.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5bbfe88976c45b233b3a0e73031e7e1135093551","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if sort_dirs:"},{"line_number":73,"context_line":"            qparams[\u0027sort_dirs\u0027] \u003d sort_dirs"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        query_string \u003d (\"?%s\" % urlparse.urlencode(qparams.items())"},{"line_number":76,"context_line":"                        if qparams else \"\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return self._list("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_25b847e5","line":75,"updated":"2015-09-21 07:48:48.000000000","message":"I suggest here we need to wrap qparams.items() in dict() otherwise we get py34 error.","commit_id":"4228b623bd4ba59a374ed70c97b133296547d14e"}],"mistralclient/api/v2/workflows.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"a306ee58425ad6e045e05b1c407e93946f28d25a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from urllib import urlencode"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from mistralclient.api import base"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_33a763be","line":16,"updated":"2015-09-18 10:15:19.000000000","message":"So, urllib.urlencode module is python3-incompatible. Let\u0027s keep python34 gate green and use the following: \n\n  import six\n\n  urlparse \u003d six.moves.urllib.parse\n  ...\n\n  urlparse.urlencode(...)","commit_id":"ee1f234b30cbae4f19554eff114f631f942b8a1d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"70e2b09539876f4d80966d9e134d7e728fca0c39","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from urllib import urlencode"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from mistralclient.api import base"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f3ffab63","line":16,"in_reply_to":"ba15a1d1_33a763be","updated":"2015-09-18 10:21:44.000000000","message":"Agree.","commit_id":"ee1f234b30cbae4f19554eff114f631f942b8a1d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"f81303b9cc9b58da04bb8f7bdff7fc1a2a875edb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from urllib import urlencode"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from mistralclient.api import base"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8d75e3cb","line":16,"in_reply_to":"ba15a1d1_33a763be","updated":"2015-09-18 15:39:56.000000000","message":"Thanks for the correction!","commit_id":"ee1f234b30cbae4f19554eff114f631f942b8a1d"}],"mistralclient/tests/unit/v2/test_executions.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"efb9872bea859a63dc16fae18f78aa9236f044a4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            side_effect\u003d[resp_1, resp_2]"},{"line_number":110,"context_line":"        )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        execution_list \u003d self.executions.list(limit\u003d1)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.assertEqual(2, len(execution_list))"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_ec0b7a22","line":112,"updated":"2015-09-17 13:13:18.000000000","message":"That changes in base self._list method leads to wrong representation here also. Why we request only 1 element (limit \u003d 1) but expect to get 2? I don\u0027t understand. \"limit\" itself means \"return at most N elements\".","commit_id":"bdec6df38373f650655ee6766a912e86f244b04c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"416865cce6074e2a3426ce0d279cb7fb871194c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        execution_list \u003d self.executions.list(limit\u003d1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.assertEqual(1, len(execution_list))"},{"line_number":104,"context_line":"        mock.assert_called_with(\u0027/executions?limit\u003d1\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_get(self):"},{"line_number":107,"context_line":"        mock \u003d self.mock_http_get(content\u003dEXEC)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b6db617b","line":104,"updated":"2015-09-18 10:41:34.000000000","message":"I would also add tests for other parameters like \"sort_keys\", \"sort_dirs\".","commit_id":"ee1f234b30cbae4f19554eff114f631f942b8a1d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"f81303b9cc9b58da04bb8f7bdff7fc1a2a875edb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        execution_list \u003d self.executions.list(limit\u003d1)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.assertEqual(1, len(execution_list))"},{"line_number":104,"context_line":"        mock.assert_called_with(\u0027/executions?limit\u003d1\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_get(self):"},{"line_number":107,"context_line":"        mock \u003d self.mock_http_get(content\u003dEXEC)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ed4c9f9f","line":104,"in_reply_to":"ba15a1d1_b6db617b","updated":"2015-09-18 15:39:56.000000000","message":"Done","commit_id":"ee1f234b30cbae4f19554eff114f631f942b8a1d"}]}
