)]}'
{"mistralclient/commands/v2/executions.py":[{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"49ac6083050a4f356de42efc500a822b373a1b24","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                            help\u003d\u0027Pagination marker for large data sets.\u0027,"},{"line_number":77,"context_line":"                            default\u003d\u0027\u0027,"},{"line_number":78,"context_line":"                            nargs\u003d\u0027?\u0027)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027--limit\u0027,"},{"line_number":80,"context_line":"                            type\u003dint,"},{"line_number":81,"context_line":"                            help\u003d\u0027Maximum number of resources to \u0027"},{"line_number":82,"context_line":"                                 \u0027return in a single result.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a730ba57","line":79,"updated":"2015-11-09 09:21:23.000000000","message":"What about introducing short versions of these options? Say, for limit it will be \u0027-l\u0027.","commit_id":"7533ae391862cfd29356a6ff78b4d50ca4bab325"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"333e621aa42dd3a1740ce625cfce90c0f60d1492","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        parser.add_argument(\u0027--sort_keys\u0027,"},{"line_number":85,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":86,"context_line":"                                 \u0027 Default: created_at.\u0027,"},{"line_number":87,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":88,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":89,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"},{"line_number":90,"context_line":"                                 \u0027Default:asc.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_58e75ae4","line":87,"updated":"2015-11-09 16:01:01.000000000","message":"Please explain explicitly about how to specify sort_keys or sort_dirs if more values are provided. And, please add the const value in order to support \u0027mistral execution-list --sort-keys --sort-dirs\u0027.\n\nMore UTs are deserved, btw.","commit_id":"7533ae391862cfd29356a6ff78b4d50ca4bab325"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"f272d0f2ab7a3dac32f3aefe87b010daee96f779","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        parser.add_argument(\u0027--sort_keys\u0027,"},{"line_number":85,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":86,"context_line":"                                 \u0027 Default: created_at.\u0027,"},{"line_number":87,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":88,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":89,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"},{"line_number":90,"context_line":"                                 \u0027Default:asc.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_0e5f4842","line":87,"in_reply_to":"da85f559_58e75ae4","updated":"2015-11-09 16:32:04.000000000","message":"Sorry, we don\u0027t need \u0027const\u0027 here. when not specified value, the sort_keys will be None, and the server side will give it a default value.","commit_id":"7533ae391862cfd29356a6ff78b4d50ca4bab325"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"49ac6083050a4f356de42efc500a822b373a1b24","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_resources(self, parsed_args):"},{"line_number":96,"context_line":"        return executions.ExecutionManager(self.app.client).list("},{"line_number":97,"context_line":"            marker\u003dparsed_args.marker, limit\u003dparsed_args.limit,"},{"line_number":98,"context_line":"            sort_keys\u003dparsed_args.sort_keys, sort_dirs\u003dparsed_args.sort_dirs)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_07f98680","line":96,"updated":"2015-11-09 09:21:23.000000000","message":"Soft: please use format: \n\n  method(\n      arg1,\n      arg2,\n      ...\n      argN\n  )\n\nThis example: \n\n  return executions.ExecutionManager(self.app.client).list(\n      marker\u003dparsed_args.marker,\n      limit\u003dparsed_args.limit,\n      sort_keys\u003dparsed_args.sort_keys,\n      sort_dirs\u003dparsed_args.sort_dirs\n  )","commit_id":"7533ae391862cfd29356a6ff78b4d50ca4bab325"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"333e621aa42dd3a1740ce625cfce90c0f60d1492","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_resources(self, parsed_args):"},{"line_number":96,"context_line":"        return executions.ExecutionManager(self.app.client).list("},{"line_number":97,"context_line":"            marker\u003dparsed_args.marker, limit\u003dparsed_args.limit,"},{"line_number":98,"context_line":"            sort_keys\u003dparsed_args.sort_keys, sort_dirs\u003dparsed_args.sort_dirs)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_eaad1989","line":96,"in_reply_to":"da85f559_07f98680","updated":"2015-11-09 16:01:01.000000000","message":"yeah, agree with Nikolay, please also do it in UT.","commit_id":"7533ae391862cfd29356a6ff78b4d50ca4bab325"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"5fa313a9dddf178b0bab4269b5119d1c9f394122","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                            type\u003dstr,"},{"line_number":76,"context_line":"                            help\u003d\u0027Pagination marker for large data sets.\u0027"},{"line_number":77,"context_line":"                                 \u0027Example: mistral execution-list --marker \u0027"},{"line_number":78,"context_line":"                                 \u0027abc\u0027,"},{"line_number":79,"context_line":"                            default\u003d\u0027\u0027,"},{"line_number":80,"context_line":"                            nargs\u003d\u0027?\u0027)"},{"line_number":81,"context_line":"        parser.add_argument(\u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_ef23dda5","line":78,"updated":"2015-11-09 17:17:59.000000000","message":"It will be more helpful if you will mention that the marker should be a workflow execution id and maybe change the \u0027abc\u0027 to a real UUID just so a user will know what to pass here","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"59f2ce6ca00124852a23eed862ea100a3d0938af","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_31193a7a","line":91,"updated":"2015-11-10 01:30:32.000000000","message":"Limor, thanks for the update, but according to the example here, user would get error using it because length of sort_keys and sort_dirs are not equal. You can change the description to \u0027Columns to sort results by. Default: created_at. More columns specified can be separated by commas, e.g. --sort_keys\u003did, name\u0027,the same with description for sort_dirs.","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":8592,"name":"Anastasia Kuznetsova","email":"akuznetsova@mirantis.com","username":"nastya-kuz"},"change_message_id":"fe5374a241a32d1b9ea943d542b806e52914f5c4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_bad41120","line":91,"updated":"2015-11-10 10:52:46.000000000","message":"Please, fix type in the example text: --sort_key - \u003e --sort-keyS .","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"d49452b7f669020be7fc3974ca450312336a40ce","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_87b771d7","line":91,"in_reply_to":"da85f559_0404df47","updated":"2015-11-10 12:13:59.000000000","message":"yes now i see it ok.. i will add --sort_keys the to the example","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"dc1f341b695c4d6ef2032fc692a38114b91f798a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_453e6eb9","line":91,"in_reply_to":"da85f559_0a0954dd","updated":"2015-11-10 08:34:20.000000000","message":"Thanks for the answer, Limor. Could you please write a simple functional test for this feature? That way we can say for sure this feature works in future.","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"754971aec3018ec1a406b9c0b9dd071752e707f0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0404df47","line":91,"in_reply_to":"da85f559_0a0954dd","updated":"2015-11-10 12:07:24.000000000","message":"what if \u0027mistral execution-list --mark XXXX --limit 5 --sort_dirs asc,asc,asc\u0027?","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"287fa1f0521174ec05e4598097ddf22a41cda02f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0a0954dd","line":91,"in_reply_to":"da85f559_31193a7a","updated":"2015-11-10 07:45:27.000000000","message":"Hi Thanks for the review... I test this example and it work just fine. \nlen(sort_key) \u003e\u003d len(sort_dirs) (ere is a defulte value)\n\nhere are the examples i tryed will testing this feature: \n1) mistral execution-list --limit 5 --marker 6dfb9572-2dc4-4c84-a86f-a6ddb1b90c97 --sort_dirs\u003ddesc --sort_key\u003did,Description\n\n2)mistral execution-list --limit 5 --marker 6dfb9572-2dc4-4c84-a86f-a6ddb1b90c97  --sort_key\u003did,Description","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"5c308fe68a62687154c40bafcb4807b40fcd22d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d95a502a","line":91,"in_reply_to":"da85f559_31193a7a","updated":"2015-11-10 05:18:07.000000000","message":"Yes, agree, and I think need to add a functional test for this (to see if it really works).","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"754971aec3018ec1a406b9c0b9dd071752e707f0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_87ea110e","line":91,"in_reply_to":"da85f559_453e6eb9","updated":"2015-11-10 12:07:24.000000000","message":"Yes, this was what I suggested. Although this feature is just an exposure to end users on behalf of API service, it really deserved some separated functional tests, to make sure the logic here cover all the use cases other people are not sure about the results.","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"},{"author":{"_account_id":15881,"name":"Limor Stotland","email":"limor.bortman@nokia.com","username":"LimorStotlamd"},"change_message_id":"287fa1f0521174ec05e4598097ddf22a41cda02f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                            help\u003d\u0027Columns to sort results by.\u0027"},{"line_number":89,"context_line":"                                 \u0027 Default: created_at.\u0027"},{"line_number":90,"context_line":"                                 \u0027Example : mistral execution-list \u0027"},{"line_number":91,"context_line":"                                 \u0027--sort_key\u003did,Description\u0027,"},{"line_number":92,"context_line":"                            default\u003d\u0027created_at\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":93,"context_line":"        parser.add_argument(\u0027--sort_dirs\u0027,"},{"line_number":94,"context_line":"                            help\u003d\u0027Sorting Directions (asc/desc)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_2a77783b","line":91,"in_reply_to":"da85f559_d95a502a","updated":"2015-11-10 07:45:27.000000000","message":"Hi Thanks for the review...  I talked it over with Lingxian Kong.\nI am not sure  more test are need because i just expose a featurethet was there.\nAnd besides that, all the logic is in the be and not in the client","commit_id":"6f8e2b5e386c8a98ed98c087b3842e8ea1b88a73"}]}