)]}'
{"mistralclient/commands/v2/actions.py":[{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"1a520d9c7b15f4d635af1ca6cd623488a6aff416","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super(Get, self).get_parser(prog_name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        parser.add_argument(\u0027action\u0027, help\u003d\u0027Action (name or ID\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        return parser"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b43a8f96","line":87,"range":{"start_line":87,"start_character":29,"end_line":87,"end_character":35},"updated":"2016-06-07 04:29:12.000000000","message":"I think \u0027identifier\u0027 would be good instead of action","commit_id":"f8cbd6e8058a48c40da46d282a06a8634f14a474"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"2a4729884f021cb2614d3bdbdcca4395e84883f1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def get_parser(self, prog_name):"},{"line_number":85,"context_line":"        parser \u003d super(Get, self).get_parser(prog_name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        parser.add_argument(\u0027action\u0027, help\u003d\u0027Action (name or ID\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        return parser"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e53e1fd9","line":87,"range":{"start_line":87,"start_character":29,"end_line":87,"end_character":35},"in_reply_to":"7aa08908_b43a8f96","updated":"2016-06-07 06:50:06.000000000","message":"I would leave it as \u0027action\u0027 because other python libraries, like nova [1], manage the \"concept\" (like \"server\") instead of \"name\" or \"identifier\".\n[1] https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L718","commit_id":"f8cbd6e8058a48c40da46d282a06a8634f14a474"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"1a520d9c7b15f4d635af1ca6cd623488a6aff416","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def take_action(self, parsed_args):"},{"line_number":92,"context_line":"        mistral_client \u003d self.app.client_manager.workflow_engine"},{"line_number":93,"context_line":"        action \u003d mistral_client.actions.get(parsed_args.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return format(action)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_14428310","line":93,"range":{"start_line":93,"start_character":56,"end_line":93,"end_character":60},"updated":"2016-06-07 04:29:12.000000000","message":"Please change this also.","commit_id":"f8cbd6e8058a48c40da46d282a06a8634f14a474"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"3a9b700dbd4097c5b670838b91471faf235a1b96","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def take_action(self, parsed_args):"},{"line_number":92,"context_line":"        mistral_client \u003d self.app.client_manager.workflow_engine"},{"line_number":93,"context_line":"        action \u003d mistral_client.actions.get(parsed_args.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return format(action)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d0e800b7","line":93,"range":{"start_line":93,"start_character":56,"end_line":93,"end_character":60},"updated":"2016-06-07 08:21:40.000000000","message":"You need to change here also.\nSee logs http://logs.openstack.org/21/325921/2/check/gate-python-mistralclient-python27/77687c0/console.html#_2016-06-07_06_57_14_309","commit_id":"eecad41359615733ae5995464dcbbc3e35a79009"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"91eb25944295f9ab12839f46861049a323d11a07","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def take_action(self, parsed_args):"},{"line_number":92,"context_line":"        mistral_client \u003d self.app.client_manager.workflow_engine"},{"line_number":93,"context_line":"        action \u003d mistral_client.actions.get(parsed_args.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return format(action)"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b0a3b44e","line":93,"range":{"start_line":93,"start_character":56,"end_line":93,"end_character":60},"in_reply_to":"7aa08908_d0e800b7","updated":"2016-06-07 08:25:16.000000000","message":"Oops!! right, thanks!","commit_id":"eecad41359615733ae5995464dcbbc3e35a79009"}]}