)]}'
{"id":"openstack%2Fpython-mistralclient~365416","triplet_id":"openstack%2Fpython-mistralclient~master~I9f7e79c2fbc23bc0e69ed5d0f752ad74b6ce09c5","project":"openstack/python-mistralclient","branch":"master","topic":"oslotest","hashtags":[],"change_id":"I9f7e79c2fbc23bc0e69ed5d0f752ad74b6ce09c5","subject":"Pass httpclient to managers","status":"MERGED","created":"2016-09-05 03:07:25.000000000","updated":"2017-07-18 04:30:52.000000000","submitted":"2016-09-21 13:17:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0d610f282387b52ce6c7097135e02a26a4f49145","_number":365416,"virtual_id_number":365416,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2017-07-17 21:54:34.000000000","post_submit":true,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":2,"date":"2016-09-21 13:17:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-21 12:49:46.000000000","_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},{"value":2,"date":"2016-09-21 12:42:59.000000000","_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-21 12:49:46.000000000","_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"value":0,"date":"2016-09-21 12:43:17.000000000","_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"date":"2016-09-21 12:43:22.000000000","_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 12:42:59.000000000","updated_by":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"reviewer":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"state":"REVIEWER"},{"updated":"2016-09-21 12:43:17.000000000","updated_by":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"reviewer":{"_account_id":19206,"name":"Dawid Deja","email":"dawdej@gmail.com","username":"ddeja"},"state":"REVIEWER"},{"updated":"2016-09-21 12:43:22.000000000","updated_by":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"reviewer":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"state":"REVIEWER"},{"updated":"2016-09-21 12:49:46.000000000","updated_by":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"reviewer":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"state":"REVIEWER"},{"updated":"2016-09-21 13:17:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-17 21:54:34.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"}],"messages":[{"id":"da97e7e716a06610ba96bc1f8395315c5b766100","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-09-05 03:07:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"54981afccf2ce617e417bf4a258db9f59cd99c92","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-05 03:47:15.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-mistralclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/365416/1/check/gate-python-mistralclient-docs-ubuntu-xenial/7725d96//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-mistralclient-pep8-ubuntu-xenial http://logs.openstack.org/16/365416/1/check/gate-python-mistralclient-pep8-ubuntu-xenial/03b213d/ : FAILURE in 3m 51s\n- gate-python-mistralclient-python27-ubuntu-xenial http://logs.openstack.org/16/365416/1/check/gate-python-mistralclient-python27-ubuntu-xenial/d9197fa/ : SUCCESS in 2m 29s\n- gate-python-mistralclient-python34 http://logs.openstack.org/16/365416/1/check/gate-python-mistralclient-python34/9b28073/ : SUCCESS in 2m 10s\n- gate-python-mistralclient-python35-nv http://logs.openstack.org/16/365416/1/check/gate-python-mistralclient-python35-nv/dd3d0c3/ : SUCCESS in 2m 37s (non-voting)\n- check-osc-plugins http://logs.openstack.org/16/365416/1/check/check-osc-plugins/5095701/ : SUCCESS in 6m 22s (non-voting)\n- gate-python-mistralclient-devstack-dsvm http://logs.openstack.org/16/365416/1/check/gate-python-mistralclient-devstack-dsvm/fc7e300/ : SUCCESS in 39m 02s","accounts_in_message":[],"_revision_number":1},{"id":"6bdf973687b2551b9b024bd783ab56b30aaa5cce","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-09-12 03:29:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee329498284185294cec952ed0b4e79865816899","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 04:07:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-mistralclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/365416/2/check/gate-python-mistralclient-docs-ubuntu-xenial/c872d22//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-mistralclient-pep8-ubuntu-xenial http://logs.openstack.org/16/365416/2/check/gate-python-mistralclient-pep8-ubuntu-xenial/2d4c797/ : SUCCESS in 2m 57s\n- gate-python-mistralclient-python27-ubuntu-xenial http://logs.openstack.org/16/365416/2/check/gate-python-mistralclient-python27-ubuntu-xenial/15dc4a0/ : SUCCESS in 3m 10s\n- gate-python-mistralclient-python34 http://logs.openstack.org/16/365416/2/check/gate-python-mistralclient-python34/cb01e8f/ : SUCCESS in 3m 09s\n- gate-python-mistralclient-python35-nv http://logs.openstack.org/16/365416/2/check/gate-python-mistralclient-python35-nv/68d5e82/ : SUCCESS in 3m 53s (non-voting)\n- check-osc-plugins http://logs.openstack.org/16/365416/2/check/check-osc-plugins/a252afb/ : SUCCESS in 5m 47s (non-voting)\n- gate-python-mistralclient-devstack-dsvm http://logs.openstack.org/16/365416/2/check/gate-python-mistralclient-devstack-dsvm/6744b3b/ : SUCCESS in 37m 54s","accounts_in_message":[],"_revision_number":2},{"id":"78a1eb78e2f6a2e4f58d6f390980636e057a802f","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2016-09-21 12:42:59.000000000","message":"Patch Set 2: Code-Review+2\n\nGood change, thanks Jamie. Have you encountered an issue with garbage collection when using Mistral? Just curious how you found out that it needs to be fixed..","accounts_in_message":[],"_revision_number":2},{"id":"d210ded39375f13103c051a95a5927c81c056b98","author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"date":"2016-09-21 12:49:46.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e197a4695b9eb343bdc02f32b4507a988134262b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 12:49:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a2a2610a39f813624620adc0d59fe196ceaeb851","date":"2016-09-21 13:17:29.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"c742097eb3e74f198091df0f4ad3c0262f86c0b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 13:17:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-mistralclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/365416/2/gate/gate-python-mistralclient-docs-ubuntu-xenial/e367d16//doc/build/html/ : SUCCESS in 6m 00s\n- gate-python-mistralclient-pep8-ubuntu-xenial http://logs.openstack.org/16/365416/2/gate/gate-python-mistralclient-pep8-ubuntu-xenial/1009ea1/ : SUCCESS in 3m 03s\n- gate-python-mistralclient-python27-ubuntu-xenial http://logs.openstack.org/16/365416/2/gate/gate-python-mistralclient-python27-ubuntu-xenial/ea01a44/ : SUCCESS in 4m 34s\n- gate-python-mistralclient-python34 http://logs.openstack.org/16/365416/2/gate/gate-python-mistralclient-python34/6d73ab4/ : SUCCESS in 3m 27s\n- gate-python-mistralclient-devstack-dsvm http://logs.openstack.org/16/365416/2/gate/gate-python-mistralclient-devstack-dsvm/ac94792/ : SUCCESS in 26m 21s","accounts_in_message":[],"_revision_number":2},{"id":"f2864c4f4f3192584e942c1f2af4b543aba77cd5","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2017-07-17 21:54:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"76235f97c37dc5e9289143622b33c099e37ea6be","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2017-07-18 04:30:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7650ff9dbbc48dfbbda84ecf890daa5eab44ef2","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2017-07-18 04:30:52.000000000","message":"Patch Set 2:\n\nThis is an old-old change )","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e65a0fbb2a86dc566ef2438a95a2dc3ac358913d","revisions":{"3c51f9abaacc9f850949745f4cd1664c762203ae":{"kind":"REWORK","_number":1,"created":"2016-09-05 03:07:25.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/16/365416/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/16/365416/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/1"}}},"commit":{"parents":[{"commit":"2f8a6ca7e8057c5ab44bc5766d4304be7045cceb","subject":"Use requests-mock for testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/2f8a6ca7e8057c5ab44bc5766d4304be7045cceb"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-09-03 06:29:40.000000000","tz":480},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-09-05 03:06:57.000000000","tz":0},"subject":"Pass httpclient to managers","message":"Pass httpclient to managers\n\nThe api managers don\u0027t need a reference to the client that created them.\nIndeed this is circular and can cause problems with garbage collection\nlater.\n\nOnly pass the http_client that the managers actually use to the\nmanagers.\n\nChange-Id: I9f7e79c2fbc23bc0e69ed5d0f752ad74b6ce09c5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/3c51f9abaacc9f850949745f4cd1664c762203ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/3c51f9abaacc9f850949745f4cd1664c762203ae"}]},"branch":"refs/heads/master"},"e65a0fbb2a86dc566ef2438a95a2dc3ac358913d":{"kind":"REWORK","_number":2,"created":"2016-09-12 03:29:38.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/16/365416/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/16/365416/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/16/365416/2"}}},"commit":{"parents":[{"commit":"c457718a4d2f323e3ff30bcd44a4bbec2e30d5cf","subject":"Use requests-mock for testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/c457718a4d2f323e3ff30bcd44a4bbec2e30d5cf"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-09-03 06:29:40.000000000","tz":480},"committer":{"name":"Jamie Lennox","email":"jamielennox@gmail.com","date":"2016-09-12 03:28:31.000000000","tz":600},"subject":"Pass httpclient to managers","message":"Pass httpclient to managers\n\nThe api managers don\u0027t need a reference to the client that created them.\nIndeed this is circular and can cause problems with garbage collection\nlater.\n\nOnly pass the http_client that the managers actually use to the\nmanagers.\n\nChange-Id: I9f7e79c2fbc23bc0e69ed5d0f752ad74b6ce09c5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/e65a0fbb2a86dc566ef2438a95a2dc3ac358913d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/e65a0fbb2a86dc566ef2438a95a2dc3ac358913d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
