)]}'
{"mistralclient/auth/keystone.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"084e28cccdb227b06d5e4760a7e7c359af2ccf4a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    if not mistral_url:"},{"line_number":54,"context_line":"        catalog \u003d keystone.service_catalog.get_endpoints("},{"line_number":55,"context_line":"            service_type\u003dservice_type,"},{"line_number":56,"context_line":"            endpoint_type\u003dendpoint_type"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if service_type in catalog:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_b999fc70","line":56,"updated":"2016-09-05 14:10:40.000000000","message":"See comment below.","commit_id":"40a740b1f581929ed8eea655363fbf6d6111a9a9"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"084e28cccdb227b06d5e4760a7e7c359af2ccf4a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            service \u003d catalog.get(service_type)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            if keystone.version \u003d\u003d \u0027v2.0\u0027 and service:"},{"line_number":63,"context_line":"                mistral_url \u003d service[0].get(endpoint_type)"},{"line_number":64,"context_line":"            elif service:"},{"line_number":65,"context_line":"                mistral_url \u003d service[0].get(\u0027url\u0027)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_798f7423","line":63,"updated":"2016-09-05 14:10:40.000000000","message":"I think, it would be cleaner to remove the endpoint_type argument from the method\u0027s signature and make it a local variable.","commit_id":"40a740b1f581929ed8eea655363fbf6d6111a9a9"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"fdef4172b9eb1f62df5569b40cdf712f26a81ae9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            service \u003d catalog.get(service_type)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            if keystone.version \u003d\u003d \u0027v2.0\u0027 and service:"},{"line_number":63,"context_line":"                mistral_url \u003d service[0].get(endpoint_type)"},{"line_number":64,"context_line":"            elif service:"},{"line_number":65,"context_line":"                mistral_url \u003d service[0].get(\u0027url\u0027)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_acb605da","line":63,"in_reply_to":"9a89bdaa_798f7423","updated":"2016-09-06 08:07:40.000000000","message":"what do you mean exactly? I don\u0027t get: endpoint_type is already a local variable inside the function. Or, if you mean removing endpoint_type from the function at all, then it is not correct. We must keep the possibility to pass endpoint_type parameter from outside.","commit_id":"40a740b1f581929ed8eea655363fbf6d6111a9a9"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"ccd8b6894a5ea3f9ac0f77640fe4258f63b83f96","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            service \u003d catalog.get(service_type)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            if keystone.version \u003d\u003d \u0027v2.0\u0027 and service:"},{"line_number":63,"context_line":"                mistral_url \u003d service[0].get(endpoint_type)"},{"line_number":64,"context_line":"            elif service:"},{"line_number":65,"context_line":"                mistral_url \u003d service[0].get(\u0027url\u0027)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_86c5953d","line":63,"in_reply_to":"9a89bdaa_acb605da","updated":"2016-09-06 10:45:56.000000000","message":"Ah, OK, so this option can come from the command line, too. Thanks.","commit_id":"40a740b1f581929ed8eea655363fbf6d6111a9a9"}]}