)]}'
{"mistralclient/shell.py":[{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"0b9193db0279454741fec64cdab4ad056f06fa8c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027--os-tenant-name\u0027,"},{"line_number":273,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":274,"context_line":"            dest\u003d\u0027tenant_name\u0027,"},{"line_number":275,"context_line":"            default\u003d(env(\u0027OS_TENANT_NAME\u0027) or env(\u0027OS_PROJECT_NAME\u0027)"},{"line_number":276,"context_line":"                     or \u0027Default\u0027),"},{"line_number":277,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":278,"context_line":"                 \u0027 or OS_RPOJECT_NAME)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_9e04b67e","line":275,"range":{"start_line":275,"start_character":20,"end_line":275,"end_character":68},"updated":"2016-12-12 10:27:02.000000000","message":"can this be simply env(\u0027OS_PROJECT_NAME\u0027, \u0027OS_TENANT_NAME\u0027)","commit_id":"e01ee45da427d30c4c87426925ee89049f06acd8"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"1e77eaee2835952828406e28da4de38d32ba5eb9","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027--os-tenant-name\u0027,"},{"line_number":273,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":274,"context_line":"            dest\u003d\u0027tenant_name\u0027,"},{"line_number":275,"context_line":"            default\u003d(env(\u0027OS_TENANT_NAME\u0027) or env(\u0027OS_PROJECT_NAME\u0027)"},{"line_number":276,"context_line":"                     or \u0027Default\u0027),"},{"line_number":277,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":278,"context_line":"                 \u0027 or OS_RPOJECT_NAME)\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_59bb180f","line":275,"range":{"start_line":275,"start_character":20,"end_line":275,"end_character":68},"in_reply_to":"3a71b18c_9e04b67e","updated":"2016-12-12 10:37:14.000000000","message":"Done","commit_id":"e01ee45da427d30c4c87426925ee89049f06acd8"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"0b9193db0279454741fec64cdab4ad056f06fa8c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            default\u003d(env(\u0027OS_TENANT_NAME\u0027) or env(\u0027OS_PROJECT_NAME\u0027)"},{"line_number":276,"context_line":"                     or \u0027Default\u0027),"},{"line_number":277,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":278,"context_line":"                 \u0027 or OS_RPOJECT_NAME)\u0027"},{"line_number":279,"context_line":"        )"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_7ebefaae","line":278,"range":{"start_line":278,"start_character":25,"end_line":278,"end_character":33},"updated":"2016-12-12 10:27:02.000000000","message":"PROJECT","commit_id":"e01ee45da427d30c4c87426925ee89049f06acd8"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"1e77eaee2835952828406e28da4de38d32ba5eb9","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            default\u003d(env(\u0027OS_TENANT_NAME\u0027) or env(\u0027OS_PROJECT_NAME\u0027)"},{"line_number":276,"context_line":"                     or \u0027Default\u0027),"},{"line_number":277,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":278,"context_line":"                 \u0027 or OS_RPOJECT_NAME)\u0027"},{"line_number":279,"context_line":"        )"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_79b8d411","line":278,"range":{"start_line":278,"start_character":25,"end_line":278,"end_character":33},"in_reply_to":"3a71b18c_7ebefaae","updated":"2016-12-12 10:37:14.000000000","message":"Done","commit_id":"e01ee45da427d30c4c87426925ee89049f06acd8"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"cdcf8e97b4896e707eb05c06524ec23ec9fcf349","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            \u0027--os-tenant-id\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":265,"context_line":"            dest\u003d\u0027tenant_id\u0027,"},{"line_number":266,"context_line":"            default\u003denv(\u0027OS_TENANT_ID\u0027, \u0027OS_PROJECT_ID\u0027),"},{"line_number":267,"context_line":"            help\u003d\u0027Authentication tenant identifier (Env: OS_TENANT_ID\u0027"},{"line_number":268,"context_line":"                 \u0027 or OS_PROJECT_ID)\u0027"},{"line_number":269,"context_line":"        )"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_40fb187b","line":268,"range":{"start_line":266,"start_character":12,"end_line":268,"end_character":37},"updated":"2016-12-12 12:13:34.000000000","message":"You are removing this in https://review.openstack.org/#/c/409675/2/mistralclient/shell.py\nDo we require this patch now?","commit_id":"b15760f0e122a9457c071cae87d1bb1b569c97fb"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"4bab7e26effd8c9d1f3cd050c3172b118246a96e","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            \u0027--os-tenant-id\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":265,"context_line":"            dest\u003d\u0027tenant_id\u0027,"},{"line_number":266,"context_line":"            default\u003denv(\u0027OS_TENANT_ID\u0027, \u0027OS_PROJECT_ID\u0027),"},{"line_number":267,"context_line":"            help\u003d\u0027Authentication tenant identifier (Env: OS_TENANT_ID\u0027"},{"line_number":268,"context_line":"                 \u0027 or OS_PROJECT_ID)\u0027"},{"line_number":269,"context_line":"        )"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a00a2c24","line":268,"range":{"start_line":266,"start_character":12,"end_line":268,"end_character":37},"in_reply_to":"3a71b18c_40fb187b","updated":"2016-12-12 12:21:09.000000000","message":"That patch is based on master branch. One of those two patches need to be rebased if the other is merged.","commit_id":"b15760f0e122a9457c071cae87d1bb1b569c97fb"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"1596e82dcace1042ac829e1c49a5ad5c5cf3f51a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027--os-tenant-name\u0027,"},{"line_number":273,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":274,"context_line":"            dest\u003d\u0027tenant_name\u0027,"},{"line_number":275,"context_line":"            default\u003denv(\u0027OS_TENANT_NAME\u0027, \u0027OS_PROJECT_NAME\u0027, \u0027Default\u0027),"},{"line_number":276,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":277,"context_line":"                 \u0027 or OS_PROJECT_NAME)\u0027"},{"line_number":278,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_e5d52043","line":275,"range":{"start_line":275,"start_character":62,"end_line":275,"end_character":69},"updated":"2017-01-12 04:38:28.000000000","message":"if it is default value you want to set then it should be\ndefault\u003d\u0027Default\u0027","commit_id":"d2e6bd762545428a59fc2e1f5dbed60801bcaba2"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"78139f0cbd20b915cdb7ce982c31abe7eed20649","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027--os-tenant-name\u0027,"},{"line_number":273,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":274,"context_line":"            dest\u003d\u0027tenant_name\u0027,"},{"line_number":275,"context_line":"            default\u003denv(\u0027OS_TENANT_NAME\u0027, \u0027OS_PROJECT_NAME\u0027, \u0027Default\u0027),"},{"line_number":276,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":277,"context_line":"                 \u0027 or OS_PROJECT_NAME)\u0027"},{"line_number":278,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_c4dff00a","line":275,"range":{"start_line":275,"start_character":62,"end_line":275,"end_character":69},"in_reply_to":"9a57fde8_b2677e24","updated":"2017-02-01 07:44:52.000000000","message":"I guess you should use like\nparser.add_argument(\n            \u0027--os-tenant-name\u0027,\n            action\u003d\u0027store\u0027,\n            dest\u003d\u0027tenant_name\u0027,\n            default\u003denv(\u0027OS_TENANT_NAME\u0027, \u0027OS_PROJECT_NAME\u0027, default\u003d\u0027Default\u0027),\n            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME or OS_PROJECT_NAME)\u0027\n        )","commit_id":"d2e6bd762545428a59fc2e1f5dbed60801bcaba2"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"2b92ec58c4725d57f948d726a0a30ea6a5cb1ba8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027--os-tenant-name\u0027,"},{"line_number":273,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":274,"context_line":"            dest\u003d\u0027tenant_name\u0027,"},{"line_number":275,"context_line":"            default\u003denv(\u0027OS_TENANT_NAME\u0027, \u0027OS_PROJECT_NAME\u0027, \u0027Default\u0027),"},{"line_number":276,"context_line":"            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME\u0027"},{"line_number":277,"context_line":"                 \u0027 or OS_PROJECT_NAME)\u0027"},{"line_number":278,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a57fde8_b2677e24","line":275,"range":{"start_line":275,"start_character":62,"end_line":275,"end_character":69},"in_reply_to":"ba5201f7_e5d52043","updated":"2017-01-12 08:25:16.000000000","message":"Yes, that\u0027s the correct way to set default value.\nBut here, I believe it\u0027s the original behavior to do it like this.\nApparently, it\u0027s non-sense getting value of `Default` from env. Same to line#413 in this file.\nShould I just keep it like this or set them like below:\n\"\"\"\n        parser.add_argument(\n            \u0027--os-tenant-name\u0027,\n            action\u003d\u0027store\u0027,\n            dest\u003d\u0027tenant_name\u0027,\n            default\u003denv(\u0027OS_TENANT_NAME\u0027, \u0027OS_PROJECT_NAME\u0027),\n            help\u003d\u0027Authentication tenant name (Env: OS_TENANT_NAME or OS_PROJECT_NAME)\u0027\n        )\n\"\"\"","commit_id":"d2e6bd762545428a59fc2e1f5dbed60801bcaba2"}]}