)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"64b0f179dfbf34a478724f4bf1477153a029e7c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     houweichao \u003chouwch@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-12 17:00:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone v3 needs extra parameters"},{"line_number":8,"context_line":"to support keystone v3 this commit adds project_domain_name and"},{"line_number":9,"context_line":"user_domain_name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic1b7e9d6bbb62f2c9aaa468c4c64d07ae34cdd20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_1ee8a6e1","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":16},"updated":"2016-12-12 10:22:39.000000000","message":"format the commit message properly","commit_id":"31aecef80018a99509bb44115299fffbec019fb1"}],"mistralclient/auth/keystone.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"380956a5620c9c62c94ab7f1be053bbdb1cb7117","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        target_cacert \u003d req.get(\u0027target_cacert\u0027)"},{"line_number":63,"context_line":"        target_region_name \u003d req.get(\u0027target_region_name\u0027)"},{"line_number":64,"context_line":"        target_insecure \u003d req.get(\u0027target_insecure\u0027)"},{"line_number":65,"context_line":"        user_domain_name \u003d req.get(\u0027os_user_domain_name\u0027,\u0027default\u0027)"},{"line_number":66,"context_line":"        project_domain_name \u003d req.get(\u0027os_project_domain_name\u0027,\u0027default\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if project_name and project_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_1a318f5a","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":56},"updated":"2016-12-12 11:35:04.000000000","message":"I\u0027d like to remove the \"os_\" prefix and use \"user_domain_name\" and \"project_domain_name\" here.","commit_id":"31aecef80018a99509bb44115299fffbec019fb1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6fc4d17abbac72ff1488e404156bd2e798823480","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        target_cacert \u003d req.get(\u0027target_cacert\u0027)"},{"line_number":63,"context_line":"        target_region_name \u003d req.get(\u0027target_region_name\u0027)"},{"line_number":64,"context_line":"        target_insecure \u003d req.get(\u0027target_insecure\u0027)"},{"line_number":65,"context_line":"        user_domain_name \u003d req.get(\u0027os_user_domain_name\u0027, \u0027default\u0027)"},{"line_number":66,"context_line":"        project_domain_name \u003d req.get(\u0027os_project_domain_name\u0027, \u0027default\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if project_name and project_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c3bbb20d","line":65,"updated":"2016-12-12 12:25:32.000000000","message":"the default domain\u0027s name is actually \u0027Default\u0027, while the id is \u0027default\u0027","commit_id":"5a7ec7b9390e4da744037ea640ebf499dacac512"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"015e98efd9db2e545b09840a42a76d87dc26cd21","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        target_cacert \u003d req.get(\u0027target_cacert\u0027)"},{"line_number":63,"context_line":"        target_region_name \u003d req.get(\u0027target_region_name\u0027)"},{"line_number":64,"context_line":"        target_insecure \u003d req.get(\u0027target_insecure\u0027)"},{"line_number":65,"context_line":"        user_domain_name \u003d req.get(\u0027os_user_domain_name\u0027, \u0027default\u0027)"},{"line_number":66,"context_line":"        project_domain_name \u003d req.get(\u0027os_project_domain_name\u0027, \u0027default\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if project_name and project_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_23c0e64f","line":65,"in_reply_to":"3a71b18c_c3bbb20d","updated":"2016-12-12 12:28:12.000000000","message":"Exactly.","commit_id":"5a7ec7b9390e4da744037ea640ebf499dacac512"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"96c26c7ce98048bd6d5aa7a9d5795dfcf8630b97","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        target_cacert \u003d req.get(\u0027target_cacert\u0027)"},{"line_number":63,"context_line":"        target_region_name \u003d req.get(\u0027target_region_name\u0027)"},{"line_number":64,"context_line":"        target_insecure \u003d req.get(\u0027target_insecure\u0027)"},{"line_number":65,"context_line":"        user_domain_name \u003d req.get(\u0027os_user_domain_name\u0027, \u0027default\u0027)"},{"line_number":66,"context_line":"        project_domain_name \u003d req.get(\u0027os_project_domain_name\u0027, \u0027default\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if project_name and project_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_4357a259","line":65,"range":{"start_line":65,"start_character":59,"end_line":65,"end_character":66},"updated":"2016-12-12 12:34:22.000000000","message":"Default","commit_id":"a3ee507a761deb8f9a8b1c62542c32f0566dbdc1"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cc6600099ba0cd7f981b7c5170fd6c925b259576","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        target_region_name \u003d req.get(\u0027target_region_name\u0027)"},{"line_number":64,"context_line":"        target_insecure \u003d req.get(\u0027target_insecure\u0027)"},{"line_number":65,"context_line":"        user_domain_name \u003d req.get(\u0027os_user_domain_name\u0027, \u0027default\u0027)"},{"line_number":66,"context_line":"        project_domain_name \u003d req.get(\u0027os_project_domain_name\u0027, \u0027default\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if project_name and project_id:"},{"line_number":69,"context_line":"            raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_83cb7a52","line":66,"updated":"2016-12-12 12:30:20.000000000","message":"same comment as in the previous patch. should be \u0027Default\u0027 with the first letter capitalized.","commit_id":"a3ee507a761deb8f9a8b1c62542c32f0566dbdc1"}],"mistralclient/shell.py":[{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"64b0f179dfbf34a478724f4bf1477153a029e7c5","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        # Assume that keystone v3 is used to authencate"},{"line_number":475,"context_line":"        # provide default user_domain_name and project_domain_name"},{"line_number":476,"context_line":"        if not self.options.os_user_domain_name: "},{"line_number":477,"context_line":"            setattr(self.options,\"os_user_domain_name\",\"default\")"},{"line_number":478,"context_line":"        if self.options.os_project_domain_name:"},{"line_number":479,"context_line":"            setattr(self.options,\"os_project_domain_name\",\"default\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9e2cb64b","line":476,"range":{"start_line":476,"start_character":48,"end_line":476,"end_character":49},"updated":"2016-12-12 10:22:39.000000000","message":"remove","commit_id":"31aecef80018a99509bb44115299fffbec019fb1"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"380956a5620c9c62c94ab7f1be053bbdb1cb7117","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        # Assume that keystone v3 is used to authencate"},{"line_number":475,"context_line":"        # provide default user_domain_name and project_domain_name"},{"line_number":476,"context_line":"        if not self.options.os_user_domain_name: "},{"line_number":477,"context_line":"            setattr(self.options,\"os_user_domain_name\",\"default\")"},{"line_number":478,"context_line":"        if self.options.os_project_domain_name:"},{"line_number":479,"context_line":"            setattr(self.options,\"os_project_domain_name\",\"default\")"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        # bash-completion should not require authentification."},{"line_number":482,"context_line":"        if do_help or (\u0027bash-completion\u0027 in argv):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3d06451c","line":479,"range":{"start_line":476,"start_character":0,"end_line":479,"end_character":68},"updated":"2016-12-12 11:35:04.000000000","message":"You need to add user_domain_name/project_domain_name to build_option_parser function above, then you can use them here. Right?","commit_id":"31aecef80018a99509bb44115299fffbec019fb1"},{"author":{"_account_id":18238,"name":"Hardik Parekh","email":"hardik.parekh047@gmail.com","username":"hparekh"},"change_message_id":"646e03eaa85836cb039e00ad778ee578da23f872","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        # Assume that keystone v3 is used to authencate"},{"line_number":493,"context_line":"        # provide default user_domain_name and project_domain_name"},{"line_number":494,"context_line":"        if not self.options.user_domain_name:"},{"line_number":495,"context_line":"            setattr(self.options, \"user_domain_name\", \"Default\")"},{"line_number":496,"context_line":"        if self.options.project_domain_name:"},{"line_number":497,"context_line":"            setattr(self.options, \"project_domain_name\", \"Default\")"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # bash-completion should not require authentification."},{"line_number":500,"context_line":"        if do_help or (\u0027bash-completion\u0027 in argv):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_8f55b6c7","line":497,"range":{"start_line":494,"start_character":8,"end_line":497,"end_character":67},"updated":"2016-12-20 11:40:58.000000000","message":"We don\u0027t need to set \u0027Default\u0027 separately. I think it will be set to \u0027Default\u0027 if user will not provide it. because you already mention default in\n\ndefault\u003denv(\u0027OS_PROJECT_DOMAIN_NAME\u0027, default\u003d\u0027Default\u0027),","commit_id":"29146c40ede117d803f99ac4594a6f63fb249f56"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"fa00aaa02d2c568963f1d7005d9327cc5650eb69","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        # Assume that keystone v3 is used to authencate"},{"line_number":493,"context_line":"        # provide default user_domain_name and project_domain_name"},{"line_number":494,"context_line":"        if not self.options.user_domain_name:"},{"line_number":495,"context_line":"            setattr(self.options, \"user_domain_name\", \"Default\")"},{"line_number":496,"context_line":"        if self.options.project_domain_name:"},{"line_number":497,"context_line":"            setattr(self.options, \"project_domain_name\", \"Default\")"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # bash-completion should not require authentification."},{"line_number":500,"context_line":"        if do_help or (\u0027bash-completion\u0027 in argv):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_e562cb3c","line":497,"range":{"start_line":494,"start_character":8,"end_line":497,"end_character":67},"in_reply_to":"1a6eadb0_8f55b6c7","updated":"2016-12-20 12:25:14.000000000","message":"Exactly!","commit_id":"29146c40ede117d803f99ac4594a6f63fb249f56"}]}
