)]}'
{"id":"openstack%2Fpython-mistralclient~480335","triplet_id":"openstack%2Fpython-mistralclient~master~I7eb3b115cb3c2527e32b99268ee63ce9fe16d428","project":"openstack/python-mistralclient","branch":"master","hashtags":[],"change_id":"I7eb3b115cb3c2527e32b99268ee63ce9fe16d428","subject":"Use assertTrue/False(A) instead of assertEqual(True/False, A)","status":"ABANDONED","created":"2017-07-05 03:03:37.000000000","updated":"2017-07-10 22:56:57.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b99ac27dd44a74919ad8d0bd5fed7494f022d1c9","_number":480335,"virtual_id_number":480335,"owner":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-07-05 05:35:54.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},{"date":"2017-07-10 08:06:44.000000000","_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},{"value":-1,"date":"2017-07-10 22:56:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":-1,"date":"2017-07-10 07:54:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-05 03:30:45.000000000","updated_by":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"reviewer":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"state":"REVIEWER"},{"updated":"2017-07-05 05:35:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-10 07:54:15.000000000","updated_by":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"reviewer":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"state":"REVIEWER"}],"messages":[{"id":"d08f0db266c56b35903c9c49d0406b51c3300c93","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2017-07-05 03:03:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ecfb348ccb3e33c92563fb172316123c2c49859","author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"date":"2017-07-05 03:30:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nRecheck and fix it all :) You missed some, for ex:\n\nhttps://github.com/openstack/python-mistralclient/blob/master/mistralclient/tests/functional/cli/v2/cli_tests_v2.py#L417","accounts_in_message":[],"_revision_number":1},{"id":"a23ac975d628f43423ac23587ff87079ad3d2824","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 03:43:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-mistralclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/480335/1/check/gate-python-mistralclient-docs-ubuntu-xenial/ea31579//doc/build/html/ : SUCCESS in 3m 59s\n- gate-python-mistralclient-pep8-ubuntu-xenial http://logs.openstack.org/35/480335/1/check/gate-python-mistralclient-pep8-ubuntu-xenial/c65b343/ : SUCCESS in 4m 50s\n- gate-python-mistralclient-python27-ubuntu-xenial http://logs.openstack.org/35/480335/1/check/gate-python-mistralclient-python27-ubuntu-xenial/97d0097/ : SUCCESS in 2m 11s\n- gate-python-mistralclient-python35 http://logs.openstack.org/35/480335/1/check/gate-python-mistralclient-python35/7f62dd8/ : SUCCESS in 2m 10s\n- check-osc-plugins http://logs.openstack.org/35/480335/1/check/check-osc-plugins/d2a5845/ : SUCCESS in 5m 11s (non-voting)\n- python-mistralclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/35/480335/1/check/python-mistralclient-coverage-ubuntu-xenial-nv/cb07c1b/ : FAILURE in 2m 37s (non-voting)\n- gate-python-mistralclient-devstack-dsvm-ubuntu-xenial http://logs.openstack.org/35/480335/1/check/gate-python-mistralclient-devstack-dsvm-ubuntu-xenial/9a54952/ : FAILURE in 39m 15s","accounts_in_message":[],"_revision_number":1},{"id":"ee4a5946763cef927607061711c8b93001597e41","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2017-07-05 04:57:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"61ea204bcf5be3a7fe8149c71b4599e5f84f30d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 05:35:54.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-mistralclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/480335/2/check/gate-python-mistralclient-docs-ubuntu-xenial/684eb2a//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-mistralclient-pep8-ubuntu-xenial http://logs.openstack.org/35/480335/2/check/gate-python-mistralclient-pep8-ubuntu-xenial/6eea5ec/ : SUCCESS in 2m 58s\n- gate-python-mistralclient-python27-ubuntu-xenial http://logs.openstack.org/35/480335/2/check/gate-python-mistralclient-python27-ubuntu-xenial/ac3045e/ : SUCCESS in 2m 18s\n- gate-python-mistralclient-python35 http://logs.openstack.org/35/480335/2/check/gate-python-mistralclient-python35/3f37192/ : SUCCESS in 2m 23s\n- check-osc-plugins http://logs.openstack.org/35/480335/2/check/check-osc-plugins/0e8cff4/ : SUCCESS in 3m 49s (non-voting)\n- python-mistralclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/35/480335/2/check/python-mistralclient-coverage-ubuntu-xenial-nv/13b1a31/ : FAILURE in 2m 07s (non-voting)\n- gate-python-mistralclient-devstack-dsvm-ubuntu-xenial http://logs.openstack.org/35/480335/2/check/gate-python-mistralclient-devstack-dsvm-ubuntu-xenial/0e6d6f7/ : FAILURE in 35m 45s","accounts_in_message":[],"_revision_number":2},{"id":"e7ecfa98885930e6071ad477c7700038b663b6b0","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2017-07-10 07:54:15.000000000","message":"Patch Set 2: Code-Review-1\n\nwhy dont you merge these two? since same file is being changed and changes are related","accounts_in_message":[],"_revision_number":2},{"id":"cd2aa280d4de1c5be8efef8ee9b58dfbcc64bc71","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2017-07-10 08:06:44.000000000","message":"Patch Set 2:\n\nThis is not a question.","accounts_in_message":[],"_revision_number":2},{"id":"321801b2ba64aa55f82da10d9b124ad3be2de87d","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2017-07-10 10:21:24.000000000","message":"Patch Set 2:\n\n\u003e This is not a question.\n\nI would still stand by my -1 though I didn\u0027t understand your reply :P","accounts_in_message":[],"_revision_number":2},{"id":"e85dc69fd0cd5a64f93028184dd3a18da6ec3fc6","author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"date":"2017-07-10 10:23:00.000000000","message":"Patch Set 2:\n\n\u003e This is not a question.\n\nOops!! Did I miss the link to the other patch? https://review.openstack.org/#/c/480705/ This is it","accounts_in_message":[],"_revision_number":2},{"id":"3096b26657806308aa76171e8b4b3f690314627f","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2017-07-10 22:56:52.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"b99ac27dd44a74919ad8d0bd5fed7494f022d1c9","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2017-07-10 22:56:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d326ef467e6f1f5672270b5e737903d463cb840e","revisions":{"4a5dafdb737bc0dba4690a92b672d8456725f499":{"kind":"REWORK","_number":1,"created":"2017-07-05 03:03:37.000000000","uploader":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"ref":"refs/changes/35/480335/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/35/480335/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/1"}}},"commit":{"parents":[{"commit":"d4d41137ac30f168cf64671706e788077a375a7e","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/d4d41137ac30f168cf64671706e788077a375a7e"}]}],"author":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2017-07-05 03:02:35.000000000","tz":480},"committer":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2017-07-05 03:03:32.000000000","tz":480},"subject":"Use assertTrue/False(A) instead of assertEqual(True/False, A)","message":"Use assertTrue/False(A) instead of assertEqual(True/False, A)\n\nThis patch replaces assertEqual(True/False, A) with assertTrue/False(A),\nwhich is more straightforward and easier to understand.\n\nChange-Id: I7eb3b115cb3c2527e32b99268ee63ce9fe16d428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/4a5dafdb737bc0dba4690a92b672d8456725f499"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/4a5dafdb737bc0dba4690a92b672d8456725f499"}]},"branch":"refs/heads/master"},"d326ef467e6f1f5672270b5e737903d463cb840e":{"kind":"REWORK","_number":2,"created":"2017-07-05 04:57:56.000000000","uploader":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"ref":"refs/changes/35/480335/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/35/480335/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/35/480335/2"}}},"commit":{"parents":[{"commit":"d4d41137ac30f168cf64671706e788077a375a7e","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/d4d41137ac30f168cf64671706e788077a375a7e"}]}],"author":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2017-07-05 03:02:35.000000000","tz":480},"committer":{"name":"melissaml","email":"ma.lei@99cloud.net","date":"2017-07-05 04:57:35.000000000","tz":480},"subject":"Use assertTrue/False(A) instead of assertEqual(True/False, A)","message":"Use assertTrue/False(A) instead of assertEqual(True/False, A)\n\nThis patch replaces assertEqual(True/False, A) with assertTrue/False(A),\nwhich is more straightforward and easier to understand.\n\nChange-Id: I7eb3b115cb3c2527e32b99268ee63ce9fe16d428\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/d326ef467e6f1f5672270b5e737903d463cb840e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/d326ef467e6f1f5672270b5e737903d463cb840e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}