)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"97b2aa05603484db0266c51fdd644ec58a766daa","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add --namespace flag to workflow and execution operations."},{"line_number":10,"context_line":"Also Add Namespace and Workflow namespace to the tables"},{"line_number":11,"context_line":"the users gets after some cli calls."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ieb7302870520f5491e94a9bf6759082e2aa4a450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff346bd7_63470fbe","line":12,"updated":"2017-07-28 17:01:44.000000000","message":"Partially-Implements: blueprint create-and-run-workflows-within-a-namespace","commit_id":"218f6deac1fc50d47a8f756514ccd9c2280e7599"}],"mistralclient/api/v2/executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"dd2ca5b000f48aa5b2f587d6c93c2a5995676961","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            data.update({\u0027workflow_id\u0027: workflow_identifier})"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            data.update({\u0027workflow_name\u0027: workflow_identifier})"},{"line_number":46,"context_line":"        if namespace:"},{"line_number":47,"context_line":"            data.update({\u0027workflow_namespace\u0027: namespace})"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if workflow_input:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_e07afaee","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":9},"updated":"2017-08-04 05:20:20.000000000","message":"Soft: put a blank line before 46. Otherwise, visually it may read as one if..else..something_else statement.","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b57f1f6e45c3b3e57c6206577bc5db1286fcfde","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            data.update({\u0027workflow_id\u0027: workflow_identifier})"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            data.update({\u0027workflow_name\u0027: workflow_identifier})"},{"line_number":46,"context_line":"        if namespace:"},{"line_number":47,"context_line":"            data.update({\u0027workflow_namespace\u0027: namespace})"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if workflow_input:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_6e13360f","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":9},"in_reply_to":"df3967d1_e07afaee","updated":"2017-08-07 11:44:50.000000000","message":"Done","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"23491693099cc8d7bdf22206958614189d0bd412","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class ExecutionManager(base.ResourceManager):"},{"line_number":32,"context_line":"    resource_class \u003d Execution"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create(self, workflow_identifier, namespace\u003d\u0027\u0027, workflow_input\u003dNone,"},{"line_number":35,"context_line":"               description\u003d\u0027\u0027, **params):"},{"line_number":36,"context_line":"        self._ensure_not_empty(workflow_identifier\u003dworkflow_identifier)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_6f768441","line":34,"updated":"2018-02-16 15:33:16.000000000","message":"You do realise that when you mess with argument order, you break existing users of the API, right? And that they\u0027ll get weird random behaviour at runtime because this is Python and there\u0027s no type checking.\n\nIn a Python3-only project you could made everything except the workflow_identifier a keyword-only argument. Until then, don\u0027t do this.","commit_id":"db428c0858a3e786f5fd8fc3db544f9220b31afa"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5a2e5e234bdca7eebee00936899a5bf31e14023a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class ExecutionManager(base.ResourceManager):"},{"line_number":32,"context_line":"    resource_class \u003d Execution"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create(self, workflow_identifier, namespace\u003d\u0027\u0027, workflow_input\u003dNone,"},{"line_number":35,"context_line":"               description\u003d\u0027\u0027, **params):"},{"line_number":36,"context_line":"        self._ensure_not_empty(workflow_identifier\u003dworkflow_identifier)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_29406307","line":34,"in_reply_to":"3fa0c359_6f768441","updated":"2018-02-18 10:06:58.000000000","message":"Zane, this is our mistake indeed. We somehow overlooked it together. But it was merged a cycle ago and I feel that we shouldn\u0027t roll it back now because since then we got people who use this order of args. It\u0027s probably more like a lesson to learn: we need to do a better job when reviewing such things.\n\nBut we will still discuss with the team what we can do to mitigate this.","commit_id":"db428c0858a3e786f5fd8fc3db544f9220b31afa"}],"mistralclient/api/v2/workflows.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"dd2ca5b000f48aa5b2f587d6c93c2a5995676961","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def delete(self, identifier, namespace\u003dNone):"},{"line_number":113,"context_line":"        self._ensure_not_empty(identifier\u003didentifier)"},{"line_number":114,"context_line":"        path \u003d \u0027/workflows/%s\u0027 % identifier"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if namespace:"},{"line_number":117,"context_line":"            path \u003d path + \u0027?namespace\u003d%s\u0027 % namespace"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_c068161e","line":114,"updated":"2017-08-04 05:20:20.000000000","message":"Soft: let\u0027s please separate precondition checks from other code with blank lines.","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b57f1f6e45c3b3e57c6206577bc5db1286fcfde","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def delete(self, identifier, namespace\u003dNone):"},{"line_number":113,"context_line":"        self._ensure_not_empty(identifier\u003didentifier)"},{"line_number":114,"context_line":"        path \u003d \u0027/workflows/%s\u0027 % identifier"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if namespace:"},{"line_number":117,"context_line":"            path \u003d path + \u0027?namespace\u003d%s\u0027 % namespace"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_ae323ea6","line":114,"in_reply_to":"df3967d1_c068161e","updated":"2017-08-07 11:44:50.000000000","message":"Done","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"}],"mistralclient/commands/v2/executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"dd2ca5b000f48aa5b2f587d6c93c2a5995676961","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \u0027--namespace\u0027,"},{"line_number":181,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":182,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":183,"context_line":"            help\u003d\"Parent task execution ID associated with workflow \""},{"line_number":184,"context_line":"                 \"execution list.\","},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_00df3ed6","line":183,"range":{"start_line":183,"start_character":18,"end_line":183,"end_character":42},"updated":"2017-08-04 05:20:20.000000000","message":"Wrong help message, please fix it.","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b57f1f6e45c3b3e57c6206577bc5db1286fcfde","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \u0027--namespace\u0027,"},{"line_number":181,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":182,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":183,"context_line":"            help\u003d\"Parent task execution ID associated with workflow \""},{"line_number":184,"context_line":"                 \"execution list.\","},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_8e409a09","line":183,"range":{"start_line":183,"start_character":18,"end_line":183,"end_character":42},"in_reply_to":"df3967d1_00df3ed6","updated":"2017-08-07 11:44:50.000000000","message":"Thanks,\n\nBTW, Do you think we should call this flag workflow_namespace instead? in order to match workflow_identifier (This will also leave namespace open for future use).","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"}],"mistralclient/commands/v2/workflows.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"dd2ca5b000f48aa5b2f587d6c93c2a5995676961","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            \u0027--namespace\u0027,"},{"line_number":120,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":121,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":122,"context_line":"            help\u003d\"Parent task execution ID associated with workflow \""},{"line_number":123,"context_line":"                 \"execution list.\","},{"line_number":124,"context_line":"        )"},{"line_number":125,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_a0ce322a","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":42},"updated":"2017-08-04 05:20:20.000000000","message":"Wrong help message. Please fix it.","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"},{"author":{"_account_id":9408,"name":"Michal Gershenzon","email":"michal.gershenzon@gmail.com","username":"Mgershen"},"change_message_id":"5b57f1f6e45c3b3e57c6206577bc5db1286fcfde","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            \u0027--namespace\u0027,"},{"line_number":120,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":121,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":122,"context_line":"            help\u003d\"Parent task execution ID associated with workflow \""},{"line_number":123,"context_line":"                 \"execution list.\","},{"line_number":124,"context_line":"        )"},{"line_number":125,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_6e2c5647","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":42},"in_reply_to":"df3967d1_a0ce322a","updated":"2017-08-07 11:44:50.000000000","message":"Done","commit_id":"64262c5ace723beda18c0d8bae8e358156a58aa7"}]}