)]}'
{"mistralclient/api/v2/action_executions.py":[{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"11898dfcb999c3e8ccde3fb948113d30504f4883","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            qparams[\u0027limit\u0027] \u003d limit"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        query_string \u003d (\"?%s\" % urlparse.urlencode(list(qparams.items()))"},{"line_number":83,"context_line":"                        if qparams else \"\")"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return self._list(url % query_string, response_key\u003d\u0027action_executions\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_9d79cb94","line":83,"updated":"2017-08-01 07:20:43.000000000","message":"would you be opposed to changing it to a regular if then clause?\nit makes more cleared debugging IMO","commit_id":"49ae284528790cbf39fb57a95f98845083b0455d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"f3d27d9c914fe3625bc86ce800d8a9a297cd6416","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            qparams[\u0027limit\u0027] \u003d limit"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        query_string \u003d (\"?%s\" % urlparse.urlencode(list(qparams.items()))"},{"line_number":83,"context_line":"                        if qparams else \"\")"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return self._list(url % query_string, response_key\u003d\u0027action_executions\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_a972bf79","line":83,"in_reply_to":"df3967d1_9d79cb94","updated":"2017-08-03 08:40:14.000000000","message":"Looks fancy? :) To me it\u0027s kind of ok. It\u0027s what we have in other resource managers too.","commit_id":"49ae284528790cbf39fb57a95f98845083b0455d"}],"mistralclient/tests/unit/v2/test_action_executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b6a346ead519e26a03c9f849c3b1540e8f4a9477","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.assertEqual(expected, action_execution.to_dict())"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_list_with_limit(self):"},{"line_number":98,"context_line":"        self.requests_mock.get(self.TEST_URL + URL_TEMPLATE,"},{"line_number":99,"context_line":"                               json\u003d{\u0027action_executions\u0027: [ACTION_EXEC]})"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_1d65dbe1","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":28},"updated":"2017-08-01 07:19:25.000000000","message":"Sharat, I think this test is not enough. What does it check? You use a mock that returns just one action execution and you test with limit 1. Do you think it\u0027s ok? I think it\u0027s strange.\n\nPlease fix this and also write a real functional test for all changes you made around \"--limit\" parameter. For action executions, task executions and workflow executions. For latter two it\u0027s ok to send a new patch.","commit_id":"49ae284528790cbf39fb57a95f98845083b0455d"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"9f9b739bf1d18fb921767b5e2b0e122a321803ab","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.assertEqual(expected, action_execution.to_dict())"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_list_with_limit(self):"},{"line_number":98,"context_line":"        self.requests_mock.get(self.TEST_URL + URL_TEMPLATE,"},{"line_number":99,"context_line":"                               json\u003d{\u0027action_executions\u0027: [ACTION_EXEC]})"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_e9ce87b2","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":28},"in_reply_to":"df3967d1_1d65dbe1","updated":"2017-08-03 08:37:22.000000000","message":"Ok, after having another look at the test I think it\u0027s ok. I just checks that \"limit\" is passed to the server correctly.","commit_id":"49ae284528790cbf39fb57a95f98845083b0455d"}]}