)]}'
{"mistralclient/commands/v2/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"50f8a19df74319b2071582f07df6a2c8803bb49c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def __init__(self):"},{"line_number":32,"context_line":"        pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    FORMATTER_FIELDS \u003d ["},{"line_number":35,"context_line":"        \u0027id\u0027,"},{"line_number":36,"context_line":"        \u0027name\u0027,"},{"line_number":37,"context_line":"        \u0027workflow_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ea2a66e5","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":20},"updated":"2017-08-09 07:58:48.000000000","message":"Nice approach. I would improve it even more by keeping field names and column names together. E.g. it could be a list of tuples \u003cfield_name, column_name\u003e. That way any reordering could be safely made any time.\n\nI also think we should do a similar thing for all other commands too (not necessarily in this patch).","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":23211,"name":"Kupai József","email":"jozsef.kupai@nokia.com","username":"kupsef"},"change_message_id":"8809a93c12d3138d12c760da9963884bca69290e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def __init__(self):"},{"line_number":32,"context_line":"        pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    FORMATTER_FIELDS \u003d ["},{"line_number":35,"context_line":"        \u0027id\u0027,"},{"line_number":36,"context_line":"        \u0027name\u0027,"},{"line_number":37,"context_line":"        \u0027workflow_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a87106e3","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":20},"in_reply_to":"9f436f4f_ea2a66e5","updated":"2017-08-09 09:26:20.000000000","message":"Done","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"50f8a19df74319b2071582f07df6a2c8803bb49c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                task.updated_at or \u0027\u003cnone\u003e\u0027"},{"line_number":75,"context_line":"            )"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            data \u003d (tuple(\u0027\u003cnone\u003e\u0027 for _ in range(len(columns))),)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return columns, data"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_cae1e2d2","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":33},"updated":"2017-08-09 07:58:48.000000000","message":"It was changed in https://review.openstack.org/#/c/489726/. We (reviewers) decided that the change was ok. Is there a strong reason why you put \"\u003cnone\u003e\" back?","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"21a9e13f376d0483b2de17947dc2e23898625fc9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                task.updated_at or \u0027\u003cnone\u003e\u0027"},{"line_number":75,"context_line":"            )"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            data \u003d (tuple(\u0027\u003cnone\u003e\u0027 for _ in range(len(columns))),)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return columns, data"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_0ac24a34","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":34},"updated":"2017-08-09 08:00:19.000000000","message":"probably not backward compatible change","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"c05fb28dbdd4c7b2c6361cb45bdffbf62465b385","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                task.updated_at or \u0027\u003cnone\u003e\u0027"},{"line_number":75,"context_line":"            )"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            data \u003d (tuple(\u0027\u003cnone\u003e\u0027 for _ in range(len(columns))),)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return columns, data"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_8a187a81","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":34},"in_reply_to":"9f436f4f_0ac24a34","updated":"2017-08-09 08:08:14.000000000","message":"Yeah, but it\u0027s essentially a user interface, not an API change )","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":23211,"name":"Kupai József","email":"jozsef.kupai@nokia.com","username":"kupsef"},"change_message_id":"8809a93c12d3138d12c760da9963884bca69290e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                task.updated_at or \u0027\u003cnone\u003e\u0027"},{"line_number":75,"context_line":"            )"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            data \u003d (tuple(\u0027\u003cnone\u003e\u0027 for _ in range(len(columns))),)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return columns, data"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_48805a8c","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":34},"in_reply_to":"9f436f4f_8a187a81","updated":"2017-08-09 09:26:20.000000000","message":"I just messed up my conflict resolution. Nice catch.","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"b226f75e98b26d62a12303c882bc937a1fe10feb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    COLUMNS \u003d ["},{"line_number":35,"context_line":"        (\u0027id\u0027,                      \u0027ID\u0027),"},{"line_number":36,"context_line":"        (\u0027name\u0027,                    \u0027Name\u0027),"},{"line_number":37,"context_line":"        (\u0027workflow_name\u0027,           \u0027Workflow name\u0027),"},{"line_number":38,"context_line":"        (\u0027workflow_execution_id\u0027,   \u0027Execution ID\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_a84a267d","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":36},"updated":"2017-08-09 09:21:45.000000000","message":"Nice but I think pep8 won\u0027t pass it :)","commit_id":"5849261da19cb44208924d65853c8aece2771a88"},{"author":{"_account_id":23211,"name":"Kupai József","email":"jozsef.kupai@nokia.com","username":"kupsef"},"change_message_id":"ccce87ae1b64dc30718471882d9ff6294739dcf7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    COLUMNS \u003d ["},{"line_number":35,"context_line":"        (\u0027id\u0027,                      \u0027ID\u0027),"},{"line_number":36,"context_line":"        (\u0027name\u0027,                    \u0027Name\u0027),"},{"line_number":37,"context_line":"        (\u0027workflow_name\u0027,           \u0027Workflow name\u0027),"},{"line_number":38,"context_line":"        (\u0027workflow_execution_id\u0027,   \u0027Execution ID\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_de1e406f","line":35,"range":{"start_line":35,"start_character":14,"end_line":35,"end_character":36},"in_reply_to":"9f436f4f_a84a267d","updated":"2017-08-09 10:30:52.000000000","message":"I doubted it too, but pep8 passed locally:)","commit_id":"5849261da19cb44208924d65853c8aece2771a88"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"832d354b96d8123f3acd936115925c5497965b70","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class TaskFormatter(object):"},{"line_number":31,"context_line":"    def __init__(self):"},{"line_number":32,"context_line":"        pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    COLUMNS \u003d ["},{"line_number":35,"context_line":"        (\u0027id\u0027,                      \u0027ID\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_71730217","line":32,"updated":"2017-08-09 14:17:57.000000000","message":"The __init__ method can be deleted.","commit_id":"8c670adc78ff84afbd8e26033631c46b2bc32e7e"}],"mistralclient/tests/unit/v2/test_tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"50f8a19df74319b2071582f07df6a2c8803bb49c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            task.to_dict()"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_list_with_fields(self):"},{"line_number":54,"context_line":"        field_params \u003d \"?fields\u003did,name\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.requests_mock.get(self.TEST_URL + URL_TEMPLATE + field_params,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ca18c2d4","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":29},"updated":"2017-08-09 07:58:48.000000000","message":"I don\u0027t see any assertions. Is it just not finished?","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"},{"author":{"_account_id":23211,"name":"Kupai József","email":"jozsef.kupai@nokia.com","username":"kupsef"},"change_message_id":"8809a93c12d3138d12c760da9963884bca69290e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            task.to_dict()"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_list_with_fields(self):"},{"line_number":54,"context_line":"        field_params \u003d \"?fields\u003did,name\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.requests_mock.get(self.TEST_URL + URL_TEMPLATE + field_params,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_2856362b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":29},"in_reply_to":"9f436f4f_ca18c2d4","updated":"2017-08-09 09:26:20.000000000","message":"Done","commit_id":"1e22e6fd65234859319f2033a75a3a4068d7abc0"}]}