)]}'
{"mistralclient/shell.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"dfc635dc1e58c7cffd6a742acea6b1f6339aacf1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        parser.add_argument("},{"line_number":312,"context_line":"            \u0027--os-project-domain-name\u0027,"},{"line_number":313,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":314,"context_line":"            dest\u003d\u0027project_domain_name\u0027,"},{"line_number":315,"context_line":"            default\u003denv(\u0027OS_PROJECT_DOMAIN_NAME\u0027, \u0027OS_PROJECT_DOMAIN_ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_928795d8","line":312,"updated":"2017-08-23 13:50:22.000000000","message":"I think it might be more accurate to add --os-project-domain-id etc. Maybe we can do that with argparses aliases?","commit_id":"d79e094f7f25c006714f20ab4b9098041306030e"},{"author":{"_account_id":24064,"name":"Goutham Pratapa","email":"pratapagoutham@gmail.com","username":"GouthamPratapa"},"change_message_id":"ce7c6ca2ba92055a139a2be4bece5963cbd6ee32","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        parser.add_argument("},{"line_number":312,"context_line":"            \u0027--os-project-domain-name\u0027,"},{"line_number":313,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":314,"context_line":"            dest\u003d\u0027project_domain_name\u0027,"},{"line_number":315,"context_line":"            default\u003denv(\u0027OS_PROJECT_DOMAIN_NAME\u0027, \u0027OS_PROJECT_DOMAIN_ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a91a117a","line":312,"in_reply_to":"7f287b81_928795d8","updated":"2017-08-24 06:59:23.000000000","message":"Done","commit_id":"d79e094f7f25c006714f20ab4b9098041306030e"},{"author":{"_account_id":24064,"name":"Goutham Pratapa","email":"pratapagoutham@gmail.com","username":"GouthamPratapa"},"change_message_id":"a0a261070a9675d1554450ee1021e6a76d4393d1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        )"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        parser.add_argument("},{"line_number":312,"context_line":"            \u0027--os-project-domain-name\u0027,"},{"line_number":313,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":314,"context_line":"            dest\u003d\u0027project_domain_name\u0027,"},{"line_number":315,"context_line":"            default\u003denv(\u0027OS_PROJECT_DOMAIN_NAME\u0027, \u0027OS_PROJECT_DOMAIN_ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_4694c837","line":312,"in_reply_to":"7f287b81_928795d8","updated":"2017-08-23 16:49:41.000000000","message":"i will try that.\nIn the mean while we will see for the other comments and decide based on that..","commit_id":"d79e094f7f25c006714f20ab4b9098041306030e"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1040d9c299f9ed5b16b52961c28195948f2e9615","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            \u0027cert\u0027: self.options.os_cert,"},{"line_number":591,"context_line":"            \u0027key\u0027: self.options.os_key,"},{"line_number":592,"context_line":"            \u0027user_domain_name\u0027:"},{"line_number":593,"context_line":"                self.options.user_domain_name or"},{"line_number":594,"context_line":"                self.options.user_domain_id,"},{"line_number":595,"context_line":"            \u0027project_domain_name\u0027:"},{"line_number":596,"context_line":"                self.options.project_domain_name or"},{"line_number":597,"context_line":"                self.options.project_domain_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_ffa619ab","line":594,"range":{"start_line":593,"start_character":16,"end_line":594,"end_character":43},"updated":"2017-08-29 09:41:06.000000000","message":"I\u0027m not sure this is right to use \"OR\" here. By doing that we attempt to guess what parameter takes precedence over another at the client side. If you look at the class BaseGenericPlugin from keystoneauth1 project you\u0027ll see that it takes parameters \"project_domain_id\" and \"project_domain_name\".\n\nWhat I mean is that we probably need to pass both params to keystone auth plugins so that they decide how to use them. No? For example, Password auth plugin uses both \"user_domain_name\" and \"user_domain_id\".","commit_id":"fd7aff0913cf6d2c395b070f935790eba9aa50d3"},{"author":{"_account_id":24064,"name":"Goutham Pratapa","email":"pratapagoutham@gmail.com","username":"GouthamPratapa"},"change_message_id":"ec7b48e8f29d3fbb26407e7b195101cae8dad2dd","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            \u0027cert\u0027: self.options.os_cert,"},{"line_number":591,"context_line":"            \u0027key\u0027: self.options.os_key,"},{"line_number":592,"context_line":"            \u0027user_domain_name\u0027:"},{"line_number":593,"context_line":"                self.options.user_domain_name or"},{"line_number":594,"context_line":"                self.options.user_domain_id,"},{"line_number":595,"context_line":"            \u0027project_domain_name\u0027:"},{"line_number":596,"context_line":"                self.options.project_domain_name or"},{"line_number":597,"context_line":"                self.options.project_domain_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_5ad1b822","line":594,"range":{"start_line":593,"start_character":16,"end_line":594,"end_character":43},"in_reply_to":"7f287b81_258fee75","updated":"2017-08-29 12:25:12.000000000","message":"No, it is there for project_domain_name and project_domain_id in the BaseGenericPlugin.","commit_id":"fd7aff0913cf6d2c395b070f935790eba9aa50d3"},{"author":{"_account_id":24064,"name":"Goutham Pratapa","email":"pratapagoutham@gmail.com","username":"GouthamPratapa"},"change_message_id":"7a19a31c40acbb36a3ccecc19fa2d041acaa70a5","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            \u0027cert\u0027: self.options.os_cert,"},{"line_number":591,"context_line":"            \u0027key\u0027: self.options.os_key,"},{"line_number":592,"context_line":"            \u0027user_domain_name\u0027:"},{"line_number":593,"context_line":"                self.options.user_domain_name or"},{"line_number":594,"context_line":"                self.options.user_domain_id,"},{"line_number":595,"context_line":"            \u0027project_domain_name\u0027:"},{"line_number":596,"context_line":"                self.options.project_domain_name or"},{"line_number":597,"context_line":"                self.options.project_domain_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_8a069551","line":594,"range":{"start_line":593,"start_character":16,"end_line":594,"end_character":43},"in_reply_to":"7f287b81_ffa619ab","updated":"2017-08-30 06:49:47.000000000","message":"Done Please review the patch update :)","commit_id":"fd7aff0913cf6d2c395b070f935790eba9aa50d3"},{"author":{"_account_id":24064,"name":"Goutham Pratapa","email":"pratapagoutham@gmail.com","username":"GouthamPratapa"},"change_message_id":"524f394a46614cf984c50a4aeb2ba34b2e740720","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            \u0027cert\u0027: self.options.os_cert,"},{"line_number":591,"context_line":"            \u0027key\u0027: self.options.os_key,"},{"line_number":592,"context_line":"            \u0027user_domain_name\u0027:"},{"line_number":593,"context_line":"                self.options.user_domain_name or"},{"line_number":594,"context_line":"                self.options.user_domain_id,"},{"line_number":595,"context_line":"            \u0027project_domain_name\u0027:"},{"line_number":596,"context_line":"                self.options.project_domain_name or"},{"line_number":597,"context_line":"                self.options.project_domain_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_258fee75","line":594,"range":{"start_line":593,"start_character":16,"end_line":594,"end_character":43},"in_reply_to":"7f287b81_ffa619ab","updated":"2017-08-29 10:52:59.000000000","message":"Ok, This option is there only for user_domain_name and user_domain_id so changes have to be made in \nmistralclient/auth/keystone.py as well to send user_domain_name and user_domain_id to keystone auth plugin.","commit_id":"fd7aff0913cf6d2c395b070f935790eba9aa50d3"}]}
