)]}'
{"mistralclient/auth/keystone.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1378ca126dc0024aa911433dbc2cf89c6abda2b4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        nontarget_params, target_params \u003d self._separate_target_reqs(req)"},{"line_number":38,"context_line":"        reqs \u003d [nontarget_params, target_params]"},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            result \u003d self._authenticate(reqs, session)"},{"line_number":41,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_54853059","line":38,"range":{"start_line":38,"start_character":15,"end_line":38,"end_character":48},"updated":"2018-01-15 10:55:31.000000000","message":"Maybe I don\u0027t understand why we need this extra list. I think _separate_target_reqs() could already return a list, if needed.","commit_id":"ab8f87e58deb1f35e6c1d0e781f5e5bd46403ea0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1378ca126dc0024aa911433dbc2cf89c6abda2b4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def _authenticate(self, reqs, session\u003dNone):"},{"line_number":138,"context_line":"        \"\"\"Performs authentication via Keystone."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :param req: Request dict containing list of parameters required"},{"line_number":141,"context_line":"            for Keystone authentication."},{"line_number":142,"context_line":"        :return: Auth response dict"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_1436c853","line":140,"range":{"start_line":140,"start_character":15,"end_line":140,"end_character":18},"updated":"2018-01-15 10:55:31.000000000","message":"This should be \"reqs\" and the doc string should explain how these two requests are used I think.","commit_id":"ab8f87e58deb1f35e6c1d0e781f5e5bd46403ea0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1378ca126dc0024aa911433dbc2cf89c6abda2b4","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        The value of verify can be either True/False or a cacert."},{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":"        if insecure is False:"},{"line_number":239,"context_line":"            verify \u003d cacert or True"},{"line_number":240,"context_line":"        else:"},{"line_number":241,"context_line":"            verify \u003d False"},{"line_number":242,"context_line":"        return verify"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @staticmethod"},{"line_number":245,"context_line":"    def _is_serviceCatalogV2(catalog):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_3404247b","line":242,"range":{"start_line":238,"start_character":8,"end_line":242,"end_character":21},"updated":"2018-01-15 10:55:31.000000000","message":"Can we replace it with one boolean expression? :)","commit_id":"ab8f87e58deb1f35e6c1d0e781f5e5bd46403ea0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1378ca126dc0024aa911433dbc2cf89c6abda2b4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return verify"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @staticmethod"},{"line_number":245,"context_line":"    def _is_serviceCatalogV2(catalog):"},{"line_number":246,"context_line":"        \"\"\"Check if the service catalog is of type ServiceCatalogV2"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        :param catalog: the service catalog"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_742f0cf6","line":245,"range":{"start_line":245,"start_character":8,"end_line":245,"end_character":28},"updated":"2018-01-15 10:55:31.000000000","message":"_is_service_catalog_v2?","commit_id":"ab8f87e58deb1f35e6c1d0e781f5e5bd46403ea0"}]}