)]}'
{"mistralclient/api/httpclient.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"68ae0f391f238a1857a6f5703ac323e6e934887b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        options[\u0027headers\u0027] \u003d headers"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            content_type \u003d headers[\u0027content-type\u0027]"},{"line_number":145,"context_line":"        except KeyError:"},{"line_number":146,"context_line":"            content_type \u003d None"},{"line_number":147,"context_line":"        options[\u0027data\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_0e542e52","line":144,"updated":"2018-01-31 11:27:01.000000000","message":"I would prefer `content_type \u003d headers.get(\u0027content-type\u0027)` which will return None if it isn\u0027t found.","commit_id":"464c5811f92559608ec21ed00da2040b9e42bebd"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"68ae0f391f238a1857a6f5703ac323e6e934887b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return options"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _update_body_with_service_catalog(self, body, content_type):"},{"line_number":153,"context_line":"        if self.target_service_catalog:"},{"line_number":154,"context_line":"            if content_type \u003d\u003d \u0027application/json\u0027:"},{"line_number":155,"context_line":"                loaded \u003d json.loads(body)"},{"line_number":156,"context_line":"                loaded[\"service_catalog\"] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_89bef8b1","line":153,"updated":"2018-01-31 11:27:01.000000000","message":"If you change this to a negative assertion you could return early and remove some indentation.\n\nif not self.target_service_catalog:\n    return body","commit_id":"464c5811f92559608ec21ed00da2040b9e42bebd"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"68ae0f391f238a1857a6f5703ac323e6e934887b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    base64.b64encode("},{"line_number":158,"context_line":"                        self.target_service_catalog.encode(\u0027utf-8\u0027)"},{"line_number":159,"context_line":"                    )"},{"line_number":160,"context_line":"                # python3"},{"line_number":161,"context_line":"                for k in loaded:"},{"line_number":162,"context_line":"                    try:"},{"line_number":163,"context_line":"                        loaded[k] \u003d loaded[k].decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_09cae84c","line":160,"range":{"start_line":160,"start_character":16,"end_line":160,"end_character":25},"updated":"2018-01-31 11:27:01.000000000","message":"python3? Can you provide more detail?","commit_id":"464c5811f92559608ec21ed00da2040b9e42bebd"}]}
