)]}'
{"mistralclient/api/base.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"95709fa351d2b38ab82e3151bcffb5ad335f0d1c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.http_client \u003d http_client"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def find(self, **kwargs):"},{"line_number":77,"context_line":"        return [i for i in self._list() if _check_items(i, kwargs.items())]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _build_query_params(marker\u003dNone, limit\u003dNone, sort_keys\u003dNone,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5fc1f717_b98a24bc","line":77,"range":{"start_line":77,"start_character":32,"end_line":77,"end_character":33},"updated":"2019-03-13 13:24:16.000000000","message":"looks like this is changed by mistake. as _list needs a url, seeing some issue in tripleo job:- \n0\u003e _create_client /usr/lib/python2.7/site-packages/mistral/actions/openstack/actions.py:259\n2019-03-13 00:30:51.475 8 WARNING mistral.actions.openstack.base [req-78fd3116-8264-4558-9acb-5a32ef467209 5910d27345e24b2186820b8751af1ff9 3d3746122a4f46c6ba71c23829573997 - default default] Traceback (most recent call last):\n  File \"/usr/lib/python2.7/site-packages/mistral/actions/openstack/base.py\", line 117, in run\n    result \u003d method(**self._kwargs_for_run)\n  File \"/usr/lib/python2.7/site-packages/mistralclient/api/base.py\", line 77, in find\n    return [i for i in self._list() if _check_items(i, kwargs.items())]\nTypeError: _list() takes at least 2 arguments (1 given)\n\nExample log:- https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset010-master/9ee209e/logs/undercloud/var/log/extra/errors.txt.txt.gz#_2019-03-13_00_30_51_476","commit_id":"d53da3629f95a0319d496b66dc2ae1c322aa52b9"}],"mistralclient/api/v2/action_executions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e7d96517913ef153b0d1fd66865080899ff29246","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._update(\u0027/action_executions/%s\u0027 % id, data)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def list(self, task_execution_id\u003dNone, marker\u003d\u0027\u0027, fields\u003dNone, limit\u003dNone,"},{"line_number":63,"context_line":"             sort_keys\u003d\u0027\u0027, sort_dirs\u003d\u0027\u0027, **filters):"},{"line_number":64,"context_line":"        url \u003d \u0027/action_executions\u0027"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_d1ac43ed","line":62,"range":{"start_line":62,"start_character":43,"end_line":62,"end_character":49},"updated":"2018-11-13 13:04:10.000000000","message":"It would be better if \"limit\" was the second arg here. Then if anyone is calling .list(ID, 100) the behaviour would be the same. Otherwise it will now pass \"100\" to the marker.","commit_id":"6ecaa2f13d8cf236a2a7f872f5cdf027a1defccc"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"cfc732b8978f33bb1c6550fb55c17aa904cd0415","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        url +\u003d \"%s\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        query_string \u003d self._build_query_params(marker\u003dmarker, limit\u003dlimit,"},{"line_number":72,"context_line":"                                                sort_keys\u003dsort_keys,"},{"line_number":73,"context_line":"                                                sort_dirs\u003dsort_dirs,"},{"line_number":74,"context_line":"                                                fields\u003dfields,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_4183be4f","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":74},"updated":"2018-11-27 06:41:40.000000000","message":"Soft: please try not to put many params on a single line. It\u0027s not a strict requirement but I find the following very readable:\n\nquery_string \u003d self._build_query_params(\n    marker\u003dmarker,\n    limit\u003dlimit,\n    ....\n    filters\u003dfilters\n)\n\nIf you decide to change it, please do it with all other files too.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"aa1e5c8f83a17b5116c744f2517f19a1dbf41a3f","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        url +\u003d \"%s\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        query_string \u003d self._build_query_params(marker\u003dmarker, limit\u003dlimit,"},{"line_number":72,"context_line":"                                                sort_keys\u003dsort_keys,"},{"line_number":73,"context_line":"                                                sort_dirs\u003dsort_dirs,"},{"line_number":74,"context_line":"                                                fields\u003dfields,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_c3aff9c5","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":74},"in_reply_to":"3f79a3b5_4183be4f","updated":"2018-12-20 03:52:43.000000000","message":"Done","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"}],"mistralclient/commands/v2/action_executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"cfc732b8978f33bb1c6550fb55c17aa904cd0415","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        (\u0027updated_at\u0027, \u0027Updated at\u0027),"},{"line_number":41,"context_line":"    ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    COLUMN_FIELD_NAMES \u003d list(zip(*COLUMNS))[0]"},{"line_number":44,"context_line":"    COLUMN_HEADING_NAMES \u003d list(zip(*COLUMNS))[1]"},{"line_number":45,"context_line":"    LIST_COLUMNS \u003d [c for c in COLUMNS if c !\u003d (\u0027state_info\u0027, \u0027State info\u0027)]"},{"line_number":46,"context_line":"    LIST_COLUMN_FIELD_NAMES \u003d list(zip(*LIST_COLUMNS))[0]"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_413c1ebc","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":29},"updated":"2018-11-27 06:41:40.000000000","message":"Seems like \u0027list\u0027 here is redundant, \u0027zip\u0027 already returns a list of tuples. Same applies to other lines where a similar expression is used. Maybe it\u0027s simpler just do [c[0] for c in COLUMNS] ? IMO, \u0027zip\u0027 doesn\u0027t make code more readable. The only difference is that you\u0027ll get a list in this case, not a tuple. But I think list is even more convenient structure.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"aa1e5c8f83a17b5116c744f2517f19a1dbf41a3f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        (\u0027updated_at\u0027, \u0027Updated at\u0027),"},{"line_number":41,"context_line":"    ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    COLUMN_FIELD_NAMES \u003d list(zip(*COLUMNS))[0]"},{"line_number":44,"context_line":"    COLUMN_HEADING_NAMES \u003d list(zip(*COLUMNS))[1]"},{"line_number":45,"context_line":"    LIST_COLUMNS \u003d [c for c in COLUMNS if c !\u003d (\u0027state_info\u0027, \u0027State info\u0027)]"},{"line_number":46,"context_line":"    LIST_COLUMN_FIELD_NAMES \u003d list(zip(*LIST_COLUMNS))[0]"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_43c44993","line":43,"range":{"start_line":43,"start_character":25,"end_line":43,"end_character":29},"in_reply_to":"3f79a3b5_413c1ebc","updated":"2018-12-20 03:52:43.000000000","message":"Done (refactored)","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"cfc732b8978f33bb1c6550fb55c17aa904cd0415","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    COLUMN_FIELD_NAMES \u003d list(zip(*COLUMNS))[0]"},{"line_number":44,"context_line":"    COLUMN_HEADING_NAMES \u003d list(zip(*COLUMNS))[1]"},{"line_number":45,"context_line":"    LIST_COLUMNS \u003d [c for c in COLUMNS if c !\u003d (\u0027state_info\u0027, \u0027State info\u0027)]"},{"line_number":46,"context_line":"    LIST_COLUMN_FIELD_NAMES \u003d list(zip(*LIST_COLUMNS))[0]"},{"line_number":47,"context_line":"    LIST_COLUMN_HEADING_NAMES \u003d list(zip(*LIST_COLUMNS))[1]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_0174e699","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":9},"updated":"2018-11-27 06:41:40.000000000","message":"Not sure why we need the same thing in two forms.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"aa1e5c8f83a17b5116c744f2517f19a1dbf41a3f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    COLUMN_FIELD_NAMES \u003d list(zip(*COLUMNS))[0]"},{"line_number":44,"context_line":"    COLUMN_HEADING_NAMES \u003d list(zip(*COLUMNS))[1]"},{"line_number":45,"context_line":"    LIST_COLUMNS \u003d [c for c in COLUMNS if c !\u003d (\u0027state_info\u0027, \u0027State info\u0027)]"},{"line_number":46,"context_line":"    LIST_COLUMN_FIELD_NAMES \u003d list(zip(*LIST_COLUMNS))[0]"},{"line_number":47,"context_line":"    LIST_COLUMN_HEADING_NAMES \u003d list(zip(*LIST_COLUMNS))[1]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_03bad10a","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":9},"in_reply_to":"3f79a3b5_0174e699","updated":"2018-12-20 03:52:43.000000000","message":"There are a couple of cases where the columns in a list command are different than the fields provided by a get command.  There is probably a better way to do this.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"}],"mistralclient/commands/v2/base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"cfc732b8978f33bb1c6550fb55c17aa904cd0415","unresolved":false,"context_lines":[{"line_number":102,"context_line":"class MistralExecutionLister(MistralLister):"},{"line_number":103,"context_line":"    def get_parser(self, parsed_args):"},{"line_number":104,"context_line":"        parser \u003d super(MistralExecutionLister, self).get_parser(parsed_args)"},{"line_number":105,"context_line":"        parser.set_defaults(limit\u003dDEFAULT_LIMIT)"},{"line_number":106,"context_line":"        parser.add_argument("},{"line_number":107,"context_line":"            \u0027--oldest\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Display the executions starting from the oldest entries \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_c1210e50","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":48},"updated":"2018-11-27 06:41:40.000000000","message":"So this should provide backwards compatibility around \"limit\" parameter for executions, right? It was a pretty important change to have a default value for \"limit\" so that we accidentally don\u0027t fetch millions of entries from the server.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"aa1e5c8f83a17b5116c744f2517f19a1dbf41a3f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"class MistralExecutionLister(MistralLister):"},{"line_number":103,"context_line":"    def get_parser(self, parsed_args):"},{"line_number":104,"context_line":"        parser \u003d super(MistralExecutionLister, self).get_parser(parsed_args)"},{"line_number":105,"context_line":"        parser.set_defaults(limit\u003dDEFAULT_LIMIT)"},{"line_number":106,"context_line":"        parser.add_argument("},{"line_number":107,"context_line":"            \u0027--oldest\u0027,"},{"line_number":108,"context_line":"            help\u003d\u0027Display the executions starting from the oldest entries \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_83cee1b3","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":48},"in_reply_to":"3f79a3b5_c1210e50","updated":"2018-12-20 03:52:43.000000000","message":"Yes - this sets the default for the limit argument to DEFAULT_LIMIT, but only for resources that use the ExecutionLister.  All other resources will have no default for limit.","commit_id":"dc06a9d3f67417c240e81a4ebb01470993df6955"}],"mistralclient/tests/functional/cli/v2/test_cli_v2.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e7d96517913ef153b0d1fd66865080899ff29246","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        wf_execs \u003d self.mistral_cli("},{"line_number":849,"context_line":"            True,"},{"line_number":850,"context_line":"            \u0027execution-list\u0027,"},{"line_number":851,"context_line":"            params\u003d\"--sort_keys Description --sort_dirs desc\""},{"line_number":852,"context_line":"        )"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        self.assertIn(wf_ex1_id, [ex[\u0027ID\u0027] for ex in wf_execs])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_d1852355","line":851,"range":{"start_line":851,"start_character":55,"end_line":851,"end_character":56},"updated":"2018-11-13 13:04:10.000000000","message":"Can we no longer use \"\u003d\"?","commit_id":"6ecaa2f13d8cf236a2a7f872f5cdf027a1defccc"},{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"a03c17b77b2921f9c7ed7576ab28c3f8f7ee2fc8","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        wf_execs \u003d self.mistral_cli("},{"line_number":849,"context_line":"            True,"},{"line_number":850,"context_line":"            \u0027execution-list\u0027,"},{"line_number":851,"context_line":"            params\u003d\"--sort_keys Description --sort_dirs desc\""},{"line_number":852,"context_line":"        )"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        self.assertIn(wf_ex1_id, [ex[\u0027ID\u0027] for ex in wf_execs])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_74819dfd","line":851,"range":{"start_line":851,"start_character":55,"end_line":851,"end_character":56},"in_reply_to":"3f79a3b5_d1852355","updated":"2018-11-13 13:57:53.000000000","message":"Either will work - I\u0027ll revert this so both get tested","commit_id":"6ecaa2f13d8cf236a2a7f872f5cdf027a1defccc"}]}
