)]}'
{"id":"openstack%2Fpython-mistralclient~566469","triplet_id":"openstack%2Fpython-mistralclient~master~I2fe2bad962255e5f4f8df69dcac610276482f099","project":"openstack/python-mistralclient","branch":"master","topic":"bug/1769491","hashtags":[],"change_id":"I2fe2bad962255e5f4f8df69dcac610276482f099","subject":"Adding environment-get-definition for easy environment-update","status":"MERGED","created":"2018-05-06 17:49:24.000000000","updated":"2018-06-04 13:59:21.000000000","submitted":"2018-05-16 11:54:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"566469-1526471651590-4337d0c3","meta_rev_id":"7e49f164b8867c880d85ff940b08cf512c7be874","_number":566469,"virtual_id_number":566469,"owner":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":0,"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"date":"2018-05-10 08:55:08.000000000","_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"date":"2018-05-10 12:52:45.000000000","_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},{"value":2,"date":"2018-05-16 11:54:11.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},{"value":0,"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"all":[{"value":2,"date":"2018-05-16 09:32:05.000000000","_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":2,"date":"2018-05-16 09:39:46.000000000","_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-05-11 08:05:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},{"value":1,"date":"2018-05-11 12:09:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"all":[{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":1,"date":"2018-05-16 09:39:42.000000000","_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},{"value":0,"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-10 08:55:08.000000000","updated_by":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"reviewer":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"state":"REVIEWER"},{"updated":"2018-05-11 08:05:17.000000000","updated_by":{"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},"reviewer":{"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},"state":"REVIEWER"},{"updated":"2018-05-11 12:09:58.000000000","updated_by":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"reviewer":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"state":"REVIEWER"},{"updated":"2018-05-16 09:32:05.000000000","updated_by":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"reviewer":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"state":"REVIEWER"},{"updated":"2018-05-16 09:39:42.000000000","updated_by":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"reviewer":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"state":"REVIEWER"},{"updated":"2018-05-16 11:54:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"57c031ce0e8f9459a39f873cf4af89b1f165c739","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-06 17:49:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"543ab89693397d23778380cb0ac091496d5a1628","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-06 19:04:50.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"331c202957f032776fb111ff84f3a67c19eaa2c7","author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"date":"2018-05-06 20:12:12.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThe change makes sense but I think it belongs in a new command - environment-get-definition maybe?","accounts_in_message":[],"_revision_number":2},{"id":"70943ecb2e4438549e40064422a7bb4878e856af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-06 21:11:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/2/check/openstack-tox-pep8/31a86ed/ : SUCCESS in 3m 51s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/2/check/openstack-tox-py27/14c0964/ : SUCCESS in 4m 11s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/2/check/openstack-tox-py35/9b8502b/ : SUCCESS in 3m 50s\n- openstackclient-check-plugins http://logs.openstack.org/69/566469/2/check/openstackclient-check-plugins/4a66689/ : SUCCESS in 5m 46s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/2/check/build-openstack-sphinx-docs/0cb5278/html/ : SUCCESS in 3m 35s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/2/check/python-mistralclient-devstack-dsvm/3bdd201/ : FAILURE in 47m 54s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0c09335/ : SUCCESS in 2h 02m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/2/check/openstack-tox-lower-constraints/0d06a32/ : SUCCESS in 5m 05s","accounts_in_message":[],"_revision_number":2},{"id":"5b8da846f4d6a2630e16a429d58d464ae9b33d86","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-06 22:23:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"290459fe7ffbca50760cb1baa4aee1d534b13fe2","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-06 22:25:04.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n \u003e \n \u003e The change makes sense but I think it belongs in a new command -\n \u003e environment-get-definition maybe?\n\nThat makes sense, I have to agree with you.","accounts_in_message":[],"_revision_number":3},{"id":"6ab473314b5a1c068f1425c0e833ca246a69dc34","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-06 22:26:24.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"7d32002840354be3fdad780b3793772bd03559f8","author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"date":"2018-05-06 23:54:05.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)\n\nThanks for the update - a couple of comments inline.","accounts_in_message":[],"_revision_number":4},{"id":"ccedd72596f2f81d4b3fdacdae095c3ee5df049a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-07 00:32:17.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/4/check/openstack-tox-pep8/11469e7/ : FAILURE in 3m 58s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/4/check/openstack-tox-py27/7d9d725/ : SUCCESS in 3m 57s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/4/check/openstack-tox-py35/84cc8e3/ : SUCCESS in 4m 01s\n- openstackclient-check-plugins http://logs.openstack.org/69/566469/4/check/openstackclient-check-plugins/3f33f09/ : SUCCESS in 6m 31s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/4/check/build-openstack-sphinx-docs/0b48aca/html/ : SUCCESS in 5m 10s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/4/check/python-mistralclient-devstack-dsvm/082daad/ : SUCCESS in 41m 40s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/4/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/7188589/ : SUCCESS in 2h 03m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/4/check/openstack-tox-lower-constraints/e16b83f/ : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":4},{"id":"5a4df3cc2e550f85c7e96d31259d2f282a589d8c","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-07 01:30:28.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"905af56b0814cff11f91510c9a5a4581265bda10","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-07 01:32:36.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"6fc701e6570c0bbe8181f0c01f7dd9cfe75dfbac","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-07 01:37:28.000000000","message":"Patch Set 6:\n\n\u003e (2 comments)\n \u003e \n \u003e Thanks for the update - a couple of comments inline.\n\nBob,\n\nThanks for the very constructive feedback, I think that returning the columns data tuple allows the user to choose the format they want to work with. Let me know if I missed something.","accounts_in_message":[],"_revision_number":6},{"id":"8dc138e49e5d6bf1dec54ae022ba9498423adc2b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-07 03:55:44.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/6/check/openstack-tox-pep8/60027b9/ : FAILURE in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/6/check/openstack-tox-py27/bccee2c/ : SUCCESS in 3m 29s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/6/check/openstack-tox-py35/a5dcf18/ : SUCCESS in 3m 58s\n- openstackclient-check-plugins http://logs.openstack.org/69/566469/6/check/openstackclient-check-plugins/96a1c24/ : SUCCESS in 4m 55s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/6/check/build-openstack-sphinx-docs/4d6cbd1/html/ : SUCCESS in 3m 37s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/6/check/python-mistralclient-devstack-dsvm/560a3df/ : SUCCESS in 41m 10s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/6/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/e2c9ccb/ : SUCCESS in 2h 08m 16s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/6/check/openstack-tox-lower-constraints/9e9db32/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":6},{"id":"a6f3318db4d4722b221b003c04c06f82862fcd83","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-07 12:44:48.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"a18616306a89362a0ae24f42adb845a2400c71c1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-07 14:43:53.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/7/check/openstack-tox-pep8/fde9ab2/ : SUCCESS in 4m 10s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/7/check/openstack-tox-py27/0a86d82/ : SUCCESS in 4m 07s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/7/check/openstack-tox-py35/d47d701/ : SUCCESS in 4m 22s\n- openstackclient-check-plugins http://logs.openstack.org/69/566469/7/check/openstackclient-check-plugins/4cbdd26/ : SUCCESS in 6m 11s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/7/check/build-openstack-sphinx-docs/761262b/html/ : SUCCESS in 4m 15s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/7/check/python-mistralclient-devstack-dsvm/87ed8fc/ : FAILURE in 1h 01m 05s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/7/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/59e603b/ : SUCCESS in 1h 57m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/7/check/openstack-tox-lower-constraints/b6be5f2/ : SUCCESS in 6m 11s","accounts_in_message":[],"_revision_number":7},{"id":"4054866dc8680ca5cb702da054627875fa09c3b6","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-07 16:35:00.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"02101b6b188f7c91b7dee66047a704ab31c12762","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-07 19:31:40.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/7/check/openstack-tox-pep8/07758a8/ : SUCCESS in 4m 40s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/7/check/openstack-tox-py27/5333614/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/7/check/openstack-tox-py35/80ad972/ : SUCCESS in 4m 04s\n- openstackclient-check-plugins http://logs.openstack.org/69/566469/7/check/openstackclient-check-plugins/e68690e/ : SUCCESS in 6m 32s (non-voting)\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/7/check/build-openstack-sphinx-docs/e045b11/html/ : SUCCESS in 4m 20s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/7/check/python-mistralclient-devstack-dsvm/839de6e/ : SUCCESS in 42m 34s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/7/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/7b07802/ : SUCCESS in 2h 00m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/7/check/openstack-tox-lower-constraints/c20ed35/ : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":7},{"id":"4d68162ddfe3a64739f583b931deb444bad64eeb","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2018-05-10 08:55:08.000000000","message":"Patch Set 7:\n\nSeems OK except I\u0027m not 100% sure what the output of the \"environment-get-definition\" command is. Can you please print it here somewhere?\n\nJust looking at a semantically similar \"workflow-get-definition\" I see that we print just a workflow YAML text w/o any other fields of a workflow definition object. Just a text of the workflow. What would be a similar thing for an environment? Content of its \"variables\" field?However, here we seem to print some other fields (name, description, scope), basically similar to \"environment-get\" command but w/o timestamps and w/o using format() function.\n\nCan you elaborate more on that please?","accounts_in_message":[],"_revision_number":7},{"id":"3a178f094ed02a36d3392f4ed5b4bb0bdc3a630d","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-10 12:52:45.000000000","message":"Patch Set 7:\n\nHello Renat,\n\nThe initial goal of this is to have an import-friendly environment file. To import the environment, we need to have the variable names (scope, description and variables) in lower case and we need to not export the dates.\n\nThis is the output (truncated):\n$ mistral environment-get-definition -f yaml overcloud\nname: overcloud\ndescription: \u003cnone\u003e\nscope: private\nvariables: \u0027[...]\u0027","accounts_in_message":[],"_revision_number":7},{"id":"73883cec50edbef34ceaa4bf0d3d1ff82151abbe","author":{"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},"date":"2018-05-11 04:57:08.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"34b2d778e2abb104f5107a0327289d3850ccddeb","author":{"_account_id":25167,"name":"Qi Peng","email":"19921207pq@gmail.com","username":"pengdake"},"date":"2018-05-11 08:05:17.000000000","message":"Patch Set 7: -Code-Review\n\n\u003e Hello Renat,\n \u003e \n \u003e The initial goal of this is to have an import-friendly environment\n \u003e file. To import the environment, we need to have the variable names\n \u003e (scope, description and variables) in lower case and we need to not\n \u003e export the dates.\n \u003e \n \u003e This is the output (truncated):\n \u003e $ mistral environment-get-definition -f yaml overcloud\n \u003e name: overcloud\n \u003e description: \u003cnone\u003e\n \u003e scope: private\n \u003e variables: \u0027[...]\u0027\n\nI agree with Renat. Only variables is good enough. Otherwise, it is same as environment-get almost.","accounts_in_message":[],"_revision_number":7},{"id":"46b34a0f667098a65bf8e8cdd14a0d58d3d7ce32","author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"date":"2018-05-11 12:09:58.000000000","message":"Patch Set 7: Code-Review+1\n\nI like the fact that the name, scope and description are in included in the output of environment-get-definition.  I think it makes the environment definition files more portable, and since name and description are included in the definition of the workbook/workflow, it does not conflict with those commands.\n\nI would leave the output as it is.","accounts_in_message":[],"_revision_number":7},{"id":"82ba3e4512588e94404965a4a605ad71ce445815","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2018-05-16 09:32:05.000000000","message":"Patch Set 7: Code-Review+2\n\nI think this is okay. I wonder if it would be better to add a flag to environment-get? Maybe something like this?\n\n$ mistral environment-get -f json --export overcloud","accounts_in_message":[],"_revision_number":7},{"id":"1bebf10330b417a81a1d6ee1426f211813f7bd19","author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"date":"2018-05-16 09:39:42.000000000","message":"Patch Set 7: Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"84420b92a1d92aa5a06e142e2e5b0112ea0d32a5","author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"date":"2018-05-16 09:39:46.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"034f3b983db53d5e8db8b1d40f7a470827b7d211","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-16 09:39:54.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"00683031e6c69667ff8061757f636faa4e738049","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-16 11:54:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"d16c573f7e1cdce88dcd955073e560775ecbb4d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-16 11:54:11.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/566469/7/gate/openstack-tox-pep8/d4c290f/ : SUCCESS in 3m 48s\n- openstack-tox-py27 http://logs.openstack.org/69/566469/7/gate/openstack-tox-py27/af993f9/ : SUCCESS in 3m 21s\n- openstack-tox-py35 http://logs.openstack.org/69/566469/7/gate/openstack-tox-py35/62f6804/ : SUCCESS in 3m 47s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/566469/7/gate/build-openstack-sphinx-docs/17d402f/html/ : SUCCESS in 4m 37s\n- python-mistralclient-devstack-dsvm http://logs.openstack.org/69/566469/7/gate/python-mistralclient-devstack-dsvm/87a0668/ : SUCCESS in 41m 13s\n- tripleo-ci-centos-7-scenario003-multinode-oooq-container http://logs.openstack.org/69/566469/7/gate/tripleo-ci-centos-7-scenario003-multinode-oooq-container/8f151ff/ : SUCCESS in 2h 01m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/566469/7/gate/openstack-tox-lower-constraints/bdf3244/ : SUCCESS in 5m 23s","accounts_in_message":[],"_revision_number":7},{"id":"52e1145ffc32d9da5f1f9c58f42f4abc0674b3b2","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-18 13:51:50.000000000","message":"Patch Set 7: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit 53e1b72461b910bb05cc16417b082fc9181d0dfc","accounts_in_message":[],"_revision_number":7},{"id":"2f5252ee6efe336a1bfe42ef145d8b74f29f1856","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-18 13:52:14.000000000","message":"Patch Set 7: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit 3fb62f271bc4d3003e81644e5eb91df5b55f88fe","accounts_in_message":[],"_revision_number":7},{"id":"9bfb63e554c946d6fa37d7415d8438b9e31a57b6","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2018-05-18 13:54:32.000000000","message":"Patch Set 7: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ocata as commit eda27fefeb499579a57678d673e282613ef97608","accounts_in_message":[],"_revision_number":7},{"id":"e6959527f36de4545b0b239c01796f14db824053","author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"date":"2018-06-04 13:59:21.000000000","message":"Created a revert of this change as I98b00b512102929332b73d98fe2f556b3448b0c5","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"661103128ebd930867b4ebd5b499d508d48b7d26","revisions":{"da5e2e87975533bb2a300d2dd90120d7f749d221":{"kind":"REWORK","_number":1,"created":"2018-05-06 17:49:24.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/1"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:49:23.000000000","tz":-240},"subject":"Fix the column name for environment namespace","message":"Fix the column name for environment namespace\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\nCloses-bug: #1769491\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/da5e2e87975533bb2a300d2dd90120d7f749d221"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/da5e2e87975533bb2a300d2dd90120d7f749d221"}]},"branch":"refs/heads/master"},"169b62de045191d361529155a4bbb866f80bd1f5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-05-06 19:04:50.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/2"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 19:03:58.000000000","tz":-240},"subject":"Fix the column name for environment namespace","message":"Fix the column name for environment namespace\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/169b62de045191d361529155a4bbb866f80bd1f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/169b62de045191d361529155a4bbb866f80bd1f5"}]},"branch":"refs/heads/master"},"c956d00149ead1df8b1620f676668da2a14f1c70":{"kind":"REWORK","_number":3,"created":"2018-05-06 22:23:14.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/3"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 22:22:49.000000000","tz":-240},"subject":"Fix the column name for environment namespace","message":"Fix the column name for environment namespace\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/c956d00149ead1df8b1620f676668da2a14f1c70"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/c956d00149ead1df8b1620f676668da2a14f1c70"}]},"branch":"refs/heads/master"},"0fa84d737e5a7766140261e339c923ec1cbe3220":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-05-06 22:26:24.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/4"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 22:25:46.000000000","tz":-240},"subject":"Adding a environment-get-definition to allow easy environment-update","message":"Adding a environment-get-definition to allow easy environment-update\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/0fa84d737e5a7766140261e339c923ec1cbe3220"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/0fa84d737e5a7766140261e339c923ec1cbe3220"}]},"branch":"refs/heads/master"},"91cc79af5be4fd36ac1509d486c614a97700a7d8":{"kind":"REWORK","_number":5,"created":"2018-05-07 01:30:28.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/5"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-07 01:30:13.000000000","tz":-240},"subject":"Adding a environment-get-definition to allow easy environment-update","message":"Adding a environment-get-definition to allow easy environment-update\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/91cc79af5be4fd36ac1509d486c614a97700a7d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/91cc79af5be4fd36ac1509d486c614a97700a7d8"}]},"branch":"refs/heads/master"},"49810ac5e4ffac01987e8af91793389581acbcc7":{"kind":"REWORK","_number":6,"created":"2018-05-07 01:32:36.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/6"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-07 01:32:28.000000000","tz":-240},"subject":"Adding a environment-get-definition to allow easy environment-update","message":"Adding a environment-get-definition to allow easy environment-update\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/49810ac5e4ffac01987e8af91793389581acbcc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/49810ac5e4ffac01987e8af91793389581acbcc7"}]},"branch":"refs/heads/master"},"661103128ebd930867b4ebd5b499d508d48b7d26":{"kind":"REWORK","_number":7,"created":"2018-05-07 12:44:48.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/69/566469/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/69/566469/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/69/566469/7"}}},"commit":{"parents":[{"commit":"8cc76487fd84bfaa3b4ff74248e2b138d21a504e","subject":"Merge \"Add the force parameter to delete executions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/8cc76487fd84bfaa3b4ff74248e2b138d21a504e"}]}],"author":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-06 17:39:22.000000000","tz":-240},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2018-05-07 12:44:10.000000000","tz":-240},"subject":"Adding environment-get-definition for easy environment-update","message":"Adding environment-get-definition for easy environment-update\n\nCloses-bug: #1769491\n\nChange-Id: I2fe2bad962255e5f4f8df69dcac610276482f099\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/661103128ebd930867b4ebd5b499d508d48b7d26"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/661103128ebd930867b4ebd5b499d508d48b7d26"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
