)]}'
{"mistralclient/api/base.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cd1bf3c27855bb4e4ef9d608811eb9c5776741d6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.http_client \u003d http_client"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def find(self, **kwargs):"},{"line_number":77,"context_line":"        return [i for i in self.list() if _check_items(i, kwargs.items())]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _build_query_params(marker\u003dNone, limit\u003dNone, sort_keys\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_84a8068c","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":38},"updated":"2019-03-14 12:27:26.000000000","message":"I actually don\u0027t find a definition for a function called list for this class. I did find \"_list\" though.","commit_id":"9395297040b7405cb0e99ddf47ec163265a641b4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"99d82d198af58241635e8d1396f7068ee37ff780","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.http_client \u003d http_client"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def find(self, **kwargs):"},{"line_number":77,"context_line":"        return [i for i in self.list() if _check_items(i, kwargs.items())]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _build_query_params(marker\u003dNone, limit\u003dNone, sort_keys\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e47f8add","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":38},"in_reply_to":"5fc1f717_8496c63d","updated":"2019-03-14 12:36:37.000000000","message":"alright, had an explanation from ykarel regarding this. The list function is defined in the subclasses of this.\n\nIt would be good to define the list function in the base class though; for readability.","commit_id":"9395297040b7405cb0e99ddf47ec163265a641b4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"144a0dbb6edef102d13672669a13aede0c73b069","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.http_client \u003d http_client"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def find(self, **kwargs):"},{"line_number":77,"context_line":"        return [i for i in self.list() if _check_items(i, kwargs.items())]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _build_query_params(marker\u003dNone, limit\u003dNone, sort_keys\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8496c63d","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":38},"in_reply_to":"5fc1f717_84a8068c","updated":"2019-03-14 12:29:20.000000000","message":"the real issue is that no argument is being given to the _list function. The definition is:\n\ndef _list(self, url, response_key\u003dNone):\n\nso it expects a url parameter.","commit_id":"9395297040b7405cb0e99ddf47ec163265a641b4"},{"author":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"change_message_id":"b8ff407d83da65de76159ade39f5a57e06ab7bab","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.http_client \u003d http_client"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def find(self, **kwargs):"},{"line_number":77,"context_line":"        return [i for i in self.list() if _check_items(i, kwargs.items())]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _build_query_params(marker\u003dNone, limit\u003dNone, sort_keys\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d88a7268","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":38},"in_reply_to":"5fc1f717_e47f8add","updated":"2019-03-14 12:54:25.000000000","message":"Agreed. Just adding an abstract def list and lgtm","commit_id":"9395297040b7405cb0e99ddf47ec163265a641b4"}]}