)]}'
{"id":"openstack%2Fpython-mistralclient~656257","triplet_id":"openstack%2Fpython-mistralclient~master~I9c00cb16ac0e6cefd926974a9eab29080a4d94a7","project":"openstack/python-mistralclient","branch":"master","topic":"eyalb/mutable","hashtags":[],"change_id":"I9c00cb16ac0e6cefd926974a9eab29080a4d94a7","subject":"Don\u0027t use default mutable parameter","status":"MERGED","created":"2019-04-29 07:22:39.000000000","updated":"2019-04-30 06:09:40.000000000","submitted":"2019-04-30 06:09:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656257-1556604580982-b3e99d47","meta_rev_id":"1b150f686dba6e626053fb931723d24aa3365321","_number":656257,"virtual_id_number":656257,"owner":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-04-30 06:09:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":0,"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-29 21:39:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":2,"date":"2019-04-30 04:03:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"value":0,"date":"2019-04-29 21:39:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"value":0,"date":"2019-04-29 21:39:21.000000000","_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":1,"date":"2019-04-30 04:03:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-29 21:39:09.000000000","updated_by":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"reviewer":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"state":"REVIEWER"},{"updated":"2019-04-29 21:39:21.000000000","updated_by":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"reviewer":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"state":"REVIEWER"},{"updated":"2019-04-29 21:39:26.000000000","updated_by":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"reviewer":{"_account_id":15895,"name":"Adriano Petrich","email":"apetrich@redhat.com","username":"apetrich"},"state":"REVIEWER"},{"updated":"2019-04-30 04:03:53.000000000","updated_by":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"reviewer":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"state":"REVIEWER"},{"updated":"2019-04-30 06:09:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d9dae9d34273bf7909f9511bb1bf3ee68a855445","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2019-04-29 07:22:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5958cb47c7676ac997d7bd3cb436458da410f4cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 10:16:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/57/656257/1/check/openstack-tox-lower-constraints/dcac506/ : SUCCESS in 7m 16s\n- openstack-tox-pep8 http://logs.openstack.org/57/656257/1/check/openstack-tox-pep8/a4ad1dd/ : SUCCESS in 5m 40s\n- openstack-tox-py27 http://logs.openstack.org/57/656257/1/check/openstack-tox-py27/33a2838/ : SUCCESS in 5m 40s\n- openstack-tox-py36 http://logs.openstack.org/57/656257/1/check/openstack-tox-py36/49bcf30/ : SUCCESS in 6m 02s\n- openstack-tox-py37 http://logs.openstack.org/57/656257/1/check/openstack-tox-py37/c8629a6/ : SUCCESS in 6m 02s\n- openstackclient-check-plugins http://logs.openstack.org/57/656257/1/check/openstackclient-check-plugins/a503fbc/ : SUCCESS in 7m 17s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/57/656257/1/check/openstack-tox-docs/87b761b/html/ : SUCCESS in 6m 56s\n- python-mistralclient-functional-devstack http://logs.openstack.org/57/656257/1/check/python-mistralclient-functional-devstack/3018875/ : SUCCESS in 51m 45s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/57/656257/1/check/tripleo-ci-centos-7-containers-multinode/8877410/ : SUCCESS in 2h 42m 48s","accounts_in_message":[],"_revision_number":1},{"id":"12dcc0230b37ccd6d21cd4613757fe8c7f4a430c","author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"date":"2019-04-29 21:39:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"eee076de7d46b20f87fb2d0c07f665891146180d","author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"date":"2019-04-30 04:03:53.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"edceadaab3d50cbb751cde57dd514926c0e5fcee","author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"date":"2019-04-30 04:03:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c0a39a293dfdfe4859318b80e3f768a38ef2d9ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 04:04:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b89985b4f1387f94833605952dfc014334b0b53c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 06:09:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"090fe9f43d4ef42f7b14f2d6872bff42ef84acc4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 06:09:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/57/656257/1/gate/openstack-tox-lower-constraints/9b2215c/ : SUCCESS in 5m 22s\n- openstack-tox-pep8 http://logs.openstack.org/57/656257/1/gate/openstack-tox-pep8/7d59dd2/ : SUCCESS in 3m 53s\n- openstack-tox-py27 http://logs.openstack.org/57/656257/1/gate/openstack-tox-py27/df8fb9d/ : SUCCESS in 4m 06s\n- openstack-tox-py36 http://logs.openstack.org/57/656257/1/gate/openstack-tox-py36/7224839/ : SUCCESS in 4m 01s\n- openstack-tox-py37 http://logs.openstack.org/57/656257/1/gate/openstack-tox-py37/8144101/ : SUCCESS in 4m 12s\n- openstack-tox-docs http://logs.openstack.org/57/656257/1/gate/openstack-tox-docs/8dddf67/html/ : SUCCESS in 4m 28s\n- python-mistralclient-functional-devstack http://logs.openstack.org/57/656257/1/gate/python-mistralclient-functional-devstack/29e6107/ : SUCCESS in 42m 32s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/57/656257/1/gate/tripleo-ci-centos-7-containers-multinode/be40666/ : SUCCESS in 2h 00m 29s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"87d54bba879a90210b13bcb72c8848234007100e","revisions":{"87d54bba879a90210b13bcb72c8848234007100e":{"kind":"REWORK","_number":1,"created":"2019-04-29 07:22:39.000000000","uploader":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"ref":"refs/changes/57/656257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-mistralclient","ref":"refs/changes/57/656257/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/57/656257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/57/656257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-mistralclient refs/changes/57/656257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-mistralclient refs/changes/57/656257/1"}}},"commit":{"parents":[{"commit":"aa3171ade12853280d4605821f0ccbf6171b791a","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/aa3171ade12853280d4605821f0ccbf6171b791a"}]}],"author":{"name":"Eyal","email":"eyal.bar-ilan@nokia.com","date":"2019-04-29 07:19:22.000000000","tz":180},"committer":{"name":"Eyal","email":"eyal.bar-ilan@nokia.com","date":"2019-04-29 07:22:26.000000000","tz":180},"subject":"Don\u0027t use default mutable parameter","message":"Don\u0027t use default mutable parameter\n\nUsing default mutable parameter is bad.\nDefault parameters are evaluated only once\nif you mutate it you will get unexpected results.\n\nChange-Id: I9c00cb16ac0e6cefd926974a9eab29080a4d94a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/87d54bba879a90210b13bcb72c8848234007100e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-mistralclient/commit/87d54bba879a90210b13bcb72c8848234007100e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}