)]}'
{"mistralclient/api/base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a7bbbd596e4f0814c7d8e2464fb8d80fe0f34e9f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return \"%s [%s]\" % (self.resource_name, vals)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class Execution(Resource):"},{"line_number":58,"context_line":"    resource_name \u003d \u0027Execution\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_37a7f7bd","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":15},"updated":"2020-01-27 05:08:35.000000000","message":"I don\u0027t understand why we have this class now here in the base module? It\u0027s not supposed to have any concrete resource (or resource manager) classes here.","commit_id":"c91dc9d11cf343581340665496c4723130117bfd"}],"mistralclient/api/v2/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a7bbbd596e4f0814c7d8e2464fb8d80fe0f34e9f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return self._list("},{"line_number":58,"context_line":"            task_sub_execs_path % (id, params),"},{"line_number":59,"context_line":"            response_key\u003d\u0027executions\u0027,"},{"line_number":60,"context_line":"            returned_res_cls\u003dbase.Execution"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def rerun(self, task_ex_id, reset\u003dTrue, env\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_177d1b1d","line":60,"range":{"start_line":60,"start_character":29,"end_line":60,"end_character":43},"updated":"2020-01-27 05:08:35.000000000","message":"Just define Execution class in the executions.py module and use it here as: executions.Execution. It\u0027s totally OK because logically tasks really know about executions and they are at the same level of abstraction. Whereas, moving Execution from more concrete module to a more abstract module we misplace this class because base.py provides just a framework.","commit_id":"c91dc9d11cf343581340665496c4723130117bfd"}],"mistralclient/commands/v2/base.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a7bbbd596e4f0814c7d8e2464fb8d80fe0f34e9f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return f()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class ExecutionFormatter(MistralFormatter):"},{"line_number":166,"context_line":"    COLUMNS \u003d ["},{"line_number":167,"context_line":"        (\u0027id\u0027, \u0027ID\u0027),"},{"line_number":168,"context_line":"        (\u0027workflow_id\u0027, \u0027Workflow ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_378057f6","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":42},"updated":"2020-01-27 05:08:35.000000000","message":"The same comment here as about misplacing the Execution class. Just move it to the commands/v2/executions.py and use it also in commands/v2/tasks.py. No need to move any concrete classes to the base module. Btw, MistralExecutionLister should also be moved out of here. I\u0027m not sure why it was put here in the first place. I think we\u0027ve just overlooked it when reviewing.","commit_id":"c91dc9d11cf343581340665496c4723130117bfd"},{"author":{"_account_id":30755,"name":"ali","email":"ali.abdelal@nokia.com","username":"abdelal"},"change_message_id":"a9a3d8c7980a2c45f9bdc86a03639f2c9bf66554","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return f()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class ExecutionFormatter(MistralFormatter):"},{"line_number":166,"context_line":"    COLUMNS \u003d ["},{"line_number":167,"context_line":"        (\u0027id\u0027, \u0027ID\u0027),"},{"line_number":168,"context_line":"        (\u0027workflow_id\u0027, \u0027Workflow ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6e703974","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":42},"in_reply_to":"3fa7e38b_32c865a5","updated":"2020-01-27 12:52:06.000000000","message":"Execution in \u0027MistralExecutionLister\u0027 does not refer to workflow-execution, but execution in general, \u0027MistralExecutionLister\u0027 is the base of List for Action Execution, Task Execution, and Workflow execution.","commit_id":"c91dc9d11cf343581340665496c4723130117bfd"},{"author":{"_account_id":30755,"name":"ali","email":"ali.abdelal@nokia.com","username":"abdelal"},"change_message_id":"9145ef33110cc930f03f404b5af19da5a6d3cd46","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return f()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class ExecutionFormatter(MistralFormatter):"},{"line_number":166,"context_line":"    COLUMNS \u003d ["},{"line_number":167,"context_line":"        (\u0027id\u0027, \u0027ID\u0027),"},{"line_number":168,"context_line":"        (\u0027workflow_id\u0027, \u0027Workflow ID\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_32c865a5","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":42},"in_reply_to":"3fa7e38b_378057f6","updated":"2020-01-27 08:38:07.000000000","message":"I moved the classes to executions.py, as for MistralExecutionLister I agree, but as it\u0027s not in the scope of this patch, we can do it on a sperate patch.","commit_id":"c91dc9d11cf343581340665496c4723130117bfd"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"554dddec6863f06e15f834459987a6aafd453128","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            return f()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class SubExecutionsBaseLister(cliff_lister):"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _get_format_function(self):"},{"line_number":168,"context_line":"        raise NotImplementedError"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_445c3119","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":29},"updated":"2020-01-28 04:36:36.000000000","message":"Does it only refer to workflow executions or task executions also? If only to workflow executions then I\u0027d suggest we move it to executions.py.","commit_id":"73cca58871e9726c1a93f066d7696e1b6fc75678"}]}