)]}'
{"mistralclient/api/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2104411204889ce0d3586cea74699ed259a33dfb","unresolved":true,"context_lines":[{"line_number":75,"context_line":"class ResourceManager(object):"},{"line_number":76,"context_line":"    resource_class \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, http_client, enforce_raw_definitions\u003dFalse):"},{"line_number":79,"context_line":"        self.http_client \u003d http_client"},{"line_number":80,"context_line":"        self.enforce_raw_definitions \u003d enforce_raw_definitions"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"abb330a5_d3c902d8","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":65},"updated":"2021-07-15 15:45:06.000000000","message":"I understand the default value of False was chosen to keep the backward-compatibility, but the previous behavior is potentially dangerous and it must be set to False only when users understand the risk. I am not sure which should be considered first between security consideration and backward-compatibility in this case.\n\nNote that CLI implementation (OSC plugin) load the file contents specified by the command-line argument in the CLI layer and it is not affected even if enforce_raw_definitions is set to True.","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ab89bc24c78466e1fd5729833e9dab7ff13f65a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"class ResourceManager(object):"},{"line_number":76,"context_line":"    resource_class \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, http_client, enforce_raw_definitions\u003dFalse):"},{"line_number":79,"context_line":"        self.http_client \u003d http_client"},{"line_number":80,"context_line":"        self.enforce_raw_definitions \u003d enforce_raw_definitions"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac57a1f_d50f0a61","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":65},"in_reply_to":"0a9a21cb_663f74e4","updated":"2021-07-16 05:36:44.000000000","message":"Yeah, the question from both of us is \"double loading of file contents is an intentional feature or just an unexpected behavior?\"","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d34de83a1024dff1ad86a2b00cfdb890976c8264","unresolved":true,"context_lines":[{"line_number":75,"context_line":"class ResourceManager(object):"},{"line_number":76,"context_line":"    resource_class \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, http_client, enforce_raw_definitions\u003dFalse):"},{"line_number":79,"context_line":"        self.http_client \u003d http_client"},{"line_number":80,"context_line":"        self.enforce_raw_definitions \u003d enforce_raw_definitions"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b1fd9fdb_ae12acea","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":65},"in_reply_to":"abb330a5_d3c902d8","updated":"2021-07-15 16:01:42.000000000","message":"Currently CLI supports loading file path or url from file (I mean creating a text file which has url or file path as its content and specify path of that text file). I understand this would be an odd usage but I hesitated to break the existing usage.\n\nThe main cause of this problem was that this code to load arbitrarily contents is executed in server side, but as long as this code is executed in client side (like usage of CLI) it would be much safer.","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94319de8c55fa8dcf7bf70d9163cde4bfcccd733","unresolved":true,"context_lines":[{"line_number":75,"context_line":"class ResourceManager(object):"},{"line_number":76,"context_line":"    resource_class \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, http_client, enforce_raw_definitions\u003dFalse):"},{"line_number":79,"context_line":"        self.http_client \u003d http_client"},{"line_number":80,"context_line":"        self.enforce_raw_definitions \u003d enforce_raw_definitions"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d26277dd_9151ff43","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":65},"in_reply_to":"b1fd9fdb_ae12acea","updated":"2021-07-16 02:53:13.000000000","message":"Only mistral developers know the design intention. IMHO it should be set to True by default for safer defaults (The reason is described above already), but the final decision is up to the mistral team. I have no more word.","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a694681a51f0d4636e7aab62488abd33cfa3f24","unresolved":true,"context_lines":[{"line_number":75,"context_line":"class ResourceManager(object):"},{"line_number":76,"context_line":"    resource_class \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, http_client, enforce_raw_definitions\u003dFalse):"},{"line_number":79,"context_line":"        self.http_client \u003d http_client"},{"line_number":80,"context_line":"        self.enforce_raw_definitions \u003d enforce_raw_definitions"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"0a9a21cb_663f74e4","line":78,"range":{"start_line":78,"start_character":36,"end_line":78,"end_character":65},"in_reply_to":"d26277dd_9151ff43","updated":"2021-07-16 03:01:11.000000000","message":"Basically this depends on whether the usage I described is intentional one, and I have no strong opinion about it. I\u0027d wait for some more inputs from Mistral core team based on the history they have in their mind.","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"}],"releasenotes/notes/eoforce_raw_definitions-c5e24e712a73d9a0.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2104411204889ce0d3586cea74699ed259a33dfb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4872e14_0823bdf2","updated":"2021-07-15 15:45:06.000000000","message":"The filename contains typo: eoforce -\u003e enforce","commit_id":"506ca1177399c84aa947ac1e873c67ca7048c056"}]}