)]}'
{"monascaclient/v2_0/shell.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"85338e314ca5700a1955ec03b0d402ab9d49041e","unresolved":false,"context_lines":[{"line_number":818,"context_line":"        cols \u003d [\u0027id\u0027, \u0027alarm_definition_id\u0027, \u0027alarm_name\u0027, \u0027metric_name\u0027, \u0027metric_dimensions\u0027, \u0027severity\u0027, \u0027state\u0027]"},{"line_number":819,"context_line":"        formatters \u003d {"},{"line_number":820,"context_line":"            \u0027id\u0027: lambda x: x[\u0027id\u0027],"},{"line_number":821,"context_line":"            \u0027alarm_definition_id\u0027: lambda x: x[\u0027alarm_definition_id\u0027],"},{"line_number":822,"context_line":"            \u0027alarm_name\u0027: lambda x: x[\u0027alarm_definition\u0027][\u0027name\u0027],"},{"line_number":823,"context_line":"            \u0027metric_name\u0027: lambda x: format_metric_name(x[\u0027metrics\u0027]),"},{"line_number":824,"context_line":"            \u0027metric_dimensions\u0027: lambda x: format_metric_dimensions(x[\u0027metrics\u0027]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_df70440a","line":821,"updated":"2014-10-16 21:54:19.000000000","message":"Can you use [\u0027alarm_definition\u0027][\u0027id\u0027] here? I\u0027d like to get rid of alarm_definition_id since it is redundant","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"398986b7df2aa67d9499af67d60d727f751ade96","unresolved":false,"context_lines":[{"line_number":818,"context_line":"        cols \u003d [\u0027id\u0027, \u0027alarm_definition_id\u0027, \u0027alarm_name\u0027, \u0027metric_name\u0027, \u0027metric_dimensions\u0027, \u0027severity\u0027, \u0027state\u0027]"},{"line_number":819,"context_line":"        formatters \u003d {"},{"line_number":820,"context_line":"            \u0027id\u0027: lambda x: x[\u0027id\u0027],"},{"line_number":821,"context_line":"            \u0027alarm_definition_id\u0027: lambda x: x[\u0027alarm_definition_id\u0027],"},{"line_number":822,"context_line":"            \u0027alarm_name\u0027: lambda x: x[\u0027alarm_definition\u0027][\u0027name\u0027],"},{"line_number":823,"context_line":"            \u0027metric_name\u0027: lambda x: format_metric_name(x[\u0027metrics\u0027]),"},{"line_number":824,"context_line":"            \u0027metric_dimensions\u0027: lambda x: format_metric_dimensions(x[\u0027metrics\u0027]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_8aef4ae8","line":821,"in_reply_to":"baa201ad_df70440a","updated":"2014-10-17 15:04:41.000000000","message":"Sure, will do.","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"85338e314ca5700a1955ec03b0d402ab9d49041e","unresolved":false,"context_lines":[{"line_number":992,"context_line":"            \u0027HTTPException code\u003d%s message\u003d%s\u0027 %"},{"line_number":993,"context_line":"            (he.code, he.message))"},{"line_number":994,"context_line":"    else:"},{"line_number":995,"context_line":"        if args.json:"},{"line_number":996,"context_line":"            print(utils.json_formatter(alarm))"},{"line_number":997,"context_line":"            return"},{"line_number":998,"context_line":"        # format output"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_fff0a868","line":995,"updated":"2014-10-16 21:54:19.000000000","message":"This code seems to be a duplicate of the code above. Can you put it into a method instead?","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43448af08706764c6afe8745ea307dabdad5edb7","unresolved":false,"context_lines":[{"line_number":992,"context_line":"            \u0027HTTPException code\u003d%s message\u003d%s\u0027 %"},{"line_number":993,"context_line":"            (he.code, he.message))"},{"line_number":994,"context_line":"    else:"},{"line_number":995,"context_line":"        if args.json:"},{"line_number":996,"context_line":"            print(utils.json_formatter(alarm))"},{"line_number":997,"context_line":"            return"},{"line_number":998,"context_line":"        # format output"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_659337a3","line":995,"in_reply_to":"baa201ad_2ab2dee4","updated":"2014-10-17 15:23:30.000000000","message":"I was actually talking about the whole block of 24 lines. 995 to 1018 is a duplicate of 942 to 965.","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"edbf52ba31943f58c9d5ebd60261a4acc734692b","unresolved":false,"context_lines":[{"line_number":992,"context_line":"            \u0027HTTPException code\u003d%s message\u003d%s\u0027 %"},{"line_number":993,"context_line":"            (he.code, he.message))"},{"line_number":994,"context_line":"    else:"},{"line_number":995,"context_line":"        if args.json:"},{"line_number":996,"context_line":"            print(utils.json_formatter(alarm))"},{"line_number":997,"context_line":"            return"},{"line_number":998,"context_line":"        # format output"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a0198dd2","line":995,"in_reply_to":"baa201ad_659337a3","updated":"2014-10-17 16:07:18.000000000","message":"That makes sense!","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"398986b7df2aa67d9499af67d60d727f751ade96","unresolved":false,"context_lines":[{"line_number":992,"context_line":"            \u0027HTTPException code\u003d%s message\u003d%s\u0027 %"},{"line_number":993,"context_line":"            (he.code, he.message))"},{"line_number":994,"context_line":"    else:"},{"line_number":995,"context_line":"        if args.json:"},{"line_number":996,"context_line":"            print(utils.json_formatter(alarm))"},{"line_number":997,"context_line":"            return"},{"line_number":998,"context_line":"        # format output"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_2ab2dee4","line":995,"in_reply_to":"baa201ad_fff0a868","updated":"2014-10-17 15:04:41.000000000","message":"hmmm, I need to be clear that I am exiting(returning) from the method here.\nI could make a 2 line method that returns a bool.","commit_id":"c368e23c61ce694e806fc79d58f6a58bb8d340f6"}]}