)]}'
{"id":"openstack%2Fpython-monascaclient~215778","triplet_id":"openstack%2Fpython-monascaclient~master~I3ec01aa9562558847d784cbf4dce944507bee664","project":"openstack/python-monascaclient","branch":"master","topic":"enableTimeout","hashtags":[],"change_id":"I3ec01aa9562558847d784cbf4dce944507bee664","subject":"Enable optional timeouts for http get or post requests","status":"MERGED","created":"2015-08-21 20:51:26.000000000","updated":"2015-08-27 22:18:17.000000000","submitted":"2015-08-27 22:18:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f6fcce9f396d5f60d9e97c366048ee5e6f787807","_number":215778,"virtual_id_number":215778,"owner":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},{"value":0,"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"value":2,"date":"2015-08-27 22:18:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-08-27 21:06:27.000000000","_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},{"value":0,"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"value":0,"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"recommended":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"all":[{"value":0,"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},{"value":1,"date":"2015-08-25 18:44:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},{"value":1,"date":"2015-08-27 19:26:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"value":2,"date":"2015-08-27 22:14:06.000000000","_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"all":[{"value":0,"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},{"value":0,"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},{"value":0,"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"value":1,"date":"2015-08-27 22:14:32.000000000","_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-23 04:33:28.000000000","updated_by":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"reviewer":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"state":"REVIEWER"},{"updated":"2015-08-25 18:44:17.000000000","updated_by":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"reviewer":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"state":"REVIEWER"},{"updated":"2015-08-27 19:26:59.000000000","updated_by":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"reviewer":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"state":"REVIEWER"},{"updated":"2015-08-27 22:14:32.000000000","updated_by":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"reviewer":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"state":"REVIEWER"},{"updated":"2015-08-27 22:18:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"64133fd21c8744424f0eb4615412378792ee0fa1","author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"date":"2015-08-21 20:51:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb55b4c2507ae8976e54e5376bf4872cb393ef32","author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"date":"2015-08-21 20:52:40.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"674a5099846b47ce63fc5f5c85b70b7ac3290817","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 21:28:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-monascaclient-pep8 http://logs.openstack.org/78/215778/1/check/gate-python-monascaclient-pep8/718b082/ : FAILURE in 40s\n- gate-python-monascaclient-python27 http://logs.openstack.org/78/215778/1/check/gate-python-monascaclient-python27/6c4ce87/ : SUCCESS in 54s","accounts_in_message":[],"_revision_number":1},{"id":"f4ba56dfb8a5243529f46cc0ae3a3458d3269432","author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"date":"2015-08-22 00:47:53.000000000","message":"Patch Set 1:\n\nWe also have Delete, Patch, and update verbs.  I\u0027m not sure if we can hit all of those through the client library but if we can we should make sure those methods also use the write timeout value.","accounts_in_message":[],"_revision_number":1},{"id":"78e3550993031a2dc75bf5ea18bd09751cfa6f5e","author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"date":"2015-08-22 22:30:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d36801d12469bb55f4dee00a1717c44447309e9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-22 22:35:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-monascaclient-pep8 http://logs.openstack.org/78/215778/2/check/gate-python-monascaclient-pep8/536c7da/ : SUCCESS in 51s\n- gate-python-monascaclient-python27 http://logs.openstack.org/78/215778/2/check/gate-python-monascaclient-python27/0d440e2/ : SUCCESS in 2m 16s","accounts_in_message":[],"_revision_number":2},{"id":"15142ce5cbe6a772f70da8c5d10ef3517f2809f2","author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"date":"2015-08-23 04:33:28.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"304a1e820d7da7e9ffdc8eebf9260a811896613b","author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"date":"2015-08-25 16:07:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"31c41fd438411ed2a9a96e00fdfdad2e0ed7a536","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-25 17:12:56.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-monascaclient-pep8 http://logs.openstack.org/78/215778/3/check/gate-python-monascaclient-pep8/5fc4a42/ : SUCCESS in 47s\n- gate-python-monascaclient-python27 http://logs.openstack.org/78/215778/3/check/gate-python-monascaclient-python27/f9bd86c/ : SUCCESS in 56s","accounts_in_message":[],"_revision_number":3},{"id":"e4db6deb7c89157105e46ac1a48082efa1a29fd1","author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"date":"2015-08-25 18:44:17.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"9d989ce4f4f2bbe26ece95c1d2d06f9055aafca2","author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"date":"2015-08-27 19:26:59.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"446500f5d7249b0aa5d1a58905889702a508ce02","author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"date":"2015-08-27 20:15:25.000000000","message":"Patch Set 3:\n\nThis looks ok, but is just initializing to None.\n\nFor this to be used by the client API you need to add the parameters to the client (which initializes HTTPClient) as well don\u0027t you?","accounts_in_message":[],"_revision_number":3},{"id":"38101f4045c808d829e79eed6911e74b38c4ac66","author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"date":"2015-08-27 21:06:27.000000000","message":"Patch Set 3:\n\nWe wanted to leave the original functionality. The default timeout for request is none. The reason we are making this change is because our forwarder in the agent was getting hung on talking to our API. (the review to change the agent to use this is at https://review.openstack.org/#/c/215777/)","accounts_in_message":[],"_revision_number":3},{"id":"315fbf5a8e9891e6cc1da8fe5bb059016b63f694","author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"date":"2015-08-27 22:14:06.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"94e667d541669af486b3398e4577c3b58e8d3cc8","author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"date":"2015-08-27 22:14:32.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"ce5bba33d0fc6a0c0ee22736a8888fe8ba32d3b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-27 22:14:38.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"476c984024afa0df7283e75a820dcb023f046ace","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-27 22:18:17.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-monascaclient-pep8 http://logs.openstack.org/78/215778/3/gate/gate-python-monascaclient-pep8/0819b46/ : SUCCESS in 45s\n- gate-python-monascaclient-python27 http://logs.openstack.org/78/215778/3/gate/gate-python-monascaclient-python27/b42fe6a/ : SUCCESS in 51s","accounts_in_message":[],"_revision_number":3},{"id":"d7a6f699f23edae772aafb6ebbd8a08b4982ed63","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-27 22:18:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5c63c639ce9d46e55ad56d7c6814027d894743d1","revisions":{"41573853a2069fbcde8a84ae59e1558b02b25434":{"kind":"REWORK","_number":1,"created":"2015-08-21 20:51:26.000000000","uploader":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"ref":"refs/changes/78/215778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/78/215778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/1"}}},"commit":{"parents":[{"commit":"417eadc326385c16c7fe4d8d132b5cb61c9aac1f","subject":"Add HP copyright to files that HP has changed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/417eadc326385c16c7fe4d8d132b5cb61c9aac1f"}]}],"author":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-21 20:49:45.000000000","tz":-360},"committer":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-21 20:49:45.000000000","tz":-360},"subject":"Enable optional timeouts for http get or post requests","message":"Enable optional timeouts for http get or post requests\n\nThis fixes our client from hanging on posts and gets\n\nChange-Id: I3ec01aa9562558847d784cbf4dce944507bee664\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/41573853a2069fbcde8a84ae59e1558b02b25434"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/41573853a2069fbcde8a84ae59e1558b02b25434"}]},"branch":"refs/heads/master"},"e32841df89d42445b3c62f30e209a8292a5ac4d0":{"kind":"REWORK","_number":2,"created":"2015-08-22 22:30:11.000000000","uploader":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"ref":"refs/changes/78/215778/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/78/215778/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/2"}}},"commit":{"parents":[{"commit":"417eadc326385c16c7fe4d8d132b5cb61c9aac1f","subject":"Add HP copyright to files that HP has changed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/417eadc326385c16c7fe4d8d132b5cb61c9aac1f"}]}],"author":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-21 20:49:45.000000000","tz":-360},"committer":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-22 22:29:55.000000000","tz":-360},"subject":"Enable optional timeouts for http get or post requests","message":"Enable optional timeouts for http get or post requests\n\nThis fixes our client from hanging on posts and gets\n\nChange-Id: I3ec01aa9562558847d784cbf4dce944507bee664\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/e32841df89d42445b3c62f30e209a8292a5ac4d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/e32841df89d42445b3c62f30e209a8292a5ac4d0"}]},"branch":"refs/heads/master"},"5c63c639ce9d46e55ad56d7c6814027d894743d1":{"kind":"REWORK","_number":3,"created":"2015-08-25 16:07:45.000000000","uploader":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"ref":"refs/changes/78/215778/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/78/215778/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/78/215778/3"}}},"commit":{"parents":[{"commit":"417eadc326385c16c7fe4d8d132b5cb61c9aac1f","subject":"Add HP copyright to files that HP has changed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/417eadc326385c16c7fe4d8d132b5cb61c9aac1f"}]}],"author":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-21 20:49:45.000000000","tz":-360},"committer":{"name":"Michael James Hoppal","email":"michael.jam.hoppal@hp.com","date":"2015-08-25 16:03:42.000000000","tz":-360},"subject":"Enable optional timeouts for http get or post requests","message":"Enable optional timeouts for http get or post requests\n\nThis fixes our client from hanging on posts and gets\n\nChange-Id: I3ec01aa9562558847d784cbf4dce944507bee664\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/5c63c639ce9d46e55ad56d7c6814027d894743d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/5c63c639ce9d46e55ad56d7c6814027d894743d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}