)]}'
{"monascaclient/v2_0/shell.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2e41a68657b307457a1231d9cc4e5d3a68a6380c","unresolved":false,"context_lines":[{"line_number":874,"context_line":"           help\u003d\u0027Name of the metric.\u0027)"},{"line_number":875,"context_line":"@utils.arg(\u0027--metric-dimensions\u0027, metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2,KEY3\u003dVALUE2...\u003e\u0027,"},{"line_number":876,"context_line":"           help\u003d\u0027key value pair used to specify a metric dimension or \u0027"},{"line_number":877,"context_line":"                \u0027just key to select all values of that dimension.\u0027"},{"line_number":878,"context_line":"                \u0027This can be specified multiple times, or once with parameters \u0027"},{"line_number":879,"context_line":"                \u0027separated by a comma. \u0027"},{"line_number":880,"context_line":"                \u0027Dimensions need quoting when they contain special chars [\u0026,(,),{,},\u003e,\u003c] \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2fddfedf","line":877,"range":{"start_line":877,"start_character":18,"end_line":877,"end_character":64},"updated":"2016-04-29 21:48:46.000000000","message":"I think this would be clearer if it said:\n\nkey value pair used to select alarms with metrics that have that dimension key and value. Or\njust key can be used to select alarms with metrics that have any value for that dimension key.\n\nBut, maybe that is too verbose?","commit_id":"fcbba12c048c14f971fff445d3087142ee369f17"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"67701dcf3472cc8e8056c3d3e86840348e6a2c40","unresolved":false,"context_lines":[{"line_number":874,"context_line":"           help\u003d\u0027Name of the metric.\u0027)"},{"line_number":875,"context_line":"@utils.arg(\u0027--metric-dimensions\u0027, metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2,KEY3\u003dVALUE2...\u003e\u0027,"},{"line_number":876,"context_line":"           help\u003d\u0027key value pair used to specify a metric dimension or \u0027"},{"line_number":877,"context_line":"                \u0027just key to select all values of that dimension.\u0027"},{"line_number":878,"context_line":"                \u0027This can be specified multiple times, or once with parameters \u0027"},{"line_number":879,"context_line":"                \u0027separated by a comma. \u0027"},{"line_number":880,"context_line":"                \u0027Dimensions need quoting when they contain special chars [\u0026,(,),{,},\u003e,\u003c] \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7e08fdd9","line":877,"range":{"start_line":877,"start_character":18,"end_line":877,"end_character":64},"in_reply_to":"1a122d0e_2fddfedf","updated":"2016-06-10 20:03:20.000000000","message":"I lean towards keeping it short and simple in this case.","commit_id":"fcbba12c048c14f971fff445d3087142ee369f17"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"71ffb9ba7e33afb30b8de6010570974129a65979","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"           help\u003d\u0027The ID of the alarm definition.\u0027)"},{"line_number":1020,"context_line":"@utils.arg(\u0027--metric-name\u0027, metavar\u003d\u0027\u003cMETRIC_NAME\u003e\u0027,"},{"line_number":1021,"context_line":"           help\u003d\u0027Name of the metric.\u0027)"},{"line_number":1022,"context_line":"@utils.arg(\u0027--metric-dimensions\u0027, metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2,KEY3\u003dVALUE2...\u003e\u0027,"},{"line_number":1023,"context_line":"           help\u003d\u0027key value pair used to specify a metric dimension or \u0027"},{"line_number":1024,"context_line":"                \u0027just key to select all values of that dimension.\u0027"},{"line_number":1025,"context_line":"                \u0027This can be specified multiple times, or once with parameters \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d87567fa","line":1022,"range":{"start_line":1022,"start_character":71,"end_line":1022,"end_character":72},"updated":"2016-07-20 23:43:21.000000000","message":"Do you think change this to \u003cKEY1\u003dVALUE1,KEY2\u003dVALUE2,KEY3...\u003e or \u003cKEY1\u003dVALUE1,KEY2,KEY3\u003dVALUE3...\u003e will be easier to understand?","commit_id":"691940cbe0bc8e04ab39a5349b9f55034fe7ec09"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"a4bab29dbed0088ebc245e150bd11586c41a8f10","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"           help\u003d\u0027The ID of the alarm definition.\u0027)"},{"line_number":1020,"context_line":"@utils.arg(\u0027--metric-name\u0027, metavar\u003d\u0027\u003cMETRIC_NAME\u003e\u0027,"},{"line_number":1021,"context_line":"           help\u003d\u0027Name of the metric.\u0027)"},{"line_number":1022,"context_line":"@utils.arg(\u0027--metric-dimensions\u0027, metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2,KEY3\u003dVALUE2...\u003e\u0027,"},{"line_number":1023,"context_line":"           help\u003d\u0027key value pair used to specify a metric dimension or \u0027"},{"line_number":1024,"context_line":"                \u0027just key to select all values of that dimension.\u0027"},{"line_number":1025,"context_line":"                \u0027This can be specified multiple times, or once with parameters \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b506c3cb","line":1022,"range":{"start_line":1022,"start_character":71,"end_line":1022,"end_character":72},"in_reply_to":"dada55a8_d87567fa","updated":"2016-08-17 15:16:51.000000000","message":"I don\u0027t think the first option makes it clear that key3 doesn\u0027t have a value attached to it. The second one doesn\u0027t seem significantly different from what already exists.","commit_id":"691940cbe0bc8e04ab39a5349b9f55034fe7ec09"}]}