)]}'
{"monascaclient/v2_0/shell.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"8e2f86717337998b381cf2d442b1e151d943357e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    if isinstance(metric_names, list):"},{"line_number":140,"context_line":"        metric_names.sort(key\u003dlambda x: x[\u0027name\u0027])"},{"line_number":141,"context_line":"        utils.print_list(metric_names, [\u0027Name\u0027], formatters\u003d{\u0027Name\u0027: lambda x: x[\u0027name\u0027]})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_aeb0cbde","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":50},"updated":"2016-04-11 14:49:27.000000000","message":"The client shouldn\u0027t change the order of the results","commit_id":"e32a32ca28563ae0d03f80a5b9e0062af684a3c2"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"92a63ac2daa46da4300bce422e3dff79b15c1fe5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    if isinstance(metric_names, list):"},{"line_number":140,"context_line":"        metric_names.sort(key\u003dlambda x: x[\u0027name\u0027])"},{"line_number":141,"context_line":"        utils.print_list(metric_names, [\u0027Name\u0027], formatters\u003d{\u0027Name\u0027: lambda x: x[\u0027name\u0027]})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_61e24105","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":50},"in_reply_to":"7a1b2928_8f7229e4","updated":"2016-04-11 15:49:52.000000000","message":"Yes, I agree a sorted list is better, but the API should handle the sorting to account for paging. Also, the list should already be sorted by name.","commit_id":"e32a32ca28563ae0d03f80a5b9e0062af684a3c2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"99e3ee8d09e1e665115b8e7993cfac88d47f0eaf","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        return"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    if isinstance(metric_names, list):"},{"line_number":140,"context_line":"        metric_names.sort(key\u003dlambda x: x[\u0027name\u0027])"},{"line_number":141,"context_line":"        utils.print_list(metric_names, [\u0027Name\u0027], formatters\u003d{\u0027Name\u0027: lambda x: x[\u0027name\u0027]})"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_8f7229e4","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":50},"in_reply_to":"7a1b2928_aeb0cbde","updated":"2016-04-11 15:34:36.000000000","message":"a sorted list is more readable \u0026 user friendly\n\nis it ok to add an option for this choice?","commit_id":"e32a32ca28563ae0d03f80a5b9e0062af684a3c2"}]}