)]}'
{"monascaclient/common/http.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"0e3bc47291f479831d7bb6a7ede9ac63a676359b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    LOG.warn(\"System ca file could not be found.\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def unauthorized(resp):"},{"line_number":57,"context_line":"    status401 \u003d (resp.status_code \u003d\u003d 401)"},{"line_number":58,"context_line":"    status500 \u003d (resp.status_code \u003d\u003d 500 and \"(HTTP 401)\" in resp.content)"},{"line_number":59,"context_line":"    return status401 or status500"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_189d0dbc","line":56,"updated":"2016-05-17 13:59:45.000000000","message":"If we got a http 500, I think would be better expose the error message, instead of only return as a unauthorized.","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"88a676229088a29153848e5d42007e2458312848","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    LOG.warn(\"System ca file could not be found.\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def unauthorized(resp):"},{"line_number":57,"context_line":"    status401 \u003d (resp.status_code \u003d\u003d 401)"},{"line_number":58,"context_line":"    status500 \u003d (resp.status_code \u003d\u003d 500 and \"(HTTP 401)\" in resp.content)"},{"line_number":59,"context_line":"    return status401 or status500"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_383c51e0","line":56,"in_reply_to":"dab17558_189d0dbc","updated":"2016-05-17 14:15:26.000000000","message":"Haven\u0027t modified this from the original, but it seems reasonable. I\u0027ll see what I can do.","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"78b1bdfd052fd6dc6768838ba5c02e85c3d342f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    LOG.warn(\"System ca file could not be found.\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def unauthorized(resp):"},{"line_number":57,"context_line":"    status401 \u003d (resp.status_code \u003d\u003d 401)"},{"line_number":58,"context_line":"    status500 \u003d (resp.status_code \u003d\u003d 500 and \"(HTTP 401)\" in resp.content)"},{"line_number":59,"context_line":"    return status401 or status500"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_fb676322","line":56,"in_reply_to":"dab17558_383c51e0","updated":"2016-05-17 14:22:14.000000000","message":"This is not a keystoneauth related issue, so we can discuss this in another patch. :)","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"}],"monascaclient/ksauth.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"a49653a10ad8ec7aa4dc7639cda4057aa29891f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_35a0dc41","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":75},"updated":"2016-05-17 13:56:48.000000000","message":"This copyright is incorrect, please use a general copyright for it.","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"88a676229088a29153848e5d42007e2458312848","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_f8bac9be","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":75},"in_reply_to":"dab17558_35a0dc41","updated":"2016-05-17 14:15:26.000000000","message":"Just copied from the original file. I\u0027m not sure of what general copyright means in this context. \u003d\\ Can you please link an example?","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"78b1bdfd052fd6dc6768838ba5c02e85c3d342f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_1b7b47f6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":75},"in_reply_to":"dab17558_f8bac9be","updated":"2016-05-17 14:22:14.000000000","message":"https://github.com/openstack/keystone/blob/master/keystone/tests/unit/resource/test_backends.py#L1-L11\n\nApache license","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"64646a287f079a6ab9e18e5f9d6de242386f2246","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            auth_params.update(password_params)"},{"line_number":65,"context_line":"            auth_plugin \u003d v3.Password(**auth_params)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if insecure:"},{"line_number":68,"context_line":"            verify \u003d False"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            verify \u003d cert or True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self._session \u003d session.Session(auth\u003dauth_plugin,"},{"line_number":73,"context_line":"                                        verify\u003dverify, cert\u003dcert,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_58c835a8","line":70,"range":{"start_line":67,"start_character":8,"end_line":70,"end_character":33},"updated":"2016-05-17 14:04:16.000000000","message":"to make this more readable, I suggest make something like:\n\nverify \u003d False\n\n(...)\n\nIf not insecure:\n    verify \u003d cert or True","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"88a676229088a29153848e5d42007e2458312848","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            auth_params.update(password_params)"},{"line_number":65,"context_line":"            auth_plugin \u003d v3.Password(**auth_params)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if insecure:"},{"line_number":68,"context_line":"            verify \u003d False"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            verify \u003d cert or True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self._session \u003d session.Session(auth\u003dauth_plugin,"},{"line_number":73,"context_line":"                                        verify\u003dverify, cert\u003dcert,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_3b272b64","line":70,"range":{"start_line":67,"start_character":8,"end_line":70,"end_character":33},"in_reply_to":"dab17558_58c835a8","updated":"2016-05-17 14:15:26.000000000","message":"this one is catchy because verify is True by default. but this might work too. :)","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"}],"monascaclient/tests/fakes.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"64646a287f079a6ab9e18e5f9d6de242386f2246","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    auth_params \u003d {\u0027auth_url\u0027: \u0027http://no.where\u0027,"},{"line_number":24,"context_line":"                   \u0027project_id\u0027: \u0027project_id\u0027,"},{"line_number":25,"context_line":"                   \u0027project_name\u0027: \u0027project_name\u0027,"},{"line_number":26,"context_line":"                   \u0027project_domain_id\u0027: \u0027domain_id\u0027,"},{"line_number":27,"context_line":"                   \u0027project_domain_name\u0027: \u0027domain_name\u0027}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    password_params \u003d {\u0027username\u0027: \u0027username\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_b8fcc1b5","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":52},"updated":"2016-05-17 14:04:16.000000000","message":"I suggest use uuid.uuid4().hex for this cases, since this project_id, domain_id are not valid.","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"88a676229088a29153848e5d42007e2458312848","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    auth_params \u003d {\u0027auth_url\u0027: \u0027http://no.where\u0027,"},{"line_number":24,"context_line":"                   \u0027project_id\u0027: \u0027project_id\u0027,"},{"line_number":25,"context_line":"                   \u0027project_name\u0027: \u0027project_name\u0027,"},{"line_number":26,"context_line":"                   \u0027project_domain_id\u0027: \u0027domain_id\u0027,"},{"line_number":27,"context_line":"                   \u0027project_domain_name\u0027: \u0027domain_name\u0027}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    password_params \u003d {\u0027username\u0027: \u0027username\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_f81649a5","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":52},"in_reply_to":"dab17558_b8fcc1b5","updated":"2016-05-17 14:15:26.000000000","message":"These are also based on the original code, but sure, it\u0027s a good suggestion. :)","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"}],"monascaclient/tests/test_shell.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"64646a287f079a6ab9e18e5f9d6de242386f2246","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            \u0027OS_DOMAIN_ID\u0027: \u0027domain_id\u0027,"},{"line_number":164,"context_line":"            \u0027OS_DOMAIN_NAME\u0027: \u0027domain_name\u0027,"},{"line_number":165,"context_line":"            \u0027OS_USER_DOMAIN_ID\u0027: \u0027user_domain_id\u0027,"},{"line_number":166,"context_line":"            \u0027OS_USER_DOMAIN_NAME\u0027: \u0027user_domain_name\u0027,"},{"line_number":167,"context_line":"        }"},{"line_number":168,"context_line":"        self.set_fake_env(fake_env)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_98e9fde8","line":166,"updated":"2016-05-17 14:04:16.000000000","message":"same uuid change here","commit_id":"a55f9a75c149a5aea1b4882b66cc0ffa0f7469b4"}]}